Bug#850630: [Pkg-emacsen-addons] Bug#850630: elpa-company: Fails to upgrade from 0.8.12-4 when xemacs21 installed

2017-01-08 Thread David Bremner
Sean Whitton writes: > On Sun, Jan 08, 2017 at 04:25:07PM -0400, David Bremner wrote: >> I agree we should fix both upgrade problems. But we should also document >> what we are actually fixing > > Agreed. I've pushed two more commits to the upgrade-fix branch. > > If

Bug#850630: [Pkg-emacsen-addons] Bug#850630: elpa-company: Fails to upgrade from 0.8.12-4 when xemacs21 installed

2017-01-08 Thread Sean Whitton
On Sun, Jan 08, 2017 at 04:25:07PM -0400, David Bremner wrote: > I agree we should fix both upgrade problems. But we should also document > what we are actually fixing Agreed. I've pushed two more commits to the upgrade-fix branch. If you approve, and have nothing else to add, I can perform a

Bug#850630: [Pkg-emacsen-addons] Bug#850630: elpa-company: Fails to upgrade from 0.8.12-4 when xemacs21 installed

2017-01-08 Thread David Bremner
Sean Whitton writes: >> > + sed --quiet -i "$broken_remove_script" \ + -e >> > 's/emacs23)/emacs2[0123]*)/' >> >> this seems unrelated to the problem in the comments. Did you mean to say >> something like "xemacs21 or gnu emacs version 20-22" > > It's unrelated, but I

Bug#850630: [Pkg-emacsen-addons] Bug#850630: elpa-company: Fails to upgrade from 0.8.12-4 when xemacs21 installed

2017-01-08 Thread Sean Whitton
Thank you for your review! On Sun, Jan 08, 2017 at 02:23:42PM -0400, David Bremner wrote: > I think you mean -4 and below Yes. > > +# also installed. We manually upgrade the emacsen-common remove > > +# script so that it won't exit non-zero, which blocks the upgrade > > > +if [ "$1" =

Bug#850630: [Pkg-emacsen-addons] Bug#850630: elpa-company: Fails to upgrade from 0.8.12-4 when xemacs21 installed

2017-01-08 Thread David Bremner
Sean Whitton writes: > +++ b/debian/elpa-company.prerm > @@ -0,0 +1,16 @@ > +#!/bin/sh > + > +set -e > + > +# fix upgrade from 0.8.12-5 and below, which can fail if xemacs21 is I think you mean -4 and below > +# also installed. We manually upgrade the emacsen-common

Bug#850630: elpa-company: Fails to upgrade from 0.8.12-4 when xemacs21 installed

2017-01-08 Thread Sean Whitton
Package: elpa-company Version: 0.8.12-5 Severity: important Tags: patch Dear maintainer, If xemacs21 is installed, apt cannot upgrade from elpa-company 0.8.12-4 to 0.8.12-5. Steps to reproduce in a minimal sid chroot: apt-get install xemacs21 apt-get install elpa-company=0.8.12-4