Bug#873520: Check for bad distribution in d/changelog only when changes file is signed

2019-08-19 Thread Chris Lamb
Felix Lechner wrote: > > Did we get that logic right? Should Lintian perhaps complain instead > > when analysing a changes file---which is clearly intended for > > upload---versus a dsc file that can hold sources at any stage? > > Forgive me. Our original idea works great. There is no way >

Bug#873520: Check for bad distribution in d/changelog only when changes file is signed

2019-08-18 Thread Felix Lechner
Hi, On Tue, Aug 13, 2019 at 9:14 AM Felix Lechner wrote: > > Did we get that logic right? Should Lintian perhaps complain instead > when analysing a changes file---which is clearly intended for > upload---versus a dsc file that can hold sources at any stage? Forgive me. Our original idea works

Bug#873520: Check for bad distribution in d/changelog only when changes file is signed

2019-08-13 Thread Felix Lechner
Hi Chris, On Tue, Aug 13, 2019 at 9:10 AM Felix Lechner wrote: > > When the changes file is unsigned, which is part of the > normal workflow for those using 'dch', the tag is not issued. Did we get that logic right? Should Lintian perhaps complain instead when analysing a changes file---which

Bug#873520: Check for bad distribution in d/changelog only when changes file is signed

2019-08-13 Thread Felix Lechner
Hi Chris, On Mon, Aug 5, 2019 at 9:45 AM Chris Lamb wrote: > > That's a good idea. Care to implement that? Please see: https://salsa.debian.org/lintian/lintian/merge_requests/246 > Given that this might still generate false-positives The merge requests also includes a test for the most

Bug#873520: Check for bad distribution in d/changelog only when changes file is signed

2019-08-05 Thread Chris Lamb
tags 873520 - patch moreinfo thanks Hi Felix, > Would it be acceptable to generate the tag for bad distribution in > d/changelog only when the *.changes file is signed (if it is present)? That's a good idea. Care to implement that? Given that this might still generate false-positives whilst we

Bug#873520: Check for bad distribution in d/changelog only when changes file is signed

2019-08-04 Thread Felix Lechner
Hi, > However, ... this would mean that every time you built a package > locally as part of regular development it would emit this tag. Would it be acceptable to generate the tag for bad distribution in d/changelog only when the *.changes file is signed (if it is present)? That should bypass