Bug#898356: git-buildpackage: Multiple --git-pbuilder-options do not stack

2018-05-17 Thread Guido Günther
On Thu, May 17, 2018 at 10:34:30PM +0200, Matthijs Kooijman wrote: > Hi Guido, > > > --git-pbuilder-options-append="option1" > > --git-pbuilder-options-append="option2" > > > > so you can decide on a per option basis if you want to append to the > > currently set value. Each

Bug#898356: git-buildpackage: Multiple --git-pbuilder-options do not stack

2018-05-17 Thread Matthijs Kooijman
Hi Guido, > --git-pbuilder-options-append="option1" > --git-pbuilder-options-append="option2" > > so you can decide on a per option basis if you want to append to the > currently set value. Each "--git-pbuilder-options" would reset the whole > thing and start over so: > >

Bug#898356: git-buildpackage: Multiple --git-pbuilder-options do not stack

2018-05-17 Thread Guido Günther
On Thu, May 17, 2018 at 07:47:58PM +0200, Matthijs Kooijman wrote: > Hi Guido, > > > > My suggestion of adding a --git-append-pbuilder-option could solve both > > > usecases: > > > - you can use --git-pbuilder-options on the commandline to override all > > >previously set options, including

Bug#898356: git-buildpackage: Multiple --git-pbuilder-options do not stack

2018-05-17 Thread Matthijs Kooijman
Hi Guido, > > My suggestion of adding a --git-append-pbuilder-option could solve both > > usecases: > > - you can use --git-pbuilder-options on the commandline to override all > >previously set options, including in gbp.conf > > - you can use --git-append-pbuilder-option to extend any

Bug#898356: git-buildpackage: Multiple --git-pbuilder-options do not stack

2018-05-10 Thread Guido Günther
On Thu, May 10, 2018 at 10:53:47PM +0200, Matthijs Kooijman wrote: > Hi Guido, > > > > When passing multiple options on the commandline, this is (for me) > > > unexpected but easily fixed by passing all needed options into a single > > > --git-pbuilder-options, but when a gbp.conf file also uses

Bug#898356: git-buildpackage: Multiple --git-pbuilder-options do not stack

2018-05-10 Thread Matthijs Kooijman
Hi Guido, > > When passing multiple options on the commandline, this is (for me) > > unexpected but easily fixed by passing all needed options into a single > > --git-pbuilder-options, but when a gbp.conf file also uses > > "pbuilder-options", these are also overriden by the commandline, which >

Bug#898356: git-buildpackage: Multiple --git-pbuilder-options do not stack

2018-05-10 Thread Guido Günther
On Thu, May 10, 2018 at 09:29:57PM +0200, Matthijs Kooijman wrote: > Hi Guido, > > I noticed one more related thing, also possibly a bug. It seems that the > arguments to --git-pbuilder-options are further processed. I tried > running this command: > > gbp buildpackage

Bug#898356: git-buildpackage: Multiple --git-pbuilder-options do not stack

2018-05-10 Thread Matthijs Kooijman
Hi Guido, I noticed one more related thing, also possibly a bug. It seems that the arguments to --git-pbuilder-options are further processed. I tried running this command: gbp buildpackage --git-pbuilder-options=--extrapackage=/foo/a.deb\ --extrapackage=/foo/b.deb\ --bindmounts=/foo Which

Bug#898356: git-buildpackage: Multiple --git-pbuilder-options do not stack

2018-05-10 Thread Guido Günther
control: severity -1 wishlist Hi Matthijs, On Thu, May 10, 2018 at 08:06:58PM +0200, Matthijs Kooijman wrote: > Package: git-buildpackage > Version: 0.9.8 > Severity: normal > > Hi Guido, > > I was using the --git-pbuilder-options option to gbp-buildpackage today, > and was surprised that

Bug#898356: git-buildpackage: Multiple --git-pbuilder-options do not stack

2018-05-10 Thread Matthijs Kooijman
Package: git-buildpackage Version: 0.9.8 Severity: normal Hi Guido, I was using the --git-pbuilder-options option to gbp-buildpackage today, and was surprised that multiple options do not stack. Instead, each --git-pbuilder-options passed overrides the previous one, so only the last one is