Bug#965363: Fwd: Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-14 Thread Alec Leamas
On Sun, 13 Sep 2020 15:27:24 +0200 Tobias Frost wrote: > On Sun, Sep 13, 2020 at 02:50:43PM +0200, Tobias Frost wrote: > > On Sun, Sep 13, 2020 at 01:23:41PM +0200, Alec Leamas wrote: > More stuff. Lintian this time. > > - Lintian overrides > Lintian overrides should only be used if Lintian is

Bug#965363: Fwd: Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-14 Thread Tobias Frost
On Sun, Sep 13, 2020 at 11:19:33PM +0200, Alec Leamas wrote: > Hi, > > On Sun, 13 Sep 2020 15:27:24 +0200 Tobias Frost wrote: > > On Sun, Sep 13, 2020 at 02:50:43PM +0200, Tobias Frost wrote: > > > On Sun, Sep 13, 2020 at 01:23:41PM +0200, Alec Leamas wrote: > > > > > So far for now… > > > >

Bug#965363: Fwd: Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-13 Thread Alec Leamas
Hi, On Sun, 13 Sep 2020 15:27:24 +0200 Tobias Frost wrote: > On Sun, Sep 13, 2020 at 02:50:43PM +0200, Tobias Frost wrote: > > On Sun, Sep 13, 2020 at 01:23:41PM +0200, Alec Leamas wrote: > > > So far for now… > > More stuff. Lintian this time. > > - Lintian overrides > Lintian overrides

Bug#965363: Fwd: Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-13 Thread Alec Leamas
Hi, On Sun, 13 Sep 2020 15:27:24 +0200 Tobias Frost wrote: > On Sun, Sep 13, 2020 at 02:50:43PM +0200, Tobias Frost wrote: > > On Sun, Sep 13, 2020 at 01:23:41PM +0200, Alec Leamas wrote: > > Ah, regarding my remark for NSIS.template.in: > After thinking about it: This is probably an upstream

Bug#965363: Fwd: Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-13 Thread Alec Leamas
On 13/09/2020 14:50, Tobias Frost wrote: > On Sun, Sep 13, 2020 at 01:23:41PM +0200, Alec Leamas wrote: > > (snipping stuff that is done or settled … Its getting a long mail) > > (regarding the transitinal package and Replace/Breaks versioning) >> OK, will do (unless not done in a MR)> > MR

Bug#965363: Fwd: Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-13 Thread Tobias Frost
On Sun, Sep 13, 2020 at 02:50:43PM +0200, Tobias Frost wrote: > On Sun, Sep 13, 2020 at 01:23:41PM +0200, Alec Leamas wrote: > > (snipping stuff that is done or settled … Its getting a long mail) > > (regarding the transitinal package and Replace/Breaks versioning) > > OK, will do (unless not

Bug#965363: Fwd: Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-13 Thread Tobias Frost
On Sun, Sep 13, 2020 at 01:23:41PM +0200, Alec Leamas wrote: (snipping stuff that is done or settled … Its getting a long mail) (regarding the transitinal package and Replace/Breaks versioning) > OK, will do (unless not done in a MR) MR sent.

Bug#965363: Fwd: Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-13 Thread Tobias Frost
On Sun, Sep 13, 2020 at 11:00:17AM +0200, Alec Leamas wrote: > > Hi Tobias, > > Here we go: > > On 12/09/2020 16:28, Tobias Frost wrote: > > Control: owner -1 ! > > > > > Two remarks: > > - d/changelog You could bumpt the timestamp on the changelog from time to > > time, though > > ;-): dch

Bug#965363: Fwd: Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-13 Thread Alec Leamas
Hi Tobias, Here we go: On 12/09/2020 16:28, Tobias Frost wrote: > Control: owner -1 ! > > Two remarks: > - d/changelog You could bumpt the timestamp on the changelog from time to > time, though > ;-): dch -r "" is a nice trick ;-) Indeed, thanks! Tried now, will need to to it again. > -

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-12 Thread Tobias Frost
Control: owner -1 ! Ok, finally found time \o/, but did not have enough to complete the review :-( (The review is based on the package from mentors uploaded 2020-09-10 19:38.) Not yetreviewed: dep3-headers on patches, d/changelog and d/copyright as Alec is actively working on those (as per

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-10 Thread Tobias Frost
On Thu, Sep 10, 2020 at 12:12:29PM +0200, Alec Leamas wrote: > On Thu, 10 Sep 2020 05:12:34 -0400 The Wanderer > wrote: > > On 2020-09-10 at 01:45, Tobias Frost wrote: > > > > > On Wed, Sep 09, 2020 at 10:53:37PM +0200, Alec Leamas wrote: > > > > > > > Well, actually, all those lines probably

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-10 Thread Tobias Frost
On Thu, Sep 10, 2020 at 05:12:34AM -0400, The Wanderer wrote: > > https://www.debian.org/doc/debian-policy/ch-source.html#debian-changelog-debian-changelog > > for some better/more accurate wording in the Policy) > > I'm not sure I read that section as meaning that. Could you point more >

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-10 Thread Alec Leamas
On Thu, 10 Sep 2020 05:12:34 -0400 The Wanderer wrote: > On 2020-09-10 at 01:45, Tobias Frost wrote: > > > On Wed, Sep 09, 2020 at 10:53:37PM +0200, Alec Leamas wrote: > > > > Well, actually, all those lines probably should be removed: > > debian/changelog is intended to record changes to the

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-10 Thread The Wanderer
On 2020-09-10 at 01:45, Tobias Frost wrote: > On Wed, Sep 09, 2020 at 10:53:37PM +0200, Alec Leamas wrote: >> Hi, >> >> A new version is uploaded to mentors. Time to reset the history. Changes >> since last round: >> >> - New warning dialog for downloading binary plugin content (patch). >>

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-10 Thread Alec Leamas
Hi Tobias, On Thu, 10 Sep 2020 08:06:10 +0200 Tobias Frost wrote: > On Wed, Sep 09, 2020 at 11:08:53PM +0200, Alec Leamas wrote: > > On Wed, 9 Sep 2020 22:53:37 +0200 Alec Leamas wrote: > > Dammit. There's still one copyright for src/gshhs.cpp to fix. I'm on it, > > but holding next upload

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-10 Thread Alec Leamas
On Thu, 10 Sep 2020 07:46:32 +0200 Tobias Frost wrote: > On Wed, Sep 09, 2020 at 11:08:53PM +0200, Alec Leamas wrote: > > On Wed, 9 Sep 2020 22:53:37 +0200 Alec Leamas wrote: > just go ahead and update the package on mentors. Done. --alec

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-10 Thread Tobias Frost
On Wed, Sep 09, 2020 at 11:08:53PM +0200, Alec Leamas wrote: > On Wed, 9 Sep 2020 22:53:37 +0200 Alec Leamas wrote: > > Hi, > > > > A new version is uploaded to mentors. Time to reset the history. Changes > > since last round: > > ... > > Dammit. There's still one copyright for src/gshhs.cpp

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-09 Thread Tobias Frost
On Wed, Sep 09, 2020 at 11:08:53PM +0200, Alec Leamas wrote: > On Wed, 9 Sep 2020 22:53:37 +0200 Alec Leamas wrote: > > Hi, > > > > A new version is uploaded to mentors. Time to reset the history. Changes > > since last round: > > ... > > Dammit. There's still one copyright for src/gshhs.cpp

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-09 Thread Tobias Frost
On Wed, Sep 09, 2020 at 10:53:37PM +0200, Alec Leamas wrote: > Hi, > > A new version is uploaded to mentors. Time to reset the history. Changes > since last round: > > - New warning dialog for downloading binary plugin content (patch). > - Spelling error fixed > - Removed references to

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-09 Thread Alec Leamas
On Wed, 9 Sep 2020 18:44:17 +0200 Tobias Frost wrote: > On Wed, Sep 09, 2020 at 07:39:38AM +0200, Alec Leamas wrote: > > > Now, this should not really change anything. OpenCPN is perfectly usable > > without any plugins, and builds fine on all Debian core platforms (sic!) > > Sounds good ;-) >

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-09 Thread Alec Leamas
On Wed, 9 Sep 2020 22:53:37 +0200 Alec Leamas wrote: > Hi, > > A new version is uploaded to mentors. Time to reset the history. Changes > since last round: ... Dammit. There's still one copyright for src/gshhs.cpp to fix. I'm on it, but holding next upload until I hear from you. "Annoyed"

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-09 Thread Alec Leamas
Hi, A new version is uploaded to mentors. Time to reset the history. Changes since last round: - New warning dialog for downloading binary plugin content (patch). - Spelling error fixed - Removed references to upstream bugs. I think it's a pity, the references linked patches in

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-09 Thread Tobias Frost
On Wed, Sep 09, 2020 at 07:39:38AM +0200, Alec Leamas wrote: > Now, this should not really change anything. OpenCPN is perfectly usable > without any plugins, and builds fine on all Debian core platforms (sic!) Sounds good ;-) (And it can happen that someone is showing up later and packaging

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-08 Thread Alec Leamas
On Tue, 8 Sep 2020 21:01:47 +0200 Tobias Frost wrote: > On Tue, Sep 08, 2020 at 08:10:48PM +0200, Alec Leamas wrote: >> On Tue, 8 Sep 2020 19:05:21 +0200 Tobias Frost wrote: >> All this said: do you think it's motivated to make such a patch? > > I guess. (Again being Debianite ;-)) OK, will

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-08 Thread Tobias Frost
On Tue, Sep 08, 2020 at 08:10:48PM +0200, Alec Leamas wrote: > On Tue, 8 Sep 2020 19:05:21 +0200 Tobias Frost wrote: > > > > Not really. Do you think a patch is motivated? If so, for each and every > > > plugin, or just for the first one? > > > > I'm not sure how plugins are installed. If there

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-08 Thread Alec Leamas
On Tue, 8 Sep 2020 19:05:21 +0200 Tobias Frost wrote: > > Not really. Do you think a patch is motivated? If so, for each and every > > plugin, or just for the first one? > > I'm not sure how plugins are installed. If there is an UI, the warning > could be presented in that gui. The basic

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-08 Thread Tobias Frost
On Tue, Sep 08, 2020 at 05:54:42PM +0200, Alec Leamas wrote: > Hi Tobias, > > Thanks for taking some time for this! > > On 08/09/2020 16:29, Tobias Frost wrote: > > > a short review: > > > > * New upstream release including plugin downloader. Closes: 948702 > > > > It is a privacy violation

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-08 Thread Alec Leamas
Hi Tobias, Thanks for taking some time for this! On 08/09/2020 16:29, Tobias Frost wrote: > a short review: > > * New upstream release including plugin downloader. Closes: 948702 > > It is a privacy violation to download stuff. Do you inform your user about it? Not really. Do you think a

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-09-08 Thread Tobias Frost
Control: tags -1 moreinfo Hi Alec, a short review: * New upstream release including plugin downloader. Closes: 948702 It is a privacy violation to download stuff. Do you inform your user about it? Are the downloads somehow validated that it won't execute malicious / (MITM) modified code? (It

Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software

2020-07-20 Thread Alec Leamas
Package: sponsorship-requests Severity: important Dear mentors, I am looking for a sponsor for my package "opencpn" * Package name: opencpn Version : 5.2.0+dfsg-1 Upstream Author : Dave S. Register * URL : https://opencpn.org * License : GPL-2+ * Vcs