Bug#977328: false positive when passing variables to functions by address

2020-12-24 Thread Russ Allbery
Joachim Reichel writes: > The first and third issue are fixed in the upstream master branch. For > the second issue, upstream asked for a separate bug report which is at > https://trac.cppcheck.net/ticket/10062#ticket . Awesome, thank you so much! -- Russ Allbery (r...@debian.org)

Bug#977328: false positive when passing variables to functions by address

2020-12-24 Thread Joachim Reichel
On 15.12.20 20:13, Russ Allbery wrote: 2.3 was a net improvement for me, although the code base on which I've tested it is not all that large (about 35K lines including comments). I think it's fine to move to 2.3 in the upcoming release. This falls within the "normal" level of cppcheck false

Bug#977328: false positive when passing variables to functions by address

2020-12-15 Thread Russ Allbery
Joachim Reichel writes: > Now the tricky question: how frequent/annoying are these regressions > with large code bases, i.e., with existing real-world code? Is version > 2.3 a net improvement over version 2.2? Should we keep 2.3 out of > testing for now (and possibly out of the upcoming

Bug#977328: false positive when passing variables to functions by address

2020-12-15 Thread Joachim Reichel
tag 977328 +upstream forwarded 977328 https://trac.cppcheck.net/ticket/10037#ticket thanks Ok, I forwarded the modified tests to the upstream bug tracker. Btw the first test also fails with cppcheck 2.2, while the second and third test are regressions. On the other hand, cppcheck 2.3 fixes bug

Bug#977328: false positive when passing variables to functions by address

2020-12-14 Thread Russ Allbery
Joachim Reichel writes: > On 14.12.20 01:23, Russ Allbery wrote: >> In the second case, something about adding retval to the test messes up >> its understanding of the data flow. > Removing retval from the if() condition does not change anything for > me. Could you double-check? Ah, it's not

Bug#977328: false positive when passing variables to functions by address

2020-12-14 Thread Joachim Reichel
Hi Russ, On 14.12.20 01:23, Russ Allbery wrote: > (Apologies, I haven't reported these upstream since they want bug > reporters to catch them on IRC to get a Trac account created.) Yes, the problems with account creation are very unfortunate. I'll forward your test cases, but before doing so,

Bug#977328: false positive when passing variables to functions by address

2020-12-13 Thread Russ Allbery
Package: cppcheck Version: 2.3-1 Severity: normal Thank you for packaging cppcheck 2.3! I'm pleased to confirm that the bugs that I reported in #943463 were indeed fixed in that release. Unfortunately, it appears to have introduced a few more false positives in this general area. Here is a