Bug#982786: growlight: autopkgtest regression

2021-02-16 Thread nick black
hurrah, it would appear that 1.2.31 is running successfully on the autopkgtest servers (all show as passed save ppc64el, which shows as passed here: https://ci.debian.net/packages/g/growlight/testing/ppc64el/).

Bug#982786: growlight: autopkgtest regression

2021-02-16 Thread Nick Black
ok, the good news is that with 1.2.30, we're no longer seeing the segfault. the bad news is that we error out due to an inability to load up notcurses without a TERM variable. the proper fix for this is to avoid using notcurses in any case where we're not connected to a tty. i can get this done

Bug#982786: growlight: autopkgtest regression

2021-02-15 Thread Nick Black
alright, with 1.2.30 (1.2.29 was never released), we pass the autopkgtests, huzzah.

Bug#982786: growlight: autopkgtest regression

2021-02-15 Thread Nick Black
not so fast! while this does indeed fix the segfault when run without TERM, i still get an autopkgtest failure, this one tracked down to stdout being redirected =[. so i'm gonna address that as well. how embarrassing.

Bug#982786: growlight: autopkgtest regression

2021-02-15 Thread Nick Black
Here's the upstream bug: https://github.com/dankamongmen/growlight/issues/139 Here's the (obvious, trivial) fix: https://github.com/dankamongmen/growlight/commit/297f487a8be84441ff75a22b5fa63305931cae70 A real brown-bagger =[. I'm going to cut 1.2.29 and upload it to unstable. If I ought prepare

Bug#982786: growlight: autopkgtest regression

2021-02-15 Thread Nick Black
Alright, I've got it locked down to the absence of a TERM environment variable in the autopkgtest environment. If I run the same command outside of autopkgtest, after running `unset TERM`, i get the exact same failure. So, this failure is IMHO definitely worth fixing, and I intend to do so now,

Bug#982786: growlight: autopkgtest regression

2021-02-15 Thread Nick Black
I can now reproduce this locally, and expect to have a fix this evening. I've looked over the rules for the Soft Freeze, and understand that it'll be acceptable to cut a new upstream release (I'm the upstream author) with this fix only (there have been no other changes since this release), upload

Bug#982786: growlight: autopkgtest regression

2021-02-14 Thread Nick Black
Thanks for the heads-up; glad I've got those autopkgtests. Looking into this now with the hope of fixing it ASAP.

Bug#982786: growlight: autopkgtest regression

2021-02-14 Thread Adrian Bunk
Source: growlight Version: 1.2.28-1 Severity: serious https://ci.debian.net/data/autopkgtest/testing/amd64/g/growlight/10443325/log.gz ... autopkgtest [11:04:28]: test blockdev: echo "blockdev -v" | growlight-readline -v autopkgtest [11:04:28]: test blockdev: [--- growlight