Bug#985151: dh_bash-completion: treats nitrokey-app file list as script

2021-03-28 Thread Kevin Locke
Hi Gabriel, On Sun, 2021-03-28 at 12:12 -0300, Gabriel F. T. Gomes wrote: > On Mon, 15 Mar 2021 07:07:36 -0600 Kevin Locke wrote: >> I've attached an updated version >> which matches & and | in addition to ; as command separators. We may >> also want to consider modifying the compgen expression

Bug#985151: dh_bash-completion: treats nitrokey-app file list as script

2021-03-28 Thread Gabriel F. T. Gomes
Hi, Kevin, On Mon, 15 Mar 2021 07:07:36 -0600 Kevin Locke wrote: > > I've attached an updated version > which matches & and | in addition to ; as command separators. We may > also want to consider modifying the compgen expression in the same way. I added this patch (with a changelog entry) to

Bug#985151: dh_bash-completion: treats nitrokey-app file list as script

2021-03-15 Thread Gabriel F. T. Gomes
On Mon, 15 Mar 2021, Kevin Locke wrote: > > Which appears to be a common idiom for only defining the function and > completion if the command is in $PATH. I've attached an updated version > which matches & and | in addition to ; as command separators. We may > also want to consider modifying the

Bug#985151: dh_bash-completion: treats nitrokey-app file list as script

2021-03-15 Thread Gabriel F. T. Gomes
On Mon, 15 Mar 2021, Gabriel F. T. Gomes wrote: > > I'll check if it works correctly with the scripts currently installed > under my /usr/share/bash-completion. Perhaps we could also add && and || as command termination characters, so that idioms like the following also get detected: complete

Bug#985151: dh_bash-completion: treats nitrokey-app file list as script

2021-03-15 Thread Kevin Locke
Hi Gabriel, On Mon, 2021-03-15 at 09:52 -0300, Gabriel F. T. Gomes wrote: > On Sat, 13 Mar 2021, Kevin Locke wrote: >> I've attached a patch to fix the issue by requiring complete to follow a >> line break or semicolon. It obviously does not address the root of the >> problem of reliably

Bug#985151: dh_bash-completion: treats nitrokey-app file list as script

2021-03-15 Thread Gabriel F. T. Gomes
Hi, Kevin, On Sat, 13 Mar 2021, Kevin Locke wrote: > > I've attached a patch to fix the issue by requiring complete to follow a > line break or semicolon. It obviously does not address the root of the > problem of reliably differentiating a list of paths from a Bash script. > (Which is not

Bug#985151: dh_bash-completion: treats nitrokey-app file list as script

2021-03-13 Thread Kevin Locke
Package: bash-completion Version: 1:2.11-2 Severity: normal Tags: patch X-Debbugs-Cc: j.naum...@fu-berlin.de Dear Maintainer, The regular expressions in is_filelist which matches "well-known idioms on bash scripts" currently matches the path to the bash-completion script in the nitrokey-app