Hi Sebastian,
One more (technical) thing to mention: the best way to centralize ToLower and
ToUpper (omitting collations for now, for that there is a libicu PR for v20
targeting Android) is to declare an overloaded 'StringUtils::ToLower(char c,
bool useCLocale)' function and make all Kodi use
>C++ has an overloaded version of tolower that takes a locale:
>https://en.cppreference.com/w/cpp/locale/tolower
Good find, thanks! Still, what do you think about this concern:
> but to separate "culture-dependent" and "ordinal" comparisons, one needs to
> overhaul half of Kodi.
> And this
On 2021-07-02 08:48:10 +, Vasyl Gello wrote:
> Also I don't see std::tolower_l as part of C++ standard. Looks like tolower_l
> is POSIX standard and Kodi uses std:: stuff there :(
C++ has an overloaded version of tolower that takes a locale:
https://en.cppreference.com/w/cpp/locale/tolower
Also I don't see std::tolower_l as part of C++ standard. Looks like tolower_l
is POSIX standard and Kodi uses std:: stuff there :(
--
Vasyl Gello
==
Certified SolidWorks Expert
Mob.:+380 (98) 465 66 77
E-Mail: vasek.ge...@gmail.com
Skype:
Hi Sebastian!
> So what you're telling me is that this tolower call should actually be
> call to tolower_l with an appropriate locale as kodi only expects
> tolower("...") == "includes.xml" under the C locale.
Very likely it is the more "proper" solution, but to separate
"culture-dependent" and
Hi Vasyl
On 2021-07-02 08:14:34 +, Vasyl Gello wrote:
> Hi Sebastian!
>
> > I'm not sure why the second patch is needed. If I understand the first
> > patch correctly, in the case where LC_CTYPE is set to a Turkish locale,
> > the locale will be reset to C.UTF-8 (not sure that this is sane,
Hi Sebastian!
> I'm not sure why the second patch is needed. If I understand the first
> patch correctly, in the case where LC_CTYPE is set to a Turkish locale,
> the locale will be reset to C.UTF-8 (not sure that this is sane,
> though). The second patch makes it even worse since it resets it to
Control: tags -1 moreinfo
On 2021-07-01 03:47:05 +, Vasyl Gello wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian@packages.debian.org
> Usertags: unblock
> X-Debbugs-Cc: mat...@debian.org
>
> Please unblock package kodi
>
> [ Reason ]
>
> Targeted bug fix
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: mat...@debian.org
Please unblock package kodi
[ Reason ]
Targeted bug fix for #989814
[ Impact ]
Turkish users get Kodi unusable without it
[ Tests ]
See related Debian
9 matches
Mail list logo
