Bug#1065153: v4l-utils: FTBFS on armhf/armel: _TIME_BITS=64 is allowed only with _FILE_OFFSET_BITS=64

[Gregor Jasny]

Hello,

On 01.03.24 11:34, Emanuele Rocca wrote:

This seems intentional, see meson.build:

   v4l2_wrapper_args = [
   # As the library needs to provide both 32-bit and 64-bit versions
   # of file operations, disable transparent large file support (fixes
   # 'Error: symbol `open64/mmap64' is already defined' compile failure
   # otherwise)
   '-U_FILE_OFFSET_BITS',
   '-D_FILE_OFFSET_BITS=32',
   '-D_LARGEFILE64_SOURCE',
   ]


You're right disabling LFS was intentional. Those "wrappers" are meent 
to be preloaded with LD_PRELOAD and should intercept all V4L related 
calls like open, close, mmap, etc.


I believe the conflict arose because the Debian CFLAGS now define a 64 
bit time_t value on 32bit architectures. I believe none of the code 
within those wrappers is sensitive to time_t. Therefore I also undefined

the _TIME_BITS. That should resolve the issue for the Debian package.

For upstream the problem is a little bit trickier because the "tracer" 
also uses those flags. But the tracer consists of lots of files. Maybe 
those have to be split up.


Thanks,
Gregor

Bug#1062032: c-ares: NMU diff for 64-bit time_t transition

[Gregor Jasny]

Hello Steve,

On 31.01.24 04:15, Steve Langasek wrote:

Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time.  Therefore I have prepared a 0-day NMU for c-ares
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.

Please find the patch for this NMU attached.


Currently, for c-ares2 the library package does not match the SONAME and 
needs a lintian 
override:https://salsa.debian.org/debian/c-ares/-/blob/master/debian/libc-ares2.lintian-overrides?ref_type=heads


I wonder if you could rename the package into libcares2 instead of the 
proposed libc-ares2t64. That would make the package name matching the 
SONAME. But I'm also fine with your NMU.


Thanks for considering,
Gregor

Bug#1014887: ir-ctl: increase the size of the buffer used to read raw files

[Gregor Jasny]

Hello Joe,

thanks for your bug report. I looked through the current code base of 
ir-ctl and saw that Sean committed the following change to increase the 
limit from 1k to 8k:



https://git.linuxtv.org/v4l-utils.git/commit/utils/ir-ctl/ir-ctl.c?id=1874b2d0dfbb8a38b0c8b75a23a4b9a60e52fd6a


Maybe that's already large enough for your use case, too?

But replacing fgets with getline should be a straight-forward fix to get 
rid of the limit once and for all.


Sean, what do you think about that replacement and do you have time to 
work on the change?


Thanks,
Gregor

Bug#1056729: RFS: libnginx-mod-vts/0.2.2-1 [ITP] -- Virtual host traffic status (VTS) module for Nginx

[Gregor Jasny]

Package: sponsorship-requests
Severity: wishlist
X-Debbugs-Cc: pkg-nginx-maintain...@alioth-lists.debian.net

Dear mentors,

I am looking for a sponsor for my package "libnginx-mod-vts":

 * Package name : libnginx-mod-vts
   Version  : 0.2.2-1
   Upstream contact : YoungJoo.Kim (김영주) 
 * URL  : https://github.com/vozlt/nginx-module-vts
 * License  : BSD-2-clause
 * Vcs  : https://salsa.debian.org/gjasny-guest/libnginx-mod-vts
   Section  : httpd

The source builds the following binary packages:

  libnginx-mod-http-vhost-traffic-status - Virtual host traffic status (VTS) 
module for Nginx

To access further information about this package, please visit the following 
URL:

  https://mentors.debian.net/package/libnginx-mod-vts/

Alternatively, you can download the package with 'dget' using this command:

  dget -x 
https://mentors.debian.net/debian/pool/main/libn/libnginx-mod-vts/libnginx-mod-vts_0.2.2-1.dsc

Changes for the initial release:

 libnginx-mod-vts (0.2.2-1) unstable; urgency=medium
 .
   * Initial release (Closes: #1055012)

Regards,
Gregor Jasny

Bug#1056691: nodejs: Compatibility with c-ares 1.21.0

[Gregor Jasny]

Package: nodejs
Version: 18.13.0+dfsg1-1
Severity: important
Tags: patch

Hello,

while packaging c-ares 1.21.0 (and newer) I noticed that the autopkgtests
fail for nodejs. The problem was reported to the c-ares[1] and node[2]
upstream and a fix for the overly strict tests landed in nodejs mainline[3].

Could you please apply the patch[3] to the unstable version of nodejs so that
the c-ares package could pass the autopkgtest migration barrier?

In case your nodejs package build runs the node test suite (which fails with the
c-ares version in sid) this bug might even be a serious FTBFS one.

Thanks,
Gregor

[1] https://github.com/c-ares/c-ares/issues/621
[2] https://github.com/nodejs/node/issues/50741
[3] 
https://github.com/nodejs/node/commit/345d16cc5064a07383c9cd0b9bc3d95741b50a75

-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: arm64 (aarch64)

Kernel: Linux 6.5.0-4-arm64 (SMP w/4 CPU threads)
Locale: LANG=en_US.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages nodejs depends on:
ii  libc6   2.37-12
ii  libnode108  18.13.0+dfsg1-1

Versions of packages nodejs recommends:
ii  ca-certificates  20230311
ii  nodejs-doc   18.13.0+dfsg1-1

Versions of packages nodejs suggests:
pn  npm  

-- no debconf information

Bug#1055012: ITP: libnginx-mod-vts -- Nginx virtual host traffic status module

[Gregor Jasny]

Dear Debian Nginx maintainers,

Let me introduce myself, first:

I'm Gregor, a software engineer and free software enthusiast. I started 
contributing to OSS projects around the year 2000 with some patches to 
the KDE desktop environment. Due to my work activities I had to interact 
with the Video4Linux subsystem and became the Debian maintainer of the 
v4l-utils package. Some months after that I successfully applied to 
become a Debian Maintainer. Since then I took over mainatenance of the 
c-ares package and prometheus-cpp. I'm most proficient in the C/C++ space.


My latest endevour is packaging the Nginx VTS module. I noticed this 
package is available for Alpine, Arch, and Fedora. Because at work we 
run most services with Debian and Ubuntu, I wanted to close the gap.


You could find the packaged module here:
https://salsa.debian.org/gjasny-guest/libnginx-mod-vts

Based on your opinions, I'd either like to maintain that module af part 
of the nginx team, or move it into the collab-maint / Debian space on 
Salsa. Either way I'd need an initial sponsor (due to my DM status).


What do you think?

Thanks,
Gregor

Bug#1055012: ITP: libnginx-mod-vts -- Nginx virtual host traffic status module

[Gregor Jasny]

Package: wnpp
Severity: wishlist
Owner: Gregor Jasny 
X-Debbugs-Cc: debian-de...@lists.debian.org, 
pkg-nginx-maintain...@alioth-lists.debian.net

* Package name: libnginx-mod-vts
  Version : 0.2.2
  Upstream Contact: YoungJoo.Kim (김영주) 
* URL : https://github.com/vozlt/nginx-module-vts
* License : BSD-2-Clause
  Programming Lang: C
  Description : Nginx virtual host traffic status module

This package enables easy monitoring of nginx instances with
telegraf [1]. We use it in production since a very long time
and would like to switch from a locally built package to one
maintained by the distribution.

Maintaining this package seems to be low-effort. I could
maintain it on my own or join forces with the Debian
nginx maintainers.

Thanks,
Gregor

[1] 
https://github.com/influxdata/telegraf/blob/master/plugins/inputs/nginx_vts/README.md

Bug#1036592: pre-approval: unblock: c-ares/1.18.1-3

[Gregor Jasny]

Control: tags -1 - moreinfo

Hello,

On 27.05.23 08:19, Paul Gevers wrote:
Please go ahead, taking into account that the build needs to be done 
before tomorrow 12:00 UTC. Remove the moreinfo tag once the upload 
happened.


I just uploaded to ftp-master.

Thanks,
Gregor

Bug#1036592: pre-approval: unblock: c-ares/1.18.1-3

[Gregor Jasny]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: c-a...@packages.debian.org
Control: affects -1 + src:c-ares

Hello,

[ Reason ]

yesterday a version 1.19.1 of c-ares was release which fixes four CVEs.
The Debian Security team considers two of them relevant for Debian and
I'd like to cherry-pick them into the unstable package so that the fixes
can migrate to Bookworm.

Attached you'll find the debdiff. The changes are also visible in Salsa:
https://salsa.debian.org/debian/c-ares/-/compare/debian%2F1.18.1-2...master?from_project_id=11264=false

[ Impact ]

CVE-2023-31130 has a CVSS score of 4.1
CVE-2023-32067 has a CVSS score of 7.5

[ Tests ]

On the experimental branch I enabled the unit and integration tests:
would you consider that commit as acceptable, too?
https://salsa.debian.org/debian/c-ares/-/commit/25f515f728eeae82013a9c1cb8aa6ce80e913d09

[ Risks ]

The fix for the 0-byte DoS issue seems to be straight-forward.
The fix for inet_net_pton_ipv6 has been synced from OpenBSD and
is covered by the unit tests.

Both changes are port of the 1.19.1 release which built and passed
tests on experimental (except Hurd):
https://buildd.debian.org/status/package.php?p=c-ares=experimental

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

unblock c-ares/1.18.1-3

Thanks,
Gregor
diff -Nru c-ares-1.18.1/debian/changelog c-ares-1.18.1/debian/changelog
--- c-ares-1.18.1/debian/changelog  2023-02-17 23:34:35.0 +0100
+++ c-ares-1.18.1/debian/changelog  2023-05-23 07:58:02.0 +0200
@@ -1,3 +1,10 @@
+c-ares (1.18.1-3) unstable; urgency=medium
+
+  * Fix buffer underwrite in ares_inet_net_pton (CVE-2023-31130)
+  * Zero byte UDP packet causes DoS (CVE-2023-32067)
+
+ -- Gregor Jasny   Tue, 23 May 2023 07:58:02 +0200
+
 c-ares (1.18.1-2) unstable; urgency=medium
 
   * Add str len check in config_sortlist to avoid stack overflow
diff -Nru c-ares-1.18.1/debian/patches/CVE-2023-31130.diff 
c-ares-1.18.1/debian/patches/CVE-2023-31130.diff
--- c-ares-1.18.1/debian/patches/CVE-2023-31130.diff1970-01-01 
01:00:00.0 +0100
+++ c-ares-1.18.1/debian/patches/CVE-2023-31130.diff2023-05-23 
07:57:13.0 +0200
@@ -0,0 +1,319 @@
+From f22cc01039b6473b736d3bf438f56a2654cdf2b2 Mon Sep 17 00:00:00 2001
+From: Brad House 
+Date: Mon, 22 May 2023 06:51:34 -0400
+Subject: [PATCH 2/3] Merge pull request from GHSA-x6mf-cxr9-8q6v
+Applied-Upstream: 1.19.1, 
https://github.com/c-ares/c-ares/commit/f22cc01039b6473b736d3bf438f56a2654cdf2b2
+Bug: https://github.com/c-ares/c-ares/security/advisories/GHSA-x6mf-cxr9-8q6v
+
+* Merged latest OpenBSD changes for inet_net_pton_ipv6() into c-ares.
+* Always use our own IP conversion functions now, do not delegate to OS
+  so we can have consistency in testing and fuzzing.
+* Removed bogus test cases that never should have passed.
+* Add new test case for crash bug found.
+
+Fix By: Brad House (@bradh352)
+---
+ src/lib/inet_net_pton.c| 155 -
+ test/ares-test-internal.cc |   7 +-
+ 2 files changed, 86 insertions(+), 76 deletions(-)
+
+--- a/src/lib/inet_net_pton.c
 b/src/lib/inet_net_pton.c
+@@ -1,19 +1,20 @@
+ 
+ /*
+- * Copyright (c) 2004 by Internet Systems Consortium, Inc. ("ISC")
++ * Copyright (c) 2012 by Gilles Chehade 
+  * Copyright (c) 1996,1999 by Internet Software Consortium.
+  *
+  * Permission to use, copy, modify, and distribute this software for any
+  * purpose with or without fee is hereby granted, provided that the above
+  * copyright notice and this permission notice appear in all copies.
+  *
+- * THE SOFTWARE IS PROVIDED "AS IS" AND ISC DISCLAIMS ALL WARRANTIES
+- * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+- * MERCHANTABILITY AND FITNESS.  IN NO EVENT SHALL ISC BE LIABLE FOR
+- * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+- * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+- * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT
+- * OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
++ * THE SOFTWARE IS PROVIDED "AS IS" AND INTERNET SOFTWARE CONSORTIUM DISCLAIMS
++ * ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED 
WARRANTIES
++ * OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL INTERNET SOFTWARE
++ * CONSORTIUM BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL
++ * DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR
++ * PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS
++ * ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS
++ * SOFTWARE.
+  */
+ 
+ #include "ares_setup.h"
+@@ -35,9 +36,6 @@
+ 
+ const struct ares_in6_addr ares_in6addr_any = { { { 
0,0,0,0,0,0,0,

Bug#1031525: Upload through -security possible

[Gregor Jasny]

Hello,

It look like the clearance for -proposed takes some time (#1031652). 
Would it be possible to upload through -security even without a DSA?


Thanks,
Gregor

Bug#1031652: bullseye-pu: package c-ares/1.17.1-1+deb11u1 CVE-2022-4904

[Gregor Jasny]

Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian@packages.debian.org
Usertags: pu
X-Debbugs-Cc: c-a...@packages.debian.org
Control: affects -1 + src:c-ares

Dear Release Team,

[ Reason ]
I'd like to upload a new version of c-ares which fixes
CVE-2022-4904 (#1031525). According to the assessment of the 
Security Team the bug is not severe enough to warrant an upload
to bullseye-seurity but the patch should go into -proposed instead.

[ Impact ]
The CVE will stay unfixed.

[ Tests ]
The upstream patch also adds a test to the c-ares test suite.
I ran the test suite locally and it passes as expected.

[ Risks ]
IMO minimal risks.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

[ Changes ]
Backport of the upstream fix. It applied cleanly.

Thanks,
Gregor
diff -Nru c-ares-1.17.1/debian/changelog c-ares-1.17.1/debian/changelog
--- c-ares-1.17.1/debian/changelog  2021-08-07 11:56:59.0 +0200
+++ c-ares-1.17.1/debian/changelog  2023-02-18 00:24:32.0 +0100
@@ -1,3 +1,13 @@
+c-ares (1.17.1-1+deb11u2) bullseye; urgency=medium
+
+   * Fix CVE-2022-4904:
+ It was discovered that in c-ares, an asynchronous name resolver library,
+ the config_sortlist function is missing checks about the validity of the
+ input string, which allows a possible arbitrary length stack overflow and
+ thus may cause a denial of service. (Closes: #1031525)
+
+ -- Gregor Jasny   Sat, 18 Feb 2023 00:24:32 +0100
+
 c-ares (1.17.1-1+deb11u1) bullseye-security; urgency=high
 
   * Non-maintainer upload by the Security Team.
diff -Nru c-ares-1.17.1/debian/patches/CVE-2022-4904.diff 
c-ares-1.17.1/debian/patches/CVE-2022-4904.diff
--- c-ares-1.17.1/debian/patches/CVE-2022-4904.diff 1970-01-01 
01:00:00.0 +0100
+++ c-ares-1.17.1/debian/patches/CVE-2022-4904.diff 2023-02-18 
00:24:32.0 +0100
@@ -0,0 +1,36 @@
+Subject: Add str len check in config_sortlist to avoid stack overflow
+Origin: 
https://github.com/c-ares/c-ares/commit/9903253c347f9e0bffd285ae3829aef251cc852d
+Bug: https://github.com/c-ares/c-ares/issues/496
+Bug-Debian: https://bugs.debian.org/1031525
+
+--- a/src/lib/ares_init.c
 b/src/lib/ares_init.c
+@@ -2198,6 +2198,8 @@
+   q = str;
+   while (*q && *q != '/' && *q != ';' && !ISSPACE(*q))
+ q++;
++  if (q-str >= 16)
++return ARES_EBADSTR;
+   memcpy(ipbuf, str, q-str);
+   ipbuf[q-str] = '\0';
+   /* Find the prefix */
+@@ -2206,6 +2208,8 @@
+   const char *str2 = q+1;
+   while (*q && *q != ';' && !ISSPACE(*q))
+ q++;
++  if (q-str >= 32)
++return ARES_EBADSTR;
+   memcpy(ipbufpfx, str, q-str);
+   ipbufpfx[q-str] = '\0';
+   str = str2;
+--- a/test/ares-test-init.cc
 b/test/ares-test-init.cc
+@@ -270,6 +270,8 @@
+ 
+ TEST_F(DefaultChannelTest, SetSortlistFailures) {
+   EXPECT_EQ(ARES_ENODATA, ares_set_sortlist(nullptr, "1.2.3.4"));
++  EXPECT_EQ(ARES_EBADSTR, ares_set_sortlist(channel_, "111.111.111.111*/16"));
++  EXPECT_EQ(ARES_EBADSTR, ares_set_sortlist(channel_, 
"111.111.111.111/255.255.255.240*"));
+   EXPECT_EQ(ARES_SUCCESS, ares_set_sortlist(channel_, "xyzzy ; lwk"));
+   EXPECT_EQ(ARES_SUCCESS, ares_set_sortlist(channel_, "xyzzy ; 0x123"));
+ }
diff -Nru c-ares-1.17.1/debian/patches/series 
c-ares-1.17.1/debian/patches/series
--- c-ares-1.17.1/debian/patches/series 2021-08-07 11:56:59.0 +0200
+++ c-ares-1.17.1/debian/patches/series 2023-02-18 00:24:32.0 +0100
@@ -1,3 +1,4 @@
 disable-cflags-rewrite.diff
 ares_expand_name-should-escape-more-characters.patch
 ares_expand_name-fix-formatting-and-handling-of-root.patch
+CVE-2022-4904.diff

Bug#1031525: c-ares: CVE-2022-4904

[Gregor Jasny]

Hi Salvatore,

On 17.02.23 21:31, Salvatore Bonaccorso wrote:

The following vulnerability was published for c-ares.

CVE-2022-4904[0]:
| buffer overflow in config_sortlist() due to missing string length check


I uploaded a fixed package for sid and prepared an update for bullseye 
and buster:


https://salsa.debian.org/debian/c-ares/-/commits/bullseye/
https://salsa.debian.org/debian/c-ares/-/commits/buster/

Are you a member of the Debian Security team and could give me the green 
light to upload those two packages into the "security upload queue".


Thanks,
Gregor

Bug#1031027: libprometheus-cpp-core1.0: Library is built w/o optimization enabled

[Gregor Jasny]

Hello,

On 10.02.23 16:44, Max Dmitrichenko wrote:

The CMakeList.txt of the library doesn't contain default CMAKE_BUILD_TYPE to be 
set to Release. Neither this variable is not set in debian/rules file. So the 
resulting library is build with no optimization enabled which hits performance 
by factor of around 2x.



Setting CMAKE_BUILD_TYPE to None and using the distribution default 
C(XX)FLAGS is what debhelper defaults to [1].


In the prometheus-cpp build logs [2] I can see that the "-O2" 
optimization flags get applied.


How did you measure the performance degradation?

Thanks,
Gregor

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=701233#27
[2] 
https://buildd.debian.org/status/fetch.php?pkg=prometheus-cpp=amd64=1.0.1-1=1653219882=0

Bug#1018915: v4l-utils: FTBFS with libbpf 1.0.0

[Gregor Jasny]

Hi Sudip,

thanks for working on the patch!

On 10/30/22 10:43 AM, Sean Young wrote:

On Sat, Oct 29, 2022 at 11:17:03PM +0100, Sudip Mukherjee wrote:

Sean, would you be able to port the existing code to libbpf 1.0? I noticed
that the current code already triggers deprecation warnings with libbpf
0.8.0.


This needs porting, I'll add it to my todo list.


Can you please test the attached patch and confirm that it does not break
any of the functionality. This is the only one now which is blocking me
from requesting libbbpf transition.


That looks great, I'll give some good testing. Thanks for writing this
patch.

The way to get this merged upstream is to send to linux-me...@vger.kernel.org
and then get a review from the wider community.


Will you handle upstreaming it? Unfortunately, I don't have any Infrared 
Receiver hardware, anymore and cannot test it. So I'll wait for an ACK 
by Sean before applying it.


One thing I miss in the patch is tightening the pkg-config rule to a 
minimum required version which provides LIBBPF_OPTS. Proper place would 
be here:


https://git.linuxtv.org/v4l-utils.git/tree/configure.ac#n567

Thanks,
Gregor

Bug#997677: v4l-utils: FTBFS on riscv64 due to missing build-depends on clang:native

[Gregor Jasny]

Hello,

Thanks for noticing me about the missing riscv64 architecture. I was 
hoping that GCC catches up with eBPF compilation and I could omit clang 
altogether. But I guess I'll have to wait a little bit longer.


On 24.10.21 10:47, Aurelien Jarno wrote:

The missing file reported by dh_install is lacking as the "BPF IR
Decoders" are not enabled, because clang is not available in the
build-depends on riscv64, contrary to many other architectures.
Therefore the fix is as simple as adding riscv64 to the clang:native
build-depends:

--- v4l-utils-1.22.1/debian/control
+++ v4l-utils-1.22.1/debian/control
@@ -4,7 +4,7 @@
  Maintainer: Gregor Jasny 
  Uploaders: Loic Minier 
  Build-Depends: debhelper-compat (= 13),
-   clang:native [amd64 arm64 armel armhf i386 mips mips64el mipsel 
ppc64el s390x powerpc powerpcspe ppc64 sparc64 x32],
+   clang:native [amd64 arm64 armel armhf i386 mips mips64el mipsel 
ppc64el s390x powerpc powerpcspe riscv64 ppc64 sparc64 x32],
 doxygen,
 gettext,
 graphviz,

Could you please consider applying this patch for the future uploads?


I added the patch to the salsa git repo. It will be included with the 
next upload.



As a long-time member of Debian maybe you could give me an advise how to 
conditionally install the (conditionally created) systemd file. Creatin 
depends on the presence of clang and if systemd enabled bpf socket 
filtering (Debian does, Ubuntu does not). The decision is within the 
autoconf and based on it the systemd unit is created or omitted.


My approach
https://salsa.debian.org/debian/libv4l/-/commit/fe63c0af29bab9471daa6e0aba8d39e955777692

Seems to fail in the test-build-all

https://salsa.debian.org/debian/libv4l/-/jobs/2118024

Do you have an idea how to solve the problem more elegant?

Thanks,
Gregor

Bug#992053: c-ares: diff for NMU version 1.17.1-1.1

[Gregor Jasny]

Hello,

Thank you for handling this issue so quickly. I'm travelling for the next
week and won't be able to work on anything Debian related.

If you feel comfortable, you could also upload the fixed package without
any delay.

Thanks,
Gregor

Bug#983585: RFS: prometheus-cpp/0.12.1-1 [ITP] -- Prometheus Client Library for Modern C++

[Gregor Jasny]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "prometheus-cpp":

 * Package name: prometheus-cpp
   Version : 0.12.1-1
   Upstream Author : https://github.com/jupp0r/prometheus-cpp/issues
 * URL : https://github.com/jupp0r/prometheus-cpp
 * License : Expat, 0BSD, Apache-2.0
 * Vcs : https://salsa.debian.org/debian/prometheus-cpp
   Section : libs

It builds those binary packages:

  libprometheus-cpp-push0.12 - Prometheus Client Library for Modern C++ 
(push gateway support)
  libprometheus-cpp-pull0.12 - Prometheus Client Library for Modern C++ 
(pull support)
  libprometheus-cpp-core0.12 - Prometheus Client Library for Modern C++ 
(core metrics)
  prometheus-cpp-dev - Prometheus Client Library for Modern C++ 
(development files)


To access further information about this package, please visit the 
following URL:


  https://mentors.debian.net/package/prometheus-cpp/

Alternatively, one can download the package with dget using this command:

  dget -x 
https://mentors.debian.net/debian/pool/main/p/prometheus-cpp/prometheus-cpp_0.12.1-1.dsc


Changes for the initial release:

 prometheus-cpp (0.12.1-1) unstable; urgency=medium
 .
   * Initial release (Closes: #917817)

Regards,
--
  Gregor Jasny

Bug#979610: v4l-utils: vendors ancient version of libbpf

[Gregor Jasny]

Hello,

On 09.01.21 00:08, Luca Boccassi wrote:

v4l-utils embeds sources from a very old version of libbpf, from
before it split from the kernel. This version is mostly compatible
with the public standalone release, minus a small change.
It would be great to unvendorize it and use libbpf from the archive,
now that it's available.


Thank you for also pushing the patch to upstream v4l-utils. I'll try to 
release a new upstream version, soon which will fix the bug.


Up to now I also ran a Launchpad recipe for Ubuntu where I provide a PPA 
with the latest stable and development v4l-utils version. It looks like 
the libbpf-dev is only available since Ubuntu groovy.


Are you in any way affiliated with libbpf packaging and could provide a 
PPA with latest libbpf?


Thanks,
Gregor

Bug#811242: libc-ares-dev: Please provide way to talk to DNS servers on ports != 53

[Gregor Jasny]

Hello,

it seems that in recent versions ares_set_servers is also accepting 
custom ports for the configured list of servers:


https://manpages.debian.org/testing/libc-ares-dev/ares_set_servers.3.en.html

Does that solve your issue?

Thanks,
Gregor

Bug#957904: v4l-utils: ftbfs with GCC-10

[Gregor Jasny]

Hello,

Thanks for your bug report.

On 17.04.20 13:12, Matthias Klose wrote:

Package: src:v4l-utils
Version: 1.18.0-2
Severity: normal
Tags: sid bullseye
User: debian-...@lists.debian.org
Usertags: ftbfs-gcc-10


The issue is fixed in the following upstream commit:

https://git.linuxtv.org/v4l-utils.git/commit/?id=afb123618b087f3ca2305b84fb004624662e52f0

I'll discuss with upstream if we can cut a new release instead of 
cherry-picking.


Thanks,
Gregor

Bug#945365: v4l-utils: [INTL:de] Updated German translation

[Gregor Jasny]

Hello,

thank you for translating. I committed your translation upstream:
https://git.linuxtv.org/v4l-utils.git/commit/?id=9a1155dbaa1ce1b3d1610b223fe58fc65a734a10

And also addressed the fixme.

Thanks,
Gregor

Bug#940936: dvb-tools: dvbv5-scan fails to scan channels

[Gregor Jasny]

Hello Mauro,

Do you have an idea why scanning fails here?

Thanks,
Gregor

On 22.09.19 10:25, Clément Vuchener wrote:

Package: dvb-tools
Version: 1.16.7-1
Severity: important

Dear Maintainer,

I am trying to receive DVB-S2 using a Hauppauge WinTV Starbust 2 tuner
card. dvbv5-scan fails to find anything and always report status 00,
while w_scan successfully scanned channels. As reportbug asked me to use
the latest version, I installed sid versions of dvb-tools and libdvbv5-0
on my Debian Buster installation, but this did not change the result.

$ dvbv5-scan -l universal /usr/share/dvb/dvb-s/Atlantic-Bird-3-5.0W
Using LNBf UNIVERSAL
Old European Universal. Nowadays mostly replaced by Astra 19.2E
Freqs : 10800 to 11800 MHz, LO: 9750 MHz
Freqs : 11600 to 12700 MHz, LO: 10600 MHz
ERRORcommand BANDWIDTH_HZ (5) not found during retrieve
Cannot calc frequency shift. Either bandwidth/symbol-rate is unavailable (yet).
Scanning frequency #1 11012000
(0x00)
Scanning frequency #2 11012000
(0x00)
Scanning frequency #3 11012000
(0x00)
Scanning frequency #4 11179000
(0x00)
Scanning frequency #5 11179000
(0x00)
Scanning frequency #6 11179000
(0x00)
Scanning frequency #7 11637000
(0x00)
Scanning frequency #8 11637000
(0x00)
Scanning frequency #9 11637000
(0x00)
Scanning frequency #10 11637000
(0x00)
Scanning frequency #11 11637000
(0x00)
Scanning frequency #12 11637000
(0x00)
Scanning frequency #13 11675000
(0x00)
Scanning frequency #14 11675000
(0x00)
Scanning frequency #15 11675000
(0x00)
Scanning frequency #16 11675000
(0x00)
Scanning frequency #17 11675000
(0x00)
Scanning frequency #18 11675000
(0x00)
Scanning frequency #19 11675000
(0x00)
Scanning frequency #20 11675000
(0x00)
Scanning frequency #21 11675000
(0x00)
Scanning frequency #22 11675000
(0x00)
Scanning frequency #23 12585000
(0x00)
Scanning frequency #24 12585000
(0x00)
Scanning frequency #25 12606000
(0x00)
Scanning frequency #26 12606000
(0x00)
Scanning frequency #27 12648000
(0x00)
Scanning frequency #28 12648000
(0x00)
Scanning frequency #29 12669000
(0x00)
Scanning frequency #30 12669000
(0x00)

Scanning configuration files is from package dtv-scan-tables
0+git20171226.07b18ec-1.

Tuner is:
0b:00.0 Multimedia video controller [0400]: Conexant Systems, Inc. CX23887/8 
PCIe Broadcast Audio and Video Decoder with 3D Comb [14f1:8880] (rev 04)
Subsystem: Hauppauge computer works Inc. CX23887/8 PCIe Broadcast Audio 
and Video Decoder with 3D Comb [0070:f02a]
Flags: bus master, fast devsel, latency 0, IRQ 17
Memory at fbe0 (64-bit, non-prefetchable) [size=2M]
Capabilities: [40] Express Endpoint, MSI 00
Capabilities: [80] Power Management version 3
Capabilities: [90] Vital Product Data
Capabilities: [a0] MSI: Enable- Count=1/1 Maskable- 64bit+
Capabilities: [100] Advanced Error Reporting
Capabilities: [200] Virtual Channel
Kernel driver in use: cx23885
Kernel modules: cx23885

Kernel log does not report any issue:
sept. 22 08:11:56 htpc kernel: cx23885: cx23885 driver version 0.0.4 loaded
sept. 22 08:11:56 htpc kernel: cx23885: CORE cx23885[0]: subsystem: 0070:f02a, 
board: Hauppauge WinTV-Starburst2 [card=59,autodetected]
sept. 22 08:11:56 htpc kernel: tveeprom: Hauppauge model 150300, rev C2I9, 
serial# 4036111795
sept. 22 08:11:56 htpc kernel: tveeprom: MAC address is 00:0d:fe:92:2d:b3
sept. 22 08:11:56 htpc kernel: tveeprom: tuner model is unknown (idx 189, type 
4)
sept. 22 08:11:56 htpc kernel: tveeprom: TV standards UNKNOWN (eeprom 0x01)
sept. 22 08:11:56 htpc kernel: tveeprom: audio processor is CX23888 (idx 40)
sept. 22 08:11:56 htpc kernel: tveeprom: decoder processor is CX23888 (idx 34)
sept. 22 08:11:56 htpc kernel: tveeprom: has no radio, has IR receiver, has no 
IR transmitter
sept. 22 08:11:56 htpc kernel: cx23885: cx23885[0]: warning: unknown hauppauge 
model #150300
sept. 22 08:11:56 htpc kernel: cx23885: cx23885[0]: hauppauge eeprom: 
model=150300
sept. 22 08:11:56 htpc kernel: cx23885: cx23885_dvb_register() allocating 1 
frontend(s)
sept. 22 08:11:56 htpc kernel: cx23885: cx23885[0]: cx23885 based dvb card
sept. 22 08:11:56 htpc kernel: i2c i2c-1: Added multiplexed i2c bus 4
sept. 22 08:11:56 htpc kernel: Adding 3905532k swap on /dev/sda5.  Priority:-2 
extents:1 across:3905532k SSFS
sept. 22 08:11:56 htpc kernel: a8293 1-000b: Allegro A8293 SEC successfully 
attached
sept. 22 08:11:56 htpc kernel: m88rs6000t 4-0021: chip_id=64
sept. 22 08:11:56 htpc kernel: EXT4-fs (sda6): mounted filesystem with ordered 
data mode. Opts: (null)
sept. 22 08:11:56 htpc kernel: m88rs6000t 4-0021: Montage M88RS6000 internal 
tuner successfully identified
sept. 22 08:11:56 htpc kernel: dvbdev: 

Bug#923545: Offer to prepare Ninja 1.9.0 package

[Gregor Jasny]

Hello Felix,

I'd like to help you with Ninja 1.9.0 packaging. Would you agree to me 
preparing ninja 1.9.0 on salsa?


Right now I'm taking care of of two packages: v4l-utils (10+ years) and 
c-ares.


Thanks,
Gregor

Bug#929262: libv4l-dev: pac207 cam(s) give frame decode errors

[Gregor Jasny]

Hello,

On 20.05.19 10:25, folk...@vanheusden.com wrote:

Trying to get a pac207 camera to work with constatus.

2019-05-20 10:22:34.864900  INFO constatus [1-1] source v4l2 thread started
libv4l2: error got 4 consecutive frame decode errors, last error: v4l-convert: 
error unknown pac207 row header: 0x
2019-05-20 10:22:35.597949 ERROR cs:src_v4l2 [1-1] VIDIOC_DQBUF failed: 
Input/output error
ioctl(VIDIOC_QBUF) failed
errno: 22 (Invalid argument)

To verify that it is not a constatus-problem I also tried a raspberry-pi camera 
via its video4linux-interface and that works fine.


According to the Linux Kernel Maintainers file the device driver is 
maintained by Hans, which I CC'ed on this bug report:


GSPCA PAC207 SONIXB SUBDRIVER
M:  Hans Verkuil 
L:  linux-me...@vger.kernel.org
T:  git git://linuxtv.org/media_tree.git
S:  Odd Fixes
F:  drivers/media/usb/gspca/pac207.c

Did your camera ever work on another Kernel, CPU architecture, or 
v4l-utils version? Do you have anything suspicious in dmesg output?


Thanks,
Gregor

Bug#927341: libdvbv5-0: upgrade to version 1.16.3-2 break kaffeine

[Gregor Jasny]

Hello Antonio,

thank you for the bug report. I will look into it earliest in one week.

If you'd like to help out could you please test the 1.17 packages built
from master branch?

Theres a ppa repo that whose packages should also work on Debian:

https://code.launchpad.net/~libv4l/+archive/ubuntu/development

Thanks,
Gregor

Bug#925936: release.debian.org: Would v4l-utils 1.16.5 match unblocking criteria?

[Gregor Jasny]

Control: tags -1 - moreinfo

Hello,

A new patch turned up and I decided to only cherry-pick the three most 
important patches from the stable-1.16 tree.


Debdiff is attached.

If you agree on the changes I will upload via unstable.

Thanks,
Gregor
diff -Nru v4l-utils-1.16.3/debian/changelog v4l-utils-1.16.3/debian/changelog
--- v4l-utils-1.16.3/debian/changelog   2018-12-15 19:34:33.0 +0100
+++ v4l-utils-1.16.3/debian/changelog   2019-04-14 14:30:26.0 +0200
@@ -1,3 +1,9 @@
+v4l-utils (1.16.3-2) unstable; urgency=medium
+
+  * Fix double-free and uninitailized memory issue. LP: #1819650
+
+ -- Gregor Jasny   Sun, 14 Apr 2019 14:30:26 +0200
+
 v4l-utils (1.16.3-1) unstable; urgency=medium
 
   * Imported Upstream version 1.16.3
diff -Nru v4l-utils-1.16.3/debian/gbp.conf v4l-utils-1.16.3/debian/gbp.conf
--- v4l-utils-1.16.3/debian/gbp.conf2018-10-06 13:53:55.0 +0200
+++ v4l-utils-1.16.3/debian/gbp.conf2019-04-14 14:23:39.0 +0200
@@ -1,6 +1,6 @@
 [DEFAULT]
 upstream-branch = upstream
-debian-branch = master
+debian-branch = buster
 upstream-tag = upstream/%(version)s
 debian-tag = debian/%(version)s
 pristine-tar = True
diff -Nru 
v4l-utils-1.16.3/debian/patches/0003-dvbv5-tools-be-sure-to-zero-struct-arguments.patch
 
v4l-utils-1.16.3/debian/patches/0003-dvbv5-tools-be-sure-to-zero-struct-arguments.patch
--- 
v4l-utils-1.16.3/debian/patches/0003-dvbv5-tools-be-sure-to-zero-struct-arguments.patch
 1970-01-01 01:00:00.0 +0100
+++ 
v4l-utils-1.16.3/debian/patches/0003-dvbv5-tools-be-sure-to-zero-struct-arguments.patch
 2019-04-14 14:28:27.0 +0200
@@ -0,0 +1,50 @@
+Subject: dvbv5-tools: be sure to zero struct arguments
+Author: Mauro Carvalho Chehab 
+Origin: upstream, 
https://git.linuxtv.org/v4l-utils.git/commit/?h=stable-1.16=faef148b1b67bd17f879fd71746532c86e90
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1819650
+
+From 23e5056b0487acdaa56e5569952b5a8f344cf49b Mon Sep 17 00:00:00 2001
+Date: Thu, 14 Mar 2019 19:23:38 -0300
+
+Let's not let the arguments struct with some random value.
+
+Signed-off-by: Mauro Carvalho Chehab 
+---
+ utils/dvb/dvb-format-convert.c | 2 +-
+ utils/dvb/dvbv5-scan.c | 2 +-
+ utils/dvb/dvbv5-zap.c  | 2 +-
+ 3 files changed, 3 insertions(+), 3 deletions(-)
+
+--- a/utils/dvb/dvb-format-convert.c
 b/utils/dvb/dvb-format-convert.c
+@@ -123,7 +123,7 @@
+ 
+ int main(int argc, char **argv)
+ {
+-  struct arguments args;
++  struct arguments args = {};
+   int idx = -1, missing = 0;
+   const struct argp argp = {
+   .options = options,
+--- a/utils/dvb/dvbv5-scan.c
 b/utils/dvb/dvbv5-scan.c
+@@ -450,7 +450,7 @@
+ 
+ int main(int argc, char **argv)
+ {
+-  struct arguments args;
++  struct arguments args = {};
+   int err, lnb = -1,idx = -1;
+   struct dvb_device *dvb;
+   struct dvb_dev_list *dvb_dev;
+--- a/utils/dvb/dvbv5-zap.c
 b/utils/dvb/dvbv5-zap.c
+@@ -1018,7 +1018,7 @@
+ 
+ int main(int argc, char **argv)
+ {
+-  struct arguments args;
++  struct arguments args = {};
+   char *homedir = getenv("HOME");
+   char *channel = NULL;
+   int lnb = -1, idx = -1;
diff -Nru 
v4l-utils-1.16.3/debian/patches/0005-libdvbv5-leaks-and-double-free-in-dvb_fe_open_fname.patch
 
v4l-utils-1.16.3/debian/patches/0005-libdvbv5-leaks-and-double-free-in-dvb_fe_open_fname.patch
--- 
v4l-utils-1.16.3/debian/patches/0005-libdvbv5-leaks-and-double-free-in-dvb_fe_open_fname.patch
  1970-01-01 01:00:00.0 +0100
+++ 
v4l-utils-1.16.3/debian/patches/0005-libdvbv5-leaks-and-double-free-in-dvb_fe_open_fname.patch
  2019-04-14 14:28:25.0 +0200
@@ -0,0 +1,93 @@
+Subject: libdvbv5: leaks and double free in dvb_fe_open_fname()
+Author: Sean Young 
+Origin: upstream, 
https://git.linuxtv.org/v4l-utils.git/commit/?h=stable-1.16=c82608ca1595427c2bdbd4abb9aca9163e1df60a
+Bug-Ubuntu: https://bugs.launchpad.net/raspbian/+bug/1819650
+
+dvb_fe_open_fname() takes ownership of fname if the function succeeds, but
+also in two of the error paths (e.g. if the ioctl FE_GET_PROPERTY fails).
+
+Adjust dvb_fe_open_fname() so it copies fname rather than taking ownership
+(and passing that to params). This makes the code cleaner.
+
+Signed-off-by: Sean Young 
+---
+ lib/libdvbv5/dvb-dev-local.c |  2 +-
+ lib/libdvbv5/dvb-fe.c| 18 --
+ 2 files changed, 9 insertions(+), 11 deletions(-)
+
+--- a/lib/libdvbv5/dvb-dev-local.c
 b/lib/libdvbv5/dvb-dev-local.c
+@@ -467,7 +467,7 @@
+   flags &= ~O_NONBLOCK;
+   }
+ 
+-  ret = dvb_fe_open_fname(parms, strdup(dev->path), flags);
++  ret = dvb_fe_open_fname(parms, dev->path, flags);
+   if (ret) {
+   free(open_dev);
+   return NULL;
+--- a/lib/libdvbv5/dvb-fe.c
 b/lib/libdvbv5/dvb-fe.c
+@@ -133,7 +133,6 @@
+  

Bug#923545: ninja-build: Package ninja 1.9.0

[Gregor Jasny]

Package: ninja-build
Version: 1.8.2-1
Severity: wishlist

Hello,

could you please package ninja 1.9.0? If you need help I could
prepare a merge request on salsa.

Thanks,
Gregor

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages ninja-build depends on:
ii  libc6   2.28-5
ii  libstdc++6  8.2.0-14

ninja-build recommends no packages.

ninja-build suggests no packages.

-- no debconf information

Bug#917817: ITP: prometheus-cpp -- Prometheus Client Library for Modern C++

[Gregor Jasny]

Package: wnpp
Severity: wishlist
Owner: Gregor Jasny 

* Package name: prometheus-cpp
  Version : 0.7.0
  Upstream Author : Jupp Müller 
* URL : https://github.com/jupp0r/prometheus-cpp
* License : MIT
  Programming Lang: C++
  Description : Prometheus Client Library for Modern C++

This library aims to enable Metrics-Driven Development for C++ services.
It implements the Prometheus Data Model, a powerful abstraction on which
to collect and expose metrics. It offers the possibility for metrics to
be collected by Prometheus, but other push/pull collections can be added
as plugins.

Providing this library for the Debian ecosystem might help to overcome
the chicken-and-egg problem and hopefully will encourage more C++
based services to provide metrics.

Thanks,
Gregor

Bug#912904: v4l-utils FTCFBS due to clang dependency

[Gregor Jasny]

tags 912904 + pending
stop

Hello,

On 11/4/18 8:56 PM, Helmut Grohne wrote:

v4l-utils' build dependency on clang poses issues for cross compilation.
The dependency asks for the host architecture clang, which cannot be
run. It's not obvious that just changing it to the build architecture
clang works as clang has an architecture-dependent default target.
However, v4l-utils uses clang for compiling bpf sources and therefore
always passes -target to clang. And that means we can indeed safely
annotate it with :native. Please consider applying the attached patch.


thanks for the patch! I added it to the master packaging branch and will 
upload as soon as I have a fix for the mips FTBFS error.


Thanks,
Gregor

Bug#900240: cmake: FTBFS on hurd-i386

[Gregor Jasny]

Hello,

in https://gitlab.kitware.com/cmake/cmake/issues/18337#note_456628 CMake 
upstream suggested to use --system-libuv as additional bootstrap 
argument to use external libuv.


Maybe that would make the patch obsolete and the Debian rules more 
robust because libuv versions in Debian might be better adjusted to all 
of its tartet platforms?


Thanks,
Gregor

Bug#882085: Also in screenshots.d.o

[Gregor Jasny]

Dear maintainers,

In case you'll remove the image, please also take care of replacing the
package screenshot at
https://screenshots.debian.net/package/cowsay-off

Thanks,
Gregor

Bug#859715: Info received (resiprocate: Please migrate to openssl1.1 in Buster)

[Gregor Jasny]

There's also an upstream PR open:
https://github.com/resiprocate/resiprocate/pull/83

Bug#859715: resiprocate: Please migrate to openssl1.1 in Buster

[Gregor Jasny]

Hello,

I'll try to come up with a patch for that. Is anyone aware of a wiki 
page that has snippets for the most common migration problems?


Thanks,
Gregor

Bug#866333: jessie-pu: package c-ares/1.10.0-2+deb8u1

[Gregor Jasny]

Package: release.debian.org
Severity: normal
Tags: jessie
User: release.debian@packages.debian.org
Usertags: pu

Hello,

recently a buffer overlow in c-ares has been fixed and the Security Team
asked me to prepare an upload to jessie (see #865360).

Attached you'll find the debdiff.

Thanks,
Gregor

-- System Information:
Debian Release: 9.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru c-ares-1.10.0/debian/changelog c-ares-1.10.0/debian/changelog
--- c-ares-1.10.0/debian/changelog  2016-09-29 20:30:48.0 +0200
+++ c-ares-1.10.0/debian/changelog  2017-06-26 22:03:42.0 +0200
@@ -1,3 +1,9 @@
+c-ares (1.10.0-2+deb8u2) jessie; urgency=medium
+
+  * Add patch for CVE-2017-1000381 (Closes: #865360)
+
+ -- Gregor Jasny <gja...@googlemail.com>  Mon, 26 Jun 2017 22:03:42 +0200
+
 c-ares (1.10.0-2+deb8u1) jessie-security; urgency=high
 
   * Apply patch for CVE-2016-5180 (Closes: #839151)
diff -Nru c-ares-1.10.0/debian/patches/CVE-2017-1000381.diff 
c-ares-1.10.0/debian/patches/CVE-2017-1000381.diff
--- c-ares-1.10.0/debian/patches/CVE-2017-1000381.diff  1970-01-01 
01:00:00.0 +0100
+++ c-ares-1.10.0/debian/patches/CVE-2017-1000381.diff  2017-06-26 
22:03:42.0 +0200
@@ -0,0 +1,30 @@
+Origin: upstream, e1f43d4d7e89ef8db479d6efd0389c6b6ee1d116
+From: David Drysdale <drysd...@google.com>
+Date: Mon, 22 May 2017 10:54:10 +0100
+Subject: [PATCH 5/5] ares_parse_naptr_reply: check sufficient data
+Bug-Debian: http://bugs.debian.org/865360
+
+Check that there is enough data for the required elements
+of an NAPTR record (2 int16, 3 bytes for string lengths)
+before processing a record.
+
+--- a/ares_parse_naptr_reply.c
 b/ares_parse_naptr_reply.c
+@@ -110,6 +110,12 @@
+   status = ARES_EBADRESP;
+   break;
+ }
++  /* RR must contain at least 7 bytes = 2 x int16 + 3 x name */
++  if (rr_len < 7)
++{
++  status = ARES_EBADRESP;
++  break;
++}
+ 
+   /* Check if we are really looking at a NAPTR record */
+   if (rr_class == C_IN && rr_type == T_NAPTR)
+@@ -185,4 +191,3 @@
+ 
+   return ARES_SUCCESS;
+ }
+-
diff -Nru c-ares-1.10.0/debian/patches/series 
c-ares-1.10.0/debian/patches/series
--- c-ares-1.10.0/debian/patches/series 2016-09-29 20:28:42.0 +0200
+++ c-ares-1.10.0/debian/patches/series 2017-06-26 22:03:42.0 +0200
@@ -1,2 +1,3 @@
 disable-cflags-rewrite.diff
 CVE-2016-5180.diff
+CVE-2017-1000381.diff

Bug#866332: stretch-pu: package c-ares/1.12.0-1

[Gregor Jasny]

Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian@packages.debian.org
Usertags: pu

Hello,

recently a buffer overlow in c-ares has been fixed and the Security Team
asked me to prepare an upload to stretch (see #865360).

Attached you'll find the debdiff.

Thanks,
Gregor

-- System Information:
Debian Release: 9.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru c-ares-1.12.0/debian/changelog c-ares-1.12.0/debian/changelog
--- c-ares-1.12.0/debian/changelog  2016-09-29 18:19:09.0 +0200
+++ c-ares-1.12.0/debian/changelog  2017-06-26 22:00:03.0 +0200
@@ -1,3 +1,9 @@
+c-ares (1.12.0-1+deb9u1) stretch; urgency=medium
+
+  * Add patch for CVE-2017-1000381 (Closes: #865360)
+
+ -- Gregor Jasny <gja...@googlemail.com>  Mon, 26 Jun 2017 22:00:03 +0200
+
 c-ares (1.12.0-1) unstable; urgency=high
 
   [ Daniel Stenberg ]
diff -Nru c-ares-1.12.0/debian/gbp.conf c-ares-1.12.0/debian/gbp.conf
--- c-ares-1.12.0/debian/gbp.conf   2016-02-12 22:09:13.0 +0100
+++ c-ares-1.12.0/debian/gbp.conf   2017-06-26 22:00:03.0 +0200
@@ -1,6 +1,6 @@
 [DEFAULT]
 upstream-branch = upstream
-debian-branch = master
+debian-branch = stretch
 upstream-tag = upstream/%(version)s
 debian-tag = debian/%(version)s
 pristine-tar = True
diff -Nru c-ares-1.12.0/debian/patches/CVE-2017-1000381.diff 
c-ares-1.12.0/debian/patches/CVE-2017-1000381.diff
--- c-ares-1.12.0/debian/patches/CVE-2017-1000381.diff  1970-01-01 
01:00:00.0 +0100
+++ c-ares-1.12.0/debian/patches/CVE-2017-1000381.diff  2017-06-26 
22:00:03.0 +0200
@@ -0,0 +1,30 @@
+Origin: upstream, e1f43d4d7e89ef8db479d6efd0389c6b6ee1d116
+From: David Drysdale <drysd...@google.com>
+Date: Mon, 22 May 2017 10:54:10 +0100
+Subject: [PATCH 5/5] ares_parse_naptr_reply: check sufficient data
+Bug-Debian: http://bugs.debian.org/865360
+
+Check that there is enough data for the required elements
+of an NAPTR record (2 int16, 3 bytes for string lengths)
+before processing a record.
+
+--- a/ares_parse_naptr_reply.c
 b/ares_parse_naptr_reply.c
+@@ -110,6 +110,12 @@
+   status = ARES_EBADRESP;
+   break;
+ }
++  /* RR must contain at least 7 bytes = 2 x int16 + 3 x name */
++  if (rr_len < 7)
++{
++  status = ARES_EBADRESP;
++  break;
++}
+ 
+   /* Check if we are really looking at a NAPTR record */
+   if (rr_class == C_IN && rr_type == T_NAPTR)
+@@ -185,4 +191,3 @@
+ 
+   return ARES_SUCCESS;
+ }
+-
diff -Nru c-ares-1.12.0/debian/patches/series 
c-ares-1.12.0/debian/patches/series
--- c-ares-1.12.0/debian/patches/series 2016-02-12 22:09:13.0 +0100
+++ c-ares-1.12.0/debian/patches/series 2017-06-26 22:00:03.0 +0200
@@ -1 +1,2 @@
 disable-cflags-rewrite.diff
+CVE-2017-1000381.diff

Bug#863957: libv4l-0: Webcam does not work anymore

[Gregor Jasny]

Hello,

On 6/2/17 12:24 PM, Victor Porton wrote:
> libv4l2: error turning on stream: Input/output error
> libv4l2: error turning on stream: Input/output error

are there any errors in the Kernel message buffer visible? Please type
dmesg and look for errors.

Could you please try qv4l2 and check if it displays proper video?

Thanks,
Gregor

Bug#862295: unblock: v4l-utils/1.12.5-1

[Gregor Jasny]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package v4l-utils

Hello,

please unblock the latest stable version of v4l-utils 1.12. It fixes
a crash in the Digital Video Broadcasting (DVB) library that occurs
when a German DVB-T2 transport stream is parsed. Additionally it fixes
a bug where identical transport streams were not detected as such.

Thanks,
Gregor

diff -Nru v4l-utils-1.12.3/ChangeLog v4l-utils-1.12.5/ChangeLog
--- v4l-utils-1.12.3/ChangeLog  2017-02-17 20:07:58.0 +0100
+++ v4l-utils-1.12.5/ChangeLog  2017-05-10 20:23:45.0 +0200
@@ -1,3 +1,27 @@
+v4l-utils-1.12.5
+
+
+Mauro Carvalho Chehab (1):
+  dvb-scan: fix the logic for multi-section handling
+
+
+v4l-utils-1.12.4
+
+
+Clemens Ladisch (1):
+  libdvbv5: T2 delivery descriptor: fix wrong size of bandwidth field
+
+Mauro Carvalho Chehab (5):
+  desc_t2_delivery: consider valid to have a short T2 descriptor
+  desc_t2_delivery: properly handle cell and subcell tables
+  desc_t2_delivery: improve print dumps of T2 delivery
+  desc_t2_delivery: resize frequency array for subcel freqs
+  libdvbv5: add support for more PMT descriptors
+
+Reinhard Speyerer (1):
+  libdvbv5: fix T2 delivery descriptor parsing in 
dvb_desc_t2_delivery_init()
+
+
 v4l-utils-1.12.3
 
 
diff -Nru v4l-utils-1.12.3/configure v4l-utils-1.12.5/configure
--- v4l-utils-1.12.3/configure.ac   2017-02-17 20:05:46.0 +0100
+++ v4l-utils-1.12.5/configure.ac   2017-05-10 20:24:05.0 +0200
@@ -3,7 +3,7 @@
 # Process this file with autoconf to produce a configure script.
 
 AC_PREREQ(2.59)
-AC_INIT([v4l-utils],[1.12.3])
+AC_INIT([v4l-utils],[1.12.5])
 
 AC_CONFIG_AUX_DIR([build-aux])
 AC_CONFIG_MACRO_DIR([m4])
diff -Nru v4l-utils-1.12.3/contrib/cobalt-ctl/Makefile 
v4l-utils-1.12.5/contrib/cobalt-ctl/Makefile
diff -Nru v4l-utils-1.12.3/debian/changelog v4l-utils-1.12.5/debian/changelog
--- v4l-utils-1.12.3/debian/changelog   2017-02-17 20:14:26.0 +0100
+++ v4l-utils-1.12.5/debian/changelog   2017-05-10 20:29:42.0 +0200
@@ -1,3 +1,22 @@
+v4l-utils (1.12.5-1) unstable; urgency=medium
+
+  * Imported Upstream version 1.12.5 (Closes: #859008)
+
+ -- Gregor Jasny <gja...@googlemail.com>  Wed, 10 May 2017 20:29:42 +0200
+
+v4l-utils (1.12.4-1) unstable; urgency=medium
+
+  * Imported Upstream version 1.12.4 (Closes: #859008)
+  * Remove patches applied upstream
+
+ -- Gregor Jasny <gja...@googlemail.com>  Sat, 06 May 2017 19:29:03 +0200
+
+v4l-utils (1.12.3-2) unstable; urgency=medium
+
+  * Fix DVB descriptor parsing (Closes: #859008)
+
+ -- Gregor Jasny <gja...@googlemail.com>  Tue, 02 May 2017 22:12:52 +0200
+
 v4l-utils (1.12.3-1) unstable; urgency=medium
 
   * Imported Upstream version 1.12.3 (Closes: #854100)
diff -Nru v4l-utils-1.12.3/debian/control v4l-utils-1.12.5/debian/control
--- v4l-utils-1.12.3/debian/control 2017-01-22 21:28:14.0 +0100
+++ v4l-utils-1.12.5/debian/control 2017-05-06 19:27:07.0 +0200
@@ -21,7 +21,7 @@
 Standards-Version: 3.9.8
 Vcs-Browser: https://anonscm.debian.org/cgit/collab-maint/libv4l.git
 Vcs-Git: https://anonscm.debian.org/git/collab-maint/libv4l.git
-Homepage: http://linuxtv.org/downloads/v4l-utils/
+Homepage: https://linuxtv.org/downloads/v4l-utils/
 
 Package: libv4l-0
 Section: libs
diff -Nru v4l-utils-1.12.3/debian/libdvbv5-0.symbols 
v4l-utils-1.12.5/debian/libdvbv5-0.symbols
--- v4l-utils-1.12.3/debian/libdvbv5-0.symbols  2017-01-22 19:33:15.0 
+0100
+++ v4l-utils-1.12.5/debian/libdvbv5-0.symbols  2017-05-06 19:43:11.0 
+0200
@@ -271,6 +271,7 @@
  isdbt_interval@Base 1.4.0
  isdbt_mode@Base 1.4.0
  pmt_stream_name@Base 1.4.0
+ siso_miso@Base 1.12.4
  stack_dump@Base 1.12.1
  sys_atsc_props@Base 1.4.0
  sys_atscmh_props@Base 1.4.0
diff -Nru v4l-utils-1.12.3/debian/watch v4l-utils-1.12.5/debian/watch
--- v4l-utils-1.12.3/debian/watch   2016-06-15 21:34:30.0 +0200
+++ v4l-utils-1.12.5/debian/watch   2017-05-06 19:26:55.0 +0200
@@ -1,3 +1,3 @@
 version=4
-opts=pgpsigurlmangle=s/$/.asc/ http://linuxtv.org/downloads/@PACKAGE@/ 
@PACKAGE@@ANY_VERSION@@ARCHIVE_EXT@ debian uupdate
+opts=pgpsigurlmangle=s/$/.asc/ https://linuxtv.org/downloads/@PACKAGE@/ 
@PACKAGE@@ANY_VERSION@@ARCHIVE_EXT@ debian uupdate
 
diff -Nru v4l-utils-1.12.3/lib/include/libdvbv5/desc_t2_delivery.h 
v4l-utils-1.12.5/lib/include/libdvbv5/desc_t2_delivery.h
--- v4l-utils-1.12.3/lib/include/libdvbv5/desc_t2_delivery.h2017-01-22 
18:33:34.0 +0100
+++ v4l-utils-1.12.5/lib/include/libdvbv5/desc_t2_delivery.h2017-05-10 
20:21:39.0 +0200
@@ -45,10 +45,14 @@
  *
  * @param cell_id_extensioncell id extension
  * @param transposer_frequency transposer frequency
+ *
+ * NOTE: This struct is deprecated and will never be filled. All
+ * subcell transposer frequen

Bug#861941: v4l-utils: [INTL:de] Initial German translation

[Gregor Jasny]

Hello Chris,

On 5/6/17 9:36 AM, Chris Leick wrote:
> please find attached the initial German translations of v4l-utils.
> While translating, I've found some typos in the original string. I've
> marked them with "FIXME".

Thank you for providing the translation. I submitted your changes to the
v4l-utils master and also addressed all FIXMEs.

You can find the commits here:

https://git.linuxtv.org/v4l-utils.git/log/

Those changes will most probably not be included in the Stretch release
because the current package lacks packaging steps for translations.

Thanks,
Gregor

Bug#861941: v4l-utils: [INTL:de] Initial German translation

[Gregor Jasny]

Hello Chris,

On May 6, 2017 9:39 AM, "Chris Leick"  wrote:

Package: v4l-utils
Version: 1.12..3
Severity: wishlist
Tags: l10n patch



Hi,

please find attached the initial German translations of v4l-utils.
While translating, I've found some typos in the original string. I've
marked them with "FIXME".


Do you have a pointer to the l10n documentation if Debian packages? This is
my first localized package, I'm unsure how to handle it properly.

Thanks,
Gregor

Bug#859008: dvb-tools: dvbv5-scan segfaults with DVB-T2 HD service that just started in Germany

[Gregor Jasny]

Hello Mauro,

could you please take a look?

Thanks,
Gregor

On 3/30/17 9:36 PM, Frank Heckenbach wrote:
> I got the same problem, only on some channels though, e.g. ZDF using
> this input:
> 
> [CH34]
> DELIVERY_SYSTEM = DVBT2
> FREQUENCY = 57800
> BANDWIDTH_HZ = 800
> MODULATION = QAM/16
> 
> *** Error in `dvbv5-scan': malloc(): memory corruption: 0x00fe13c0 ***
> 
> I did some debugging with gdb and valgrind (using the upstream
> version v4l-utils-1.12.3.tar.bz2 since I needed to recompile anyway
> to get debug info).
> 
> I found an invalid access in descriptors/desc_t2_delivery.c:55
> 
>   memcpy(>centre_frequency, p, len);
> 
> Before this, dvb_extension_descriptor_init had
> 
>   desc_type == 4 (T2_delivery_system_descriptor)
> 
> and
> 
>   dvb_ext_descriptors[4].size == sizeof(struct dvb_desc_t2_delivery) (23)
> 
> so it allocated only 23 bytes, but didn't change desc_len which was
> still 68, causing the overflow.
> 
> Setting desc_len to 23 didn't help, but just allocating 68 bytes
> did:
> 
> --- v4l-utils-1.12.3/lib/libdvbv5/descriptors/desc_extension.c
> +++ v4l-utils-1.12.3/lib/libdvbv5/descriptors/desc_extension.c
> @@ -149,7 +149,7 @@
>   if (!size)
>   size = desc_len;
>  
> - ext->descriptor = calloc(1, size);
> + ext->descriptor = calloc(1, desc_len);
>  
>   if (init) {
>   if (init(parms, p, ext, ext->descriptor) != 0)
> 
> NOTE: This is probably not a proper fix, just a bandaid. Since
> scanning channels is mostly a one-off job, I'm happy now that I got
> my channels list and don't plan to invest more time resarching the
> issue.
> 

Bug#859008: dvb-tools: dvbv5-scan segfaults with DVB-T2 HD service that just started in Germany

[Gregor Jasny]

Hello Mauro & list,

could you please have a look at the dvbv5-scan crash report below?
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=859008

Is there anything else you need to debug this?

Thanks,
Gregor

On 3/29/17 4:42 PM, Tino Mettler wrote:
> 
> $ gdb --args ./utils/dvb/dvbv5-scan ~/tmp/dvb-t2/init2 
> GNU gdb (Debian 7.12-6) 7.12.0.20161007-git
> Copyright (C) 2016 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later 
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
> and "show warranty" for details.
> This GDB was configured as "x86_64-linux-gnu".
> Type "show configuration" for configuration details.
> For bug reporting instructions, please see:
> .
> Find the GDB manual and other documentation resources online at:
> .
> For help, type "help".
> Type "apropos word" to search for commands related to "word"...
> Reading symbols from ./utils/dvb/dvbv5-scan...done.
> (gdb) run
> Starting program: /home/scorpion/build/9643/v4l-utils/utils/dvb/dvbv5-scan 
> /home/scorpion/tmp/dvb-t2/init2
> [Thread debugging using libthread_db enabled]
> Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
> Scanning frequency #1 55400
> Lock   (0x1f) C/N= 23.75dB
> Service Das Erste HD, provider BR: reserved
> Service arte HD, provider BR: reserved
> Service PHOENIX HD, provider BR: reserved
> Service tagesschau24 HD, provider BR: reserved
> Service ONE HD, provider BR: reserved
> New transponder/channel found: #11: -1776415946
> New transponder/channel found: #12: 504706590
> New transponder/channel found: #13: 523640360
> New transponder/channel found: #14: 907948854
> New transponder/channel found: #15: -397832490
> New transponder/channel found: #16: 0
> New transponder/channel found: #17: 0
> New transponder/channel found: #18: 0
> New transponder/channel found: #19: 0
> New transponder/channel found: #20: 0
> New transponder/channel found: #21: 0
> New transponder/channel found: #22: 0
> New transponder/channel found: #23: 0
> New transponder/channel found: #24: 0
> New transponder/channel found: #25: 0
> New transponder/channel found: #26: 0
> New transponder/channel found: #27: 0
> New transponder/channel found: #28: 0
> New transponder/channel found: #29: 0
> New transponder/channel found: #30: 0
> New transponder/channel found: #31: 0
> New transponder/channel found: #32: 0
> New transponder/channel found: #33: 0
> New transponder/channel found: #34: 0
> New transponder/channel found: #35: 0
> New transponder/channel found: #36: 0
> New transponder/channel found: #37: 0
> New transponder/channel found: #38: 0
> New transponder/channel found: #39: 0
> New transponder/channel found: #40: 0
> New transponder/channel found: #41: 0
> New transponder/channel found: #42: 0
> New transponder/channel found: #43: 0
> New transponder/channel found: #44: 0
> New transponder/channel found: #45: 0
> New transponder/channel found: #46: 0
> New transponder/channel found: #47: 0
> New transponder/channel found: #48: 0
> New transponder/channel found: #49: 0
> New transponder/channel found: #50: 0
> New transponder/channel found: #51: 0
> New transponder/channel found: #52: 0
> New transponder/channel found: #53: 0
> New transponder/channel found: #54: 0
> New transponder/channel found: #55: 0
> New transponder/channel found: #56: 0
> New transponder/channel found: #57: 0
> New transponder/channel found: #58: 0
> New transponder/channel found: #59: 0
> New transponder/channel found: #60: 0
> New transponder/channel found: #61: 0
> New transponder/channel found: #62: 0
> New transponder/channel found: #63: 0
> New transponder/channel found: #64: 0
> New transponder/channel found: #65: 0
> New transponder/channel found: #66: 0
> New transponder/channel found: #67: 0
> New transponder/channel found: #68: 0
> New transponder/channel found: #69: 0
> New transponder/channel found: #70: 0
> New transponder/channel found: #71: 0
> New transponder/channel found: #72: 0
> New transponder/channel found: #73: 0
> New transponder/channel found: #74: 0
> New transponder/channel found: #75: 0
> Scanning frequency #2 65000
>(0x00) Signal= -69.00dBm
> Scanning frequency #3 73800
>(0x00) Signal= -76.00dBm
> Scanning frequency #4 57800
> Lock   (0x1f) Signal= -76.00dBm C/N= 27.25dB
> *** Error in `/home/scorpion/build/9643/v4l-utils/utils/dvb/dvbv5-scan': 
> malloc(): memory corruption: 0x557a6b70 ***
> === Backtrace: =
> /lib/x86_64-linux-gnu/libc.so.6(+0x70bcb)[0x7759fbcb]
> /lib/x86_64-linux-gnu/libc.so.6(+0x76f96)[0x775a5f96]
> /lib/x86_64-linux-gnu/libc.so.6(+0x78f69)[0x775a7f69]
> /lib/x86_64-linux-gnu/libc.so.6(__libc_calloc+0x27b)[0x775aa99b]
> 

Bug#859008: dvb-tools: dvbv5-scan segfaults with DVB-T2 HD service that just started in Germany

[Gregor Jasny]

Hello,

could you please re-try with a debug build?

git clone git://linuxtv.org/v4l-utils.git
cd v4l-utils
./bootstrap.sh
./configure --enable-static --disable-shared CFLAGS="-O0 -g" 
CXXFLAGS="-O0 -g"

make -j4
utils/dvb/dvbv5-scan

Thanks,
Gregor

Bug#855443: unblock: v4l-utils/1.12.3-1

[Gregor Jasny]

Package: release.debian.org
Severity: important
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package v4l-utils

The version in testing contains a revised DVB-S tuning logic
that is broken for some types of satellite-dish LNBs. Upstream
author and Linux Media subsystem maintainer Mauro Carvalho Chehab
fixed the bug and added some more logging for future incidents
of that sort. He also added an configuration entry for another
LNB. The changes look pretty straight-forward and I trust Mauro
to be ablke to decide what's -stable material and what is not.

Additionally the kFreeBSD build fix was applied upstream and
some translation files updated. All those changes were bundled
into a new stable v4l-utils release.

Thanks,
Gregor

diff -Nru v4l-utils-1.12.2/ChangeLog v4l-utils-1.12.3/ChangeLog
--- v4l-utils-1.12.2/ChangeLog  2017-01-22 21:56:18.0 +0100
+++ v4l-utils-1.12.3/ChangeLog  2017-02-17 20:07:58.0 +0100
@@ -1,3 +1,17 @@
+v4l-utils-1.12.3
+
+
+Gregor Jasny (1):
+  Apply FreeBSD header search paths also to kFreeBSD
+
+Mauro Carvalho Chehab (5):
+  dvb-sat: fix rangeswitch logic
+  dvb-sat: add verbose options for LNBf settings
+  dvb-sat: add support for Invacom QPH-031 LNBf
+  pt_BR: update translation file to reflect latest changes
+  dvb-sat: fix translation issues at LNBf settings
+
+
 v4l-utils-1.12.2
 
 
diff -Nru v4l-utils-1.12.2/configure.ac v4l-utils-1.12.3/configure.ac
--- v4l-utils-1.12.2/configure.ac   2017-01-22 21:56:44.0 +0100
+++ v4l-utils-1.12.3/configure.ac   2017-02-17 20:05:46.0 +0100
@@ -152,7 +152,7 @@
   linux*)
 linux_os="yes"
 ;;
-  freebsd*)
+  *freebsd*)
 freebsd_os="yes"
 ;;
 esac
diff -Nru v4l-utils-1.12.2/debian/changelog v4l-utils-1.12.3/debian/changelog
--- v4l-utils-1.12.2/debian/changelog   2017-01-23 20:42:16.0 +0100
+++ v4l-utils-1.12.3/debian/changelog   2017-02-17 20:14:26.0 +0100
@@ -1,3 +1,9 @@
+v4l-utils (1.12.3-1) unstable; urgency=medium
+
+  * Imported Upstream version 1.12.3 (Closes: #854100)
+
+ -- Gregor Jasny <gja...@googlemail.com>  Fri, 17 Feb 2017 20:14:26 +0100
+
 v4l-utils (1.12.2-2) unstable; urgency=medium
 
   * Apply FreeBSD header search paths also to kFreeBSD
diff -Nru v4l-utils-1.12.2/debian/patches/kfreebsd-header-search-path.diff 
v4l-utils-1.12.3/debian/patches/kfreebsd-header-search-path.diff
--- v4l-utils-1.12.2/debian/patches/kfreebsd-header-search-path.diff
2017-01-23 20:41:39.0 +0100
+++ v4l-utils-1.12.3/debian/patches/kfreebsd-header-search-path.diff
1970-01-01 01:00:00.0 +0100
@@ -1,15 +0,0 @@
-Author: Gregor Jasny <gja...@googlemail.com>
-Description: Apply FreeBSD header search paths also to kFreeBSD
-Applied-Upstream: 
https://git.linuxtv.org/v4l-utils.git/commit/?id=15479381d6924c02bb02755f0e05b84ddd1b4e1a
-
 a/configure.ac
-+++ b/configure.ac
-@@ -152,7 +152,7 @@
-   linux*)
- linux_os="yes"
- ;;
--  freebsd*)
-+  *freebsd*)
- freebsd_os="yes"
- ;;
- esac
diff -Nru v4l-utils-1.12.2/debian/patches/series 
v4l-utils-1.12.3/debian/patches/series
--- v4l-utils-1.12.2/debian/patches/series  2017-01-23 20:33:09.0 
+0100
+++ v4l-utils-1.12.3/debian/patches/series  2017-02-17 20:14:26.0 
+0100
@@ -1,2 +1 @@
-kfreebsd-header-search-path.diff
 dont-gererate-treeview.diff
diff -Nru v4l-utils-1.12.2/lib/libdvbv5/dvb-sat.c 
v4l-utils-1.12.3/lib/libdvbv5/dvb-sat.c
--- v4l-utils-1.12.2/lib/libdvbv5/dvb-sat.c 2017-01-22 18:33:34.0 
+0100
+++ v4l-utils-1.12.3/lib/libdvbv5/dvb-sat.c 2017-02-17 20:05:04.0 
+0100
@@ -152,6 +152,29 @@
},
}, {
.desc = {
+   .name = N_("Invacom QPH-031"),
+   .alias = "QPH031",
+   // Legacy fields - kept just to avoid API/ABI breakages
+   .lowfreq = 10750,
+   .highfreq = 11250,
+   .rangeswitch = 12200,
+   .freqrange = {
+   { 11700, 12200 },
+   { 12200, 12700 },
+   },
+   },
+   // Note: This LNBf can accept both V/H and L/R polarization
+   // on ports 1 and 3, V is 12V and H is 19V
+   // on ports 2 and 4, R is 12V and L is 19V
+   // This is the same as what's done for Universal LNBf, so,
+   // we don't need any special logic here to handle this special
+   // case.
+   .freqrange = {
+   { 11700, 12200, 10750, 12200  },
+   { 12200, 12700, 11250, 0  },
+   },
+   }, {
+   .desc = {
.name = N_("Big Dish - Monopoint LNBf"),
  

Bug#854100: Fwd: Re: Bug#854100: libdvbv5-0: fails to tune / scan

[Gregor Jasny]

 Forwarded Message 
Subject: Re: Bug#854100: libdvbv5-0: fails to tune / scan
Date: Fri, 17 Feb 2017 22:50:57 +0100
From: Marcel Heinz <quisqui...@gmx.de>
To: mche...@osg.samsung.com
CC: Linux Media Mailing List <linux-me...@vger.kernel.org>, Gregor Jasny
<gja...@googlemail.com>

Hi,

Am 13. Februar 2017 schrieb Mauro Carvalho Chehab:

> Em Fri, 10 Feb 2017 22:02:01 +0100
> Gregor Jasny <gjasny@xx> escreveu:
> 
>> Bug report against libdvbv5 is here:
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=854100
> 
> There was a bug at the logic that was checking if the frequency was
> at the range of the local oscillators. This patch should be addressing
> it:
>   
> https://git.linuxtv.org/v4l-utils.git/commit/?id=5380ad44de416a41b4972e8a9c147ce42b0e3ba0
> 
> With that, the logic now seems to be working fine:
> 
> $ ./utils/dvb/dvbv5-scan ~/Intelsat-34 --lnbf universal -vv
> Using LNBf UNIVERSAL
>   Universal, Europe
>   10800 to 11800 MHz, LO: 9750 MHz
>   11600 to 12700 MHz, LO: 10600 MHz
> ...
> Seeking for LO for 12.17 MHz frequency
> LO setting 0: 10.80 MHz to 11.80 MHz
> LO setting 1: 11.60 MHz to 12.70 MHz
> Multi-LO LNBf. using LO setting 1 at 10600.00 MHz
> frequency: 12170.00 MHz, high_band: 1
> L-Band frequency: 1570.00 MHz (offset = 10600.00 MHz)
> 
> I can't really test it here, as my satellite dish uses a different
> type of LNBf, but, from the above logs, the bug should be fixed.
> 
> Marcel,
> 
> Could you please test? The patch is already upstream.
> I added a debug patch after it, in order to help LNBf issues
> (enabled by using "-vv" command line parameters).

I can confirm that 1.12.3 solves the issue for me. Thanks for the fix.

Regards,
Marcel

Bug#854100: libdvbv5-0: fails to tune / scan

[Gregor Jasny]

Hello,

On 2/4/17 3:35 AM, Marcel Heinz wrote:
> After the upgrade from libdvbv5-0 1.10.1-1 to 1.12.2-2, any applications
> using libdvbv5-0 fail to work with my DVB-S card.
> 
> Output with old dvb-tools / libdvbv5-0 1.10.1-1:
> 
> |$ dvbv5-scan -l UNIVERSAL /usr/share/dvb/dvb-s/Astra-19.2e
> |Using LNBf UNIVERSAL
> |Europe
> |10800 to 11800 MHz and 11600 to 12700 MHz
> |  Dual LO, IF = lowband 9750 MHz, highband 10600 MHz
> |ERRORcommand BANDWIDTH_HZ (5) not found during retrieve
> |Cannot calc frequency shift. Either bandwidth/symbol-rate is unavailable 
> (yet).
> |Scanning frequency #1 12551500
> |Lock   (0x1f) Signal= 85,55% C/N= 99,84% postBER= 0
> | [scan runs normally from then on]
> 
> Output with new dvb-tools / libdvbv5-0 1.12.2-2:
> 
> |$ dvbv5-scan -l UNIVERSAL /usr/share/dvb/dvb-s/Astra-19.2e
> |Using LNBf UNIVERSAL
> |Europe
> |10800 to 11800 MHz and 11600 to 12700 MHz
> |  Dual LO, IF = lowband 9750 MHz, highband 10600 MHz
> |ERRORcommand BANDWIDTH_HZ (5) not found during retrieve
> |Cannot calc frequency shift. Either bandwidth/symbol-rate is unavailable 
> (yet).
> |Scanning frequency #1 12551500
> |ERRORFE_SET_PROPERTY: Invalid argument
> |ERRORdvb_fe_set_parms failed: Invalid argument
> 
> Similarily, kaffeine fails to tune to any channel, or to do a scan.
> Other applications not using libdvbv5-0 (mplayer, tvheadend) still
> work fine with the card.
> 
> DVB device is:
> 
> |$ dmesg | grep DVB
> | [8.641450] DVB: registering new adapter (FlexCop Digital TV device)
> | [8.662380] b2c2_flexcop_pci :09:00.0: DVB: registering adapter 0 
> frontend 0 (Conexant CX24123/CX24109)...
> | [8.662664] b2c2-flexcop: initialization of 'Sky2PC/SkyStar 2 DVB-S rev 
> 2.8' at the 'PCI' bus controlled by a 'FlexCopIIb' complete
> 
> -- System Information:
> Debian Release: 9.0
>   APT prefers testing
>   APT policy: (500, 'testing')
> Architecture: amd64 (x86_64)
> Foreign Architectures: i386
> 
> Kernel: Linux 4.9.0-1-amd64 (SMP w/4 CPU cores)
> Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)

Mauro, do you have an idea why tuning broke?

Thanks,
Gregor

Bug#847554: clang: Clang should produce position independent code by default

[Gregor Jasny]

Package: clang
Version: 1:3.8-34
Severity: normal

Dear Maintainer,

gcc nowadys seems to be built with --enable-default-pie config option.
That flag results in generation of position independent code and
executables by default:

$ gcc -dM -E - < /dev/null|egrep -i '(pie|pic)'
#define __pie__ 2
#define __PIE__ 2
#define __pic__ 2
#define __PIC__ 2

$ g++ -o main main.cpp && readelf -h ./main | grep Type
  Type: DYN (Shared object file)

>From a useability and security perspective it would be nice if clang
could follow the GCC behaviour.

Thanks,
Gregor

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.6.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages clang depends on:
ii  clang-3.8  1:3.8.1-16

clang recommends no packages.

clang suggests no packages.

-- no debconf information

Bug#839151: c-ares: CVE-2016-5180: out-of-bounds write in ares_create_query and ares_mkquery

[Gregor Jasny]

Hello Security Team,

This about https://security-tracker.debian.org/tracker/CVE-2016-5180 and
my first security upload. Please be gentle :)

For Sid and Stretch I uploaded 1.12.0-1 with urgency high.

For Jessie I backported the patch and prepared an upload to
jessie-security (debdiff also attached). Please review and tell me how
to proceed.

https://anonscm.debian.org/cgit/collab-maint/c-ares.git/log/?id=refs/heads/jessie
https://mentors.debian.net/debian/pool/main/c/c-ares/c-ares_1.10.0-2+deb8u1.dsc

Wheezy with c-ares 1.9.1 in not affected (stated in upstream announcement).

Thanks,
Gregor
diff -Nru c-ares-1.10.0/debian/changelog c-ares-1.10.0/debian/changelog
--- c-ares-1.10.0/debian/changelog  2013-06-16 13:39:20.0 +0200
+++ c-ares-1.10.0/debian/changelog  2016-09-29 20:30:48.0 +0200
@@ -1,3 +1,9 @@
+c-ares (1.10.0-2+deb8u1) jessie-security; urgency=high
+
+  * Apply patch for CVE-2016-5180 (Closes: #839151)
+
+ -- Gregor Jasny <gja...@googlemail.com>  Thu, 29 Sep 2016 20:30:48 +0200
+
 c-ares (1.10.0-2) unstable; urgency=low
 
   * Bump standards to v3.9.4 (no changes needed)
diff -Nru c-ares-1.10.0/debian/gbp.conf c-ares-1.10.0/debian/gbp.conf
--- c-ares-1.10.0/debian/gbp.conf   2012-05-10 21:24:25.0 +0200
+++ c-ares-1.10.0/debian/gbp.conf   2016-09-29 20:15:36.0 +0200
@@ -1,6 +1,6 @@
 [DEFAULT]
 upstream-branch = upstream
-debian-branch = master
+debian-branch = jessie
 upstream-tag = upstream/%(version)s
 debian-tag = debian/%(version)s
 pristine-tar = True
diff -Nru c-ares-1.10.0/debian/patches/CVE-2016-5180.diff 
c-ares-1.10.0/debian/patches/CVE-2016-5180.diff
--- c-ares-1.10.0/debian/patches/CVE-2016-5180.diff 1970-01-01 
01:00:00.0 +0100
+++ c-ares-1.10.0/debian/patches/CVE-2016-5180.diff 2016-09-29 
20:29:25.0 +0200
@@ -0,0 +1,138 @@
+From: Daniel Stenberg <dan...@haxx.se>
+Description: ares_create_query: avoid single-byte buffer overwrite 
(CVE-2016-5180)
+Origin: backport, https://c-ares.haxx.se/CVE-2016-5180.patch
+Bug-Debian: http://bugs.debian.org/839151
+
+
+--- a/ares_create_query.c
 b/ares_create_query.c
+@@ -85,57 +85,31 @@
+  */
+ 
+ int ares_create_query(const char *name, int dnsclass, int type,
+-  unsigned short id, int rd, unsigned char **buf,
+-  int *buflen, int max_udp_size)
++  unsigned short id, int rd, unsigned char **bufp,
++  int *buflenp, int max_udp_size)
+ {
+-  int len;
++  size_t len;
+   unsigned char *q;
+   const char *p;
++  size_t buflen;
++  unsigned char *buf;
+ 
+   /* Set our results early, in case we bail out early with an error. */
+-  *buflen = 0;
+-  *buf = NULL;
++  *buflenp = 0;
++  *bufp = NULL;
+ 
+-  /* Compute the length of the encoded name so we can check buflen.
+-   * Start counting at 1 for the zero-length label at the end. */
+-  len = 1;
+-  for (p = name; *p; p++)
+-{
+-  if (*p == '\\' && *(p + 1) != 0)
+-p++;
+-  len++;
+-}
+-  /* If there are n periods in the name, there are n + 1 labels, and
+-   * thus n + 1 length fields, unless the name is empty or ends with a
+-   * period.  So add 1 unless name is empty or ends with a period.
++  /* Allocate a memory area for the maximum size this packet might need. +2
++   * is for the length byte and zero termination if no dots or ecscaping is
++   * used.
+*/
+-  if (*name && *(p - 1) != '.')
+-len++;
+-
+-  /* Immediately reject names that are longer than the maximum of 255
+-   * bytes that's specified in RFC 1035 ("To simplify implementations,
+-   * the total length of a domain name (i.e., label octets and label
+-   * length octets) is restricted to 255 octets or less."). We aren't
+-   * doing this just to be a stickler about RFCs. For names that are
+-   * too long, 'dnscache' closes its TCP connection to us immediately
+-   * (when using TCP) and ignores the request when using UDP, and
+-   * BIND's named returns ServFail (TCP or UDP). Sending a request
+-   * that we know will cause 'dnscache' to close the TCP connection is
+-   * painful, since that makes any other outstanding requests on that
+-   * connection fail. And sending a UDP request that we know
+-   * 'dnscache' will ignore is bad because resources will be tied up
+-   * until we time-out the request.
+-   */
+-  if (len > MAXCDNAME)
+-return ARES_EBADNAME;
+-
+-  *buflen = len + HFIXEDSZ + QFIXEDSZ + (max_udp_size ? EDNSFIXEDSZ : 0);
+-  *buf = malloc(*buflen);
+-  if (!*buf)
+-  return ARES_ENOMEM;
++  len = strlen(name) + 2 + HFIXEDSZ + QFIXEDSZ +
++(max_udp_size ? EDNSFIXEDSZ : 0);
++  buf = malloc(len);
++  if (!buf)
++return ARES_ENOMEM;
+ 
+   /* Set up the header. */
+-  q = *buf;
++  q = buf;
+   memset(q, 0, HFIXEDSZ);
+   DNS_HEADER_SET_QID(q, id);
+   DNS_HEADER_SET_OPCODE(q, QUERY);
+@@ -159,8 +133,10 @@
+   q += HFIXEDSZ;
+   while (*name)
+ {
+-

Bug#827302: v4l-utils: FTBFS: jpeg_memsrcdest.h:6:1: error: conflicting types for 'jpeg_mem_src'

[Gregor Jasny]

Hello Bill and Ondřej,

Do you know how to properly detect jpeg_mem_src presence in libjpeg(turbo)?

Since the transition to jpegturbo my package FTBFS:

On 14/06/16 20:42, Chris Lamb wrote:

  In file included from jpeg.c:28:0:
  jpeg_memsrcdest.h:6:1: error: conflicting types for 'jpeg_mem_src'
   jpeg_mem_src (j_decompress_ptr cinfo, unsigned char * buffer,
   ^
  In file included from libv4lconvert-priv.h:31:0,
   from jpeg.c:26:
  /usr/include/jpeglib.h:923:14: note: previous declaration of 'jpeg_mem_src' 
was here
   EXTERN(void) jpeg_mem_src (j_decompress_ptr cinfo,
^


Would it make sense to change the check in the emulation layer [1] from

#if JPEG_LIB_VERSION < 80

to

#if JPEG_LIB_VERSION < 80 && !defined(MEM_SRCDST_SUPPORTED)

or should I add a check during autoconf?

Thanks,
Gregor

[1] 
https://git.linuxtv.org/v4l-utils.git/tree/lib/libv4lconvert/jpeg_memsrcdest.h

Bug#813883: PST: Considers version 1.8.1 newer than 1.10.0

[Gregor Jasny]

Package: qa.debian.org
Severity: normal

Hello,

the PTS page of v4l-utils[1] reminds me to package the new 1.8.1 version
of v4l-utils. But version 1.10.0 is already in sid and testing. It looks
like it does not do a version compare but a numeric one instead.

Thanks,
Gregor

[1] https://packages.qa.debian.org/v/v4l-utils.html

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.3.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Bug#813469: caff: Please restore support for older Perl versions

[Gregor Jasny]

Package: signing-party
Version: 2.2-1
Severity: normal

Dear Maintainer,

I'd like to use caff on a MacOSX installation with Perl v5.18.2. To do so I
have to apply the following patch:

  https://github.com/Homebrew/homebrew/pull/48717/files

Couly you please consider applying it?

Thanks,
Gregor

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.2.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=UTF-8 (charmap=locale: Cannot set LC_CTYPE 
to default locale: No such file or directory
locale: Cannot set LC_ALL to default locale: No such file or directory
ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages signing-party depends on:
ii  gnupg  1.4.19-5
ii  libc6  2.19-22
ii  libclass-methodmaker-perl  2.24-1+b1
ii  libgnupg-interface-perl0.52-2
ii  libmailtools-perl  2.13-1
ii  libmime-tools-perl 5.505-1
ii  libnet-idn-encode-perl 2.300-1+b1
ii  libterm-readkey-perl   2.33-1+b1
ii  libtext-template-perl  1.46-1
ii  perl   5.22.1-5
pn  python:any 
ii  qprint 1.1.dfsg.2-2

Versions of packages signing-party recommends:
ii  exim4-daemon-light [mail-transport-agent]  4.86-3
ii  libgd-perl [libgd-gd2-perl]2.53-2.1
ii  libpaper-utils 1.1.24+nmu4
ii  whiptail   0.52.18-1+b1

Versions of packages signing-party suggests:
ii  fonts-droid1:4.4.4r2-7
ii  imagemagick8:6.8.9.9-6
ii  mutt   1.5.24-1
pn  qrencode   
ii  texlive-font-utils 2015.20150917-1
ii  texlive-latex-extra2015.20150917-1
ii  texlive-latex-recommended  2015.20150917-1
pn  texlive-xetex  
pn  wipe   

-- debconf information excluded

Bug#812543: doxygen: segfaults while building v4l-utils on powerpc

[Gregor Jasny]

Package: doxygen
Version: 1.8.9.1-6
Severity: important

See the build log at
https://buildd.debian.org/status/fetch.php?pkg=v4l-utils=powerpc=1.10.0-1=1453631268

It looks like doxygen segfaults which breaks the build.

Thanks,
Gregor

Bug#811241: libc-ares-dev: Please provide ares_set_servers_csv(3) manual page

[Gregor Jasny]

On 17/01/16 05:43, Petter Reinholdtsen wrote:
> The ares_set_servers_csv(3) manual page being referenced from
> ares_set_servers(3) is missing in Debian.

The following manual pages are missing:

   ares_set_local_dev.3
   ares_set_local_ip4.3
   ares_set_local_ip6.3
   ares_set_servers_csv.3

I will add them to the Debian package and work with upstream to add it
to the distribution tarball.

Thanks,
Gregor

Bug#783075: 1.6.2 is out

[Gregor Jasny]

Hello Mathieu,

On 21/04/15 18:13, Mathieu Malaterre wrote:
 Package: v4l-utils
 
 It would be nice to package the latest upstream: 1.6.2. 

do you miss something in 1.6.0 that's in 1.6.2?

I'd like to do another upstream stable release within one or two weeks
and skip 1.6.1 and 1.6.2 alltogether. Hopefully the freeze will be over
then.

Thanks,
Gregor


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#728576: I'd like to adopt tvtime

[Gregor Jasny]

Hello,

I'd like to adopt the tvtime package. Will look into BTS and latest
upstream during the next days.

Thanks,
Gregor


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#770363: pre-approval: unblock: v4l-utils/1.6.0-2

[Gregor Jasny]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hello,

Iain Lane found a crash in the current v4l-utils which can
easily triggered by using certain webcams (#770340).

Upstream fixed the bug with a small patch which will be
included in 1.6.0-2.

Before uploading I'd like to have your pre-approval.

Thanks,
Gregor

unblock v4l-utils/1.6.0-2

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.11-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru v4l-utils-1.6.0/debian/changelog v4l-utils-1.6.0/debian/changelog
--- v4l-utils-1.6.0/debian/changelog	2014-10-05 20:48:12.0 +0200
+++ v4l-utils-1.6.0/debian/changelog	2014-11-20 19:45:23.0 +0100
@@ -1,3 +1,9 @@
+v4l-utils (1.6.0-2) unstable; urgency=medium
+
+  * Fix JPEG subsampling issue (Closes: #770340)
+
+ -- Gregor Jasny gja...@googlemail.com  Thu, 20 Nov 2014 19:39:33 +0100
+
 v4l-utils (1.6.0-1) unstable; urgency=medium
 
   * Imported Upstream version 1.6.0
diff -Nru v4l-utils-1.6.0/debian/patches/fix-jpeg-subsampling.diff v4l-utils-1.6.0/debian/patches/fix-jpeg-subsampling.diff
--- v4l-utils-1.6.0/debian/patches/fix-jpeg-subsampling.diff	1970-01-01 01:00:00.0 +0100
+++ v4l-utils-1.6.0/debian/patches/fix-jpeg-subsampling.diff	2014-11-20 19:45:23.0 +0100
@@ -0,0 +1,83 @@
+Author: Hans de Goede hdego...@redhat.com
+Origin: upstream, http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=757d7910ddf43d9a9187dddae4f51a57fb723e8d
+Date:   Thu Nov 20 13:03:35 2014 +0100
+Bug-Debian: http://bugs.debian.org/770340
+Description: v4lconvert: Fix decoding of jpeg data with no vertical sub-sampling
+
+Our YUV output is always 2x subsampled in both vertical and horizontal
+direction, but some cameras generate JPEG data which is only subsampled in
+the horizontal direction.
+
+Since averaging the extra UV data these JPEGs contains is somewhat slow,
+and UV data is not all that important anyways, we simple take every other
+line. Or at least that is the intent.
+
+But before this commit the code was not doing this properly, for each 16
+Y input lines 1 - 16 we also get 16 UV input lines 1 - 16, but we only need
+8 output lines. so we should store input line 1 or 2 in output line 1, input
+line 3 or 4 in output line 2, etc. Instead we were storing input lines
+9 - 16 into output lines 1 - 8, which leads to some unwanted color bleeding.
+
+More over this also leads for 1920x1080 JPEG to us writing (1080 / 8 + 1) / 2
+* 8 = 544 UV output lines rather then 540, this means that the last 4 U output
+lines overwrite the first 4 V output lines, and worse that the last 4 V output
+lines overrun the output buffer.
+
+So far this only lead to some wrong colors in various places, but since that
+we dynamically allocate the output buffer to just the right size this actually
+causes a crash.
+
+This commit fixes both the crash, and the wrong colors.
+
+Signed-off-by: Hans de Goede hdego...@redhat.com
+
+--- a/lib/libv4lconvert/jpeg.c
 b/lib/libv4lconvert/jpeg.c
+@@ -242,23 +242,34 @@
+ 			y_rows[y] = ydest;
+ 			ydest += width;
+ 		}
+-		for (y = 0; y  8; y++) {
+-			u_rows[y] = udest;
+-			v_rows[y] = vdest;
+-			udest += width / 2;
+-			vdest += width / 2;
++		/*
++		 * For v_samp == 1 were going to get 1 set of uv values per
++		 * line, but we need only 1 set per 2 lines since our output
++		 * has v_samp == 2. We store every 2 sets in 1 line,
++		 * effectively using the second set for each output line.
++		 */
++		if (v_samp == 1) {
++			for (y = 0; y  8; y++) {
++u_rows[y] = udest;
++v_rows[y] = vdest;
++y++;
++u_rows[y] = udest;
++v_rows[y] = vdest;
++udest += width / 2;
++vdest += width / 2;
++			}
++		} else { /* v_samp == 2 */
++			for (y = 0; y  8; y++) {
++u_rows[y] = udest;
++v_rows[y] = vdest;
++udest += width / 2;
++vdest += width / 2;
++			}
+ 		}
++
+ 		y = jpeg_read_raw_data(cinfo, rows, 8 * v_samp);
+ 		if (y != 8 * v_samp)
+ 			return -1;
+-
+-		/* For v_samp == 1 were going to get another set of uv values,
+-		   but we need only 1 set since our output has v_samp == 2, so
+-		   rewind u and vdest and overwrite the previous set. */
+-		if (cinfo-output_scanline % 16) {
+-			udest -= width * 8 / 2;
+-			vdest -= width * 8 / 2;
+-		}
+ 	}
+ 	return 0;
+ }
diff -Nru v4l-utils-1.6.0/debian/patches/series v4l-utils-1.6.0/debian/patches/series
--- v4l-utils-1.6.0/debian/patches/series	2014-10-05 20:47:46.0 +0200
+++ v4l-utils-1.6.0/debian/patches/series	2014-11-20 19:33:25.0 +0100
@@ -1,3 +1,4 @@
 dont-gererate-treeview.diff
 man-section.diff
 man-ellipsis.diff
+fix-jpeg-subsampling.diff

Bug#758572: Underlinked cmake executable

[Gregor Jasny]

Hello,

Some wild guesses:

I ran into something maybe similar some time ago:
https://lists.debian.org/debian-devel/2008/10/msg00359.html

it looks like glibc provides stubs for the pthread API if no threads are
present. A git grep pthread_create in the cmake source only showed
some invocations in the tests itself.

So IMHO the symbol is provided by glibc and linking pthread is not
necessary. If another component like libcurl uses pthreads then this
component needs to pull in the pthread dependency (which it does).

Thanks,
Gregor


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#763433: Color format emulation breaks GStreamer's V4L2 support since 1.4.0

[Gregor Jasny]

Hello,

Thank you for detailed bug report and the bisection.

On 30/09/14 10:57, Sebastian Dröge wrote:
 since version 1.4.0 the color format emulation in libv4l breaks 
 GStreamer's v4l2 support.
 
 In specific, this commit breaks it: 
 http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=10213c975afdfcc90aa7de39e66c40cd7e8a57f7

I
 
will revert that commit and try to fix the issue with the upcoming
v4l-utils 1.6.0.

Thanks,
Gregor


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#763035: Fwd: Re: Ship DTV Scan Tables in v5 format

[Gregor Jasny]

FYI

 Forwarded Message 
From: Mauro Carvalho Chehab mche...@osg.samsung.com

As a reference, this is what I did in Fedora:
http://koji.fedoraproject.org/koji/taskinfo?taskID=7710543

Basically, there are now two packages: one with the legacy format,
that works with the legacy dvb-apps (but doesn't have ISDB-T scan
files, because the old format is not compatible), and one with the
channel files using the new dvbv5 format, with is compatible with
v4l-utils applications (dvbv5-scan, dvbv5-zap), and have all scan
files there.

Regards,
Mauro


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#763170: RM: media-ctl -- ROM; Superseded by v4l-utils

[Gregor Jasny]

Package: ftp.debian.org
Severity: normal

Hello,

there is a RC bug (#753286) about broken co-installability of media-ctl and 
v4l-utils. Consensus with the media-ctl maintainer in that bug thread was to 
remove media-ctl.

Thanks,
Gregor


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#753286: Removal request for media-ctl filed

[Gregor Jasny]

block 753286 by 763170
stop

Hello,

I filed a removal request for media-ctl with #763170

Thanks,
Gregor


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#763035: Ship DTV Scan Tables in v5 format

[Gregor Jasny]

Package: dtv-scan-tables
Version: 0+git20140611.14bd6c7-1
Severity: wishlist

Hello,

I'm the Debian packager of v4l-utils which ships some DVBv5 related
utilities. During an email conversation Mauro Carvalho Chehab asked me
the following:

On 26/09/14 02:38, Mauro Carvalho Chehab wrote:
 Ah, btw if you know who maintains the dtv-scan-tables package on Debian,
 it could be worth to ask him to rebase the package to use the new format.
 The tables there were fully converted to DVBv5 format, and a Makefile
 target was added to generate the tables with the old format.

I admit I'm not that deep into DVB stuff and don't know which
consequences the change would have. Looking at the upstream repo it
seems that the Makefile now contains two targets: one for v3 and one for
v5 format.

So it seems that Mauro would like you to package a current snapshot with
the v5 tables.

Thanks,
Gregor


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#753286: v4l-utils and media-ctl: error when trying to install together

[Gregor Jasny]

Hello Andreas,

On 03/07/14 01:57, Andreas Bombe wrote:
 On Mon, Jun 30, 2014 at 02:38:33PM +0200, Gregor Jasny wrote:
 Is it reasonable if I add a conflict against media-ctl and you remove the
 package completely?
 
 Yes, I will take care of removing my package then.

Should I file a removal request?

Thanks,
Gregor


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#758308: RM: v4l-utils [kfreebsd-amd64 kfreebsd-i386] -- ANAIS; Upstream dropped kFreeBSD support for v4l-utils

[Gregor Jasny]

Package: ftp.debian.org
Severity: normal

Hi,

This is a follow up report for #756154. Please remove the *binary*
package v4l-utils from the kfreebsd architectures.

Thanks,
Gregor


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#758309: reportbug: Properly distinguish between source and binary packages in ftpmaster removal requests

[Gregor Jasny]

Package: reportbug
Version: 6.5.0+nmu1
Severity: wishlist

Hello,

I filed a ftp.debian.org removal request for the *binary* package
v4l-utils. But the source package does have the same name. So in my
request #756154 the ftpmaster tried to remove the source package with
that name.

I think it would be beneficial if the ftp.debian.org package removal
template would allow to distinguish between source and binary removals.

The wiki page at https://wiki.debian.org/ftpmaster_Removals also gives
no hint how to properly addess this problem.

Thanks,
Gregor 

-- Package-specific info:
** Environment settings:
DEBEMAIL=Gregor Jasny gja...@googlemail.com
INTERFACE=text

** /home/gjasny/.reportbugrc:
reportbug_version 4.12.6
mode advanced
ui text
no-cc
header X-Debbugs-CC: gja...@googlemail.com
smtphost reportbug.debian.org

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.11-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages reportbug depends on:
ii  apt   1.0.6
ii  python2.7.8-1
ii  python-reportbug  6.5.0+nmu1

reportbug recommends no packages.

Versions of packages reportbug suggests:
pn  claws-mail  none
pn  debconf-utils   none
pn  debsums none
ii  dlocate 1.02+nmu3
ii  emacs23-bin-common  23.4+1-4.1+b1
ii  file1:5.19-1
ii  gnupg   1.4.18-2
ii  postfix [mail-transport-agent]  2.11.1-1
ii  python-gtk2 2.24.0-3+b1
pn  python-gtkspell none
pn  python-urwidnone
pn  python-vte  none
ii  xdg-utils   1.1.0~rc1+git20111210-7.1

Versions of packages python-reportbug depends on:
ii  apt   1.0.6
ii  python2.7.8-1
ii  python-debian 0.1.22
ii  python-debianbts  1.12
ii  python-support1.0.15

python-reportbug suggests no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#756401: v4l2loopback: Please make v4l2loopback a Linux-only package

[Gregor Jasny]

Source: v4l2loopback
Severity: normal

Hello,

the v4l2loopback-utils has a dependency on v4l-utils. Unfortunately
v4l-utils is not available for kFreeBSD anymore. But because
v4l2loopback-utils unconditionally depends on v4l-utils, ftpmaster
refused to remove the now stale kFreeBSD versions of v4l-utils [1].
This effectively prevents migration to testing.

I see two possibilities:
1) Change v4lloopback Architecture: all to linux-any. I suppose the
   whole loopback driver does not work at all on kFreeBSD or Hurd.

2) Keep the Architecture: all but make v4l-utils a [linux-any]
   dependency. 

Thanks,
Gregor

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756154

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.11-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#756407: swrast_dri.so: undefined symbol: _glapi_tls_Dispatch

[Gregor Jasny]

Package: libgl1-mesa-dri
Version: 10.2.4-1
Severity: normal

Hello,

I'm running Debian in a Parallels VM with the VESA driver. But I have
the problem that no OpenGL support is available. glxinfo just gets
terminated after startup.

In the Xorg.0.log I see the following error which I supspect are related
to my problem:

[   717.202] (II) AIGLX: Screen 0 is not DRI2 capable
[   717.202] (EE) AIGLX: reverting to software rendering
[   717.207] (EE) AIGLX error: dlopen of 
/usr/lib/x86_64-linux-gnu/dri/swrast_dri.so failed 
(/usr/lib/x86_64-linux-gnu/dri/swrast_dri.so: undefined symbol: 
_glapi_tls_Dispatch)
[   717.207] (EE) GLX: could not load software renderer
[   717.207] (II) GLX: no usable GL providers found for screen 0

Do you have an idea what's wrong here? The symbol appears to be there:

root@sid:~# readelf -Ws /usr/lib/x86_64-linux-gnu/dri/swrast_dri.so |grep _glapi
 6:  0 NOTYPE  GLOBAL DEFAULT  UND _glapi_set_dispatch
30:  0 TLS GLOBAL DEFAULT  UND _glapi_tls_Dispatch
45:  0 TLS GLOBAL DEFAULT  UND _glapi_tls_Context
   115:  0 NOTYPE  GLOBAL DEFAULT  UND 
_glapi_check_multithread
   181:  0 NOTYPE  GLOBAL DEFAULT  UND _glapi_set_context
   239:  0 NOTYPE  GLOBAL DEFAULT  UND _glapi_add_dispatch
   313:  0 NOTYPE  GLOBAL DEFAULT  UND 
_glapi_get_proc_address
   319:  0 NOTYPE  GLOBAL DEFAULT  UND 
_glapi_get_dispatch_table_size
   323:  0 NOTYPE  GLOBAL DEFAULT  UND _glapi_get_context

I remember that I installed the Parallels X driver some years ago. But
becuse support for latest Xorg version appears there very late, I
reverted back to VESA. Maybe there is something left over?

Thanks,
Gregor

-- Package-specific info:
glxinfo:

DISPLAY is not set.

X server symlink status:

lrwxrwxrwx 1 root root 13 Sep 26  2010 /etc/X11/X - /usr/bin/Xorg
-rwxr-xr-x 1 root root 2327520 Apr 15 21:01 /usr/bin/Xorg

VGA-compatible devices on PCI bus:
--
01:00.0 VGA compatible controller [0300]: Parallels, Inc. Accelerated Virtual 
Video Adapter [1ab8:4005]

/etc/X11/xorg.conf does not exist.

/etc/X11/xorg.conf.d does not exist.

KMS configuration files:

/etc/modprobe.d/i915-kms.conf:
  options i915 modeset=1
/etc/modprobe.d/radeon-kms.conf:
  options radeon modeset=1

Kernel version (/proc/version):
---
Linux version 3.11-1-amd64 (debian-ker...@lists.debian.org) (gcc version 4.8.1 
(Debian 4.8.1-10) ) #1 SMP Debian 3.11.6-2 (2013-11-01)

Xorg X server log files on system:
--
-rw-r--r-- 1 root root 116960 Mar 18 22:15 /var/log/Xorg.1.log
-rw-r--r-- 1 root root 113832 Jul 29 16:53 /var/log/Xorg.0.log

Contents of most recent Xorg X server log file (/var/log/Xorg.0.log):
-
[   717.164] 
X.Org X Server 1.15.1
Release Date: 2014-04-13
[   717.164] X Protocol Version 11, Revision 0
[   717.164] Build Operating System: Linux 3.13-1-amd64 x86_64 Debian
[   717.164] Current Operating System: Linux sid 3.11-1-amd64 #1 SMP Debian 
3.11.6-2 (2013-11-01) x86_64
[   717.164] Kernel command line: BOOT_IMAGE=/boot/vmlinuz-3.11-1-amd64 
root=UUID=3b0feeb6-7c29-4d77-b282-5b758ec054c1 ro quiet
[   717.165] Build Date: 15 April 2014  06:58:36PM
[   717.165] xorg-server 2:1.15.1-1 (http://www.debian.org/support) 
[   717.165] Current version of pixman: 0.32.6
[   717.165]Before reporting problems, check http://wiki.x.org
to make sure that you have the latest version.
[   717.165] Markers: (--) probed, (**) from config file, (==) default setting,
(++) from command line, (!!) notice, (II) informational,
(WW) warning, (EE) error, (NI) not implemented, (??) unknown.
[   717.165] (==) Log file: /var/log/Xorg.0.log, Time: Tue Jul 29 16:53:11 
2014
[   717.165] (==) Using system config directory /usr/share/X11/xorg.conf.d
[   717.165] (==) No Layout section.  Using the first Screen section.
[   717.165] (==) No screen section available. Using defaults.
[   717.165] (**) |--Screen Default Screen Section (0)
[   717.165] (**) |   |--Monitor default monitor
[   717.165] (==) No monitor specified for screen Default Screen Section.
Using a default monitor configuration.
[   717.165] (==) Automatically adding devices
[   717.165] (==) Automatically enabling devices
[   717.165] (==) Automatically adding GPU devices
[   717.166] (WW) The directory /usr/share/fonts/X11/cyrillic does not exist.
[   717.166]Entry deleted from font path.
[   717.166] (==) FontPath set to:
/usr/share/fonts/X11/misc,
/usr/share/fonts/X11/100dpi/:unscaled,
/usr/share/fonts/X11/75dpi/:unscaled,
/usr/share/fonts/X11/Type1,
/usr/share/fonts/X11/100dpi,

Bug#756154: RM: v4l-utils [kfreebsd-amd64 kfreebsd-i386] -- ANAIS; Upstream dropped support for V4L utilities on kFreeBSD

[Gregor Jasny]

Hello,

On 28/07/14 14:49, Scott Kitterman wrote:
 On Saturday, July 26, 2014 21:14:55 Gregor Jasny wrote:
 Package: ftp.debian.org Severity: normal
 
 Please remove the binary packages v4l-utils, qv4l2, dvb-tools,
 ir-keytable on [kfreebsd-amd64 kfreebsd-i386].
 
 There are significant rdepends that will have to be dealt with
 first.  Please remove the moreinfo tag once these are addressed:
 
 # Broken Build-Depends: amsn: libv4l-dev
...
 zoneminder: libv4l-dev (= 0.8.3)

What I want you to do is to remove the *binary* packages v4l-utils,
qv4l2, dvb-tools, ir-keytable on [kfreebsd-amd64 kfreebsd-i386], not
the source package v4l-utils.

In the reportbug mask I could not find a way to distinguish source and
binary packages. That's why I wrote my little comment into the bug
report itself.

I hope this clarifies my intents. For more background please have a
look at:

https://www.mail-archive.com/debian-release@lists.debian.org/msg75705.html

Thanks,
Gregor


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#756154: RM: v4l-utils [kfreebsd-amd64 kfreebsd-i386] -- ANAIS; Upstream dropped support for V4L utilities on kFreeBSD

[Gregor Jasny]

Package: ftp.debian.org
Severity: normal

Please remove the binary packages v4l-utils, qv4l2, dvb-tools, ir-keytable on 
[kfreebsd-amd64 kfreebsd-i386].

Thanks,
Gregor 


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#753286: v4l-utils and media-ctl: error when trying to install together

[Gregor Jasny]

Hi,

I did not notice that there is already an existing media-ctl package. 
Otherwise I'd have done an more coordinated upload.


How do we want to go from here? It seems that upstream decided to add 
the code to v4l-utils.


Is it reasonable if I add a conflict against media-ctl and you remove 
the package completely?


Thanks,
Gregor


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#743229: cmake: Suggest or recommend ninja-build

[Gregor Jasny]

Package: cmake
Version: 2.8.12.1-1.1
Severity: wishlist

Hello,

the ninja build tool is a good replacement for make.
Please add the ninja-build package as suggestion or
recommendation.

Thanks,
Gregor

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.11-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages cmake depends on:
ii  cmake-data2.8.12.1-1.1
ii  libarchive13  3.1.2-8
ii  libc6 2.18-4
ii  libcurl3  7.35.0-1
ii  libexpat1 2.1.0-4
ii  libgcc1   1:4.8.2-16
ii  libstdc++64.8.2-16
ii  procps1:3.3.9-4
ii  zlib1g1:1.2.8.dfsg-1

Versions of packages cmake recommends:
ii  gcc   4:4.8.2-2
ii  make  3.81-8.3

Versions of packages cmake suggests:
pn  codeblocks  none
pn  eclipse none

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#743231: cmake: Please provide 3.0-rc3 as experimental build

[Gregor Jasny]

Package: cmake
Version: 2.8.12.1-1.1
Severity: wishlist

Hello,

A snapshot of the upcoming cmake 3.0 has been released. It would
be great if you could package it and upload to experimental.

Thanks,
Gregor

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.11-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages cmake depends on:
ii  cmake-data2.8.12.1-1.1
ii  libarchive13  3.1.2-8
ii  libc6 2.18-4
ii  libcurl3  7.35.0-1
ii  libexpat1 2.1.0-4
ii  libgcc1   1:4.8.2-16
ii  libstdc++64.8.2-16
ii  procps1:3.3.9-4
ii  zlib1g1:1.2.8.dfsg-1

Versions of packages cmake recommends:
ii  gcc   4:4.8.2-2
ii  make  3.81-8.3

Versions of packages cmake suggests:
pn  codeblocks  none
pn  eclipse none

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#737901: libv4l-0: Please clarify license of the library.

[Gregor Jasny]

Hi Kurt,

On 06/02/14 21:48, Kurt Roeckx wrote:
 According to the copyright file, there are sources covered by the
 GPL-2, GPL-2+, LGPL-2+ and LGPL-2.1+, an some other licenses.  However
 it's not clear which files end up in the resulting library and so
 what the resulting license is, or those from other binaries.
 
 I know that at least some people stay away because of the GPL
 instead of the LGPL.
 
 Could you please clarify the license as they apply to the
 binaries?  And if the GPL applies to the library, could you
 please ask for a change in license so that everything is
 LGPL?

the libv4l libraries (libv4l1, libv4l2, and libv4lconvert are all
covered by LGPL-2.1+). libv4lconvert utilizes two GPL helper binaries to
decode ancient OV51* picture formats. We tried to contact the original
author of this code but got no response.

I will write a paragraph about the licensing of the components on top of
the copyright file.

Thanks,
Gregor


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#733100: libv4l2rds0: Typo in package description: straem

[Gregor Jasny]

tags 733100 + pending
thanks

Changed in git repository. Will get fixed with next upload.


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#701548: libv4l-0: bashism in /bin/sh script

[Gregor Jasny]

Hello,

I'll fix the shell rediretion with the next upload. But the other
complain puzzles me:

On 2/24/13 7:07 AM, Raphael Geissert wrote:
 checkbashisms' output:
 possible bashism in ./usr/share/bug/libv4l-0 line 5 ('command' with option
 other than -p):
 if command -v v4l-info  /dev/null

 You can find hints about how to fix bashisms at:
 https://wiki.ubuntu.com/DashAsBinSh

Your linked Wiki page states:
 Also, the following can be used to check for the presence of the time program.
 ...
  # if statement
 if [ ! $(command -v time) ]; then
 echo time is not installed
 exit 1
 fi

So the example also uses the -v option. Is the -v option allowed or not?

Thanks,
Gregor


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#583585: dpkg-maintscript-helper: replace symlink with directory

[Gregor Jasny]

Hello,

In my v4l-utils package I want to replace a documentation symlink with a
directory. When I was searching for the proper solution I stumbled upon
this bug.

Attached you'll find my proposal how to implement the symlink_to_dir
function. (Please disregard any indention problems for now).

I'd like to call the new function the following way:
dpkg-maintscript-helper.sh symlink_to_dir /usr/share/doc/libv4l-dev
libv4l0 -- $@

The first parameter is the symlink that should be replaced, the second
is the target it pointed to when an old package installed it first.

Via the original target it should be possible to detect any changes by
the system administrator and leave the symlink as is.

There are some open questions on my side:
1) Do you see a demand to also require a LASTVERSION argument?
2) Shold I also check where $SYMLINK.dpkg-remove is pointing to in the
post* scripts?
3) Is there a testbed where I can add tests for this?
4) What about downgrading packages? Would that be an use case, too?

Thanks,
Gregor
diff --git a/scripts/dpkg-maintscript-helper.sh 
b/scripts/dpkg-maintscript-helper.sh
index 48793b8..36792fe 100755
--- a/scripts/dpkg-maintscript-helper.sh
+++ b/scripts/dpkg-maintscript-helper.sh
@@ -216,6 +216,55 @@ abort_mv_conffile() {
fi
 }
 
+##
+## Functions to replace a symlink with a directory
+##
+symlink_to_dir() {
+local SYMLINK=$1
+local SYMLINK_TARGET=$2
+
+   # Skip remaining parameters up to --
+   while [ $1 != -- -a $# -gt 0 ]; do shift; done
+   [ $# -gt 0 ] || badusage
+   shift
+
+   [ -n SYMLINK ] || error symlink parameter is missing
+   [ -n SYMLINK_TARGET ] || original symlink target is missing
+   [ -n $1 ] || error maintainer script parameters are missing
+   [ -n $DPKG_MAINTSCRIPT_NAME ] || \
+   error environment variable DPKG_MAINTSCRIPT_NAME is required
+
+   debug Executing $0 symlink_to_dir in $DPKG_MAINTSCRIPT_NAME \
+ of $DPKG_MAINTSCRIPT_PACKAGE
+   debug SYMLINK=$SYMLINK - $SYMLINK_TARGET  \
+ ACTION=$1 PARAM=$2
+
+   case $DPKG_MAINTSCRIPT_NAME in
+   preinst)
+   if [ $1 = install -o $1 = upgrade ]  [ -n $2 ]  [ 
-L $SYMLINK ]  [ $(readlink $SYMLINK) = $SYMLINK_TARGET ]; then
+   mv -f $SYMLINK $SYMLINK.dpkg-remove
+   fi
+   ;;
+   postinst)
+   if [ $1 = configure ]  [ -L $SYMLINK.dpkg-remove ]; then
+   rm -f $SYMLINK.dpkg-remove
+   fi
+   ;;
+   postrm)
+   if [ $1 = purge ]  [ -L $SYMLINK.dpkg-remove ]; then
+   rm -f $SYMLINK.dpkg-remove
+   fi
+   if [ $1 = abort-install -o $1 = abort-upgrade ]  [ -n 
$2 ]  [ -L $SYMLINK.dpkg-remove ]  [ ! -e $SYMLINK ]; then
+   echo Reinstalling $SYMLINK that was moved away
+   mv $SYMLINK.dpkg-remove $SYMLINK
+   fi
+   ;;
+   *)
+   debug $0 symlink_to_dir not required in $DPKG_MAINTSCRIPT_NAME
+   ;;
+   esac
+}
+
 # Common functions
 debug() {
if [ -n $DPKG_DEBUG ]; then
@@ -244,6 +293,9 @@ Commands:
postrm.
   mv_conffile old-conf new-conf [last-version [package]]
Rename a conffile. Must be called in preinst, postinst and postrm.
+  symlink_to_dir symlink original-symlink-target
+Replace a symlink with a directory. Must be called in preinst,
+postinst and postrm.
   help
Display this usage information.
 END
@@ -266,7 +318,7 @@ shift
 case $command in
 supports)
case $1 in
-   rm_conffile|mv_conffile)
+   rm_conffile|mv_conffile|symlink_to_dir)
code=0
;;
*)
@@ -289,6 +341,9 @@ rm_conffile)
 mv_conffile)
mv_conffile $@
;;
+symlink_to_dir)
+   symlink_to_dir $@
+   ;;
 --help|help|-?)
usage
;;

Bug#680640: [libc-ares2] name resolves in descriptions

[Gregor Jasny]

Dear l10n-english team,

could you please comment on Bug 680640?

On 7/7/12 5:07 PM, Filipus Klutiero wrote:
 Package: libc-ares2
 Version: 1.9.1-3
 Severity: minor
 
 The short description reads:
 
 library for asynchronous name resolves
 
 One can say that foo.com resolves to 192.168.0.1, but - although I am
 not a native speaker of English - I don't think resolves can be used
 in the sense of name resolutions. The noun resolves exists, but not
 with that meaning.

Thanks for your help,
Gregor


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#680640: [libc-ares2] name resolves in descriptions

[Gregor Jasny]

tags 680640 + patch pending
thanks

On 11/4/12 1:20 PM, Justin B Rye wrote:
 It's true - resolve does exist as a noun, but not with this meaning
 (and it probably doesn't have a plural).
 The long description (following the upstream webpage) has some grammar
 and punctuation oddities too; patch and revised version attached.

Thank you, I applied your patch to the c-ares git repository:
http://anonscm.debian.org/gitweb/?p=collab-maint/c-ares.git;a=commit;h=5174fb608821f61a870daa6301a9e8b56af446d1

It will be applied with the next package upload.

Thanks,
Gregor


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#657395: cinnamon needs to build depend on gnome-common

[Gregor Jasny]

Hello Nicolas,

I tried to compile your package on my unclean desktop system. There I
catched the following error:

   dh_testdir
   debian/rules override_dh_autoreconf
make[1]: Entering directory `/home/gjasny/src/debian/cinnamon-1.4+up3+repack'
dh_autoreconf --as-needed ./autogen.sh
You need to install gnome-common from GNOME Git (or from
your OS vendor's package manager).
dh_autoreconf: ./autogen.sh returned exit code 1
make[1]: *** [override_dh_autoreconf] Error 2
make[1]: Leaving directory `/home/gjasny/src/debian/cinnamon-1.4+up3+repack'

After I installed gnome-common, everything built as expected.

Thanks,
Gregor


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#655791: Can this bug be closed?

[Gregor Jasny]

Hello Alexander,

ipvsadm 1:1.26 builds fine here. The dpatch directory also contains a 
patch that seems to fix the popt multiarch breakage. But the changelog 
does not mention it.


Thanks,
Gregor



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#669479: Time to upload fix for #669479

[Gregor Jasny]

Hello Artur,

maybe you should just NMU upload to DELAYED/2.

Thanks,
Gregor



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#664943: Should be buildable again

[Gregor Jasny]

Hello,

since #677705 is fixed, this package should be buildable with gcc  4.7, 
again.


Thanks,
Gregor



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#658841: Patch for isl multiarch problem

[Gregor Jasny]

merge 658841 670004
tags 658841 + patch
thanks

Hello,

attached you'll find the debdiff of my proposed fix. I choose to remove 
the generator line after the build. The other approach to modify the m4 
and don't write the generator line in the first place was more intrusive 
because of the needed autoreconf.


Thanks,
Gregor

PS: I also uploaded to mentors if you prefer to grab the already patched 
package
diff -Nru isl-0.08/debian/changelog isl-0.08/debian/changelog
--- isl-0.08/debian/changelog   2011-12-15 17:50:34.0 +0100
+++ isl-0.08/debian/changelog   2012-06-27 21:02:10.0 +0200
@@ -1,3 +1,11 @@
+isl (0.08-1.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Note about stdint.h generator differs among architectures
+and breaks multiarch (Closes: #658841)
+
+ -- Gregor Jasny gja...@googlemail.com  Wed, 27 Jun 2012 21:00:51 +0200
+
 isl (0.08-1) unstable; urgency=low
 
   * New upstream version.
diff -Nru isl-0.08/debian/rules isl-0.08/debian/rules
--- isl-0.08/debian/rules   2011-12-15 18:23:34.0 +0100
+++ isl-0.08/debian/rules   2012-06-27 21:07:54.0 +0200
@@ -9,6 +9,10 @@
 override_dh_auto_configure:
dh_auto_configure -v -- --libdir=/usr/lib/$(DEB_HOST_MULTIARCH)
 
+override_dh_auto_install:
+   dh_auto_install --
+   sed -i -e 's,/.*/,,' debian/tmp/usr/include/isl/stdint.h
+
 override_dh_strip:
dh_strip --dbg-package=libisl-dbg
 

Bug#665629: Patch for xoo ftbfs

[Gregor Jasny]

tags 665629 + patch
stop

Hello,

the attached debdiff fixes the ftbfs error for me.

Thanks,
Gregor
diff -u xoo-0.8/debian/changelog xoo-0.8/debian/changelog
--- xoo-0.8/debian/changelog
+++ xoo-0.8/debian/changelog
@@ -1,3 +1,10 @@
+xoo (0.8-1.2) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Fix FTBFS error (Closes: #665629) 
+
+ -- Gregor Jasny gja...@googlemail.com  Wed, 27 Jun 2012 21:54:56 +0200
+
 xoo (0.8-1.1) unstable; urgency=low
 
   * Non-maintainer upload.
only in patch2:
unchanged:
--- xoo-0.8.orig/debian/patches/02_glib-single-include.patch
+++ xoo-0.8/debian/patches/02_glib-single-include.patch
@@ -0,0 +1,13 @@
+Index: xoo-0.8/src/button.c
+===
+--- xoo-0.8.orig/src/button.c  2007-08-06 11:19:10.0 +0200
 xoo-0.8/src/button.c   2012-06-27 21:53:40.0 +0200
+@@ -16,7 +16,7 @@
+ #include config.h
+ #include string.h
+ #include stdio.h
+-#include glib/gmessages.h
++#include glib.h
+ #include gtk/gtkimage.h
+ #include fakedev.h
+ 

Bug#675567: Please support searching for keymaps in both /lib and /etc

[Gregor Jasny]

Hello,

just an update: I proposed a patchset for the development version:
http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/49889

Thanks,
Gregor



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#675567: Please support searching for keymaps in both /lib and /etc

[Gregor Jasny]

severity 675567 wishlist
stop

Hello Josh,

On 6/2/12 9:26 AM, Josh Triplett wrote:
 ... If ir-keytable searched
 for relative filenames in both /etc/rc_keymaps and /lib/udev/rc_keymaps,
 then /etc/rc_maps.cfg could use entirely relative filenames by default,
 eliminating the second step.

I started working on a patch for the development branch to achieve the
described search order. But I have to fix the upstream (k)FreeBSD
compatibility to be able to build the new versions for Debian.

I'll post updates here.

Thanks,
Gregor



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#665721: Patch

[Gregor Jasny]

tags 665721 + patch
thanks

Hello,

I've created a patch as described by Pere.

Thanks,
Gregor
Description: Find postgresql headers on Debian
Author: Pere Nubiola i Radigales p...@nubiola.cat
Bug: http://bugs.debian.org/665721

--- a/Modules/FindPostgreSQL.cmake
+++ b/Modules/FindPostgreSQL.cmake
@@ -116,6 +116,7 @@
# Look in other places.
${PostgreSQL_ROOT_DIRECTORIES}
   PATH_SUFFIXES
+postgresql
 pgsql/server
 postgresql/server
 include/server

Bug#675564: Support for RC-5-SZ protocol

[Gregor Jasny]

Hello Mauro,

I just got a bug report about the unsupported RC-5-SZ protocol:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=675564

The patch in the follow up mail adds support for this protocol
but as the reporter I ask myself if ir-keytable should support
arbitrary protocol strings (at least for version 2).

Could you please ACK the patch or submit it youself?

Thanks,
Gregor



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#675564: [PATCH] ir-keytable: Add support for RC-5-SZ protocol

[Gregor Jasny]

Signed-off-by: Gregor Jasny gja...@googlemail.com
---
 utils/keytable/keytable.c |   17 +
 1 file changed, 17 insertions(+)

diff --git a/utils/keytable/keytable.c b/utils/keytable/keytable.c
index cb03f2b..9857c37 100644
--- a/utils/keytable/keytable.c
+++ b/utils/keytable/keytable.c
@@ -88,6 +88,7 @@ enum ir_protocols {
SONY= 1  4,
LIRC= 1  5,
SANYO   = 1  6,
+   RC_5_SZ = 1  7,
OTHER   = 1  31,
 };
 
@@ -229,6 +230,8 @@ static error_t parse_keyfile(char *fname, char **table)
ch_proto |= SONY;
else if (!strcasecmp(p,sanyo))
ch_proto |= SANYO;
+   else if 
(!strcasecmp(p,rc-5-sz))
+   ch_proto |= RC_5_SZ;
else if (!strcasecmp(p,other) 
|| !strcasecmp(p,unknown))
ch_proto |= OTHER;
else {
@@ -462,6 +465,8 @@ static error_t parse_opt(int k, char *arg, struct 
argp_state *state)
ch_proto |= SANYO;
else if (!strcasecmp(p,lirc))
ch_proto |= LIRC;
+   else if (!strcasecmp(p,rc-5-sz))
+   ch_proto |= RC_5_SZ;
else
goto err_inval;
p = strtok(NULL, ,;);
@@ -733,6 +738,8 @@ static enum ir_protocols v1_get_hw_protocols(char *name)
proto |= SONY;
else if (!strcmp(p, sanyo))
proto |= SANYO;
+   else if (!strcmp(p, rc-5-sz))
+   proto |= RC_5_SZ;
else
proto |= OTHER;
 
@@ -776,6 +783,9 @@ static int v1_set_hw_protocols(struct rc_device *rc_dev)
if (rc_dev-current  SANYO)
fprintf(fp, sanyo );
 
+   if (rc_dev-current  RC_5_SZ)
+   fprintf(fp, rc-5-sz );
+
if (rc_dev-current  OTHER)
fprintf(fp, unknown );
 
@@ -900,6 +910,8 @@ static enum ir_protocols v2_get_protocols(struct rc_device 
*rc_dev, char *name)
proto = SANYO;
else if (!strcmp(p, lirc))/* Only V2 has LIRC support */
proto = LIRC;
+   else if (!strcmp(p, rc-5-sz))
+   proto = RC_5_SZ;
else
proto = OTHER;
 
@@ -953,6 +965,9 @@ static int v2_set_protocols(struct rc_device *rc_dev)
if (rc_dev-current  LIRC)
fprintf(fp, +lirc\n);
 
+   if (rc_dev-current  RC_5_SZ)
+   fprintf(fp, +rc-5-sz\n);
+
if (rc_dev-current  OTHER)
fprintf(fp, +unknown\n);
 
@@ -980,6 +995,8 @@ static void show_proto( enum ir_protocols proto)
fprintf (stderr, SANYO );
if (proto  LIRC)
fprintf (stderr, LIRC );
+   if (proto  RC_5_SZ)
+   fprintf (stderr, RC-5-SZ );
if (proto  OTHER)
fprintf (stderr, other );
 }
-- 
1.7.10




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#674406: Homepage field needs updating

[Gregor Jasny]

tags 674406 + pending
severity 674406 minor
thanks

Hello Touko,

thank you for noticing. I updated the homepage field in the package VCS
and it will be part of the next upload.

 http://anonscm.debian.org/gitweb/?p=collab-maint/c-ares.git;a=commit;h=ce1c7fdf4d044dd03060e4167e15f33854492d9f


Thanks,
Gregor



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#674299: Patch for GCC 4.7 build failure

[Gregor Jasny]

tags 674299 + patch
thanks

Hello,

attached you'll find two patches to fix the GCC 4.7 build failures.
Number one comes from upstream and number two was created by me. It
moves the lighten_Color stuff into a separate header to have it
available in the blitter.h template regardless of the include order.

Thanks,
Gregor

Description: Fix remaining GCC 4.7 build failures
Author: Gregor Jasny gja...@googlemail.com

--- a/source/graphics/blitter.h
+++ b/source/graphics/blitter.h
@@ -30,6 +30,7 @@
 #include ../misc.h
  #include ../palette.h
  #include ../basegfx.h
+#include lighten.h
 
 typedef SDLmm::Color Color;
 
--- a/source/graphics/drawing.h
+++ b/source/graphics/drawing.h
@@ -31,6 +31,7 @@
 #include ../misc.h
  #include ../palette.h
  // #include ../basegfx.h
+#include lighten.h
 
 
 
@@ -128,30 +129,6 @@
 
 extern char saturationTranslationTable[256][256];
 
-
-inline SDLmm::Color lighten_Color( SDLmm::Color color, int factor16 )
-{
-   return saturationTranslationTable[color  0xff][factor16] |
-  (saturationTranslationTable[(color  8)  0xff][factor16]  8 ) |
-  (saturationTranslationTable[(color  16)  0xff][factor16]  16 ) |
-  (color  0xff00);
-}
-
-inline void lighten_Color( SDLmm::Color* color, int factor16 )
-{
-   *color = lighten_Color( *color, factor16 );
-};
-
-inline SDL_Color lighten_Color( const SDL_Color color, int factor16 )
-{
-   SDL_Color c  = color;
-   c.r =  saturationTranslationTable[color.r  0xff][factor16];
-   c.g =  saturationTranslationTable[color.g  0xff][factor16];
-   c.b =  saturationTranslationTable[color.b  0xff][factor16];
-   return c;
-}
-
-
 template int pixelsize,
 templateint class ColorMerger 
 class PutPixel: public ColorMergerpixelsize
@@ -169,7 +146,7 @@
  PixelType* pix = (PixelType*)( surf.pixels() );
  pix += pos.y * surf.pitch()/pixelsize + pos.x;
 
- assign ( src, pix );
+ this-assign ( src, pix );
   };
 };
 
--- a/source/itemrepository.cpp
+++ b/source/itemrepository.cpp
@@ -88,7 +88,7 @@
t-filename = fileName;
t-location = location;
t-archive = prc.getArchive();
-   add ( t );
+   this-add ( t );
 }
 
 
@@ -110,7 +110,7 @@
   t-archive = stream.readString();
   dataLoaderTicker();
 
-  add ( t );
+  this-add ( t );
   // add ( T::newFromStream(stream ));
}
 }
--- /dev/null
+++ b/source/graphics/lighten.h
@@ -0,0 +1,60 @@
+/*
+This file is part of Advanced Strategic Command; http://www.asc-hq.de
+Copyright (C) 1994-2004  Martin Bickel  and  Marc Schellenberger
+ 
+This program is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2 of the License, or
+(at your option) any later version.
+ 
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+ 
+You should have received a copy of the GNU General Public License
+along with this program; see the file COPYING. If not, write to the
+Free Software Foundation, Inc., 59 Temple Place, Suite 330,
+Boston, MA  02111-1307  USA
+*/
+
+#ifndef lightenH
+ #define lightenH
+
+#include cmath
+ #include map
+ #include loki/static_check.h
+ #include ../libs/sdlmm/src/sdlmm.h
+ #include surface.h
+
+#include ../misc.h
+ #include ../palette.h
+ // #include ../basegfx.h
+
+extern char saturationTranslationTable[256][256];
+
+
+inline SDLmm::Color lighten_Color( SDLmm::Color color, int factor16 )
+{
+   return saturationTranslationTable[color  0xff][factor16] |
+  (saturationTranslationTable[(color  8)  0xff][factor16]  8 ) |
+  (saturationTranslationTable[(color  16)  0xff][factor16]  16 ) |
+  (color  0xff00);
+}
+
+inline void lighten_Color( SDLmm::Color* color, int factor16 )
+{
+   *color = lighten_Color( *color, factor16 );
+};
+
+inline SDL_Color lighten_Color( const SDL_Color color, int factor16 )
+{
+   SDL_Color c  = color;
+   c.r =  saturationTranslationTable[color.r  0xff][factor16];
+   c.g =  saturationTranslationTable[color.g  0xff][factor16];
+   c.b =  saturationTranslationTable[color.b  0xff][factor16];
+   return c;
+}
+
+#endif
+
Description: Fixed gcc 4.7 compilation problems
Origin: upstream, 205e73929e9576f4abfdde7188bef381396b8ce1
Author: Martin Bickel mar...@asc-hq.org

diff -r 83e224cdaf50 -r 205e73929e95 source/graphics/blitter.h
--- a/source/graphics/blitter.h Sun May 13 15:41:46 2012 +0200
+++ b/source/graphics/blitter.h Wed May 16 19:17:17 2012 +0200
@@ -749,7 +749,7 @@
 
   void assign ( PixelType src, PixelType* dest )
   {
- if ( isOpaque(src ) ) {
+ if ( this-isOpaque(src ) ) {
 *dest = src;
  }
   };
@@ -769,7 +769,7 @@
 
   void assign ( PixelType src

Bug#672411: gcc-4.7: Inlining error in combination with FORTIFY_SOURCE

[Gregor Jasny]

Package: gcc-4.7
Version: 4.7.0-8
Severity: normal

Hello,

this bug reports originates from #667406 in v4l-utils.

I've attached a minimal testcase for the bug. Maybe it's related to
upstream bug http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33763

Problem description:
libv4l provides a preloadable library that intercepts calls like
open, open64, etc. 
The library provides the open and open64 symbols. The replacement
open64 function tries to call the replacement open function with
somewhat changed arguments. But this code fails to compile with:

inlining failed in call to always_inline ‘open’: function not inlinable

this is due to the declaration of the libc open() in fcntl2.h which has a
always inline attibute.

Full source can be found here:
http://git.linuxtv.org/v4l-utils.git/blob/HEAD:/lib/libv4l2/v4l2convert.c

Is this a compilier bug? Without the FORTIFY_SOURCE define the error is
gone.

Thanks,
Gregor

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-2-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages gcc-4.7 depends on:
ii  binutils  2.22-6
ii  cpp-4.7   4.7.0-8
ii  gcc-4.7-base  4.7.0-8
ii  libc6 2.13-27
ii  libgcc1   1:4.7.0-8
ii  libgmp10  2:5.0.4+dfsg-1
ii  libgomp1  4.7.0-8
ii  libitm1   4.7.0-8
ii  libmpc2   0.9-4
ii  libmpfr4  3.1.0-4
ii  libquadmath0  4.7.0-8
ii  zlib1g1:1.2.6.dfsg-2

Versions of packages gcc-4.7 recommends:
ii  libc6-dev  2.13-27

Versions of packages gcc-4.7 suggests:
pn  binutils-goldnone
pn  gcc-4.7-doc  none
pn  gcc-4.7-locales  none
pn  gcc-4.7-multilib none
pn  libgcc1-dbg  none
pn  libgomp1-dbg none
pn  libitm1-dbg  none
pn  libmudflap0-4.7-dev  none
pn  libmudflap0-dbg  none
pn  libquadmath0-dbg none

-- no debconf information
/*
gcc-4.7 -c testcase.c -O2 -D_FORTIFY_SOURCE=2
*/

#include fcntl.h

int open(const char *file, int oflag, ...)
{
	return -1;
}

#ifdef linux
int open64(const char *file, int oflag, ...)
{
	return open(file, oflag);
}
#endif

Bug#667958: Upside down webcam on ThinkPad X200/X201

[Gregor Jasny]

Hello Nedim,

On 3/13/12 11:47 AM, Nedim Cholich wrote:
 I've never seen a Lenovo tablet. Does this comment also apply to
 your X200 / X201 tablet? Do you undock it from the keyboard part
 when converting it from notebook to tablet? Does lsusb, lspci, or
 other system configuration infos differ between the docked /
 undocked case?

 The comment is not correct. In laptop mode the webcam picture is
 upside down. I haven't trying it in tabled mode, my guess is it would
 be ok. But this is a laptop with secondary function as a tablet.

 Nevertheless I added your webcam / machine combination to the libv4l 
 upside down table locally and created a snapshot. Please test this 
 snapshot with the following commands. This will change nothing on
 your installation.

After I added your X201 to the upside down list Joe discovered that his
X201 now shows the image upside down where it worked before:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667958

The DMI diff from your machine to Joes machine shows the following
differences:

  BIOS Information
 Vendor: LENOVO
 -   Version: 6QET53WW (1.23 )
 -   Release Date: 09/15/2010
 +   Version: 6QET64WW (1.34 )
 +   Release Date: 02/24/2011
 Address: 0xE

 -   BIOS Revision: 1.35
 -   Firmware Revision: 1.17
 +   BIOS Revision: 1.52
 +   Firmware Revision: 1.19

  System Information
 Manufacturer: LENOVO
 Product Name: 0831CTO
 Version: ThinkPad X201 Tablet
 -   Serial Number: R9849X4
 -   UUID: A2CCDB40-D7A2-11DF-848F-D77E9F1AA257
 +   Serial Number: R9C99NH
 +   UUID: 2063F7ED-6B53-E011-878A-88AD21B2D6B3
 Wake-up Type: Power Switch
 SKU Number: Not Specified
 Family: ThinkPad X201 Tablet

  Base Board Information
 Manufacturer: LENOVO
 Product Name: 0831CTO
 Version: Not Available
 -   Serial Number: 1ZHWF09D4LS
 +   Serial Number: 1ZHWF13G21N

  Chassis Information
 Manufacturer: LENOVO
 Type: Notebook
 Lock: Not Present
 Version: Not Available
 -   Serial Number: R9849X4
 +   Serial Number: R9C99NH
 Asset Tag: No Asset Information
 Boot-up State: Unknown
 Power Supply State: Unknown
 Thermal State: Unknown
 Security Status: Unknown

So besides the different serial numbers, the BIOS and firmware version
differs. Could you try upgrading BIOS and other firmware to the latest
(or same version as Joe uses). I wonder if this would solve the upside
down problems?

I hope the different BIOS and firmware version explains the fixed upside
down issues. Does the BIOS / firmware update mentions something like a
fixed camera orientation in the changelog?

I plan to revert the X201 table entry until the issue is solved.

Thanks,
Gregor



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#667958: libv4l-0: Lenovo X201 Tablet shouldn't be in upside-down list

[Gregor Jasny]

Hello Joe,

could you please attach the output of dmidecode? Is the orientation in
both modes (laptop and tablet) wrong?

I'll follow up with the original requester of this change during the
next days.

Thanks,
Gregor



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#667406: v4l-utils: ftbfs with GCC-4.7

[Gregor Jasny]

Hello,

It looks like we've hit a variant of
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33763

The attached patch fixes the problem for me. It simply avoids calling 
the file local open() function and inlines their code instead. 
Additionally it adds O_LARGEFILE to the oflags.


Hans, please review.

Thanks,
Gregor

From be2de842647ea51a84fdfab21056639ba1cc67b4 Mon Sep 17 00:00:00 2001
From: Gregor Jasny gja...@googlemail.com
Date: Wed, 4 Apr 2012 13:40:56 +0200
Subject: [PATCH] Work around GCC 4.7 inlining problem

With GCC 4.7 and enabled stack protector we get an compiler error
about fained inlining. (See http://bugs.debian.org/667406)

This patch avoids calling the file local open function and inlines
their code instead.

Signed-off-by: Gregor Jasny gregor.ja...@citrix.com
---
 lib/libv4l2/v4l2convert.c |   31 +++
 1 file changed, 7 insertions(+), 24 deletions(-)

diff --git a/lib/libv4l2/v4l2convert.c b/lib/libv4l2/v4l2convert.c
index 9e2f546..1347726 100644
--- a/lib/libv4l2/v4l2convert.c
+++ b/lib/libv4l2/v4l2convert.c
@@ -45,6 +45,11 @@
 
 LIBV4L_PUBLIC int open(const char *file, int oflag, ...)
 {
+}
+
+#ifdef linux
+LIBV4L_PUBLIC int open64(const char *file, int oflag, ...)
+{
int fd;
struct v4l2_capability cap;
int v4l_device = 0;
@@ -57,6 +62,8 @@ LIBV4L_PUBLIC int open(const char *file, int oflag, ...)
v4l_device = 1;
}
 
+   oflag |= O_LARGEFILE;
+
/* original open code */
if (oflag  O_CREAT) {
va_list ap;
@@ -90,30 +97,6 @@ LIBV4L_PUBLIC int open(const char *file, int oflag, ...)
 
return fd;
 }
-
-#ifdef linux
-LIBV4L_PUBLIC int open64(const char *file, int oflag, ...)
-{
-   int fd;
-
-   /* original open code */
-   if (oflag  O_CREAT) {
-   va_list ap;
-   mode_t mode;
-
-   va_start(ap, oflag);
-   mode = va_arg(ap, mode_t);
-
-   fd = open(file, oflag | O_LARGEFILE, mode);
-
-   va_end(ap);
-   } else {
-   fd = open(file, oflag | O_LARGEFILE);
-   }
-   /* end of original open code */
-
-   return fd;
-}
 #endif
 
 LIBV4L_PUBLIC int close(int fd)
-- 
1.7.9.5

Bug#633387: Updated xawtv3 package is being prepared

[Gregor Jasny]

Dear reporters,

Currently I'm preparing xawtv 3.102. Current efforts are available in 
https://github.com/gjasny/xawtv and will move to collab-maint on alioth 
once it's back.


But I'll need some more days to polish it.

Thanks,
Gregor



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#621960: Patch for dv4l RC bugs

[Gregor Jasny]

tags 621960 + patch
thanks

Hello,

attached you'll find a debdiff (taken from Ubuntu) that fixes the FTBFS
bugs in the dv4l package. Unfortunately I'm no DD yet, so I cannot NMU
this package. Gregor H., could you please NMU this package if Nobuhiro
does not take care himself?

Additionally I prepared a Lintian clean package:
http://mentors.debian.net/debian/pool/main/d/dv4l/dv4l_1.0-4.dsc

Thanks,
Gregor
diff -u dv4l-1.0/debian/changelog dv4l-1.0/debian/changelog
--- dv4l-1.0/debian/changelog
+++ dv4l-1.0/debian/changelog
@@ -1,3 +1,17 @@
+dv4l (1.0-3.1) unstable; urgency=low
+
+  [ Daniel Polehn ]
+  * Fix FTBFS, changed linux/videodev.h location. LP: #749235.
+
+  [ Matthias Klose ]
+  * Build with -fPIC.
+  * Fix FTBFS with ld --as-needed.
+
+  [ Gregor Jasny ]
+  * Imported patch from Ubuntu (Closes: #615836 #621960)
+
+ -- Gregor Jasny gja...@googlemail.com  Sat, 31 Dec 2011 13:09:36 +0100
+
 dv4l (1.0-3) unstable; urgency=low
 
   * Fix FTBFS with new dpkg-dev. (Closes: #535287)
diff -u dv4l-1.0/debian/control dv4l-1.0/debian/control
--- dv4l-1.0/debian/control
+++ dv4l-1.0/debian/control
@@ -4,7 +4,7 @@
 Maintainer: Nobuhiro Iwamatsu iwama...@nigauri.org
 Dm-Upload-Allowed: yes
 Build-Depends: cdbs, debhelper (= 7), autotools-dev, dpatch, 
-   libraw1394-dev, libiec61883-dev, libdv-dev
+   libraw1394-dev, libiec61883-dev, libdv-dev, libv4l-dev
 Standards-Version: 3.8.2
 Homepage: http://dv4l.berlios.de/
 
diff -u dv4l-1.0/debian/patches/00list dv4l-1.0/debian/patches/00list
--- dv4l-1.0/debian/patches/00list
+++ dv4l-1.0/debian/patches/00list
@@ -6,0 +7,3 @@
+07_ld_as_needed
+07_use_libv4l-dev
+08_fix_build_fail
diff -u dv4l-1.0/debian/patches/06_fix_fdset_conflicting_types.dpatch 
dv4l-1.0/debian/patches/06_fix_fdset_conflicting_types.dpatch
--- dv4l-1.0/debian/patches/06_fix_fdset_conflicting_types.dpatch
+++ dv4l-1.0/debian/patches/06_fix_fdset_conflicting_types.dpatch
@@ -14,7 +14,7 @@
  
  VER := @PACKAGE_VERSION@
 -CFLAGS := -Wall -O3 -MMD 
-+CFLAGS := -Wall -O3 -MMD -D__KERNEL_STRICT_NAMES
++CFLAGS := -Wall -fPIC -O3 -MMD -D__KERNEL_STRICT_NAMES
  LDFLAGS := -lraw1394 -liec61883 -ldv
  
  datarootdir=@datarootdir@
only in patch2:
unchanged:
only in patch2:
unchanged:
--- dv4l-1.0.orig/debian/patches/07_use_libv4l-dev.dpatch
+++ dv4l-1.0/debian/patches/07_use_libv4l-dev.dpatch
@@ -0,0 +1,66 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## use_libv4l-dev.dpatch by Daniel Polehn dpol...@gmail.com
+##
+## All lines beginning with `## DP:' are a description of the patch.
+## DP: No description.
+
+@DPATCH@
+diff -urNad '--exclude=CVS' '--exclude=.svn' '--exclude=.git' 
'--exclude=.arch' '--exclude=.hg' '--exclude=_darcs' '--exclude=.bzr' 
dv4l~/dv4l.c dv4l/dv4l.c
+--- dv4l~/dv4l.c   2011-06-26 22:32:29.058413510 -0700
 dv4l/dv4l.c2011-06-26 22:37:55.608892461 -0700
+@@ -23,7 +23,7 @@
+ #include sys/select.h
+ #include sys/stat.h
+ #include sys/time.h
+-#include linux/videodev.h
++#include libv4l1-videodev.h
+ #include assert.h
+ #include fcntl.h
+ #include getopt.h
+@@ -61,6 +61,10 @@
+ #define DV4LVERSION 0.0
+ #endif
+ 
++#ifndef BASE_VIDIOCPRIVATE
++#define BASE_VIDIOCPRIVATE  192
++#endif
++
+ /*
+  * these constants are used to detect a vloopback input device
+  * let's hope they won't change them
+diff -urNad '--exclude=CVS' '--exclude=.svn' '--exclude=.git' 
'--exclude=.arch' '--exclude=.hg' '--exclude=_darcs' '--exclude=.bzr' 
dv4l~/interdv4l.c dv4l/interdv4l.c
+--- dv4l~/interdv4l.c  2011-06-26 22:32:29.038413485 -0700
 dv4l/interdv4l.c   2011-06-26 22:32:29.218413750 -0700
+@@ -44,7 +44,7 @@
+ 
+ #define __USE_LARGEFILE64
+ #include sys/stat.h
+-#include linux/videodev.h
++#include libv4l1-videodev.h
+ #include dirent.h
+ #include config.h
+ #include version.h
+diff -urNad '--exclude=CVS' '--exclude=.svn' '--exclude=.git' 
'--exclude=.arch' '--exclude=.hg' '--exclude=_darcs' '--exclude=.bzr' 
dv4l~/palettes.c dv4l/palettes.c
+--- dv4l~/palettes.c   2011-06-26 22:26:53.0 -0700
 dv4l/palettes.c2011-06-26 22:32:29.218413750 -0700
+@@ -17,7 +17,7 @@
+  * Author: Wolfgang Beck bewo at users.berlios.de 2007
+  */
+ 
+-#include linux/videodev.h
++#include libv4l1-videodev.h
+ 
+ /*
+  * RGB to YUV420P conversion taken from
+diff -urNad '--exclude=CVS' '--exclude=.svn' '--exclude=.git' 
'--exclude=.arch' '--exclude=.hg' '--exclude=_darcs' '--exclude=.bzr' 
dv4l~/util.c dv4l/util.c
+--- dv4l~/util.c   2011-06-26 22:26:53.0 -0700
 dv4l/util.c2011-06-26 22:32:29.218413750 -0700
+@@ -23,7 +23,7 @@
+ #include stdarg.h
+ #include string.h
+ #include fcntl.h
+-#include linux/videodev.h
++#include libv4l1-videodev.h
+ #include util.h
+ 
+ static int tracelevel = 1;
only in patch2:
unchanged:
--- dv4l-1.0.orig/debian/patches/07_ld_as_needed.dpatch
+++ dv4l-1.0/debian/patches/07_ld_as_needed.dpatch
@@ -0,0 +1,24 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+
+@DPATCH@
+--- ./Makefile.in.old  2011-09-19 14:02

Bug#652252: Patch for ust FTBFS error

[Gregor Jasny]

tags 652252 + patch
thanks

Hello,

attached you'll find a debdiff that fixes the FTBFS error. I picked the
patch from the upstream 0.16 version and bumped the urcu dependency.

Thanks,
Gregor
diff -Nru ust-0.15/debian/changelog ust-0.15/debian/changelog
--- ust-0.15/debian/changelog   2011-09-04 15:58:07.0 +0200
+++ ust-0.15/debian/changelog   2011-12-31 14:28:47.0 +0100
@@ -1,3 +1,10 @@
+ust (0.15-3.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Use caa_unlikely, depend on liburcu = 0.6.6 (Closes: #652252)
+
+ -- Gregor Jasny gja...@googlemail.com  Sat, 31 Dec 2011 14:28:00 +0100
+
 ust (0.15-3) unstable; urgency=low
 
   * [61bf984] Remove liburcu1 from libust0 Depends (Closes: #637636)
diff -Nru ust-0.15/debian/control ust-0.15/debian/control
--- ust-0.15/debian/control 2011-09-04 15:58:07.0 +0200
+++ ust-0.15/debian/control 2011-12-31 14:27:08.0 +0100
@@ -1,7 +1,7 @@
 Source: ust
 Priority: extra
 Maintainer: Jon Bernard jbern...@debian.org
-Build-Depends: debhelper (= 7.0.50~), autotools-dev, liburcu-dev (= 0.6.2), 
texinfo
+Build-Depends: debhelper (= 7.0.50~), autotools-dev, liburcu-dev (= 0.6.6), 
texinfo
 Standards-Version: 3.9.2
 Section: libs
 Vcs-Git: git://git.debian.org/git/collab-maint/ust.git
@@ -23,8 +23,7 @@
 Package: libust-dev
 Section: libdevel
 Architecture: i386 amd64 powerpc ppc64
-Depends: ${misc:Depends}, libust0 (= ${binary:Version})
-Recommends: liburcu-dev
+Depends: ${misc:Depends}, libust0 (= ${binary:Version}), liburcu-dev (= 0.6.6)
 Description: LTTng Userspace Tracer (development)
  The userspace tracer is designed to provide detailed information about
  userspace activity. Like the kernel tracer, performance is the main goal.
diff -Nru ust-0.15/debian/patches/0003-use_caa_unlikely.patch 
ust-0.15/debian/patches/0003-use_caa_unlikely.patch
--- ust-0.15/debian/patches/0003-use_caa_unlikely.patch 1970-01-01 
01:00:00.0 +0100
+++ ust-0.15/debian/patches/0003-use_caa_unlikely.patch 2011-12-31 
14:23:44.0 +0100
@@ -0,0 +1,45 @@
+From: Mathieu Desnoyers mathieu.desnoy...@efficios.com
+Date: Thu, 15 Dec 2011 22:10:50 + (-0500)
+Subject: Use caa_unlikely, depend on liburcu = 0.6.6
+X-Git-Tag: v0.16~1
+X-Git-Url: 
http://git.lttng.org/?p=ust.git;a=commitdiff_plain;h=5296e06cffd5ed5dcf3bb9fe7e3a18744ac18823
+
+Use caa_unlikely, depend on liburcu = 0.6.6
+
+Signed-off-by: Mathieu Desnoyers mathieu.desnoy...@efficios.com
+---
+
+diff --git a/README b/README
+index a2d115b..8776ce4 100644
+--- a/README
 b/README
+@@ -16,7 +16,7 @@ PREREQUISITES:
+   - liburcu
+ Userspace RCU library, by Mathieu Desnoyers and Paul E. McKenney
+ 
+-- This release depends on liburcu v0.6
++- This release depends on liburcu v0.6.6
+ 
+   * Debian/Ubuntu package: liburcu-dev
+   * Website:  http://lttng.org/urcu
+diff --git a/include/ust/tracepoint.h b/include/ust/tracepoint.h
+index 5e7f9d8..ade5677 100644
+--- a/include/ust/tracepoint.h
 b/include/ust/tracepoint.h
+@@ -27,6 +27,7 @@
+ 
+ #include urcu-bp.h
+ #include urcu/list.h
++#include urcu/compiler.h
+ 
+ struct tracepoint_probe {
+   void *func;
+@@ -96,7 +97,7 @@ struct tracepoint {
+ 
+ #define __CHECK_TRACE(name, proto, args)  \
+   do {\
+-  if (unlikely(__tracepoint_##name.state))\
++  if (caa_unlikely(__tracepoint_##name.state))\
+   __DO_TRACE(__tracepoint_##name,\
+   TP_PROTO(proto), TP_ARGS(args));\
+   } while (0)
diff -Nru ust-0.15/debian/patches/series ust-0.15/debian/patches/series
--- ust-0.15/debian/patches/series  2011-09-04 15:58:07.0 +0200
+++ ust-0.15/debian/patches/series  2011-12-31 14:32:10.0 +0100
@@ -1,2 +1,3 @@
 0001-Add-category-and-directory-entries-to-the-info-docum.patch
 0002-Link-register-test-against-libpthread-for-binutils-g.patch
+0003-use_caa_unlikely.patch

Bug#607438: Bugs in stable c-ares package

[Gregor Jasny]

Hello Adam,

On 11/22/11 10:24 PM, Adam D. Barratt wrote:

On Sun, 2011-11-06 at 16:17 +, Adam D. Barratt wrote:

On Sat, 2011-11-05 at 20:51 +0100, Gregor Jasny wrote:



Uploaded to mentors for reviewing and testing:

http://mentors.debian.net/debian/pool/main/c/c-ares/c-ares_1.7.3-1squeeze1.dsc


Andreas, could you please upload to stable (if you have no objections)
once the release team gives their OK?


The debdiff as provided in your mail looks fine; thanks.


Any news on the upload?


I'd suggest to upload to DELAYED/7 to give Andreas a chance to 
intervene. I'm not sure if I as a DM am allowed to upload to stable.


The dsc on mentors contains the original source. Otherwise mentors 
rejected the upload. Is this a problem?


Maybe you could sponsor the upload?

Thanks,
Gregor



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#647535: cheese: Wrong colours and artefacts on image

[Gregor Jasny]

Hello,

I'm about uploading libv4l-0.8.5-6 to Debian. If should fix the libjpeg
8 incompatibility.

-Gregor



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#647535: cheese: Wrong colours and artefacts on image

[Gregor Jasny]

Hi Jonathan and Faidon,

could you please check if libv4l-0.8.5-6 fixes the issue for you and
close this bug if it does so?

Thanks,
Gregor




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org