Bug#965142: RM: pegtl -- ROM; superseded by tao-pegtl

[Muri Nicanor]

Package: ftp.debian.org
X-Debbugs-CC: m...@immerda.ch
Severity: normal

pegtl was superseded by tao-pegtl and can thus be removed. there are no
packages depending on it.

cheers,
muri

Bug#905524: usbguard: unowned files after purge (policy 6.8, 10.8): /etc/usbguard/rules.conf

[Muri Nicanor]

control: -1 + pending

Thanks for the bugreport and making me aware of piuparts!
I've added a postrm script that removes the files and uploaded a new
version to mentors. The bug should be fixed as soon as the package is
sponsored.

cheers,
muri

Bug#905654: RFS: usbguard/0.7.2+ds-2

[Muri Nicanor]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "usbguard"

* Package name : usbguard
  Version  : 0.7.2+ds-2
  Upstream Author  : Daniel Kopeček 
* Url  : https://dkopecek.github.io/usbguard/
* Licenses : public-domain,CC-BY-SA-3.0,GPL-3+,GPL-2+,FSFULLR
  Programming Lang : C
  Section  : utils

 The USBGuard software framework helps to protect your computer against
rogue
 USB devices (a.k.a. BadUSB) by implementing basic whitelisting and
blacklisting
 capabilities based on device attributes.

It builds those binary packages:

  * libusbguard0
  * usbguard
  * usbguard-applet-qt

To access further information about this package, visit the following URL:

https://mentors.debian.net/package/usbguard

Alternatively, one can download the package with dget using this command:
dget -x
https://mentors.debian.net/debian/pool/main/u/usbguard/usbguard_0.7.2+ds-2.dsc

Alternatively, you can access package debian/ directory via git from URL:
https://salsa.debian.org/muri-guest/usbguard.git

More information about usbguard can be obtained from
https://dkopecek.github.io/usbguard/


Changes since last upload:

  * Add a postrm file to clean up on purge (Closes: #905524)

Cheers,
muri

Bug#896969: Info received (Bug#896969: Acknowledgement (nlohmann-json: Version 3.1.2 is now available - any reason not to update?))

[Muri Nicanor]

Hi Wookey,

sorry for the delay- there is an ITP for nlohmann-json3
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886865

cheers,
muri

On 04/28/2018 05:02 AM, Wookey wrote:
> On 2018-04-27 03:39 +, Debian Bug Tracking System wrote:
> I have prepared a 3.1.2 package (just needed a uupdate and a couple of minor 
> changes)
> 
> horizon-eda builds against that package so that works.
> 
> I'll test some of the others. 
> 
> Wookey
> 

Bug#887665: marked as done (RFS: usbguard/0.7.1+ds-1)

[Muri Nicanor]

hm, somehow i didn't receive that mail...

On 03/15/2018 10:54 AM, Gianfranco Costamagna wrote:
> control: owner -1 ! control: tags -1 moreinfo
> 1) please fix the qt bug in this upload
> 2) missing lots of copyrights, e.g. src/ThirdParty/Catch/* 
> src/ThirdParty/PEGTL/*
> do you need such external libraries? why aren't it packaged separately?
they are- i apparently forgot to readd the folder to files-excluded at
some point. i readded the folder now and repackaged and reimported the
archive.

> 3) std-version is 4.1.3
yes, should it not be?

> 4)  dh ${@} --parallel --with=autoreconf
> isn't this automatic with compat level 10?
both removed.

i've also fixed a bug in the usbguard.postinst script that errored out
if one of the chmoded files didn't exist.

i've uploaded new versions of the packages to mentors.d.o and pushed all
the commits to salsa.

cheers and thanks,
muri



signature.asc
Description: OpenPGP digital signature

Bug#892201: nlohmann-json build issues with gcc 7.2

[Muri Nicanor]

Hi Dominique,

uhoreg offered to package version 3
(https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=885540) of
nlohmann-json and already created an ITP for that:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886865

cheers,
muri

On 03/06/2018 05:36 PM, Dominique Belhachemi wrote:
> Package: nlohmann-json
> Version: 2.1.1-1
> Severity: grave
> 
> Some applications don't compile with nlohmann-json 2.1.1 and gcc 7.2 .
> 
> You can find details here:
> 
> https://github.com/nlohmann/json/issues/742
> 
> Please update the package.
> 
> Thanks
> -Dominique
> 



signature.asc
Description: OpenPGP digital signature

Bug#887665: marked as done (RFS: usbguard/0.7.1+ds-1)

[Muri Nicanor]

Hi nicoo,

On 02/11/2018 08:32 PM, Nicolas Braud-Santoni wrote:
> On Wed, Jan 24, 2018 at 08:23:12PM +0100, Muri Nicanor wrote:
>> i've fixed the bugs and uploaded the new version of usbguard to mentors,
>> and i've also pushed all the commits to salsa.
> 
> Hi!
> 
> Thanks for the good work on usbguard.
> 
> 
> I started taking a look, but it seems you forgot to push tags to the
> repository on salsa.d.o, so it's a bit annoying to diff with the version
> currently in Debian (or even just run `gbp buildpackage`).
> 
> Could you do that?  It's just a `git push --tags`  :)

i've pushed the tags, thanks for pointing that out.

cheers,
muri

> 
> 
> Best,
> 
>   nicoo
> 



signature.asc
Description: OpenPGP digital signature

Bug#868112: nlohmann-json-dev: include dir: wrong

[Muri Nicanor]

Hello Dominique,

On 01/25/2018 08:41 PM, Dominique Belhachemi wrote:
> Do you mind removing the symbolic link ?
> 
> lrwxrwxrwx 1 root root 17 Jul 12  2017 /usr/include/json.hpp ->
> nlohmann/json.hpp
> -rw-r--r-- 1 root root 428838 Jul 12  2017 /usr/include/nlohmann/json.hpp
> 

I've added the link on purpose, so that the package is backwards
compatible. The Plan is to remove the link after buster. Is this
approach a problem?

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#887665: marked as done (RFS: usbguard/0.7.1+ds-1)

[Muri Nicanor]

control: reopen -1
control: retitle -1 RFS: usbguard/0.7.2+ds-1

On 01/23/2018 08:36 AM, Tobias Frost wrote:
> Please do not close RFS in this cases, so that the context is maintained.
> A RFS should be only be closed when uploaded (or when there is no longer
> something to sponsor).
> 
> When you have a new version, please recycle the bug, and retitle it
> appropiatly.

oke! i'm reopening the bug and retitleing for the new version.
i've fixed the bugs and uploaded the new version of usbguard to mentors,
and i've also pushed all the commits to salsa.

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#887671: usbguard: USBGuard daemon seems to leak filehandles

[Muri Nicanor]

control: forwarded -1 https://github.com/USBGuard/usbguard/issues/219

Hello Matti,

thanks for the bug report- i've reproduced the issue on version 0.7.1
which i'm in the process of packaging and thus forwarded the bug to
upstream.

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#887665: RFS: usbguard/0.7.1+ds-1

[Muri Nicanor]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "usbguard"

* Package name : usbguard
  Version  : 0.7.1+ds-1
  Upstream Author  : Muri Nicanor <m...@immerda.ch>
* Url  : https://dkopecek.github.io/usbguard/
* Licenses : GPL-2+,GPL-3+,CC-BY-SA-3.0,FSFULLR,public-domain
  Programming Lang : C
  Section  : utils

 The USBGuard software framework helps to protect your computer against
 rogue USB devices (a.k.a. BadUSB) by implementing basic whitelisting
 and blacklisting capabilities based on device attributes.

It builds those binary packages:

  * libusbguard0
  * usbguard
  * usbguard-applet-qt

To access further information about this package, visit the following URL:

https://mentors.debian.net/package/usbguard

Alternatively, one can download the package with dget using this command:
dget -x
https://mentors.debian.net/debian/pool/main/u/usbguard/usbguard_0.7.1+ds-1.dsc

Alternatively, you can access package debian/ directory via git from URL:
https://salsa.debian.org/muri-guest/usbguard

More information about usbguard can be obtained from
https://dkopecek.github.io/usbguard/


Changes since last upload:

  * New upstream version 0.7.1 (Closes: #868160)
  * remove dh-systemd due to being part of debhelper (>= 9.20160709)
  * bump standards version
  * add correct section to libusbguard0
  * remove parsing of dpkg-genchangelog
  * updated the watch file for the new github url, modified the archive name
so the correct version will be used and removed the signature line, as
that version is not signed
  * remove patches that have been upstreamed
  * add asciidoctor to build depends

Regards,
  Muri Nicanor





signature.asc
Description: OpenPGP digital signature

Bug#885540: nlohmann-json-dev: new upstream releases (3.0.0 & 2.1.1)

[Muri Nicanor]

hi,

On 01/07/2018 05:00 PM, Hubert Chathi wrote:
>> I'm not sure if i will have enough time to package the version 3 of
>> the library, but i'll look into it.
> 
> If you do not have time to package v3, then I can do that.  I don't mind
> packaging it, but I didn't want to "hijack" it on you, if you wanted to
> package it.  Let me know if you'd prefer to package it, or if you'd
> prefer that I do so.
> 
i'd be happy if you'd package v3! I initially packaged the library only
because it was a dependency of usbguard, but usbguard dropped that
dependency ... ;)

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#885540: nlohmann-json-dev: new upstream releases (3.0.0 & 2.1.1)

[Muri Nicanor]

On 01/07/2018 05:07 PM, Hubert Chathi wrote:
> On Sun, 7 Jan 2018 13:18:11 +0100, Muri Nicanor <m...@immerda.ch> said:
> 
>> Hello Hubert, thanks for your interest in nlohmann-json. I've already
>> packaged the 2.1.1 version of the library and had uploaded it to
>> mentors, but i didn't find a sponsor and meanwhile it has been removed
>> from mentors.  Maybe you're interested in sponsoring the upload?  The
>> git repository for the package is on
>> https://0xacab.org/muri/debian-nlohmann-json, but i can also reupload
>> the package to mentors.
> 
> I don't have permission to view that git repository.  Can you give me
> permissions (I logged in via GitHub -- my username on GitHub is uhoreg),
> or you can reupload to mentors, and I can try to take a look at it
> there.

argl, sorry, i forgot to make the repository public. its public now, so
you should not even need to login to clone.

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#885540: nlohmann-json-dev: new upstream releases (3.0.0 & 2.1.1)

[Muri Nicanor]

Hello Hubert,

thanks for your interest in nlohmann-json. I've already packaged the
2.1.1 version of the library and had uploaded it to mentors, but i
didn't find a sponsor and meanwhile it has been removed from mentors.
Maybe you're interested in sponsoring the upload?
The git repository for the package is on
https://0xacab.org/muri/debian-nlohmann-json, but i can also reupload
the package to mentors.

I'm not sure if i will have enough time to package the version 3 of the
library, but i'll look into it.

cheers,
muri

On 12/27/2017 09:19 PM, Hubert Chathi wrote:
> Package: nlohmann-json-dev
> Version: 2.0.6-1
> Severity: wishlist
> 
> Version 3.0.0 of nlohmann's JSON library has been released.  It has some
> breaking changes from the 2.x series, so maybe it should be given a
> separate package name (nlohmann-json3-dev?).
> 
> The 2.x series is also now up to 2.1.1, which includes new features such
> as converting from/to arbitrary types, and CBOR/MessagePack support.
> 2.1.1 should be backwards compatible with the currently packaged release.
> 
> -- System Information:
> Debian Release: 8.7
>   APT prefers stable
>   APT policy: (990, 'stable'), (500, 'unreleased'), (500, 'stable-updates'), 
> (300, 'testing'), (200, 'unstable'), (1, 'experimental')
> Architecture: amd64 (x86_64)
> Foreign Architectures: i386
> 
> Kernel: Linux 4.9.0-0.bpo.2-amd64 (SMP w/4 CPU cores)
> Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
> 
> -- no debconf information
> 



signature.asc
Description: OpenPGP digital signature

Bug#869483: ITP: python3-ansi -- ANSI cursor movement and graphics

[Muri Nicanor]

Hi Herbert,

On 11/28/2017 01:43 PM, Herbert Fortes wrote:
> Hi Muri Nicanor,
> 
>>>>  - Remove ${python:Recommends} and ${python:Suggests} or see the 
>>>> lintian-info
>> i'm not sure what you're referring to, but there are no more
>> lintian-info warnings
> 
> You are right. The are no lintian warnings this
> morning to me too. But look:
> 
> 
> dpkg-gencontrol: warning: Recommends field of package python3-ansi: unknown 
> substitution variable ${python:Recommends}
> dpkg-gencontrol: warning: Suggests field of package python3-ansi: unknown 
> substitution variable ${python:Suggests}
> 
> Please remove them.
> 
> And also in debian/control, Description:
> 
>  - the '.X' is not necessary:
>Python 3.X (short description)
> 
>  - it will look better if you to a dot in long
>description:
> 
>Various ANSI escape codes, used in moving the cursor in a text console or
>rendering coloured text.
>  + .
>256 RGB colours supported.
>.
>This package installs the library for Python 3.
> 
> 
> Let me know when you finish these small changes.

thanks for reviewing! i've implemented the changes, pushed to git and
uploaded a new version of the package to mentors.

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#869483: ITP: python3-ansi -- ANSI cursor movement and graphics

[Muri Nicanor]

Hi,

On 11/18/2017 01:55 PM, Herbert Fortes wrote:
>> O did a review and have some comments. Please do:
thanks a lot!

>>
>>  - debian/changelog needs an update on timestamp:
>>      - run 'dch -r'
done.

>>  - debian/control:
>>      - add python3-setuptools to Build-Depends
done.

>>      - Standards-Version is 4.1.1
done.

>>      - Depends field:  ${python3:Depends} not ${python:Depends}
done.

>>  - Remove ${python:Recommends} and ${python:Suggests} or see the 
>> lintian-info
i'm not sure what you're referring to, but there are no more
lintian-info warnings

>>  - Add two more lines on long description. Can be something like:
done.

>>  - debian/watch:
>>  - the line seems ok, but it is version 4 not 3
done.

>>  - run wrap-and-sort at the end.
done.

>>
> 
> I forgot one thing:
> 
>   - debian/python-ansi.docs should be debian/python3-ansi.docs
> And README and README.md are the same file.
done, only installing with .md now

thanks for the review, i've uploade an updated version to mentors and
pushed the changes to the git repo on alioth.

muri



signature.asc
Description: OpenPGP digital signature

Bug#878516: RFS: ansi/0.1.3-1 [ITP]

[Muri Nicanor]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "ansi". (i've already sent an
RFS to debian-python a month ago:
https://lists.debian.org/debian-python/2017/09/msg00038.html)

* Package name : ansi
  Version  : 0.1.3-1
  Upstream Author  : Wijnand Modderman-Lenstra 
* Url  : https://github.com/tehmaze/ansi/
* Licenses : Expat
  Programming Lang : Python
  Section  : python

 Various ANSI escape codes, used in moving the cursor in a text console or
 rendering coloured text.

It builds those binary packages:

  * python3-ansi

To access further information about this package, visit the following URL:

https://mentors.debian.net/package/ansi

Alternatively, one can download the package with dget using this command:
dget -x
https://mentors.debian.net/debian/pool/main/a/ansi/ansi_0.1.3-1.dsc

Alternatively, you can access package debian/ directory via git from URL:
https://anonscm.debian.org/git/python-modules/packages/ansi.git

More information about ansi can be obtained from
https://github.com/tehmaze/ansi/


cheers,
  muri



signature.asc
Description: OpenPGP digital signature

Bug#875808: usbguard: does not work with 4.13 kernel

[Muri Nicanor]

Hi,

On 10/03/2017 11:41 PM, Aaron M. Ucko wrote:
> Package: usbguard
> Followup-For: Bug #875808
> 
> I encountered this bug upon upgrading to 4.13, which hit unstable
> today, and can confirm the fix.  Could you please go ahead and upload
> it when you get a chance?

The package is awaiting sponsorship in #876199

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#876199: RFS: usbguard/0.7.0+ds1-2

[Muri Nicanor]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "usbguard"

* Package name : usbguard
  Version  : 0.7.0+ds1-2
  Upstream Author  : Daniel Kopeček <dkope...@redhat.com>
* Url  : https://dkopecek.github.io/usbguard/
* Licenses : GPL-2+,GPL-3+,CC-BY-SA-3.0,FSFULLR,public-domain
  Programming Lang : C
  Section  : utils

 The USBGuard software framework helps to protect your computer against
 rogue USB devices (a.k.a. BadUSB) by implementing basic whitelisting
 and blacklisting capabilities based on device attributes.
 .
 This package contains the shared library

It builds those binary packages:

  * libusbguard0
  * usbguard
  * usbguard-applet-qt

To access further information about this package, visit the following URL:

https://mentors.debian.net/package/usbguard

Alternatively, one can download the package with dget using this command:
dget -x
https://mentors.debian.net/debian/pool/main/u/usbguard/usbguard_0.7.0+ds1-2.dsc

Alternatively, you can access package debian/ directory via git from URL:
https://0xacab.org/muri/debian-usbguard

More information about usbguard can be obtained from
https://dkopecek.github.io/usbguard/


Changes since last upload:

  * Remove qt4 dependencies (Closes: #875220)
  * Backport patch for multiple applet instances
(Closes: #871997)
  * Backport patch to make UEventDeviceManager work
with kernel >= 4.13 (Closes: #875808)

Regards,
  Muri Nicanor



signature.asc
Description: OpenPGP digital signature

Bug#869483: ITP: python3-ansi -- ANSI cursor movement and graphics

[Muri Nicanor]

hi,

On 07/23/2017 05:31 PM, Scott Kitterman wrote:
> 
> 
> On July 23, 2017 11:07:47 AM EDT, Muri Nicanor <m...@immerda.ch> wrote:
[...]
>> - this is a dependency of errbot (see #803347)
>> - i plan to build the initial package myself and then get
>>  in contact with the python team for RFS and joining or
>>  handing over the package
> 
> Every package needs a human uploader.
which can not be me, i'm not a DM

> There is no 'handing over'.
sorry for me not being a native speaker, my wording was off, i didn't
mean to offend anyone

> It looks like this would be reasonable to maintain as part of DPMT, but if 
> you don't plan to keep it updated, don't upload it.
i plan to keep it updated

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#869483: ITP: python3-ansi -- ANSI cursor movement and graphics

[Muri Nicanor]

Package: wnpp
Severity: wishlist
Owner: Muri Nicanor <m...@immerda.ch>

* Package name: python3-ansi
  Version : 0.1.3
  Upstream Author : Wijnand Modderman-Lenstra <m...@pyth0n.org>
* URL : https://pypi.python.org/pypi/ansi
* License : Expat
  Programming Lang: Python
  Description : ANSI cursor movement and graphics

Various ANSI escape codes, used in moving the cursor in a text console
or rendering coloured text.

- this is a dependency of errbot (see #803347)
- i plan to build the initial package myself and then get
  in contact with the python team for RFS and joining or
  handing over the package



signature.asc
Description: OpenPGP digital signature

Bug#863278: RFS: usbguard/0.7.0-1

[Muri Nicanor]

Hi gustavo,

On 07/22/2017 08:43 AM, gustavo panizzo wrote:
> Hello
> 
> I did review the package, here are my comments
> 
> - i did compare usbguard-0.7.0 tag from upstream github with
>  upstream/0.7.0+ds1 from your repo
> 
> - Why did you remove NOTES.md, doc/usbguard-vs-udev.md,  and
> ROADMAP.md?, they look useful.
I did not- i'm not using the git repo from upstream as a source for
orig, but i'm using the tar.gz upstream provides. In this tar.gz (which
i imported using gbp import-orig --uscan), those files are not included

> - in your git repo there should be a tags with the debian releases, i only
>  see upstream/XXX tags. please push, and sign, tags to your repo.
Oke, i've created a signed tag for this release and pushed it

> - why m4/* files haven't been updated since release 0.5, upstream no
>  longer ship those files. Why keep shipping it? i can build
>  successfully against stretch, with or without them.
Hm, they are part of upstreams release, i'll ask if they can be removed
upstream

> - why src/GUI.qt/ is deleted?
Hm, what do you mean? i don't see that happening...

> - i'm glad you deleted the 3rd party code :)
> 
> - please import upstream tags on your git repo, that makes more easy for
>  others to review (and hopefully send patches)
I plan to switch to using upstreams git repo at some point, but at the
moment I feel more safe using the released .tar.gz files. Is it a big
advantage for reviewing the packaging stuff? In that case i'll try to
have a go at this before the next usbguard release...

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#756397: Link to the new tracker: new patch

[Muri Nicanor]

On 07/19/2017 02:54 AM, Paul Wise wrote:
> On Wed, Jul 19, 2017 at 6:21 AM, Muri Nicanor wrote:
> 
>> attached a new patch which is based on sylvestre's patch from three
>> years ago, but replaces the old links.
> 
> The wording change is a bit suboptimal, I would suggest sticking with
> "Developer Information".
> 
> If pts_url is no longer used, it should be removed also.

Done, updated patch is attached. Not sure about "Developer Information"
though, the tracker gives information about packages, not about
developers, imo

cheers,
muri

From 067fae3263596d4b2384bce310f9058ff78cbe05 Mon Sep 17 00:00:00 2001
From: Muri Nicanor <m...@immerda.ch>
Date: Wed, 19 Jul 2017 15:03:02 +0200
Subject: [PATCH] Replace the link to the old PTS with a link to the new
 tracker on tracker.debian.org.

---
 templates/config.tmpl| 2 +-
 templates/html/show.tmpl | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/templates/config.tmpl b/templates/config.tmpl
index 3f64edf..b28642a 100644
--- a/templates/config.tmpl
+++ b/templates/config.tmpl
@@ -12,7 +12,7 @@
search_url = '/search'
tags_url = 'http://debtags.alioth.debian.org/'
bugs_url = 'https://bugs.debian.org/'
-   pts_url = 'https://packages.qa.debian.org/'
+   tracker_url = 'https://tracker.debian.org/'
ddpo_url = 'https://qa.debian.org/developer.php?login='
src_bugs_url = bugs_url _ 'src:'
mirror_url = 'http://ftp.debian.org/'
diff --git a/templates/html/show.tmpl b/templates/html/show.tmpl
index 31cfce8..f27efbe 100644
--- a/templates/html/show.tmpl
+++ b/templates/html/show.tmpl
@@ -73,9 +73,9 @@
 [% g('Bug Reports') %]
 
 [% IF src.pkg -%]
-[% g('Developer Information (PTS)') %]
+[% g('Developer Information') %]
 [% ELSIF is_source %]
-[% g('Developer Information (PTS)') %]
+[% g('Developer Information') %]
 [%- END %]
 
 [% IF files && (!archive or archive == main_archive or archive == 'security') %]
-- 
2.13.2



signature.asc
Description: OpenPGP digital signature

Bug#756397: Link to the new tracker: new patch

[Muri Nicanor]

hi,

i also think a link to the new package tracker should replace the link
to the old pts; especially since the old pts suggests to look at the new
tracker in big red letters ;)
attached a new patch which is based on sylvestre's patch from three
years ago, but replaces the old links.

cheers,
muri
From 3f2810af18e64ff3dfd66a6a0e43d314fd32da5f Mon Sep 17 00:00:00 2001
From: Muri Nicanor <m...@immerda.ch>
Date: Tue, 18 Jul 2017 22:02:35 +0200
Subject: [PATCH] Replace the link to the old PTS with a link to the new
 package tracker on tracker.debian.org

---
 templates/config.tmpl| 1 +
 templates/html/show.tmpl | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/templates/config.tmpl b/templates/config.tmpl
index 3f64edf..5d3a6f6 100644
--- a/templates/config.tmpl
+++ b/templates/config.tmpl
@@ -13,6 +13,7 @@
tags_url = 'http://debtags.alioth.debian.org/'
bugs_url = 'https://bugs.debian.org/'
pts_url = 'https://packages.qa.debian.org/'
+   tracker_url = 'https://tracker.debian.org/'
ddpo_url = 'https://qa.debian.org/developer.php?login='
src_bugs_url = bugs_url _ 'src:'
mirror_url = 'http://ftp.debian.org/'
diff --git a/templates/html/show.tmpl b/templates/html/show.tmpl
index 31cfce8..6ac383a 100644
--- a/templates/html/show.tmpl
+++ b/templates/html/show.tmpl
@@ -73,9 +73,9 @@
 [% g('Bug Reports') %]
 
 [% IF src.pkg -%]
-[% g('Developer Information (PTS)') %]
+[% g('Package Tracker') %]
 [% ELSIF is_source %]
-[% g('Developer Information (PTS)') %]
+[% g('Package Tracker') %]
 [%- END %]
 
 [% IF files && (!archive or archive == main_archive or archive == 'security') %]
-- 
2.13.2



signature.asc
Description: OpenPGP digital signature

Bug#868378: RFS: nlohmann-json/2.1.1-1

[Muri Nicanor]

Hello Christian,

thanks for pointing that out!

On 07/16/2017 08:47 AM, Christian Seiler wrote:
> This will likely break builds of reverse dependencies because they
> might not find the header anymore. Did you test all of the reverse
> dependencies of nlohmann-json in the archive that they'll find the
> header in the new location? If some of them don't, you should file
> bugs against those packages (ideally with patches) that the
> maintainers know about this change. [1]
There are two reverse dependencies atm, usbguard and mkvtoolnix. I've
removed the build-dependency from usbguard, because it was not needed
anymore and i've filed bug #868573 against mkvtoolnix and attached a patch.

Not sure if that qualifies as a library transition if its only one
package, especially as mkvtoolnix doesn't FTBFS with the new
nlohmann-json package (because it ships its own copy os the json.hpp
file which it falls back to if the system one is not found...)

cheers,
muri

> 
> Also, if the current packages can't auto-detect the new location
> (i.e. they start to FTBFS with your new package), then this is
> technically a library transition, so you should follow the
> guidelines for those:
> https://wiki.debian.org/Teams/ReleaseTeam/Transitions
> 
> Regards,
> Christian
> 
> [1] List of reverse depends (since this is a header-only library):
> grep-dctrl -s Package -F Build-Depends,Build-Depends-Indep \
> nlohmann-json-dev /var/lib/apt/lists/*Sources
> (You need sid in your sources.list and a recent apt-get update
> to ensure this is up to date.)
> 



signature.asc
Description: OpenPGP digital signature

Bug#868573: Location of nlohmann-json header file will change to upstream default

[Muri Nicanor]

Package: src:mkvtoolnix
Version: 13.0.0-2

Hi Christian,

the location where the json.hpp of nlohmann-json-dev is being installed
will be /usr/include/nlohmann in the next upload, which is what upstream
defaults to and what other systems honor (see #868112).
mkvtoolnix is the only reverse dependency of nlohmann-json-dev and will
have to set the includedir accordingly. I've attached a patch which does
that (and which also works with the old nlohmann-json-dev 2.0.6 version).

cheers,
muri
diff -Nru mkvtoolnix-13.0.0/debian/rules mkvtoolnix-13.0.0/debian/rules
--- mkvtoolnix-13.0.0/debian/rules	2017-04-23 19:01:33.0 +0200
+++ mkvtoolnix-13.0.0/debian/rules	2017-07-16 17:13:09.0 +0200
@@ -14,7 +14,8 @@
 
 override_dh_auto_configure:
 	dh_auto_configure -- \
-	--enable-gui
+	--enable-gui \
+	--with-extra-includes=/usr/include/nlohmann
 
 #	exit 1
 


signature.asc
Description: OpenPGP digital signature

Bug#863278: RFS: usbguard/0.7.0-1

[Muri Nicanor]

Hi,

On 07/16/2017 05:28 PM, gustavo panizzo wrote:
>> [...]
>> but i've removed those files from the archive for now, patched the
>> relevant testscripts and created a bug report to create the testdata
>> from source [0]
> cool, excelent
> please add a target gen-orig-xz (or gz, or bz2) to d/rules to generate
> the source from upstream source.
done in git

>>> d/control
>>>
>>> - You have a d/gbp.conf but not Vcs-* headers on d/control
>>>  would be cool if you publish your git packaging, and documented it on
>>>  d/control
>> fixed
> 
> please push tags to you repo so i can compare between your tags and
> upstream tags
done

> the package fails to build with sbuild
it works here *if* i stop the usbguard-daemon on the system i'm building
the package. one of the tests tries to start a usbguard daemon which
fails if there is already a daemon running

> please do the d/rules targe and/or the tag in the repo so i have a way
> to validate the source you are providing before upload. i don't see
> anything else
> missing in the package :)

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#868514: usbguard: unused dependency on nlohmann-json-dev

[Muri Nicanor]

Control: tag -1 + pending

Hi James,

thank you for the bug report, i've removed the build-dependency and
uploaded a new version to mentors

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#863278: RFS: usbguard/0.7.0-1

[Muri Nicanor]

i've uploaded another version that removes an unused build-dependency



signature.asc
Description: OpenPGP digital signature

Bug#868378: RFS: nlohmann-json/2.1.1-1

[Muri Nicanor]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "nlohmann-json"

* Package name : nlohmann-json
  Version  : 2.1.1-1
  Upstream Author  : Niels Lohmann <m...@nlohmann.me>
* Url  : https://nlohmann.github.io/json/
* Licenses : MIT,BSL-1.0,Apache-2.0
  Programming Lang :
  Section  : libs

 JSON library with intuitive syntax, trivial integration and serious
 testing. Other aspects, as memory efficiency and speed were not so
 important. The library consists of a single source file json.hpp.

It builds those binary packages:

  * nlohmann-json-dev

To access further information about this package, visit the following URL:

https://mentors.debian.net/package/nlohmann-json

Alternatively, one can download the package with dget using this command:
dget -x
https://mentors.debian.net/debian/pool/main/n/nlohmann-json/nlohmann-json_2.1.1-1.dsc


More information about nlohmann-json can be obtained from
https://nlohmann.github.io/json/


Changes since last upload:

  * New upstream version 2.1.1
  * Switched build system to cmake, library is now installed in
/usr/include/nlohmann, which is upstream default (Closes: #868112)

Regards,
  Muri Nicanor



signature.asc
Description: OpenPGP digital signature

Bug#868160: usbguard does not start with read-only /etc

[Muri Nicanor]

Control: forwarded -1 https://github.com/dkopecek/usbguard/issues/191

thanks for spotting this! i've forwarded the bug to upstream

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#868112: nlohmann-json-dev: include dir: wrong

[Muri Nicanor]

hi,

On 07/12/2017 08:29 AM, Simon Désaulniers wrote:
> As [1] shows, upstream has default installation path as
> `$libdir/nlohmann/json.hpp`, but debian package installs the lib under 
> $libdir.
> Archlinux AUR package honors this. I think the right thing should be to use 
> what
> upstream decides as installation location, no?

you're totally right, thanks for spotting this. i'll fix this in the
next upload!

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#863278: RFS: usbguard/0.7.0-1

[Muri Nicanor]

On 06/29/2017 05:35 PM, gustavo panizzo wrote:
> Hello, apologies for the late response

no worries, as you can see i'm not very fast myself

oke, so...

On 06/18/2017 11:23 AM, gustavo panizzo wrote:
> d/copyright
> 
> - please set the years to include 2016, 2017. there are some files owned
> by RH which are copyright 2016 but in d/copyright it only says 2015
fixed

> - src/Tests/Makefile.in, src/Tests/test-driver are copyright FSF
added in d/copyright

> - would be cool to run files-without-copyright.sh
you mean in d/rules?

>>> - src/Tests/USB/data/0001.bin src/Tests/UseCase/DummyDevices/root.tar.xz
>>>  what's the source of that file? please regenerate them at build time
>> i'm not sure how to deal with this- the 0001.bin is a copy of a binary
>> USB Descriptor of one of upstreams devices.
> which device? is it a physical device? is it a virtual device?

upstream says:
> This is a copy of a binary USB descriptor of one of my devices. I
don't think I know anymore which one

but i've removed those files from the archive for now, patched the
relevant testscripts and created a bug report to create the testdata
from source [0]

> - please clarify copyright for src/Tests/custom.supp
done so in [1] and upstream added a public domain header [2]. i've added
a paragraph about that file to d/copyright, although it does not yet
contain that public domain header in this release (the file containing
the public domain header is not part of a relaese)

> d/control
> 
> - You have a d/gbp.conf but not Vcs-* headers on d/control
>  would be cool if you publish your git packaging, and documented it on
>  d/control
fixed

>  if you do that, please use pristine-tar to publish the tarballs
oke, i've imported the tarballs using pristine-tar commit
../usbguard_0.7.0+ds1.orig.tar.gz and used --git-pristine-tar with gbp

> d/changelog
> 
> - please fix spelling in 'neede kernek'
fixed

> * New upstream version 0.7.0
>  This release contains a backwards incompatible
>  change because it changes how the device hash is
>  computed for Linux root hub devices
> 
> Please create a NEWS.Debian file, also please make a note to add a
> notice in the release manual for buster (i know, looong time)
> Users hate when things change without notice (i'm an usbguard user :)
i've added a d/NEWS file (dch --create --news) and added the information
there. did you mean i should make a note for myself or did you mean a
note in d/NEWS and if the latter, what is the syntax?

new version is on mentors ;)

cheers,
muri

[0] https://github.com/dkopecek/usbguard/issues/188
[1] https://github.com/dkopecek/usbguard/issues/175
[2]
https://github.com/dkopecek/usbguard/commit/faa84a648a575db7d8e382729ea7dcea079afe3a



signature.asc
Description: OpenPGP digital signature

Bug#863278: RFS: usbguard/0.7.0-1

[Muri Nicanor]

Hi,

On 06/18/2017 11:23 AM, gustavo panizzo wrote:
> - src/Tests/USB/data/0001.bin src/Tests/UseCase/DummyDevices/root.tar.xz
>  what's the source of that file? please regenerate them at build time

i'm not sure how to deal with this- the 0001.bin is a copy of a binary
USB Descriptor of one of upstreams devices. The root.tar.xz is an
archive containing the files from
src/Tests/UseCase/DummyDevices/{bus,devices}, which itself is a copy of
upstreams /sys/bus/usb and /sys/devices, containing also some binary
files. And the files are only there for the tests.

i would compare this with a JPG-file thats part of a graphics library
test-routine or something like that...

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#864821: new upstream version (0.7.0)

[Muri Nicanor]

control: tags -1 pending

Hello Philipp,

the new usbguard release is already packaged an uploaded to mentors
https://mentors.debian.net/debian/pool/main/u/usbguard/usbguard_0.7.0-1.dsc

It is awaiting review.

cheers,
muri

On 06/15/2017 01:17 PM, Philipp Plüss wrote:
> Package: usbguard
> Severity: whishlist
> 
> Hallo Muri
> 
> Thank you for maintaining usbguard in Debian.
> 
> It would be nice, if you could update the package to the new upstream
> version 0.7.0.
> 
> regards
> Philipp
> 



signature.asc
Description: OpenPGP digital signature

Bug#863278: RFS: usbguard/0.7.0-1

[Muri Nicanor]

control: tags -1 - moreinfo

hi,

On 06/01/2017 12:07 PM, gustavo panizzo wrote:
> the package builds fine with pbuilder but tests fails when i try to
> build using sbuild.
> 
> FAIL UseCase/001_cli_policy.sh (exit status: 1)
this fails if there is already a running usbguard instance- when i
stopped mine the test ran fine


> perhaps usbguard should build-depend on sudo?
> 
> UseCase/002_cli_devices.sh.log:  + sudo -n dd bs=4096 count=1
> if=/dev/zero of=/tmp/usbguard_disk
> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line 81:
> sudo: command not found
> UseCase/002_cli_devices.sh.log:  + sudo -n modprobe dummy_hcd
> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line 82:
> sudo: command not found
> UseCase/002_cli_devices.sh.log:  + sudo -n rmmod g_mass_storage
> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line 83:
> sudo: command not found
> UseCase/002_cli_devices.sh.log:  + sudo -n modprobe g_mass_storage
> file=/tmp/usbguard_disk iSerialNumber=555666111
> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line 84:
> sudo: command not found
> UseCase/002_cli_devices.sh.log:  + '[' 127 -ne 0 ']'
> UseCase/002_cli_devices.sh.log:  + exit 77
> UseCase/002_cli_devices.sh.log:  SKIP UseCase/002_cli_devices.sh (exit
> status: 77)

this test is now disabled (skipped), as the neede kernel modules needed
are not part of debian default kernel

> this should be easy to fix
> 
> Packaging/spell-check.sh.log:  Skipping test because some dependecies
> are missing
> Packaging/spell-check.sh.log:  ASPELL: Packaging/spell-check.sh.log: 
> PANDOC: /usr/bin/pandoc
> Packaging/spell-check.sh.log:  SKIP Packaging/spell-check.sh (exit
> status: 77)
fixed.

i've uploaded a new version to mentors,

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#864313: ITP: ipcalcng -- Tool to assist in network address calculations for IPv4 and IPv6

[Muri Nicanor]

Package: wnpp
Severity: wishlist
Owner: Muri Nicanor <m...@immerda.ch>

* Package name : ipcalcng
  Version  : 0.2.0-1
  Upstream Author  : Nikos Mavrogiannopoulos
* Url  : https://github.com/nmav/ipcalc
* Licenses : BSD-3-Clause,GPL-2
  Programming Lang : C
  Section  : net

 This is a modern tool to assist in network address calculations for
 IPv4 and IPv6. It acts both as a tool to output human readable
 information about a network or address, as well as a tool suitable to
 be used by scripts or other programs.
 .
 It supports printing a summary about the provided network address,
 multiple command line options per information to be printed,
 transparent IPv6 support, and in addition it will use libGeoIP if
 available to provide geographic information.

I'm an intense user of ipcalc, which is a really useful tool, but ipcalc
does not do IPv6 addresses. I've stumbled over the ipcalc by Nikos
Mavrogiannopoulos when looking for a version that is IPv6 capable. I'm
aware of the naming collision, thats why i propose to call the package
(and the binary) ipcalng. I'm not sure yet if that name is the right
solution, in particular because in fedora the perl ipcalc version was
renamed to ipcalculator and this one is now called ipcalc [0]. This
could lead to a lot of confusion and i would have to maintain that
change forever. If there are better solutions please let me know.

cheers,
muri

[0] https://fedoraproject.org/wiki/Changes/ipcalculator



signature.asc
Description: OpenPGP digital signature

Bug#863278: RFS: usbguard/0.7.0-1

[Muri Nicanor]

Hi,

On 06/01/2017 11:54 AM, gustavo panizzo wrote:
> Hello
> 
> On Wed, May 24, 2017 at 07:43:35PM +0200, Muri Nicanor wrote:
> 
>>  * New upstream version 0.7.0
>>This release contains a backwards incompatible
>>change because it changes how the device hash is
>>computed for Linux root hub devices
> 
> How is it handled for users that already have a config file? do they
> need to create a new configuration file?
kind of. the hashes of the devices in the usbguard rules file will have
to be set to new values. in the old versions of usbguard, the Linux root
hub bcdDevice value was included in the hash value of the device- but
this value changes every new kernel release. so it is now excluded from
calculating the hash.

> Can the update to the config file by done automatically? (postinst)
i don't think so- postinst would have to calculate new hashes for every
device listed in the rules file but most devices won't be present at the
time of upgrading.

> does this version need a newer kernel than older versions?
no



signature.asc
Description: OpenPGP digital signature

Bug#863278: RFS: usbguard/0.7.0-1

[Muri Nicanor]

hi,

On 06/01/2017 12:07 PM, gustavo panizzo wrote:
> control: owner -1 !
> control: tags -1 moreinfo
> 
> the package builds fine with pbuilder but tests fails when i try to
> build using sbuild.
thanks for the pointer, i totally missed that only using pbuilder. now i
also have a working sbuild schroot ;)

> FAIL UseCase/001_cli_policy.sh (exit status: 1)
hm, i'm not sure yet why this test is failing, looking into thath

> 
> some tests are skipped, i feel they should run
> 
> 
> perhaps usbguard should build-depend on sudo?
> 
> UseCase/002_cli_devices.sh.log:  + sudo -n dd bs=4096 count=1
> if=/dev/zero of=/tmp/usbguard_disk
> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line 81:
> sudo: command not found
> UseCase/002_cli_devices.sh.log:  + sudo -n modprobe dummy_hcd
> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line 82:
> sudo: command not found
> UseCase/002_cli_devices.sh.log:  + sudo -n rmmod g_mass_storage
> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line 83:
> sudo: command not found
> UseCase/002_cli_devices.sh.log:  + sudo -n modprobe g_mass_storage
> file=/tmp/usbguard_disk iSerialNumber=555666111
> UseCase/002_cli_devices.sh.log:  ./UseCase/002_cli_devices.sh: line 84:
> sudo: command not found
> UseCase/002_cli_devices.sh.log:  + '[' 127 -ne 0 ']'
> UseCase/002_cli_devices.sh.log:  + exit 77
> UseCase/002_cli_devices.sh.log:  SKIP UseCase/002_cli_devices.sh (exit
> status: 77)

i tried with removing the sudo, but debian doesn't have dummy_hcd or
g_mass_storage included in the kernel, so these tests won't work at all :(

> 
> 
> this should be easy to fix
> 
> Packaging/spell-check.sh.log:  Skipping test because some dependecies
> are missing
> Packaging/spell-check.sh.log:  ASPELL: Packaging/spell-check.sh.log: 
> PANDOC: /usr/bin/pandoc
> Packaging/spell-check.sh.log:  SKIP Packaging/spell-check.sh (exit
> status: 77)

thanks! i've added aspell to the build-dependencies!

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#863278: RFS: usbguard/0.7.0-1

[Muri Nicanor]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "usbguard"

* Package name: usbguard
  Version : 0.7.0-1
  Upstream Author : Daniel Kopeček
* Url : https://dkopecek.github.io/usbguard/
* Licenses: CC-BY-SA-3.0,FSFULLR,GPL-3+,GPL-2+
  Section : utils

It builds those binary packages:

  * libusbguard0
  * usbguard
  * usbguard-applet-qt

To access further information about this package, visit the following URL:

https://mentors.debian.net/package/usbguard

Alternatively, one can download the package with dget using this command:
dget -x
https://mentors.debian.net/debian/pool/main/u/usbguard/usbguard_0.7.0-1.dsc

Or clone the package from https://0xacab.org/muri/debian-usbguard

More information about usbguard can be obtained from
https://dkopecek.github.io/usbguard/

Changes since last upload:

  * New upstream version 0.7.0
This release contains a backwards incompatible
change because it changes how the device hash is
computed for Linux root hub devices
  * Add support for bash-completion
  * Delete add-unistd.patch, its not needed anymore
  * Compile the library static, to make `make check` work
  * Bump compat version to 10
  * Add d/usbguard.dirs

Regards,
  Muri Nicanor




signature.asc
Description: OpenPGP digital signature

Bug#803347: (no subject)

[Muri Nicanor]

control: owner -1 !
control: retitle -1 ITP: err -- pluggable chatbot

i'm working on packaging errbot

Bug#854240: unblock: usbguard/0.6.2+ds1-2

[Muri Nicanor]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package usbguard

i've found a serious bug (#854192) in the usbguard packages
yesterday- the installation procedure was stalling on a
minimal stretch installation, because dbus was missing from the Depends:.
i've fixed the bug today and uploaded to mentors, and its
been sponsored shortly after (#854230).

debdiff is attached

unblock usbguard/0.6.2+ds1-2

-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.8.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)


diff -Nru usbguard-0.6.2+ds1/debian/changelog usbguard-0.6.2+ds1/debian/changelog
--- usbguard-0.6.2+ds1/debian/changelog	2016-12-08 11:16:28.0 +0100
+++ usbguard-0.6.2+ds1/debian/changelog	2017-02-05 08:21:56.0 +0100
@@ -1,3 +1,9 @@
+usbguard (0.6.2+ds1-2) unstable; urgency=medium
+
+  * Add dbus to Depends (Closes: #854192)
+
+ -- Muri Nicanor <m...@immerda.ch>  Sun, 05 Feb 2017 08:21:56 +0100
+
 usbguard (0.6.2+ds1-1) unstable; urgency=medium
 
   * New upstream version 0.6.2+ds1
diff -Nru usbguard-0.6.2+ds1/debian/control usbguard-0.6.2+ds1/debian/control
--- usbguard-0.6.2+ds1/debian/control	2016-12-08 11:16:28.0 +0100
+++ usbguard-0.6.2+ds1/debian/control	2017-02-04 23:39:40.0 +0100
@@ -48,7 +48,7 @@
 
 Package: usbguard
 Architecture: linux-any
-Depends: ${misc:Depends}, ${shlibs:Depends}
+Depends: ${misc:Depends}, ${shlibs:Depends}, dbus
 Description: USB device authorization policy framework
  The USBGuard software framework helps to protect your computer against rogue
  USB devices (a.k.a. BadUSB) by implementing basic whitelisting and blacklisting




signature.asc
Description: OpenPGP digital signature

Bug#854230: RFS: usbguard/0.6.2+ds1-2 [RC]

[Muri Nicanor]

Package: sponsorship-requests
Severity: serious

Dear mentors,

I am looking for a sponsor for my package "usbguard". This revision
fixes a serious bug (#854192), which makes installing break on a minimal
stretch installation. I'm not sure, should i contact release team about
that or does the sponsor do that?

* Package name: usbguard
  Version : 0.6.2+ds1-2
  Upstream Author : Daniel Kopeček <dkope...@redhat.com>
* URL : https://github.com/dkopecek/usbguard
* License : GPL-2+
  Section : utils

It builds those binary packages:

 libusbguard0 - USB device authorization policy framework - shared library
 usbguard   - USB device authorization policy framework
 usbguard-applet-qt - USB device authorization policy framework - qt applet

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/usbguard


Alternatively, one can download the package with dget using this command:

dget -x
https://mentors.debian.net/debian/pool/main/u/usbguard/usbguard_0.6.2+ds1-2.dsc

Changes since the last upload:

  * Add dbus to Depends (Closes: #854192)


Regards,
   Muri Nicanor



signature.asc
Description: OpenPGP digital signature

Bug#854192: serious bug in usbguard installation

[Muri Nicanor]

Hi!

On 02/04/2017 11:25 PM, Christian Seiler wrote:
> On 02/04/2017 10:09 PM, Muri Nicanor wrote:
>> i just found a bug (#854192) in the installation procedure of usbguard:
>> when i install usbguard on a minimal stretch system, the installation
>> stalls and never ends successfully. apparently it has something to do
>> with dbus being a dependency of usbguard. if i install dbus *before*
>> installing usbugard, everything works fine. this is probably, why it
>> didn't come up before. if i don't, the installations procedure stalls at
>>> /var/lib/dpkg/info/usbguard.postinst configure
>>
>> and the journal says
>>> Feb 04 13:11:04 debian dbus-daemon[1200]: Unknown username
>>> "usbguard-dbus" in message bus configuration file
>>> Feb 04 13:11:04 debian dbus-daemon[1200]: Failed to start message
>>> bus: Could not get UID and GID for username "messagebus"
> 
> Problem is that DBus fails to start, and systemd requires DBus to be
> running (and configured properly) if Type=dbus is used.
> 
> The problem is that your package doesn't have Depends: dbus, so it
> doesn't depend on the DBus daemon being available, so APT configures
> dbus after usbguard (it's allowed to do that w/o an explicit Depends),
> which is bad, since dbus's postinst creates the 'messagebus' user,
> without which the DBus daemon doesn't start.
> 
> Fix is simple: add that dependency. :-) If you look at other DBus
> services, they all have that dependency explicitly.

Ah, thanks! Thats actually much easier than i thought ;) i'll upload a
new revision today!

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#854192: usbguard installation fails on clean minimal stretch system without dbus

[Muri Nicanor]

Package: usbguard
Version: 0.6.2+ds1-1
Severity: serious

when installing usbguard on a clean stretch installation (with no dbus
package installed) usbguard installs dbus as a dependency. but
apparently if both the packages get installed at the same time, the
usbguard-dbus service gets stuck at startup:

this is what apt install usbguard says:
>Setting up usbguard (0.6.2+ds1-1) ...
>Created symlink /etc/systemd/system/dbus-org.usbguard.service →
/lib/systemd/system/usbguard-dbus.service.
>Created symlink
/etc/systemd/system/multi-user.target.wants/usbguard-dbus.service →
/lib/systemd/system/usbguard-dbus.service.
>Created symlink /etc/systemd/system/basic.target.wants/usbguard.service
→ /lib/systemd/system/usbguard.service.
>Job for usbguard-dbus.service failed because a timeout was exceeded.
>See "systemctl status usbguard-dbus.service" and "journalctl -xe" for
details.
>usbguard-dbus.service couldn't start.

this is the output of journalctl -xe:

>Feb 04 13:11:04 debian systemd[1]: Listening on D-Bus System Message
Bus Socket.
>-- Subject: Unit dbus.socket has finished start-up
>-- Defined-By: systemd
>-- Support: https://www.debian.org/support
>--
>-- Unit dbus.socket has finished starting up.
>--
>-- The start-up result is done.
>Feb 04 13:11:04 debian systemd[1]: Starting USBGuard D-Bus Service...
>-- Subject: Unit usbguard-dbus.service has begun start-up
>-- Defined-By: systemd
>-- Support: https://www.debian.org/support
>--
>-- Unit usbguard-dbus.service has begun starting up.
>Feb 04 13:11:04 debian systemd[1]: Started D-Bus System Message Bus.
>-- Subject: Unit dbus.service has finished start-up
>-- Defined-By: systemd
>-- Support: https://www.debian.org/support
>--
>-- Unit dbus.service has finished starting up.
>--
>-- The start-up result is done.
>Feb 04 13:11:04 debian dbus-daemon[1200]: Unknown username
"usbguard-dbus" in message bus configuration file
>Feb 04 13:11:04 debian dbus-daemon[1200]: Failed to start message bus:
Could not get UID and GID for username "messagebus"
>Feb 04 13:11:29 debian systemd[1]: Failed to subscribe to
NameOwnerChanged signal for 'org.usbguard': Connection timed out
>Feb 04 13:11:29 debian systemd[1]: Failed to subscribe to
NameOwnerChanged signal for 'org.freedesktop.login1': Connection timed out
>Feb 04 13:11:29 debian systemd[1]: Failed to subscribe to activation
signal: Connection timed out
>Feb 04 13:11:29 debian systemd[1]: Failed to register name: Connection
timed out
>Feb 04 13:11:29 debian systemd[1]: Failed to set up API bus: Connection
timed out
>Feb 04 13:11:29 debian systemd[1]: dbus.service: Main process exited,
code=exited, status=1/FAILURE
>Feb 04 13:11:29 debian systemd[1]: dbus.service: Unit entered failed state.
>Feb 04 13:11:29 debian systemd[1]: dbus.service: Failed with result
'exit-code'.
>Feb 04 13:11:29 debian systemd[1]: Looping too fast. Throttling
execution a little.
>Feb 04 13:11:30 debian systemd[1]: Looping too fast. Throttling
execution a little.
>Feb 04 13:11:31 debian systemd[1]: Looping too fast. Throttling
execution a little.

and then the 'Looping too fast.'-Message just repeats. But if i install
dbus first and then install usbguard,
everything works fine.



signature.asc
Description: OpenPGP digital signature

Bug#852108: usbguard: fails to start after installation: "ERROR: Configuration: /etc/usbguard/rules.conf: usbguard::Exception"

[Muri Nicanor]

control: tags -1 + moreinfo unreproducible

hi again,

On 01/21/2017 07:08 PM, intrig...@debian.org wrote:
> after installing the package, usbguard.service fails to start:
> 
>   systemd[1]: Started USBGuard daemon.
>   usbguard-daemon[30357]: [1485021770.799] (E) ERROR: Configuration: 
> /etc/usbguard/rules.conf: usbguard::Exception
>   systemd[1]: usbguard.service: Main process exited, code=exited, 
> status=1/FAILURE
>   systemd[1]: usbguard.service: Unit entered failed state.
>   systemd[1]: usbguard.service: Failed with result 'exit-code'.

i'm actually not able to reproduce the bug. if i install usbguard on a
clean stretch installation i can start usbguard[0] without having an
/etc/usbguard/rules.conf file:

> muri@debian:~$ ls /etc/usbguard/
> usbguard-daemon.conf
> muri@debian:~$ grep RuleFile /etc/usbguard/usbguard-daemon.conf
> # RuleFile=/path/to/rules.conf
> RuleFile=/etc/usbguard/rules.conf
> muri@debian:~$ sudo service usbguard stop
> [sudo] password for muri:
> muri@debian:~$ sudo service usbguard start
> muri@debian:~$ sudo systemctl status usbguard
> ● usbguard.service - USBGuard daemon
>   Loaded: loaded (/lib/systemd/system/usbguard.service; enabled;
>vendor preset: enabled)
>   Active: active (running) since Sat 2017-02-04 12:44:55 EST; 5s ago
> Docs: man:usbguard-daemon(8)
> Main PID: 1130 (usbguard-daemon)
>Tasks: 2 (limit: 4915)
>   CGroup: /system.slice/usbguard.service
>   └─1130 /usr/sbin/usbguard-daemon -k -c /etc/usbguard
>/usbguard-daemon.conf
>
>Feb 04 12:44:55 debian systemd[1]: Started USBGuard daemon.

was there maybe a file without read permissions? or with maybe with
rules that made usbguard choke?

(nontheless i'll still add the rules.conf in the postinst script)

cheers,
muri

[0] i found another bug, that i'll file right away



signature.asc
Description: OpenPGP digital signature

Bug#852108: usbguard: fails to start after installation: "ERROR: Configuration: /etc/usbguard/rules.conf: usbguard::Exception"

[Muri Nicanor]

control: tags -1 + pending

Hi intrigeri,

thanks a lot for spotting this. You're totally right, there should be at
least an empty rules.conf file. I'll fix that.

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#847358: ERROR: BUG: Unknown error code.

[Muri Nicanor]

hello micah,

sorry for the late reply, sadly i was occupied with other stuff. but
your bug report pushed me to package and upload the 0.6 version of
usbguard, which is in testing for a week or two now ;)

would you mind testing if your problem persists with the 0.6 version?
there have been some changes in device matching, so chances are good
that the new version fixes the bug

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#847792: RFS: usbguard/0.6.2+ds1-1

[Muri Nicanor]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "usbguard"

* Package name: usbguard
  Version : 0.6.2+ds1-1
  Upstream Author : Daniel Kopeček
* Url : https://dkopecek.github.io/usbguard/
* Licenses: CC-BY-SA-3.0,GPL-3+,FSFULLR,GPL-2+
  Section : utils

It builds those binary packages:

  * libusbguard0
  * usbguard
  * usbguard-applet-qt

To access further information about this package, visit the following URL:

https://mentors.debian.net/package/usbguard

Alternatively, one can download the package with dget using this command:
dget -x
https://mentors.debian.net/debian/pool/main/u/usbguard/usbguard_0.6.2+ds1-1.dsc


More information about usbguard can be obtained from
https://dkopecek.github.io/usbguard/

Changes since last upload:

  * New upstream version 0.6.2+ds1
  * Add xdg autostart file to usbguard-applet-qt (Closes: #838173)
  * fixed upstream version tag
  * set default compilder and linker flags
  * changed the location of libusbguard.so.0 to a private directory
and set the rpath accordingly
  * remove the fix-mips-build patch, it was included upstream
  * remove the development file package, because the library is not
stable for now

cheers,
-- 
muri





signature.asc
Description: OpenPGP digital signature

Bug#838172: usbguard-applet-qt: GUI window cannot be opened again after the first time

[Muri Nicanor]

control: tags -1 + moreinfo unreproducible

hi,

thanks for your bug report,

On 09/18/2016 04:09 AM, Christoph Anton Mitterer wrote:
> When using usbguard-applet-qt and clicking on the systray icon to open it's 
> window,
> then this only works for the first time the program has been started.
> 
> Once the window has been closed the following happens when clicking on the 
> icon again:
> For half a second or so, a minimised window (noted by [] brackets around the 
> title)
> appears in the window least, which then disappears again.

i've tried to reproduce this on a fresh installation, both with gnome3
and with cinnamon. in both cases, clicking the symbol in the icon in the
notification area opens the usbguard-applet-qt window and clicking it
again closes the window and this also work the subsequent times clicking
the icon.
it also works on my production machine with openbox, so it seems to me
there is something else causing that behaviour.

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#838173: usbguard-applet-qt: register the applet with major desktop environments

[Muri Nicanor]

control: tags -1 + pending

hello and thanks for your bug report,

On 09/18/2016 04:13 AM, Christoph Anton Mitterer wrote:
> Since usbguard-applet-qt is probably the most usable way for controlling 
> usbguard
> when running on a desktop, it would be nice to have it somehow registered
> with the major desktop environments (Cinnamon, KDE, LXDE, XFCE, GNOME, etc.)
> and started automatically per default (one can assume the user wants this, 
> when
> he installs the package).
> 
> Cinnamon, for e.g. has "Applets" in its system control. But I assume for there
> to show up a true cinnamon applet would be needed (or at least some wrapping
> around the Qt applet).

there is a /usr/share/applications/usbguard-applet-qt.desktop shipped
with the usbguard debian package. in the debian default setup with gnome
desktop, i can see a usbguard-applet-qt menu entry.

> Another way could be the "Startup Applications" from its system control.
> Having it there, would also allow to easily enable/disable the applet.

thats a good idea, thanks. i'll ship a .desktop autostart file with
the next upload.

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#847403: RFS: nlohmann-json/2.0.6-1

[Muri Nicanor]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "nlohmann-json"

* Package name: nlohmann-json
  Version : 2.0.6-1
  Upstream Author : Niels Lohmann
* Url : https://nlohmann.github.io/json/
* Licenses: Apache-2.0,BSL-1.0,MIT
  Section : libs

It builds those binary packages:

  * nlohmann-json-dev

To access further information about this package, visit the following URL:

https://mentors.debian.net/package/nlohmann-json

Alternatively, one can download the package with dget using this command:
dget -x
https://mentors.debian.net/debian/pool/main/n/nlohmann-json/nlohmann-json_2.0.6-1.dsc


More information about nlohmann-json can be obtained from
https://nlohmann.github.io/json/

Changes since last upload:

  * New upstream version 2.0.5
  * New upstream version 2.0.6

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#837704: RFS: usbguard/0.5.14+ds1-2

[Muri Nicanor]

Package: sponsorship-requests
Severity: normal

Dear mentors,

because there is still some stuff to sort out with the new usbguard 0.6
release, i fixed the bugs in the already uploaded release and made a new
debian revision. I hope that approach is oke.

I am looking for a sponsor for my package "usbguard"

 * Package name: usbguard
   Version : 0.5.14+ds1-2
   Upstream Author : Daniel Kopeček 
 * URL : https://github.com/dkopecek/usbguard
 * License : GPL-2+
   Section : utils

  It builds those binary packages:

 libusbguard-dev - USB device authorization policy framework -
development files
 libusbguard0 - USB device authorization policy framework - shared library
 usbguard   - USB device authorization policy framework
 usbguard-applet-qt - USB device authorization policy framework - qt applet

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/usbguard


Alternatively, one can download the package with dget using this command:

dget -x
https://mentors.debian.net/debian/pool/main/u/usbguard/usbguard_0.5.14+ds1-2.dsc

More information about usbguard can be obtained from
https://dkopecek.github.io/usbguard/

  Changes since the last upload:

  * d/control:
   - Add systemd to build dependencies (Closes: #836713)
   - Change architectures to linux-any in d/control
  * d/rules
   - Add sysconfdir flag to autoconf (Closes: #837176)
  * d/patches/
   - Fix mips build (Closes: #836712)
   - Set correct IPCAllowedGroups (Closes: #837175)

cheers,
-- 
muri




signature.asc
Description: OpenPGP digital signature

Bug#837598: RFS: nlohmann-json/2.0.4-1

[Muri Nicanor]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "nlohmann-json"

* Package name: nlohmann-json
  Version : 2.0.4-1
   Upstream Author : Niels Lohmann
 * URL : https://github.com/nlohmann/json
 * License : MIT
   Section : libs

It builds those binary packages:

nlohmann-json-dev - JSON for Modern C++

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/nlohmann-json


Alternatively, one can download the package with dget using this command:

dget -x
https://mentors.debian.net/debian/pool/main/n/nlohmann-json/nlohmann-json_2.0.4-1.dsc

Changes since the last upload:

* New upstream version 2.0.4

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#837176: usbguard: set/ship proper RuleFile=/

[Muri Nicanor]

Control: tag -1 + pending

Hello,

thanks a lot for the bug report!

On 09/09/2016 08:46 PM, Christoph Anton Mitterer wrote:
> Currently, the config has the following set:
> RuleFile=/usr/local/etc/usbguard/rules.conf
> 
> Isn't this a config file that may also be set via the IPC of the daemon?

hm, i'm not sure about that.

> However, not even /usr/local/etc/usbguard would exist, nor should
> that IMO placed in /usr but rather /etc.

yes, you're totally right- that file path should be
/etc/usbguard/rules.conf. the --sysconfdir argument is missing from
autoconf. it's already fixed in the package of the following upstream
release ;)

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#837175: usbguard: don' set IPCAllowedGroups=wheel

[Muri Nicanor]

Control: tag -1 + pending

Hi,

thanks for the bug report!

On 09/09/2016 08:50 PM, Christoph Anton Mitterer wrote:
> Currently the config sets:
> IPCAllowedGroups=wheel
> 
> This doesn't seem to be one of the standard Debian
> system groups (it doesn't even exist), nor is it created
> by the package.
> It may very well exist already as some user (thus the security
> tag and important).
> 
> Please use porper group (I think the upstream docs use "usbguard"
> as an example,... or simply use "root" group.

ouch, yes, you're right- my time with freebsd seems to have mixed up my
knowledge of default groups ;) i think the root group should be the
right one (the current config is actually the upstream one).
i'll take care of that.

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#836959: RFS: usbguard/0.6.0+ds1-1

[Muri Nicanor]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "usbguard"

 * Package name: usbguard
   Version : 0.6.0+ds1-1
   Upstream Author : Daniel Kopeček 
 * URL : https://github.com/dkopecek/usbguard
 * License : GPL-2+
   Section : utils

  It builds those binary packages:

 libusbguard-dev - USB device authorization policy framework -
development files
 libusbguard0 - USB device authorization policy framework - shared library
 usbguard   - USB device authorization policy framework
 usbguard-applet-qt - USB device authorization policy framework - qt applet

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/usbguard

Alternatively, one can download the package with dget using this command:

dget -x
https://mentors.debian.net/debian/pool/main/u/usbguard/usbguard_0.6.0+ds1-1.dsc

More information about hello can be obtained from
https://dkopecek.github.io/usbguard/

Changes since the last upload:

  * New upstream release
  * d/control:
- Remove nlohman-json from build-dependencies
- Add protobuf build dependency
- Change the architecture to linux-any
- Add systemd to build dependencies (Closes: #836713)
  * d/rules
- Add configure flag to enable building of the qt-gui
- Add sysconfdir argument to configure
  * Add patch to link against libatomic if present (Closes: #836712)

PS: I tried to test the build process on a qemu-mips machine, but i only
could create a qemu-system-mips machine with 256MB ram, which was not
enough for the build process. But christian said that he build-tested
the patch and i trust his judgment.

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#836701: RFS: nlohmann-json/2.0.3-1

[Muri Nicanor]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "nlohmann-json"

 * Package name: nlohmann-json
   Version : 2.0.3-1
   Upstream Author : Niels Lohmann
 * URL : https://github.com/nlohmann/json
 * License : MIT
   Section : libs

It builds those binary packages:

nlohmann-json-dev - JSON for Modern C++

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/nlohmann-json


  Alternatively, one can download the package with dget using this command:

dget -x
https://mentors.debian.net/debian/pool/main/n/nlohmann-json/nlohmann-json_2.0.3-1.dsc

More information about hello can be obtained from
https://nlohmann.github.io/json/.

Changes since the last upload:

* New upstream release

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#732411: monkeysign: Being nicer with systems without a SMTP server

[Muri Nicanor]

Hi,

On 09/01/2016 05:43 PM, Antoine Beaupré wrote:
> unfortunately, this patch doesn't apply anymore. :( I have since them
> implemented a `--mta` option which allows the user to pipe the message
> through an arbitrary command. It can be (ab-)used to save it to a file
> (with `--mta "tee file.txt"` or `--mta "dd status=none of=file.txt"` for
> the more obsessive types).

this definitly sounds like a more sane option than my patch, thanks a
lot for implementing this! i'm looking forward to try it ;)

cheers
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#825302: RFS: usbguard/0.4-2 [ITP]

[Muri Nicanor]

hi,

i've just uploaded a new version of usbguard to mentors. Its now version
0.5.11, which removes the build dependency on quex, and uses pegtl
(pegtl-dev) instead, which i already packaged and Gianfranco kindly
sponsored. The other unresolved build dependency, json
(nlohmann-json-dev) i've also packaged and is also sponsored by Gianfranco.
In addition, the built packages now also include the qt-applet
(usbguard-applet-qt).

so:
I am looking for a sponsor for my package "usbguard"

 * Package name: usbguard
   Version : 0.5.11-1
   Upstream Author : Daniel Kopeček 
 * URL : https://github.com/dkopecek/usbguard
 * License : GPL-2+
   Section : utils

It builds those binary packages:

 libusbguard-dev - USB device authorization policy framework -
development files
 libusbguard0 - USB device authorization policy framework - shared library
 usbguard   - USB device authorization policy framework
 usbguard-applet-qt - USB device authorization policy framework - qt applet

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/usbguard


Alternatively, one can download the package with dget using this command:

dget -x
https://mentors.debian.net/debian/pool/main/u/usbguard/usbguard_0.5.11-1.dsc

More information about hello can be obtained from
https://dkopecek.github.io/usbguard/

Changes since the last upload:
* build dependencies are now in testing
* qt-applet is part of the package
* this release contains backwards incompatible changes: the device hash
value computation was changed to include the USB descriptor data

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#833456: RFS: nlohmann-json/2.0.2-1

[Muri Nicanor]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "nlohmann-json"

* Package name: nlohmann-json
  Version : 2.0.2-1
  Upstream Author : Niels Lohmann
* URL : https://github.com/nlohmann/json
* License : MIT
  Section : libs

It builds those binary packages:

nlohmann-json-dev - JSON for Modern C++

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/nlohmann-json


Alternatively, one can download the package with dget using this command:

  dget -x
https://mentors.debian.net/debian/pool/main/n/nlohmann-json/nlohmann-json_2.0.2-1.dsc

More information about nlohmann-json can be obtained from
https://nlohmann.github.io/json/.

Changes since the last upload:

* New upstream release

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#831910: tracker.debian.org: loaddata imports package sources wrong

[Muri Nicanor]

Package: tracker.debian.org
Severity: normal

Dear Maintainer,

i tried to setup my own tracker in a vagrant environment (based on the
vagrant debian/jessie64 image).
When following the instructions on
https://tracker.debian.org/docs/setup/repositories.html#repositories
the command
./manage.py tracker_update_repositories
fails, because the file
data/cache/apt-cache/etc/sources.list
contains sections like
m a i n   c o n t r i b   n o n - f r e e
meaning: all the characters are divided by one additional space chacter.
this leads to the command failing:

2016-07-20 18:47:46,343 INFO: Starting task UpdateRepositoriesTask
2016-07-20 18:47:46,344 INFO: UpdateRepositoriesTask Updating apt's cache
2016-07-20 18:47:55,284 ERROR: Problem processing a task.
Traceback (most recent call last):
  File "/home/vagrant/foo/distro_tracker/core/tasks.py", line 521, in run
task.execute()
  File "/home/vagrant/foo/distro_tracker/core/tasks.py", line 551, in wrapper
six.reraise(*sys.exc_info())
  File "/home/vagrant/foo/distro_tracker/core/tasks.py", line 548, in wrapper
func(self)
  File "/home/vagrant/foo/distro_tracker/core/retrieve_data.py", line 814, in 
execute
self.apt_cache.update_repositories(self.force_update)
  File "/home/vagrant/foo/distro_tracker/core/utils/packages.py", line 430, in 
update_repositories
cache.update(progress)
  File "/usr/lib/python2.7/dist-packages/apt/cache.py", line 443, in update
raise FetchFailedException(e)
FetchFailedException: W:Failed to fetch 
http://security.debian.org/dists/oldstable/updates/InRelease  Unable to find 
expected entry 'm/source/Sources' in Release file (Wrong sources.list entry or 
malformed file)
, W:Failed to fetch 
http://httpredir.debian.org/debian/dists/wheezy-backports/InRelease  Unable to 
find expected entry 'm/source/Sources' in Release file (Wrong sources.list 
entry or malformed file)
, W:Failed to fetch 
http://httpredir.debian.org/debian/dists/wheezy-backports-sloppy/InRelease  
Unable to find expected entry 'm/source/Sources' in Release file (Wrong 
sources.list entry or malformed file)
, W:Failed to fetch 
http://httpredir.debian.org/debian/dists/oldstable-updates/InRelease  Unable to 
find expected entry 'm/source/Sources' in Release file (Wrong sources.list 
entry or malformed file)
, W:Failed to fetch 
http://httpredir.debian.org/debian/dists/oldstable-proposed-updates/InRelease  
Unable to find expected entry 'm/source/Sources' in Release file (Wrong 
sources.list entry or malformed file)
, W:Failed to fetch http://security.debian.org/dists/stable/updates/InRelease  
Unable to find expected entry 'm/source/Sources' in Release file (Wrong 
sources.list entry or malformed file)
, W:Failed to fetch 
http://httpredir.debian.org/debian/dists/jessie-backports/InRelease  Unable to 
find expected entry 'm/source/Sources' in Release file (Wrong sources.list 
entry or malformed file)
, W:Failed to fetch 
http://httpredir.debian.org/debian/dists/stable-updates/InRelease  Unable to 
find expected entry 'm/source/Sources' in Release file (Wrong sources.list 
entry or malformed file)
, W:Failed to fetch 
http://httpredir.debian.org/debian/dists/proposed-updates/InRelease  Unable to 
find expected entry 'm/source/Sources' in Release file (Wrong sources.list 
entry or malformed file)
, W:Failed to fetch http://httpredir.debian.org/debian/dists/testing/InRelease  
Unable to find expected entry 'm/source/Sources' in Release file (Wrong 
sources.list entry or malformed file)
, W:Failed to fetch http://security.debian.org/dists/testing/updates/InRelease  
Unable to find expected entry 'm/source/Sources' in Release file (Wrong 
sources.list entry or malformed file)
, W:Failed to fetch 
http://httpredir.debian.org/debian/dists/testing-proposed-updates/InRelease  
Unable to find expected entry 'm/source/Sources' in Release file (Wrong 
sources.list entry or malformed file)
, W:Failed to fetch http://httpredir.debian.org/debian/dists/unstable/InRelease 
 Unable to find expected entry 'm/source/Sources' in Release file (Wrong 
sources.list entry or malformed file)
, W:Failed to fetch 
http://httpredir.debian.org/debian/dists/experimental/InRelease  Unable to find 
expected entry 'm/source/Sources' in Release file (Wrong sources.list entry or 
malformed file)
, W:Failed to fetch http://httpredir.debian.org/debian/dists/oldstable/Release  
Unable to find expected entry 'm/source/Sources' in Release file (Wrong 
sources.list entry or malformed file)
, W:Failed to fetch http://httpredir.debian.org/debian/dists/stable/Release  
Unable to find expected entry 'm/source/Sources' in Release file (Wrong 
sources.list entry or malformed file)
, E:Some index files failed to download. They have been ignored, or old ones 
used instead.

(after fixing the sources.list by hand, the tracker_update_repositories command
apparently recreates the file again with the broken section names)



-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT 

Bug#830599: RFS: nlohmann-json/2.0.1-1

[Muri Nicanor]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "nlohmann-json"

* Package name: nlohmann-json
  Version : 2.0.1-1
  Upstream Author : Niels Lohmann
* URL : https://github.com/nlohmann/json
* License : MIT
  Section : libs

It builds those binary packages:

  nlohmann-json-dev - JSON for Modern C++

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/nlohmann-json


Alternatively, one can download the package with dget using this command:

  dget -x
https://mentors.debian.net/debian/pool/main/n/nlohmann-json/nlohmann-json_2.0.1-1.dsc

More information about nlohmann-json can be obtained from
https://nlohmann.github.io/json/

Changes since the last upload:

 * New upstream realease

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#828689: qa.debian.org: manpages not listed on missing manpage page

[Muri Nicanor]

Package: qa.debian.org
Severity: normal

Dear Maintainer,

   * I opened the page https://qa.debian.org/man-pages.html
   * On the bottom of the page it says: "In total 0 man pages in 0
 packages are missing at the moment. This listing was generated from
 a Lintian report published on Sat, 25 Jun 2016."
   * I expected the number of missing manpages to be higher than 0


-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (650, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.6.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)


signature.asc
Description: PGP signature

Bug#826346: ITP: pegtl -- Parsing Expression Grammar Template Library

[Muri Nicanor]

hi!

On 06/19/2016 09:27 PM, Andrey Rahmatullin wrote:
> Please remove commented out dh_make cruft from debian/rules.
done

> Consider changing the license of debian/ to the one used by the upstream.
done

new upload of pegtl is already on mentors

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#825693: RFS: nlohmann-json/1.1.0-1 [ITP]

[Muri Nicanor]

hi,

On 06/17/2016 03:03 PM, Andrey Rahmatullin wrote:
> "No embedded code copies" is not a blind rule, it has its reasons, and I
> think none of them applies here. It would be nice to use the Debian copy
> after it is updated but I don't think it's a blocker. 
oke, sounds like a good plan

> If nobody voices
> their objections I can sponsor the package.
great, thanks! if there's anything i have to/should do now, just tell me ;)

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#825693: RFS: nlohmann-json/1.1.0-1 [ITP]

[Muri Nicanor]

thanks for the explanation, andrey and christian- i did indeed not know
that the repackaging has to be done by uscan before the build (i thought
that was done during pdebuild).

in the end the Files-Excluded field worked which lead to the unit tests
not being successful (the catch.hpp is only used for the unit tests).
i've tried to use the packaged catch library, but its outdated. so now
its back to the original release of nlohmann-json with the
test/catch.hpp included (although i've updated the copyright file
accordingly)

i'm not exactly sure how to proceed here. catch.hpp is 'only' used for
the unit tests, but nevertheless its an embedded code copy. i guess the
correct way would be to ask for (via bug report?) or create an update of
the catch package?

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#825693: RFS: nlohmann-json/1.1.0-1 [ITP]

[Muri Nicanor]

Hi Andrey,

thank you for your review!

On 06/13/2016 02:35 PM, Andrey Rahmatullin wrote:
> debian/nlohmann-json-dev.doc-base:
> "Document: json" is too generic, remember it must be unique.
fixed, it matches the package name nonw

> debian/rules:
> There is too many commented out dh_make example lines, you should remove
> them if you don't need them.
fixed

> debian/README.source:
> It says "You WILL either need to modify or delete this file"
file deleted

> debian/patches:
> Patch names should end with .patch
fixed

> debian/copyright:
> It has Files-Excluded: test/catch.hpp but the tarball still contains this
> file.
i don't know what i'm doing wrong. i've tried multiple sytaxes, but the
file somehow resists of being excluded of the tarball

> Consider using the same license as the upstream for debian/.
whats would be the benefit of this?

> The format specification doesn't know about the License-Reference:
> pseudo-field or whatever it is. Instead you should do the same as for GPL
> licenses, provide a short license grant and add the path of the license
> text. You can look at /usr/share/doc/*/copyright on your system for
> examples.
fixed!

thanks again,
cheers
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#825625: closed by Bart Martens <ba...@quantz.debian.org> (closing ITP: usbmon -- commandline linux usbmon interface and api)

[Muri Nicanor]

hello bart,

> Please retitle bug 510447 from RFP to ITP and set yourself as the
> owner.

as far as i can tell, #510447 is about another software, thats written
in C. the first commit in the repository i linked to is from 2011,
(#510447 is from 2009) and written in C++ by another author...

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#826387: RFS: pegtl/1.3.1-1 [ITP]

[Muri Nicanor]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "pegtl". This package will be
a build dependency in the next release of usbguard.

* Package name: pegtl
  Version : 1.3.1-1
  Upstream Author : Dr. Colin Hirsch and Daniel Frey
* URL : https://github.com/ColinH/PEGTL
* License : MIT
  Section : libs

It builds those binary packages:

  pegtl-dev  - Parsing Expression Grammar Template Library

To access further information about this package, please visit the
following URL:

 https://mentors.debian.net/package/pegtl

Alternatively, one can download the package with dget using this command:

dget -x
https://mentors.debian.net/debian/pool/main/p/pegtl/pegtl_1.3.1-1.dsc

More information about pegtl can be obtained from
https://github.com/ColinH/PEGTL.

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#826346: ITP: pegtl -- Parsing Expression Grammar Template Library

[Muri Nicanor]

Package: wnpp
Severity: wishlist
Owner: Muri Nicanor <m...@immerda.ch>

* Package name: pegtl
  Version : 1.3.1
  Upstream Author : Dr. Colin Hirsch and Daniel Frey
<pe...@colin-hirsch.net>
* URL : https://github.com/ColinH/PEGTL
* License : MIT
  Programming Lang: C++
  Description : Parsing Expression Grammar Template Library


The Parsing Expression Grammar Template Library (PEGTL) is a
zero-dependency C++11 header-only library for creating parsers according
to a Parsing Expression Grammar (PEG).

 - this package will be a build dependency in the next usbguard
   release.
 - i plan to maintain the package myself. i will need a sponsor.

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#825693: RFS: nlohmann-json/1.1.0-1 [ITP]

[Muri Nicanor]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "nlohmann-json"

* Package name: nlohmann-json
  Version : 1.1.0-1
  Upstream Author : Niels Lohmann
* URL : https://github.com/nlohmann/json
* License : MIT
  Section : libs

It builds those binary packages:

   nlohmann-json-dev - JSON for Modern C++

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/nlohmann-json


Alternatively, one can download the package with dget using this command:

   dget -x
https://mentors.debian.net/debian/pool/main/n/nlohmann-json/nlohmann-json_1.1.0-1.dsc

More information about nlohmann-json-dev can be obtained from
https://nlohmann.github.io/json/.

Regards,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#825623: ITP: json -- JSON for Modern C++

[Muri Nicanor]

hello,

On 05/28/2016 12:17 PM, Christian Seiler wrote:
> Hi,
> 
> On 05/28/2016 11:56 AM, Muri Nicanor wrote:
>> * Package name: json
> 
> I would suggest maybe calling the Debian package something else,
> because 'json' is really, really generic, and while the library
> you're packaging looks extremely nice (thanks for bringing it to
> my attention), I don't think it makes sense to have it reserve
> the 'json' package name.
> 
> Since the C++ namespace is called nlohmann (see the code example
> using json = nlohmann::json), you could perhaps call the source
> package nlohmann-json, with it creating a binary package called
> libnlohmann-json-dev - or similar.

yes, you're totally right! thanks for the tip with the namespace, i'll
call the package as you suggested.

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#825302: RFS: usbguard/0.4-2 [ITP]

[Muri Nicanor]

hello pabs, hello *,

On 05/27/2016 06:29 AM, Paul Wise wrote:
> Here is another review, I don't intend to sponsor this though.
thanks for the review! again, i've learned a lot ;)

i'v now pushed everythin also to
https://gitlab.com/muri/usbguard-debian/, but not yet updated the
package on mentors, because the build dependencies are now unresolvable

> These things block the upload of this package to Debian:
> 
> debian/copyright isn't complete, some files have different
> licenses/copyright holders to what is documented. I would recommend
> looking at the header of each file and ensuring that is documented.
oke, i've fixed that to my best knowlegde.
i've created a list with files that lack any license and will file a bug
upstream about that.

> debian/changelog should have unstable instead of UNRELEASED if you are
> requesting an upload to unstable.
fixed

> These things block the upload of this package to Debian in my opinion
> but maybe not for others:
> 
> src/ThirdParty and src/Library/RuleParser/quex contain embedded code
> copies. Please ask upstream to remove them from their VCS and tarballs
> and depend on them instead. You can then package them separately.
> Alternatively, package them separately and remove all of them at
> `debian/rules build` time before dh_auto_configure and at
> `debian/rules clean` time (or just have uscan auto-repack the upstream
> tarball using Files-Excluded).
oke, so:
i've filed #825620 (ITP: quex), #825623 (ITP: json), #825625 (ITP: usbmon)

i've tried to exclude the folders using Files-Exclude, but that didn't
seem to work. i'm now deleting them in override_dh_auto_configure and
override_dh_auto_clean.
as soon as all the dependencies are packaged, i'll file a bug report
about removing the bundled code.

> The parser/lexer are not build from source. The documentation is
> actually missing the source code (Markdown).
i don't get the meaning of that last sentence, could you elaborate?


> Please ask upstream to
> remove all the generated files from their VCS and tarballs and create
> them at build time. Obviously some autotools things like ./configure
> need to be in the tarball though. As long as they are regenerated at
> build time using autoreconf that is fine though.
oke


> These things would be nice to fix:
> 
> The debian/changlog excerpts in debian/patches/* aren't needed.
fixed

> I like to have this in my ~/.quiltrc to keep quilt-generated patches clean:
> 
> QUILT_REFRESH_ARGS="-pab --no-timestamps --no-index"
thanks for the tip!

> Please add some DEP-3 headers to the patches, especially Forwarded:
done

> The watch file doesn't work (see the uscan output below), I think you
> need to check the releases page instead.
fixed

> Could you ask upstream to sign their commits, tags and release files?
putting it on my TODO list

> You can glob the manual page paths in usbguard.install:
fixed

> Personally I dislike the "documentation and commented-out settings in
> /etc/..." pattern, how systemd does it is nicer.
what do you mean by 'how systemd does it'?

> For the symbols file you might want to use the c++ pattern type. See
> the dpkg-gensymbols manual page for more details.
oke

> I like to run this command to wrap-and-sort the debian/ directory to
> make diffs easier to read:
> 
> wrap-and-sort --short-indent --wrap-always --sort-binary-packages
> --trailing-comma --verbose
thanks for the tip, done!

> Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata
done

> debhelper already passes --disable-silent-rules to ./configure so you
> don't need to.
removed.

> dist/usbguard.service doesn't pay attention to the --prefix, --bindir,
> --etcdir, etc options passed to configure, I would suggest getting
> ./configure to generate it from a .in file.
adding to my TODO list

> The upstream README.md would be useful to install in the binary
> package if it didn't contain build/install instructions. I would
> suggest using sed or similar to automatically strip out those parts
> and copy the result to a README file, which could then be installed.
> Everything between these two headings should be stripped:
adding to my TODO list


> Will you also package the usbguard-applet-qt thing mentioned in README.md?
yes, as far as i can see, the qt-applet will also be part of the source
package in the next release

thanks a lot for all the tips!
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#825625: ITP: usbmon -- commandline linux usbmon interface and api

[Muri Nicanor]

Package: wnpp
Severity: wishlist
Owner: Muri Nicanor <m...@immerda.ch>

* Package name: usbmon
  Version :
  Upstream Author : Radovan Sroka <rsr...@rehat.com>
* URL : https://github.com/radosroka/usbmon
* License : GPL
  Programming Lang: C++
  Description : commandline linux usbmon interface and api

 - This c++ library is a build dependency for usbguard (see #791919 and
   #825302)
 - I plan to maintain the package by myself, any help is appreciated

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#825623: ITP: json -- JSON for Modern C++

[Muri Nicanor]

Package: wnpp
Severity: wishlist
Owner: Muri Nicanor <m...@immerda.ch>

* Package name: json
  Version : 2.0
  Upstream Author : Niels Lohmann <m...@nlohmann.me>
* URL : https://github.com/nlohmann/json
* License : MIT
  Programming Lang: C++
  Description : JSON for Modern C++

JSON library with Intuitive syntax, Trivial integration and Serious
testing

 - this library is a build dependency for the usbguard package (see
   #791919 and #825302)
 - i plan to maintain the package by myself

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#825620: ITP: quex -- Quex, a lexical analyzer generator

[Muri Nicanor]

Package: wnpp
Severity: wishlist
Owner: Muri Nicanor <m...@immerda.ch>

* Package name: quex
  Version : 0.65.11
  Upstream Author : Frank-Rene Schäfer <fsch...@users.sourceforge.net>
* URL : http://quex.sourceforge.net/
* License : GPL
  Programming Lang: Python, C++
  Description : Quex, a lexical analyzer generator

Quex is a tool to generate lexical analyzers. A lexical analyzer is a
program that transforms a stream of characters into a stream of 'atomic
chunks of meaning', so called tokens.

 - the c++ files shipped by this package are a build dependency for the
   usbguard package

 - i plan to maintain this package by myself. i do this, because quex is
   a build dependency for usbguard (see #791919 and #825302). if anyone
   else wants to take this, i'm happy to give it away ;)

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#825302: RFS: usbguard/0.4-2 [ITP]

[Muri Nicanor]

Hi,

On 05/25/2016 11:23 PM, James Cowgill wrote:
> On Wed, 2016-05-25 at 21:10 +0200, Muri Nicanor wrote:
>> I am looking for a sponsor for my package "usbguard"
> 
> This looks like quite an interesting package, so here's a review.
wow, thanks for the detailed review, i really appreciate it, i've
learned a lot!

> You do not own the wnpp bug for this package. You need to retitle the
> bug from an RFP to ITP and set yourself as the owner. Do this before
> trying to fix anything else.
done


> Since libusbguard.so is in a public libs directory, you must put it in
> a separate package (probably called libusbguard0). You should then put
> all the development files in libusbguard-dev. 
done, now there are usbguard, libusbguard0 and libusbguard-dev. usbguard
depends on libusbguard0.


> Please run wrap-and-sort so wrap the Build-Depends field in the control
> file.
done

> You don't need the -2 changelog entry since your -1 version was never
> uploaded.
oke, i deleted the old packages and reuploaded to mentors with -1

> You add a group "usbguard" in postinst but didn't remove it in postrm.
> You should probably do that during the purge step.
fixed

> The other things in postrm seem incorrect. Why do you need to remove
> the service file manually?
fixed. but, when uninstalling the package, a
/etc/systemd/system/usbguard.service link to /dev/null is created. so
when reinstalling the package one has to unmask that service. i didn't
find any other way than that part of usbguard.postrm

> "usbguard" must depend on adduser to use addgroup in your postinst.
fixed

> The *.install files should use a wildcard (*) instead of including the
> multiarch directory manually.
fixed

> In rules, --with-bundled-spdlog=no doesn't seem to work.
yes, i removed that now. i tried several times and it uses system spdlog
whatever the configure switch says. and i'm removing the bundled spdlog
before anything else, to be sure.

> Enable parallel building (dh --parallel) if it works.
done

> You build-depend on dh-autoreconf, but don't actually run it. Use
> something like "dh --with=autoreconf,systemd".
done

> copyright:
>  Upstream code is GPL-2+ (not GPL-2)
>  The license identifier for the Boost License is "BSL-1.0"
>  The license identifier for your "MIT-License" is "Expat"
>   https://spdx.org/licenses/
>  Authors isn't a valid field name. You can use Comment or
>   Upstream-Contact instead.
fixed

> The default config doesn't allow the root user to use usbguard. This
> doesn't offer ant additional security, but does add inconvenience.
i added the group wheel to the list of groups allowed to control usbguard.

> usbguard.service contains:
>  WantedBy=base.target
> but base.target doesn't exist on my system.
fixed to basic.target

> The usbguard-rules.conf manpage uses "usbguard-daemon.conf" in the NAME
> section (and other places) which is obviously a typo.
fixed

> Please submit the patch you added upstream when you get the chance.
done

> Finally, although you've fixed all the lintian warnings, please try and
> fix some of the info tags.
> 
> I: usbguard source: duplicate-short-description usbguard usbguard-dev
> I: usbguard source: debian-watch-file-is-missing
> I: usbguard: hardening-no-pie usr/bin/usbguard
> I: usbguard: hardening-no-bindnow usr/bin/usbguard
> I: usbguard: spelling-error-in-binary 
> usr/lib/x86_64-linux-gnu/libusbguard.so.0.0.0 Uknown Unknown
> I: usbguard: hardening-no-bindnow 
> usr/lib/x86_64-linux-gnu/libusbguard.so.0.0.0
> I: usbguard: hardening-no-pie usr/sbin/usbguard-daemon
> I: usbguard: hardening-no-bindnow usr/sbin/usbguard-daemon
> I: usbguard: spelling-error-in-manpage 
> usr/share/man/man5/usbguard-rules.conf.5.gz formated formatted
> I: usbguard: no-symbols-control-file 
> usr/lib/x86_64-linux-gnu/libusbguard.so.0.0.0
> I: usbguard: systemd-service-file-missing-documentation-key 
> lib/systemd/system/usbguard.service
all fixed ;)


> Hopefully I've covered everything!
thanks again, such thorough reviews really help to get an understanding
for the packaging process!

cheers,
-- 
muri



signature.asc
Description: OpenPGP digital signature

Bug#825302: RFS: usbguard/0.4-2 [ITP]

[Muri Nicanor]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "usbguard"

* Package name: usbguard
  Version : 0.4-2
  Upstream Author : Daniel Kopeček 
* URL : https://github.com/dkopecek/usbguard
* License : GPL-2
  Section : utils

It builds those binary packages:

 usbguard   - Framework for implementing USB device authorization policies
 usbguard-dev - Framework for implementing USB device authorization policies

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/usbguard


Alternatively, one can download the package with dget using this command:

dget -x
https://mentors.debian.net/debian/pool/main/u/usbguard/usbguard_0.4-2.dsc

More information about usbguard can be obtained from
https://dkopecek.github.io/usbguard/.

Changes since the last upload:

* fixing some shortcomings of the package regarding the lintian checks

Regards,
-- 
muri




signature.asc
Description: OpenPGP digital signature

Bug#732411: monkeysign: Being nicer with systems without a SMTP server

[Muri Nicanor]

On 01/08/2015 11:09 PM, Antoine Beaupré wrote:
 On 2015-01-08 14:25:45, Muri Nicanor wrote:
 (i don't know if there is a usecase for having the MIME output printed
 on the console...?)
 
 ... probably not, now that you mention it. maybe we should just output
 the signature and no email body at all?

well, i think the body is important too, because its a nice suggestion
how to write the mail...

muri



signature.asc
Description: OpenPGP digital signature

Bug#732411: monkeysign: Being nicer with systems without a SMTP server

[Muri Nicanor]

Hello and sorry for the delay,

On 12/26/2014 10:33 PM, Antoine Beaupré wrote:
 
 Thanks for the patch, it's a great idea!
 
 Can you redo the patch with the with construct instead of manual
 exception handling?

i'm not very adept in python and/or coding, but i tried. attached are
two patches, both using the 'with' construct,
monkeysphere-fileoutput2.diff is without exception handling, but there
could be an exception if the file is not writeable.
monkeysphere-fileoutput3.diff is with exception handling to catch this case.
(i wasn't sure what you meant with 'manual' exception handling...)

 Also, I'd suggest the message Could not write to %s: file exists as an
 error message.
fixed ;)

however, i stumbled over another problem: thunderbird sets the
content-type for messages, so the mail then looks a bit confusing if i
just copy and paste the output...
if i find the time i'll think about a solution (maybe don't set content
type and just save two files, content and attachment...)

cheers,
muri
diff --git a/monkeysign/ui.py b/monkeysign/ui.py
index c9b6a30..d88d63d 100644
--- a/monkeysign/ui.py
+++ b/monkeysign/ui.py
@@ -93,6 +93,7 @@ class MonkeysignUi(object):
   help=_('do not send email at all (default: use sendmail)'))
 parser.add_option('-t', '--to', dest='to', 
   help=_('override destination email for testing (default: send individually encrypted email to each uid chosen)'))
+	parser.add_option('-o', '--output', dest='output', help=_('save the email to a file'))
 return parser
 
 def parse_args(self, args):
@@ -381,6 +382,13 @@ expects an EmailFactory email, but will not mail if nomail is set
 not sending email to %s, as requested, here's the email message:
 
 %s) % (msg.mailto, msg.create_mail_from_block()))
+if self.options.output is not None:
+if not os.path.exists(self.options.output):
+with open(self.options.output, 'w') as f:
+f.write(str(msg.create_mail_from_block()))
+self.warn(_('Mail has been written to %s') % self.options.output)
+else:
+self.warn(_('Could not write to %s: file exists') % self.options.output)
 
 
 class EmailFactory:
diff --git a/monkeysign/ui.py b/monkeysign/ui.py
index c9b6a30..860e241 100644
--- a/monkeysign/ui.py
+++ b/monkeysign/ui.py
@@ -93,6 +93,7 @@ class MonkeysignUi(object):
   help=_('do not send email at all (default: use sendmail)'))
 parser.add_option('-t', '--to', dest='to', 
   help=_('override destination email for testing (default: send individually encrypted email to each uid chosen)'))
+	parser.add_option('-o', '--output', dest='output', help=_('save the email to a file'))
 return parser
 
 def parse_args(self, args):
@@ -381,6 +382,16 @@ expects an EmailFactory email, but will not mail if nomail is set
 not sending email to %s, as requested, here's the email message:
 
 %s) % (msg.mailto, msg.create_mail_from_block()))
+if self.options.output is not None:
+if not os.path.exists(self.options.output):
+try:
+with open(self.options.output, 'w') as f:
+f.write(str(msg.create_mail_from_block()))
+self.warn(_('Mail has been written to %s') % self.options.output)
+except IOError:
+self.warn(_('Could not write to file %s') % self.options.output)
+else:
+self.warn(_('Could not write to %s: file exists') % self.options.output)
 
 
 class EmailFactory:


signature.asc
Description: OpenPGP digital signature

Bug#732411: monkeysign: Being nicer with systems without a SMTP server

[Muri Nicanor]

hi,

On 01/08/2015 07:33 PM, Antoine Beaupré wrote:
 On 2015-01-08 13:20:19, Muri Nicanor wrote:
 however, i stumbled over another problem: thunderbird sets the
 content-type for messages, so the mail then looks a bit confusing if i
 just copy and paste the output...
 if i find the time i'll think about a solution (maybe don't set content
 type and just save two files, content and attachment...)
 
 hmm... maybe changing what is saved then? maybe a non encoded version
 would be enough? just the signature
 output... ie. self.tmpkeyring.export_data(self.keyfpr)?

so, it now safes only the signature in the file, but i changed the email
on stdout from
msg.create_mail_from_block() to msg.body
if -o is set, then the signature is being written to the file, if not,
it is shown on stdout with the email body.
(i don't know if there is a usecase for having the MIME output printed
on the console...?)

muri
diff --git a/monkeysign/ui.py b/monkeysign/ui.py
index c9b6a30..c7c2219 100644
--- a/monkeysign/ui.py
+++ b/monkeysign/ui.py
@@ -93,6 +93,7 @@ class MonkeysignUi(object):
   help=_('do not send email at all (default: use sendmail)'))
 parser.add_option('-t', '--to', dest='to', 
   help=_('override destination email for testing (default: send individually encrypted email to each uid chosen)'))
+	parser.add_option('-o', '--output', dest='output', help=_('save the signature to a file'))
 return parser
 
 def parse_args(self, args):
@@ -380,7 +381,19 @@ expects an EmailFactory email, but will not mail if nomail is set
 self.warn(_(\
 not sending email to %s, as requested, here's the email message:
 
-%s) % (msg.mailto, msg.create_mail_from_block()))
+%s) % (msg.mailto, msg.body))
+if self.options.output is not None:
+if not os.path.exists(self.options.output):
+try:
+with open(self.options.output, 'w') as f:
+f.write(str(self.tmpkeyring.export_data(msg.keyfpr)))
+self.warn(_('Signature has been written to %s') % self.options.output)
+except IOError:
+self.warn(_('Could not write to file %s') % self.options.output)
+else:
+self.warn(_('Could not write to %s: file exists') % self.options.output)
+else:
+self.warn(_('and here is the signature:\n%s') % str(self.tmpkeyring.export_data(msg.keyfpr)))
 
 
 class EmailFactory:


signature.asc
Description: OpenPGP digital signature

Bug#732411: monkeysign: Being nicer with systems without a SMTP server

[Muri Nicanor]

attached is a patch that add -o or --output which allows you to save the
output to a file.
diff --git a/monkeysign/ui.py b/monkeysign/ui.py
index c9b6a30..43d15ed 100644
--- a/monkeysign/ui.py
+++ b/monkeysign/ui.py
@@ -93,6 +93,7 @@ class MonkeysignUi(object):
   help=_('do not send email at all (default: use sendmail)'))
 parser.add_option('-t', '--to', dest='to', 
   help=_('override destination email for testing (default: send individually encrypted email to each uid chosen)'))
+parser.add_option('-o', '--output', dest='output', help=_('save the output email to a file'))
 return parser
 
 def parse_args(self, args):
@@ -381,6 +382,18 @@ expects an EmailFactory email, but will not mail if nomail is set
 not sending email to %s, as requested, here's the email message:
 
 %s) % (msg.mailto, msg.create_mail_from_block()))
+if self.options.output is not None:
+if not os.path.exists(self.options.output):
+try:
+f = open(self.options.output, 'w');
+f.write(str(msg.create_mail_from_block()))
+except IOError:
+self.warn(_('Error opening or writing file %s') % self.options.output);
+else:
+f.close()
+self.warn(_('Mail has been written to %s') % self.options.output)
+else:
+self.warn(_('Didn\'t write to %s, because file exists') % self.options.output)
 
 
 class EmailFactory:


signature.asc
Description: OpenPGP digital signature