Bug#521235: [pkg-lighttpd] Bug#521235: Adding modules to server.modules not idempotent
On Fri, Aug 06, 2010 at 01:03:31AM +0200, Stefan Bühler wrote: We still will not make Adding modules to server.modules idempotent, but i think we fixed the core problem. The fix is to insert small check to disable loading a module twice, so you get a clean error message when you try. See rev 2751: * http://cgit.lighttpd.net/lighttpd/lighttpd-1.x/commit/?h=lighttpd-1.4.xid=614bb7538dc9bbccf4299386f8847be018f7d63d * or http://redmine.lighttpd.net/projects/lighttpd/repository/revisions/2751 Thx to Olaf for pointing that out! Thank you for addressing this problem. That fix will at least make lighttpd not silently exhibit strange behavior with no obvious cause. Much appreciated. - Josh Triplett -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#521235: [pkg-lighttpd] Bug#521235: Adding modules to server.modules not idempotent
2010/8/5 Stefan Bühler stbueh...@lighttpd.net: Olaf is quite right here: as the order of the modules is important, adding modules can not be idempotent, and we therefore will not change it. What happens when a module is added for the second time? I don't understand why it can't be idempotent. Olaf -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#521235: [pkg-lighttpd] Bug#521235: Adding modules to server.modules not idempotent
On 07/09/2010 12:00 PM, Olaf van der Spek wrote: On Sat, Jun 26, 2010 at 7:14 PM, Josh Triplettj...@joshtriplett.org wrote: Rough recipe to reproduce: A full and minimal lighttpd.conf would be nice. Although I'm quite sure upstream will say won'tfix. :( Olaf Hi! Olaf is quite right here: as the order of the modules is important, adding modules can not be idempotent, and we therefore will not change it. Stefan (upstream dev) -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#521235: [pkg-lighttpd] Bug#521235: Adding modules to server.modules not idempotent
On 08/05/2010 11:26 PM, Olaf van der Spek wrote: 2010/8/5 Stefan Bühlerstbueh...@lighttpd.net: Olaf is quite right here: as the order of the modules is important, adding modules can not be idempotent, and we therefore will not change it. What happens when a module is added for the second time? I don't understand why it can't be idempotent. Olaf You think that a module-load-list (a, a, b) should be the same as (a, b) - i.e. removing duplicates But there is no good way to decide what to do with (a, b, a), as (a, b) and (b, a) are really different (order matters); and therefore we cannot make module loading idempotent. And i don't recommend loading modules in vhost configs; you really should know what modules are loaded from a look at your main config file. It is not uncommon that people with debian configs ask in #lighttpd for support and don't even know whether they use cgi or fastcgi (or think they know and are wrong)... Stefan -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#521235: [pkg-lighttpd] Bug#521235: Adding modules to server.modules not idempotent
2010/8/6 Stefan Bühler stbueh...@lighttpd.net: You think that a module-load-list (a, a, b) should be the same as (a, b) - i.e. removing duplicates But there is no good way to decide what to do with (a, b, a), as (a, b) and (b, a) are really different (order matters); and therefore we cannot make module loading idempotent. What about not adding a module that's in the list already? Olaf -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#521235: [pkg-lighttpd] Bug#521235: Adding modules to server.modules not idempotent
On 08/06/2010 12:04 AM, Olaf van der Spek wrote: 2010/8/6 Stefan Bühlerstbueh...@lighttpd.net: You think that a module-load-list (a, a, b) should be the same as (a, b) - i.e. removing duplicates But there is no good way to decide what to do with (a, b, a), as (a, b) and (b, a) are really different (order matters); and therefore we cannot make module loading idempotent. What about not adding a module that's in the list already? Olaf That would be deciding (a, b, a) should be (a, b). You write your replies so fast that i somehow doubt you even thought about it. If you still don't get it, ask me in irc instead of chatting here, thx. PS: Small example: server.modules += ( mod_proxy ) server.modules += ( mod_auth, mod_proxy ) - you really want mod_auth to be loaded before mod_proxy, but your algorithm would load mod_proxy before mod_auth. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#521235: [pkg-lighttpd] Bug#521235: Adding modules to server.modules not idempotent
Ok, irc makes it easier to discuss things :) We still will not make Adding modules to server.modules idempotent, but i think we fixed the core problem. The fix is to insert small check to disable loading a module twice, so you get a clean error message when you try. See rev 2751: * http://cgit.lighttpd.net/lighttpd/lighttpd-1.x/commit/?h=lighttpd-1.4.xid=614bb7538dc9bbccf4299386f8847be018f7d63d * or http://redmine.lighttpd.net/projects/lighttpd/repository/revisions/2751 Thx to Olaf for pointing that out! Good night :) -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#521235: [pkg-lighttpd] Bug#521235: Adding modules to server.modules not idempotent
On Sat, Jun 26, 2010 at 7:14 PM, Josh Triplett j...@joshtriplett.org wrote: Rough recipe to reproduce: A full and minimal lighttpd.conf would be nice. Although I'm quite sure upstream will say won'tfix. :( Olaf -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#521235: [pkg-lighttpd] Bug#521235: Adding modules to server.modules not idempotent
On Fri, Jul 09, 2010 at 12:00:24PM +0200, Olaf van der Spek wrote: On Sat, Jun 26, 2010 at 7:14 PM, Josh Triplett j...@joshtriplett.org wrote: Rough recipe to reproduce: A full and minimal lighttpd.conf would be nice. Although I'm quite sure upstream will say won'tfix. :( The recipe I provided should fully describe a minimal test case. At the moment I don't have a spare lighttpd server I can break to reproduce the problem in more detail and provide an exact configuration file. I will try to set one up and reproduce it when I have time, but since we've long since worked around this bug (by not adding duplicates to server.modules) that puts it relatively low on our priority list to reproduce. - Josh Triplett -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
