Bug#739043: lvm2: Please use --no-enable option instead of patching lvm2-lvmetad.service file
Le Sat, 1 Mar 2014 12:50:18 +0100, Laurent Bigonville bi...@debian.org a écrit : Hi, [...] Anyway this is indeed probably a minor issue, and this bug should maybe be converted in Please complete systemd integration or something like that, because looking at the installed files, it seems that a bunch of .service files are not installed. Did you discuss this with the systemd maintainers? dh_install: lib/systemd/system/blk-availability.service exists in debian/build/install_deb but is not installed to anywhere dh_install: lib/systemd/system/lvm2-pvscan@.service exists in debian/build/install_deb but is not installed to anywhere dh_install: lib/systemd/system/dm-event.socket exists in debian/build/install_deb but is not installed to anywhere dh_install: lib/systemd/system/dm-event.service exists in debian/build/install_deb but is not installed to anywhere dh_install: lib/systemd/system/lvm2-monitor.service exists in debian/build/install_deb but is not installed to anywhere With systemd 214, I'm starting to see the following message: systemd[1]: Cannot add dependency job for unit lvm2-pvscan@253:0.service, ignoring: Unit lvm2-pvscan@253:0.service failed to load: No such file or directory. lvm2-pvscan@.service should probably be installed. Could also please reconsider shipping the other ones? Cheers, Laurent Bigonville -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#739043: lvm2: Please use --no-enable option instead of patching lvm2-lvmetad.service file
Le Tue, 26 Aug 2014 12:57:08 +0200, Laurent Bigonville bi...@debian.org a écrit : lvm2-pvscan@.service should probably be installed. Could also please reconsider shipping the other ones? Please also note that in the latest version, the generator (that we are unfortunately not using) is now creating 3 service files lvm2-activation-early.service lvm2-activation-net.service lvm2-activation.service -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#739043: lvm2: Please use --no-enable option instead of patching lvm2-lvmetad.service file
On Sat, Feb 15, 2014 at 12:11:46PM +0100, Laurent Bigonville wrote: Severity: important This needs something to actually be broken. Please be specific and show outcome. -[Install] -WantedBy=sysinit.target IMHO this would breaks the ordering if somebody wants to explicitly enable the service. No. The ordering is done by After and Before, never by Wants. That it is already broken is a different problem. Bastian -- The sight of death frightens them [Earthers]. -- Kras the Klingon, Friday's Child, stardate 3497.2 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#739043: lvm2: Please use --no-enable option instead of patching lvm2-lvmetad.service file
Le Sat, 1 Mar 2014 10:31:48 +0100, Bastian Blank wa...@debian.org a écrit : On Sat, Feb 15, 2014 at 12:11:46PM +0100, Laurent Bigonville wrote: Severity: important This needs something to actually be broken. Please be specific and show outcome. Well I can definitely return you the question, what are you trying to fix here? Why are you patching upstream files instead of using debian provided options or diverting from upstream in general? -[Install] -WantedBy=sysinit.target IMHO this would breaks the ordering if somebody wants to explicitly enable the service. No. The ordering is done by After and Before, never by Wants. That it is already broken is a different problem. Well the word ordering is maybe wrong, but still if you want your service to be running when the sysinit.target target is started, the WantedBy is needed. Why are you preventing people that wants to enable the service instead of depending on the activation to do so? Anyway this is indeed probably a minor issue, and this bug should maybe be converted in Please complete systemd integration or something like that, because looking at the installed files, it seems that a bunch of .service files are not installed. Did you discuss this with the systemd maintainers? dh_install: lib/systemd/system/blk-availability.service exists in debian/build/install_deb but is not installed to anywhere dh_install: lib/systemd/system/lvm2-pvscan@.service exists in debian/build/install_deb but is not installed to anywhere dh_install: lib/systemd/system/dm-event.socket exists in debian/build/install_deb but is not installed to anywhere dh_install: lib/systemd/system/dm-event.service exists in debian/build/install_deb but is not installed to anywhere dh_install: lib/systemd/system/lvm2-monitor.service exists in debian/build/install_deb but is not installed to anywhere Laurent -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#739043: lvm2: Please use --no-enable option instead of patching lvm2-lvmetad.service file
Package: lvm2 Version: 2.02.104-2 Severity: important Tags: patch Hello Bastian, You are currently patching the lvm2-lvmetad.service file to remove the install section: -[Install] -WantedBy=sysinit.target IMHO this would breaks the ordering if somebody wants to explicitly enable the service. You should probably use the --no-enable option of the dh_systemd_enable helper. Please considere applying the following patch. Cheers, Laurent Bigonville -- System Information: Debian Release: jessie/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.12-1-amd64 (SMP w/8 CPU cores) Locale: LANG=fr_BE.utf8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages lvm2 depends on: ii dmsetup 2:1.02.83-2 ii init-system-helpers 1.15 ii initscripts 2.88dsf-51 ii libc6 2.17-97 ii libdevmapper-event1.02.1 2:1.02.83-2 ii libdevmapper1.02.12:1.02.83-2 ii libreadline5 5.2+dfsg-2 ii libudev1 204-7 ii lsb-base 4.1+Debian12 lvm2 recommends no packages. Versions of packages lvm2 suggests: pn thin-provisioning-tools none -- Configuration Files: /etc/lvm/lvm.conf changed [not included] -- no debconf information diff -Nru lvm2-2.02.104/debian/patches/systemd.patch lvm2-2.02.104/debian/patches/systemd.patch --- lvm2-2.02.104/debian/patches/systemd.patch 2014-02-10 22:49:31.0 +0100 +++ lvm2-2.02.104/debian/patches/systemd.patch 2014-02-15 11:48:03.0 +0100 @@ -45,12 +45,3 @@ + +[Install] +WantedBy=local-fs.target a/scripts/lvm2_lvmetad_systemd_red_hat.service.in -+++ b/scripts/lvm2_lvmetad_systemd_red_hat.service.in -@@ -14,6 +14,3 @@ ExecReload=@sbindir@/lvmetad -R - Environment=SD_ACTIVATION=1 - Restart=on-abort - PIDFile=@LVMETAD_PIDFILE@ -- --[Install] --WantedBy=sysinit.target diff -Nru lvm2-2.02.104/debian/rules lvm2-2.02.104/debian/rules --- lvm2-2.02.104/debian/rules 2014-02-10 22:49:31.0 +0100 +++ lvm2-2.02.104/debian/rules 2014-02-15 11:50:10.0 +0100 @@ -239,7 +239,9 @@ install_lvm2: DIR = $(BUILD_DIR)/install_deb install_lvm2: $(STAMPS_DIR)/install_deb +$(MAKE_SELF) install-base-prep INSTALL_DIR='$(DIR)' - dh_systemd_enable + dh_systemd_enable -plvm2 lvm2-activation-early.service + dh_systemd_enable -plvm2 lvm2-activation.service + dh_systemd_enable -plvm2 --no-enable lvm2-lvmetad.service dh_installinit --no-start -- start 26 S . dh_systemd_start --no-start +$(MAKE_SELF) install-base
