Bug#1002458: "version in VCS newer than in repository" might be a bit overzealous

2024-04-11 Thread Holger Levsen
On Thu, Apr 11, 2024 at 03:02:05PM +0200, Christoph Berg wrote:
> > additionally you could also only classify d/changelog changing commits
> > with "Gbp-Dch: ignore" in them as such, but I'd guess Marc's suggestion
> > really is good enough.
> I don't understand, if debian/changelog-only commits are already
> ignored, what should vcswatch do additionally?

nothing. I ment it the other way around: if you were *not* willling to
ignore debian/changelog-only commits maybe you'd be willing to ignore
debian/changelog-only commits which also have "Gbp-Dch: ignore"/

but it seems you'd be fine to just ignore debian/changelog-only commits,
so this is mood.
 
> > Please reconsider, IOW, Myon: my I reassign this back to qa.debian.org
> > for vcswatch?
> Done.

thank you!


-- 
cheers,
Holger

 ⢀⣴⠾⠻⢶⣦⠀
 ⣾⠁⢠⠒⠀⣿⡁  holger@(debian|reproducible-builds|layer-acht).org
 ⢿⡄⠘⠷⠚⠋⠀  OpenPGP: B8BF54137B09D35CF026FE9D 091AB856069AAA1C
 ⠈⠳⣄

If secure encryption is outlawed, only criminals will have it.


signature.asc
Description: PGP signature


Bug#1002458: "version in VCS newer than in repository" might be a bit overzealous

2024-04-11 Thread Christoph Berg
Control: reassign -1 qa.debian.org
Control: retitle -1 vcswatch: ignore changelog-only commits

Re: Holger Levsen
> > For starters, an early release could classify changelog-only commits as
> > "housekeeping".
> 
> *that*!
> 
> additionally you could also only classify d/changelog changing commits
> with "Gbp-Dch: ignore" in them as such, but I'd guess Marc's suggestion
> really is good enough.

I don't understand, if debian/changelog-only commits are already
ignored, what should vcswatch do additionally?

> Please reconsider, IOW, Myon: my I reassign this back to qa.debian.org
> for vcswatch?

Done.

Christoph



Bug#1002458: "version in VCS newer than in repository" might be a bit overzealous

2024-04-10 Thread Holger Levsen
On Fri, Dec 24, 2021 at 01:36:35PM +0100, Marc Haber wrote:
> On Fri, Dec 24, 2021 at 01:15:08PM +0100, Christoph Berg wrote:
> > Re: Marc Haber
> > > To fill my idea, vcswatch would need to classify commits into "real"
> > > commits and "housekeeping" commits, so that the tracker can handle them
> > > differently.
> > The idea makes sense, but I doubt that is possible without entering a
> > very deep rathole :(
> For starters, an early release could classify changelog-only commits as
> "housekeeping".

*that*!

additionally you could also only classify d/changelog changing commits
with "Gbp-Dch: ignore" in them as such, but I'd guess Marc's suggestion
really is good enough.

Please reconsider, IOW, Myon: my I reassign this back to qa.debian.org
for vcswatch?


-- 
cheers,
Holger

 ⢀⣴⠾⠻⢶⣦⠀
 ⣾⠁⢠⠒⠀⣿⡁  holger@(debian|reproducible-builds|layer-acht).org
 ⢿⡄⠘⠷⠚⠋⠀  OpenPGP: B8BF54137B09D35CF026FE9D 091AB856069AAA1C
 ⠈⠳⣄

Only change is constant.


signature.asc
Description: PGP signature


Bug#1002458: "version in VCS newer than in repository" might be a bit overzealous

2022-01-04 Thread Paul Wise
On Mon, 2021-12-27 at 18:13 +0100, Raphael Hertzog wrote:

> It's phrased as question, not as you say. And I can certainly change the
> wording but then it's no longer an "action item" and I find it hard to
> keep the entry in its current place. Thus I prefer to restrict the cases
> where we show it, rather than entirely changing the wording.

Agreed.

> For your request, maybe we should add some NEW flag near the VCS entry in
> the left panel, just informing that there are changes in the VCS and not
> asking any specific action.

That would be useful to have regardless of the action item presence.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise


signature.asc
Description: This is a digitally signed message part


Bug#1002458: "version in VCS newer than in repository" might be a bit overzealous

2021-12-27 Thread Raphael Hertzog
On Mon, 27 Dec 2021, Christoph Berg wrote:
> Re: Raphael Hertzog
> > Christoph, would it be possible to export a supplementary flag showing
> > when the changes in NEW or COMMITS contain only changes to
> > debian/changelog?
> 
> The proper first step is to change "plz upload now" to a more neutral
> "there are pending changes in VCS".

It's phrased as question, not as you say. And I can certainly change the
wording but then it's no longer an "action item" and I find it hard to
keep the entry in its current place. Thus I prefer to restrict the cases
where we show it, rather than entirely changing the wording.

For your request, maybe we should add some NEW flag near the VCS entry in
the left panel, just informing that there are changes in the VCS and not
asking any specific action.

Cheers,
-- 
  ⢀⣴⠾⠻⢶⣦⠀   Raphaël Hertzog 
  ⣾⠁⢠⠒⠀⣿⡁
  ⢿⡄⠘⠷⠚⠋The Debian Handbook: https://debian-handbook.info/get/
  ⠈⠳⣄   Debian Long Term Support: https://deb.li/LTS



Bug#1002458: "version in VCS newer than in repository" might be a bit overzealous

2021-12-27 Thread Marc Haber
On Mon, Dec 27, 2021 at 11:49:06AM +0100, Christoph Berg wrote:
> Re: Raphael Hertzog
> > Christoph, would it be possible to export a supplementary flag showing
> > when the changes in NEW or COMMITS contain only changes to
> > debian/changelog?
> 
> The proper first step is to change "plz upload now" to a more neutral
> "there are pending changes in VCS".

This message would still be fully useless to me. My repositories always
have a pending change relative to the last upload, changing the version
number from a.b-c to a.b-(c+1)~1.

Greetings
Marc

-- 
-
Marc Haber | "I don't trust Computers. They | Mailadresse im Header
Leimen, Germany|  lose things."Winona Ryder | Fon: *49 6224 1600402
Nordisch by Nature |  How to make an American Quilt | Fax: *49 6224 1600421



Bug#1002458: "version in VCS newer than in repository" might be a bit overzealous

2021-12-27 Thread Christoph Berg
Re: Raphael Hertzog
> Christoph, would it be possible to export a supplementary flag showing
> when the changes in NEW or COMMITS contain only changes to
> debian/changelog?

The proper first step is to change "plz upload now" to a more neutral
"there are pending changes in VCS".

Christoph



Bug#1002458: "version in VCS newer than in repository" might be a bit overzealous

2021-12-27 Thread Raphael Hertzog
Hi,

On Wed, 22 Dec 2021, Marc Haber wrote:
> when I upload a package (for example, foo 1.0-1), I immediately create a
> new changelog stanza for a new version foo 1.0.2~1 so that noone
> accidentally makes a commit that might end up in the changelog for the
> already-uploaded version 1.0-1.
> 
> This causes the tracker to always show the "version in VCS is newer than
> in repository, is it time to upload?" hint for all my packages.
> 
> I'd therefore like to be able to either switch this "action needed" item
> off, or it to be smarter, for example by ignoring commits that only
> touch the changelog.

The package tracker uses the vcswatch data at
https://qa.debian.org/data/vcswatch/vcswatch.json.gz and it doesn't
provide me this data AFAIK.

Christoph, would it be possible to export a supplementary flag showing
when the changes in NEW or COMMITS contain only changes to
debian/changelog?

Cheers,
-- 
  ⢀⣴⠾⠻⢶⣦⠀   Raphaël Hertzog 
  ⣾⠁⢠⠒⠀⣿⡁
  ⢿⡄⠘⠷⠚⠋The Debian Handbook: https://debian-handbook.info/get/
  ⠈⠳⣄   Debian Long Term Support: https://deb.li/LTS



Bug#1002458: "version in VCS newer than in repository" might be a bit overzealous

2021-12-22 Thread Guillem Jover
On Wed, 2021-12-22 at 13:12:40 +0100, Marc Haber wrote:
> Package: tracker.debian.org
> Severity: wishlist

> when I upload a package (for example, foo 1.0-1), I immediately create a
> new changelog stanza for a new version foo 1.0.2~1 so that noone
> accidentally makes a commit that might end up in the changelog for the
> already-uploaded version 1.0-1.
> 
> This causes the tracker to always show the "version in VCS is newer than
> in repository, is it time to upload?" hint for all my packages.
> 
> I'd therefore like to be able to either switch this "action needed" item
> off, or it to be smarter, for example by ignoring commits that only
> touch the changelog.

I think at its core this is the same as #910987.

Regards,
Guillem



Bug#1002458: "version in VCS newer than in repository" might be a bit overzealous

2021-12-22 Thread Holger Levsen
On Wed, Dec 22, 2021 at 01:12:40PM +0100, Marc Haber wrote:
> I'd therefore like to be able to either switch this "action needed" item
> off, or it to be smarter, for example by ignoring commits that only
> touch the changelog.

I also would like it to be smarter, eg by ignoring commits which only
add empty or WIP or ... entries to d/changelog.


-- 
cheers,
Holger

 ⢀⣴⠾⠻⢶⣦⠀
 ⣾⠁⢠⠒⠀⣿⡁  holger@(debian|reproducible-builds|layer-acht).org
 ⢿⡄⠘⠷⠚⠋⠀  OpenPGP: B8BF54137B09D35CF026FE9D 091AB856069AAA1C
 ⠈⠳⣄

Right-handed people commit 90% of all crime world-wide.


signature.asc
Description: PGP signature


Bug#1002458: "version in VCS newer than in repository" might be a bit overzealous

2021-12-22 Thread Marc Haber
Package: tracker.debian.org
Severity: wishlist

Hi,

when I upload a package (for example, foo 1.0-1), I immediately create a
new changelog stanza for a new version foo 1.0.2~1 so that noone
accidentally makes a commit that might end up in the changelog for the
already-uploaded version 1.0-1.

This causes the tracker to always show the "version in VCS is newer than
in repository, is it time to upload?" hint for all my packages.

I'd therefore like to be able to either switch this "action needed" item
off, or it to be smarter, for example by ignoring commits that only
touch the changelog.

Greetings
Marc