Bug#521235: [pkg-lighttpd] Bug#521235: Adding modules to server.modules not idempotent

2010-08-06 Thread Josh Triplett
On Fri, Aug 06, 2010 at 01:03:31AM +0200, Stefan Bühler wrote: We still will not make Adding modules to server.modules idempotent, but i think we fixed the core problem. The fix is to insert small check to disable loading a module twice, so you get a clean error message when you try.

Bug#521235: [pkg-lighttpd] Bug#521235: Adding modules to server.modules not idempotent

2010-08-05 Thread Olaf van der Spek
2010/8/5 Stefan Bühler stbueh...@lighttpd.net: Olaf is quite right here: as the order of the modules is important, adding modules can not be idempotent, and we therefore will not change it. What happens when a module is added for the second time? I don't understand why it can't be idempotent.

Bug#521235: [pkg-lighttpd] Bug#521235: Adding modules to server.modules not idempotent

2010-08-05 Thread Stefan Bühler
On 07/09/2010 12:00 PM, Olaf van der Spek wrote: On Sat, Jun 26, 2010 at 7:14 PM, Josh Triplettj...@joshtriplett.org wrote: Rough recipe to reproduce: A full and minimal lighttpd.conf would be nice. Although I'm quite sure upstream will say won'tfix. :( Olaf Hi! Olaf is quite right here:

Bug#521235: [pkg-lighttpd] Bug#521235: Adding modules to server.modules not idempotent

2010-08-05 Thread Stefan Bühler
On 08/05/2010 11:26 PM, Olaf van der Spek wrote: 2010/8/5 Stefan Bühlerstbueh...@lighttpd.net: Olaf is quite right here: as the order of the modules is important, adding modules can not be idempotent, and we therefore will not change it. What happens when a module is added for the second

Bug#521235: [pkg-lighttpd] Bug#521235: Adding modules to server.modules not idempotent

2010-08-05 Thread Olaf van der Spek
2010/8/6 Stefan Bühler stbueh...@lighttpd.net: You think that a module-load-list (a, a, b) should be the same as (a, b) - i.e. removing duplicates But there is no good way to decide what to do with (a, b, a), as (a, b) and (b, a) are really different (order matters); and therefore we cannot

Bug#521235: [pkg-lighttpd] Bug#521235: Adding modules to server.modules not idempotent

2010-08-05 Thread Stefan Bühler
On 08/06/2010 12:04 AM, Olaf van der Spek wrote: 2010/8/6 Stefan Bühlerstbueh...@lighttpd.net: You think that a module-load-list (a, a, b) should be the same as (a, b) - i.e. removing duplicates But there is no good way to decide what to do with (a, b, a), as (a, b) and (b, a) are really

Bug#521235: [pkg-lighttpd] Bug#521235: Adding modules to server.modules not idempotent

2010-08-05 Thread Stefan Bühler
Ok, irc makes it easier to discuss things :) We still will not make Adding modules to server.modules idempotent, but i think we fixed the core problem. The fix is to insert small check to disable loading a module twice, so you get a clean error message when you try. See rev 2751: *

Bug#521235: [pkg-lighttpd] Bug#521235: Adding modules to server.modules not idempotent

2010-07-09 Thread Olaf van der Spek
On Sat, Jun 26, 2010 at 7:14 PM, Josh Triplett j...@joshtriplett.org wrote: Rough recipe to reproduce: A full and minimal lighttpd.conf would be nice. Although I'm quite sure upstream will say won'tfix. :( Olaf -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a

Bug#521235: [pkg-lighttpd] Bug#521235: Adding modules to server.modules not idempotent

2010-07-09 Thread Josh Triplett
On Fri, Jul 09, 2010 at 12:00:24PM +0200, Olaf van der Spek wrote: On Sat, Jun 26, 2010 at 7:14 PM, Josh Triplett j...@joshtriplett.org wrote: Rough recipe to reproduce: A full and minimal lighttpd.conf would be nice. Although I'm quite sure upstream will say won'tfix. :( The recipe I