On Sun, 2009-03-29 at 20:16 -0700, Russ Allbery wrote:
Raphael Geissert atomo64+deb...@gmail.com writes:
Russ Allbery wrote:
Hm, we should probably work around that somehow in Lintian, but I'm not
at all sure how. I suppose we could catch error exit status from file
and not abort, just
Michael Tautschnig m...@debian.org writes:
I've just checked and I think both the file one can download from the
bugreport and my local copy here _do_ have a newline, but my methods for
checking that might not be as effective. Anyway, I've attached a freshly
generated index file, this
Michael Tautschnig m...@debian.org writes:
Ok, what happens here if I just do a plain tar -tvf is that indentation
increases whenever the file size doesn't fit into that particular column
anymore, like this:
-rw--- michael/staff 895232 2009-03-23 17:22
clamav-0.95/database/daily.cvd
Russ Allbery wrote:
Michael Tautschnig writes:
[...]
No sorry, that doesn't fix the problem, actually it seems it didn't
change anything.
I think what we need to know is what file was attempting to process and
failed. I'm trying to figure out the best way of doing that. Something
is
Raphael Geissert atomo64+deb...@gmail.com writes:
I just reproduced it on a clean sid chroot. file 5.00-1 is installed, and
the culprit are...
unpacked/test/.split/split.clam.ole.docaa: ERROR: Can't read SAT
unpacked/test/.split/split.clam.pptaa: ERROR: Can't read SAT
I reported this
Russ Allbery wrote:
Raphael Geissert writes:
I just reproduced it on a clean sid chroot. file 5.00-1 is installed, and
the culprit are...
unpacked/test/.split/split.clam.ole.docaa: ERROR: Can't read SAT
unpacked/test/.split/split.clam.pptaa: ERROR: Can't read SAT
I reported this against
Raphael Geissert atomo64+deb...@gmail.com writes:
Russ Allbery wrote:
Hm, we should probably work around that somehow in Lintian, but I'm not
at all sure how. I suppose we could catch error exit status from file
and not abort, just do... something with it. Ignore it or something.
If we
Raphael Geissert atomo64+deb...@gmail.com writes:
This is what collection/file-index pipes to xargs which later calls
file(1).
Oh, okay. I guess you're adding the newlines for readability?
Since unit_tests/virusaction-test.s does not exist file(1) fails which
returns the error code that
Russ Allbery wrote:
Raphael Geissert writes:
This is what collection/file-index pipes to xargs which later calls
file(1).
Oh, okay. I guess you're adding the newlines for readability?
Yes, and left the null character to make it easier to notice where it really
ends.
Since
Raphael Geissert atomo64+deb...@gmail.com writes:
Russ Allbery wrote:
Right. Okay, I get it now. So for some reason we're still getting
truncated file names out of the pipeline that's generating the list of
files in the package, this time because there's no trailing newline.
This is only
Michael Tautschnig m...@debian.org writes:
I've just checked and I think both the file one can download from the
bugreport and my local copy here _do_ have a newline, but my methods for
checking that might not be as effective. Anyway, I've attached a freshly
generated index file, this time
[...]
I'm unable to reproduce it, but the error in Command.pm can be fixed with:
diff --git a/lib/Lintian/Command.pm b/lib/Lintian/Command.pm
index 0292fea..5ba58ed 100644
--- a/lib/Lintian/Command.pm
+++ b/lib/Lintian/Command.pm
@@ -303,7 +303,7 @@ all the executions of kill_kill.
=cut
Michael Tautschnig wrote:
[...]
Could you please run lintian with --keep-lab, and in the generated lab
(you can manually specify one with --lab, or use -d to see where it was
created) and attach the path/to/lab/source/clamav/index file?
Attached.
I found a difference on the results of
Raphael Geissert atomo64+deb...@gmail.com writes:
I found a difference on the results of the file-info parsing:
diff --git a/t1 b/t2
index 14783a7..1e3fbb1 100644
--- a/t1
+++ b/t2
@@ -648,4 +648,4 @@ unit_tests/urls.nocomment.ref^@
unit_tests/urls.notags.ref^@
Russ Allbery wrote:
Raphael Geissert atomo64+debian-re5jqeeqqe8avxtiumw...@public.gmane.org
writes:
I found a difference on the results of the file-info parsing:
diff --git a/t1 b/t2
index 14783a7..1e3fbb1 100644
--- a/t1
+++ b/t2
@@ -648,4 +648,4 @@ unit_tests/urls.nocomment.ref^@
Package: lintian
Version: 2.2.8
While checking the clamav packages (you can grab these from
http://people.debian.org/~mt/clamav/) a few warnings where shown; I've repeated
the process using -d, which results in the following output:
autsch...@joey[10:11]:~/clamav$ lintian -iI -d *.dsc *.deb
N:
Hi,
Michael Tautschnig wrote:
Package: lintian
Version: 2.2.8
While checking the clamav packages (you can grab these from
http://people.debian.org/~mt/clamav/) a few warnings where shown; I've
repeated the process using -d, which results in the following output:
[...]
N: Waiting for
Raphael Geissert atomo64+deb...@gmail.com writes:
--- a/lib/Lintian/Command.pm
+++ b/lib/Lintian/Command.pm
@@ -303,7 +303,7 @@ all the executions of kill_kill.
=cut
sub kill {
-my $status;
+my $status = 0;
while (my $opts = shift @_) {
$status |=
Russ Allbery wrote:
Raphael Geissert writes:
--- a/lib/Lintian/Command.pm
+++ b/lib/Lintian/Command.pm
@@ -303,7 +303,7 @@ all the executions of kill_kill.
=cut
sub kill {
-my $status;
+my $status = 0;
while (my $opts = shift @_) {
$status |=
Raphael Geissert atomo64+deb...@gmail.com writes:
I don't know why I had the idea that it returned the return code of the
process. But taking a look at it again, I think we want here, so that
1 is returned only if none of the processes had to be SIGKILLed.
Good point. Fixed.
--
Russ
20 matches
Mail list logo
