Bug#555213: bmon/3.0+git20110323-1
On Wed, Dec 26, 2012 at 05:21:43AM +1100, Dmitry Smirnov wrote: For the record, I updated the package and committed the effort to http://git.debian.org/?p=collab-maint/bmon.git Although Philipp Kern replied to my private email on 2012-12-04, as of now he didn't have a chance to review changes yet. Why aren't you keeping the package's source in git too? You also reference just a git date, not a revision. It's a bit hard to review that misses the actual upstream source. (Apart from the fact that if anything it should go to experimental at this point.) Kind regards Philipp Kern signature.asc Description: Digital signature
Bug#555213: bmon/3.0+git20110323-1
Hi Philipp, Thanks for having a look. On Sat, 29 Dec 2012 05:52:14 Philipp Kern wrote: Why aren't you keeping the package's source in git too? I don't like it and in most cases regard it as unnecessary. I'm not a git-buildpackage addict and I prefer old school debian/* only repository layout to track packaging only. I prefer to track upstream source locally and IMHO it is redundant to have upstream sources in in public repository. I'll explain my reasons in greater details if you wish. Having said the above I don't mind converting this package repository to git- buildpackage layout and merge upstream source with packaging if it help you. You also reference just a git date, not a revision. It's a deliberate choice. When you generate orig-tar using debian/rules get- orig-source command it translate date to corresponding commit. The benefits of having git date in version number is obvious: unlike meaningless revision number the date is human-readable which gives immediate impression of the date of upstream snapshot used to build the package. It's a bit hard to review that misses the actual upstream source. Can't be that difficult really. It's the same as classic SVN packages' repos. Just get upstream source with debian/rules get-orig-source and here you go. You can even build with git-buildpackage if you like as long as you have upstream tarball in tarball-dir. Some time ago I was able to build using git-buildpackage with the following .gbp.conf: # [DEFAULT] builder = pdebuild --debbuildopts -i\.git -I.git $* [git-buildpackage] tarball-dir = ../ # (Apart from the fact that if anything it should go to experimental at this point.) Indeed. I'm not sure if it's worth uploading to experimental at this point. There is no rush, perhaps we could wait till release of Wheezy and then upload. All the best, Dmitry. signature.asc Description: This is a digitally signed message part.
Bug#555213: bmon/3.0+git20110323-1
For the record, I updated the package and committed the effort to http://git.debian.org/?p=collab-maint/bmon.git Although Philipp Kern replied to my private email on 2012-12-04, as of now he didn't have a chance to review changes yet. -- Regards, Dmitry. signature.asc Description: This is a digitally signed message part.
