Bug#638720: Odoo packaging

[W. Martin Borgert]

On 2015-09-12 09:30, Dmitry Smirnov wrote:
> Yes I did. And I remember we've already discussed that. :)

Ah, OK, I was/am really mentally away from this stuff :~)

Btw.: Is there a current list of missing Odoo dependencies?
I assume, that some JS libraries are still missing, right?

Bug#638720: Odoo packaging

[Dmitry Smirnov]

On Saturday 12 September 2015 15:57:15 W. Martin Borgert wrote:
> Ah, OK, I was/am really mentally away from this stuff :~)

Likewise.


> Btw.: Is there a current list of missing Odoo dependencies?
> I assume, that some JS libraries are still missing, right?

With package like Odoo one almost have to use some bundled libs to maintain 
version compatibility and avoid breakage. Check RFP/ITP bug for blocking bugs 
as well as "missing-sources", .linktrees and .links files.

-- 
Best wishes,
 Dmitry Smirnov.

---

In questions of science, the authority of a thousand is not worth the
humble reasoning of a single individual.
-- Galileo Galilei


signature.asc
Description: This is a digitally signed message part.

Bug#638720: Odoo packaging

[martin f krafft]

also sprach Dmitry Smirnov  [2015-05-06 18:30 +0200]:
> I'm leaving packaging in almost finished state -- as per TODO
> there are only few non-DFSG issues left. Also Bootswatch themes
> are full of "privacy-breach" issues and have to be packaged
> separately anyway.

Where is this packaging?

Has there been any progress made on the side of Odoo, or by
Martin/Ben?

-- 
 .''`.   martin f. krafft  @martinkrafft
: :'  :  proud Debian developer
`. `'`   http://people.debian.org/~madduck
  `-  Debian - when you have better things to do than fixing systems


digital_signature_gpg.asc
Description: Digital signature (see http://martin-krafft.net/gpg/sig-policy/999bbcc4/current)

Bug#638720: Odoo packaging

[Dmitry Smirnov]

On Friday 11 September 2015 20:22:26 martin f krafft wrote:
> also sprach Dmitry Smirnov  [2015-05-06 18:30 +0200]:
> > I'm leaving packaging in almost finished state -- as per TODO
> > there are only few non-DFSG issues left. Also Bootswatch themes
> > are full of "privacy-breach" issues and have to be packaged
> > separately anyway.
> 
> Where is this packaging?

At collab-maint (repo's URL already mentioned earlier in this bug):

http://anonscm.debian.org/cgit/collab-maint/odoo.git


> Has there been any progress made on the side of Odoo,

No, they've never replied to me and I'm not happy with their bug handling 
either. :(


> or by Martin/Ben?

No. I was working alone...

-- 
All the best,
 Dmitry Smirnov.

---

It has been said that democracy is the worst form of government except
all the others that have been tried.
-- Winston Churchill


signature.asc
Description: This is a digitally signed message part.

Bug#638720: Odoo packaging

[martin f krafft]

also sprach Dmitry Smirnov  [2015-09-11 21:34 +0200]:
> > Has there been any progress made on the side of Odoo,
> 
> No, they've never replied to me and I'm not happy with their bug
> handling either. :(

By "their bug handling" you mean that your 12 reported bugs
basically received no responses in months? Or is there something
else going on?

https://github.com/odoo/odoo/issues/created_by/onlyjob

-- 
 .''`.   martin f. krafft  @martinkrafft
: :'  :  proud Debian developer
`. `'`   http://people.debian.org/~madduck
  `-  Debian - when you have better things to do than fixing systems
 
"the only thing that sustains one through life is the consciousness of
 the immense inferiority of everybody else, and this is a feeling that
 I have always cultivated."
-- oscar wilde


digital_signature_gpg.asc
Description: Digital signature (see http://martin-krafft.net/gpg/sig-policy/999bbcc4/current)

Bug#638720: Odoo packaging

[Dmitry Smirnov]

On Friday 11 September 2015 22:13:44 martin f krafft wrote:
> By "their bug handling" you mean that your 12 reported bugs
> basically received no responses in months? Or is there something
> else going on?
> 
> https://github.com/odoo/odoo/issues/created_by/onlyjob

Yeah, pretty much this plus at least one case of denial in closed-without-
action #6350. They did apply one of my patches (#6402) but that's pretty much 
it...

-- 
All the best,
 Dmitry Smirnov.

---

Continuous effort - not strength or intelligence - is the key to unlocking
our potential.
-- Winston Churchill


signature.asc
Description: This is a digitally signed message part.

Bug#638720: Odoo packaging

[W. Martin Borgert]

On 2015-09-11 20:22, martin f krafft wrote:
> Has there been any progress made on the side of Odoo, or by
> Martin/Ben?

I only started, but got distracted by/busy with other things
and cannot work on Odoo packaging in the near future. I did
package, however, both python-oerplib and python-odoorpc.

Dmitry, you did some major rework of the repository in
http://anonscm.debian.org/cgit/collab-maint/odoo.git, right?
(I remember, that it was full-source, before.)

Cheers

Bug#638720: Odoo packaging

[Dmitry Smirnov]

On Saturday 12 September 2015 00:04:50 W. Martin Borgert wrote:
> Dmitry, you did some major rework of the repository in
> http://anonscm.debian.org/cgit/collab-maint/odoo.git, right?
> (I remember, that it was full-source, before.)

Yes I did. And I remember we've already discussed that. :)

-- 
Best wishes,
 Dmitry Smirnov.

---

Few people are capable of expressing with equanimity opinions which
differ from the prejudices of their social environment. Most people are
even incapable of forming such opinion.
-- Albert Einstein, from "Aphorisms for Leo Baeck;
   Opinions of Albert Einstein"


signature.asc
Description: This is a digitally signed message part.

Bug#638720: Odoo packaging

[Ben Finney]

On 11-Sep-2015, martin f krafft wrote:

> Has there been any progress made on the side of Odoo, or by
> Martin/Ben?

I'm no longer working with Odoo. I was motivated by working with Odoo
heavily at a previous job, but do not have that job now, so am
unlikely to work further on Odoo packaging.

-- 
 \ “I got some new underwear the other day. Well, new to me.” —Emo |
  `\   Philips |
_o__)  |
Ben Finney 


signature.asc
Description: Digital signature

Bug#638720: Odoo packaging

[Dmitry Smirnov]

Just to let everybody know that I am no longer working on Odoo packaging.

I'm disappointed in upstream, their bug handling and CLA; Odoo looks promising 
but it is full of bugs and spaghetti code issues and its loose dependencies 
(when activation of one module enables dependency modules that make 
irreversible changes to database) feels very fragile. Above all it does not do 
what I need.

I'm leaving packaging in almost finished state -- as per TODO there are only 
few non-DFSG issues left. Also Bootswatch themes are full of privacy-breach 
issues and have to be packaged separately anyway.

-- 
Regards,
 Dmitry Smirnov.

---

The great enemy of the truth is very often not the lie -- deliberate,
contrived and dishonest, but the myth, persistent, persuasive, and
unrealistic. Belief in myths allows the comfort of opinion without the
discomfort of thought.
-- John F Kennedy


signature.asc
Description: This is a digitally signed message part.

Bug#638720: Odoo packaging

[Ben Finney]

(including the bug report this time, apologies for the repeat)

On 17-Apr-2015, Dmitry Smirnov wrote:

 On Tue, 13 Jan 2015 10:27:27 Aaron Bohy wrote:
  I am part of the Odoo team working on packaging and we are
  currently working on an Odoo 8.0 package for the Debian archive.

 Good to know that you guys are interested to bring Odoo to Debian.

Agreed, I'm glad to see work being done on Odoo packaging for Debian.

  Many of them are due to the fact that Odoo embeds javascript
  libraries, and those libraries are often minified. However, we
  prefer to keep those libraries in the archive to have a better
  control of those libraries updates.

Yes, Debian Policy §4.13 says Debian packages should not install these
“convenience copies” of third-party code. The third-party code should
instead be installed by a separate Debian package made from the source
for that code, and dependent packages should use it only from that
package.

 It is OK to keep 3rd party javascripts in the source tree as long as
 there are no pre-built (minified) files.

The installation of upstream-provided non-source form (compiled, e.g.
minified) library code is definitely a problem because it makes it
infeasible for a recipient to know what the source form of that work
is. A package with non-source works bundled needs that bug to be
reported and fixed.

The installation of upstream-provided source form library code is less
problematic (no DFSG violation), but it still violates Policy §4.13.
Many Debian packages today violate that section, but that doesn't make
it okay — it is tolerated in some cases as suboptimal, to be fixed by
better packaging.

 It should come without saying but Copyright, License and the Origins
 of all 3rd party files should be documented -- this is often not the
 case for 3rd party components bundled within Odoo sources.

Yes. Many conversations with various upstream persons will be needed
for that, I fear.

 I doubt we can maintain compatibility with dysfunctional upstream
 packaging. Hopefully when Debian package is finished you may be
 relieved from burden of maintaining it upstream. ;)

Hopefully the Odoo team and the Debian maintainers will develop a good
ongoing work relationship. Looking forward to it!

--
 \學而不思則罔，思而不學則殆。 (To study and not think is a waste. |
  `\ To think and not study is dangerous.) |
_o__)—孔夫子 Confucius (551 BCE – 479 BCE) |
Ben Finney


signature.asc
Description: Digital signature

Bug#638720: Odoo packaging

[Dmitry Smirnov]

On Fri, 17 Apr 2015 17:44:47 Ben Finney wrote:
 Yes, Debian Policy §4.13 says Debian packages should not install these
 “convenience copies” of third-party code. The third-party code should
 instead be installed by a separate Debian package made from the source
 for that code, and dependent packages should use it only from that
 package.

This is best to be determined on case-to-case basis. Often it is not feasible 
to package some rarely used code when it will not be used outside of a 
particular package. In such case installing private copy is the right thing to 
do, provided that such cases are properly documented.

Remember that every package creates a maintenance overhead. Besides often 
bundled software is not ready to be exposed system-wide.

Having said that I agree with you that we have to compartmentalise 3rd party 
components to corresponding packages when possible. We can continue doing that 
even after when Odoo is uploaded.

Also please remember that bundled javascript libraries sometimes can not be 
externalised because of incompatibilities between versions when a particular 
version must be used. This is severely complicates backporting so sometimes we 
are just using bundled library (or its copy in missing-sources).

-- 
All the best,
 Dmitry Smirnov.

---

I am easily satisfied with the very best.
-- Winston Churchill


signature.asc
Description: This is a digitally signed message part.

Bug#638720: Odoo packaging

[Dmitry Smirnov]

Hi Aaron,

On Tue, 13 Jan 2015 10:27:27 Aaron Bohy wrote:
 I am part of the Odoo team working on packaging and we are currently
 working on an Odoo 8.0 package for the Debian archive.

Good to know that you guys are interested to bring Odoo to Debian.


 Here is our work so far: https://mentors.debian.net/package/odoo
 
 There are still some lintian errors or warnings.
 
This is practically the upstream packaging unmodified, right?


 Many of them are due to the fact that Odoo embeds javascript libraries, and
 those libraries are often minified. However, we prefer to keep those
 libraries
 in the archive to have a better control of those libraries updates.

It is OK to keep 3rd party javascripts in the source tree as long as there are 
no pre-built (minified) files.
It should come without saying but Copyright, License and the Origins of all 
3rd party files should be documented -- this is often not the case for 3rd 
party components bundled within Odoo sources.


 We also get a warning because we put image files in /usr/lib, but we
 can't put images apart from python code.

According to Python policy, application modules should be installed privately 
so the problem is not the images in /usr/lib (we can tolerate that) but the 
stuff that should go to /usr/lib/odoo but instead goes to 
/usr/lib/python2.7/dist-packages/openerp...


 About the script-with-language-extension, we could replace odoo.py by
 odoo

It's OK if script is installed privately (not to /usr/bin)...


 but
 we prefer not to do so as it could break scripts of people already using the
 deb packages published on http://nightly.odoo.com/, especially because v8.0
 is
 the stable version of Odoo (released in Sep. 14).

I doubt we can maintain compatibility with dysfunctional upstream packaging.
Hopefully when Debian package is finished you may be relieved from burden of 
maintaining it upstream. ;)

 
 We would like to do a RFS for this package. What do you think?

I'm sorry to say that your package is light years away from Debian 
requirements. While we can help with packaging the show stoppers are actually 
the upstream bugs such as bundled non-free components and even files with 
undocumented origins, license and copyright. I've logged some of the problems 
I've spotted in debian/BUGS file, see my draft packaging [1].

If you're serious about getting Odoo into Debian then we will need your help 
fixing those problems first. Also I invite you to look at patches (in case you 
can recognise something useful to include upstream). We will have to address 
all Lintian warnings, etc.

Unfortunately what's required is much more sophisticated packaging. You can 
appreciate the sheer complexity of debian/copyright file alone.

[1]: https://anonscm.debian.org/cgit/collab-maint/odoo.git/

I've deleted old repository (there were nothing useful there but plenty of 
non-DFSG stuff and all the history of upstream changes since beginning of 
time). New repository is initialised with my draft packaging.

Since nobody produced visible packaging progress so far I might be taking over 
ITP/#638720 soon.

-- 
Best wishes,
 Dmitry Smirnov
 GPG key : 4096R/53968D1B

---

There is no such thing as public opinion. There is only published opinion.
-- Winston Churchill


signature.asc
Description: This is a digitally signed message part.

Bug#638720: Odoo packaging

[Aaron Bohy]

Dear Martin,

I am part of the Odoo team working on packaging and we are currently 
working

on an Odoo 8.0 package for the Debian archive.

Here is our work so far: https://mentors.debian.net/package/odoo

There are still some lintian errors or warnings.

Many of them are due to the fact that Odoo embeds javascript libraries, and
those libraries are often minified. However, we prefer to keep those 
libraries

in the archive to have a better control of those libraries updates.

We also get a warning because we put image files in /usr/lib, but we 
can't put

images apart from python code.

About the script-with-language-extension, we could replace odoo.py by 
odoo but

we prefer not to do so as it could break scripts of people already using the
deb packages published on http://nightly.odoo.com/, especially because 
v8.0 is

the stable version of Odoo (released in Sep. 14).

We would like to do a RFS for this package. What do you think?

Regards,
Aaron Bohy


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#638720: Odoo packaging

[W. Martin Borgert]

Preliminary work is here:
http://anonscm.debian.org/gitweb/?p=collab-maint/odoo.git

Any help appreciated, e.g. with:

 * remove non-sources from source tree
 * package embedded JavaScript libraries separately
 * implement use of dbconfig-common?


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org