I've just reuploaded the package with changes as follows:
- Added forward info in the harden.patch.
- Removed the leading tabs in d/rules. (I always forget it is not
allowed :p)
For the gcc warnings, I will investigate a bit and forward to upstream soon.
Thank you and best regards,
Hi Gianfranco,
Thanks for the review!
Good idea about using the *FLAGS env vars. I've updated the patch to use
those and will also propose the change to upstream.
I've also added back -Wall as suggested.
The package has just been reuploaded to mentors.
Best regards,
Andy
On Thu, Sep 24, 2015
Hi Andy,
the packaging looks good.
I did two builds with DH_VERBOSE=1 in a sid chroot
(the unstable and mentors versions)
I did a meld between them, and I see some "issues"
-"Wall" flag has disappeared
(I guess not a real problem here :) )
- many lines are like this one
gcc -O3 -DEAPI
Yes!
this solution is really more upstream/friendly, so if you forward please drop a
note on the patch with the link,
and the last problem I found:
dget -u http://mentors.debian.net/debian/pool/main/n/neko/neko_2.0.0-4.dsccd
neko-2.0.0/
dpkg-buildpackage -S -sa
[...]
export
Hi Gianfranco,
Thanks for the review!
> 1) please bump debhelper and compat level to 9
> (bonus points for converting the package to multiarch)
>
I've bumped those to 9.
For multiarch, I will address that in the next upstream version since there
are quite some changes needed.
> 2) please drop
Control: owner -1 !
Hi, quick review:
1) please bump debhelper and compat level to 9
(bonus points for converting the package to multiarch)
2) please drop useless build-dependencies (such as quilt and maybe some others,
e.g. pkg-config?)
3) rules file, can you please convert in plain dh_
Package: sponsorship-requests
Severity: normal
Dear mentors,
I am looking for a sponsor for my package "neko". I'm a member of the
Haxe Foundation. I would like to maintain the package in the long term to
improve haxe's debian support.
* Package name: neko
Version : 2.0.0-4
7 matches
Mail list logo
