Bug#811351: additional request...

[Andrew Lunn]

> I can add more verbose comments to mainline kernel .dts on how to
> enable serial port, and how to select between rs232/485. Andrew, do
> you want me to resend the current patches, or can it be done with an
> incremental patch?

Either, but incremental is probably easiest.

Andrew

Bug#811351: additional request...

[Martin Michlmayr]

* Rick Thomas  [2016-01-20 16:59]:
> > However, Debian probably needs to provide its own documentation
> > how to modify the .dtb (probably some example how to convert the
> > dtb to source with dtc, then how to do the modifications, and
> > compile the source back to dtb).
> 
> Andrew (I think it was) suggested that the instructions for doing
> that could go on Martin’s web page, which anyone who wants to use
> Debian on OpenRD will need to reference anyway.
> 
> Martin, are you willing to do that?

I doubt there's demand for it since there are so few OpenRD users
left, but if there's demadn I can document it.

-- 
Martin Michlmayr
http://www.cyrius.com/

Bug#811351: additional request...

[Rick Thomas]

> On Jan 20, 2016, at 2:54 PM, Aaro Koskinen  wrote:
> 
> I can add more verbose comments to mainline kernel .dts on how to
> enable serial port, and how to select between rs232/485. Andrew, do
> you want me to resend the current patches, or can it be done with an
> incremental patch?
> 
> However, Debian probably needs to provide its own documentation how to
> modify the .dtb (probably some example how to convert the dtb to source
> with dtc, then how to do the modifications, and compile the source back
> to dtb).
> 
> A.

Andrew (I think it was) suggested that the instructions for doing that could go 
on Martin’s web page, which anyone who wants to use Debian on OpenRD will need 
to reference anyway.

Martin, are you willing to do that?

I can (and will gladly) test any changes and help with debuging (if such is 
necessary) .

Rick

Bug#811351: additional request...

[Aaro Koskinen]

Hi,

On Tue, Jan 19, 2016 at 03:00:57AM -0800, Rick Thomas wrote:
> Andrew wrote
> > Device tree is not particularly good for dynamic hardware. We would
> > probably have to have two device tree blobs, one for MMC and one for
> > RS232. I don't remember if this is just an issue for Base, or if
> > Client and Ultimate have the same muxing. If so, we would want two DT
> > blobs for those as well...
> > 
> > If there is demand, we can do it, but i would prefer to avoid this if
> > possible.

This affects also at least Client (which I'm using). Also if you add
new blob, there should be also one for RS485 (there is a GPIO to select
between RS232/RS485).

> Andrew wrote:
> > I was going to take Aaro Koskinen patches, since they have Tested-by:
> > etc.
> > 
> > How about you ask Aaro to add the comment?

I can add more verbose comments to mainline kernel .dts on how to
enable serial port, and how to select between rs232/485. Andrew, do
you want me to resend the current patches, or can it be done with an
incremental patch?

However, Debian probably needs to provide its own documentation how to
modify the .dtb (probably some example how to convert the dtb to source
with dtc, then how to do the modifications, and compile the source back
to dtb).

A.

Bug#811351: additional request...

[Rick Thomas]

Hi Aaro,

Andrew wrote
> On Sun, Jan 17, 2016 at 11:55:19PM -0800, Rick Thomas wrote:
>> 
>> On Jan 17, 2016, at 2:42 PM, Martin Michlmayr  wrote:
>>> * Andrew Lunn  [2016-01-10 16:38]:
 Please can you try the following patch. If this works, i can add it to
 mainline. The issue we might run into is that somebody else wants
 serial not MMC
>> 
>> Is it possible to make this depend on a DTB setting?  e.g. the
>> mainline kernel supports either serial or mmc, but which one depends
>> on which one is configured in the DTB?
> 
> Hi Rick
> 
> Device tree is not particularly good for dynamic hardware. We would
> probably have to have two device tree blobs, one for MMC and one for
> RS232. I don't remember if this is just an issue for Base, or if
> Client and Ultimate have the same muxing. If so, we would want two DT
> blobs for those as well...
> 
> If there is demand, we can do it, but i would prefer to avoid this if
> possible.
> 
>   Andrew

Andrew wrote:
> On Mon, Jan 18, 2016 at 02:49:50PM -0800, Martin Michlmayr wrote:
>> * Rick Thomas  [2016-01-18 14:45]:
>>> Would it be reasonable to put a note in the release docs (or in 
>>> /usr/share/doc/??? ) describing how to modify the released dtb for personal 
>>> use?
>> 
>> Oh, right, I was going to make that comment but I forgot.
>> 
>> Andrew: maybe instead of removing the code from the base DTB, you
>> should comment it out and add a comment about this.  This way, people
>> can easily edit the DTS and recompile the DTB if needed.
> 
> I was going to take Aaro Koskinen patches, since they have Tested-by:
> etc.
> 
> How about you ask Aaro to add the comment?
> 
> Thanks
>Andrew

As per the above discussion, would it be possible to have the patch comment the 
code, rather than delete it, so that people with a need for the serial port 
could activate it?  Maybe also add a note in the /usr/share/doc/ as to how to 
perform the activation.

As long as both are possible, my own preference would be to have the MMC be 
default and the serial port be optional. But YMMV.

I'll be more than happy to test any changes...

Thanks!

Rick

Bug#811351: additional request...

[Andrew Lunn]

> As per the above discussion, would it be possible to have the patch
> comment the code, rather than delete it, so that people with a need
> for the serial port could activate it?  Maybe also add a note in the
> /usr/share/doc/ as to how to perform the activation.

FYI

The patches go into the kernel source tree. What goes into
/usr/share/doc is up to the distribution, and i'm not aware of any
mechanism of kernel documentation getting placed in there in Debian.

Possible you better bet for documentation is to suggest some text for:

https://www.cyrius.com/debian/kirkwood/openrd/

Andrew