Bug#840748: edb: install script failed for emacs25 because of :indent keyword

[Thien-Thi Nguyen]

FYI, EDB 1.32 is available:

 https://lists.gnu.org/archive/html/gnu-emacs-sources/2017-01/msg6.html

I hope we can close this bug as a result.

-- 
Thien-Thi Nguyen ---
 (defun responsep (query)
   (pcase (context query)
 (`(technical mailing-list) t)
 ...))  748E A0E8 1CB8 A748 9BFA
--- 6CE4 6703 2224 4C80 7502


signature.asc
Description: PGP signature

Bug#840748: edb: install script failed for emacs25 because of :indent keyword

[Thien-Thi Nguyen]

() Jari Aalto 
() Wed, 02 Nov 2016 21:04:05 +0200

   [Emacs 25 breaks EDB because no more ‘cl-struct-slots’]

Thanks for the bug report.

   these need to be rewritten [...] See this post:
   https://lists.gnu.org/archive/html/emacs-devel/2015-03/msg00480.html

That approach doesn't seem to use any reflection, a pity (IMHO).

-- 
Thien-Thi Nguyen ---
 (defun responsep (type via)
   (case type
 (technical (eq 'mailing-list via))
 ...))  748E A0E8 1CB8 A748 9BFA
--- 6CE4 6703 2224 4C80 7502



signature.asc
Description: PGP signature

Bug#840748: edb: install script failed for emacs25 because of :indent keyword

[Jari Aalto]

Hi Thien-Thi Nguyen,

Followup to the previous message[1]. The error message

   "No such keyword: :indent"

Is due to use of:

isp/connection.el:502: 'cl-struct-slots
lisp/connection.el:522: 'cl-struct-slots)
lisp/db-format.el:227: (cdr (get 'edb--1ds 'cl-struct-slots)
lisp/db-rep.el:271: (cdr (get 'edb--v1-rs 'cl-struct-slots)
lisp/edb-1int-to-single.el:50: 'cl-struct-slots
lisp/edb-meta.el:80: 'cl-struct-slots))
lisp/edbcore.el:1578: (cdr (get 'edb--v1-rs 'cl-struct-slots)
lisp/edbcore.el:2080: (cdr (get 'edb--1ds 'cl-struct-slots)
lisp/edbcore.el:780: 'cl-struct-slots
lisp/edbcore.el:800: 'cl-struct-slots)

Code example from edbcore.el:

(put 'edb--v1-rs 'kwidx ; poor man's defsetf --ttn
 (let ((idx 0))
   (mapcar (lambda (ent)
 (cons (intern (format ":%s" (symbol-name (car ent
   (incf idx)))
   (cdr (get 'edb--v1-rs 'cl-struct-slots)

It appears that all of these need to be rewritten to work in
Emacs 25. See this post:

From: Stefan Monnier (Emacs project head)

(...) The main thrust is to get rid of the use of the `cl-struct-slots'
property which doesn't exist in Emacs-25 any more.

https://lists.gnu.org/archive/html/emacs-devel/2015-03/msg00480.html

Jari

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=840748

Bug#840748: edb: install script failed for emacs25 because of :indent keyword

[Agustin Martin]

Package: edb
Version: 1.31-3
Severity: important

Dear Maintainer,

emacs25 just reached the archive, but edb seems to have problems with it

Install edb for emacs25
install/edb: Handling install of emacsen flavor emacs25
install/edb: Byte-Compiling in dir /usr/share/emacs/site-lisp/edb/ ...
No such keyword: :indent
ERROR: install script from edb package failed
dpkg: error processing package emacs25 (--configure):
 subprocess installed post-installation script returned error exit status 1
Errors were encountered while processing:
 emacs25
E: Sub-process /usr/bin/dpkg returned an error code (1)

Regards,

-- 
Agustin