Bug#894131: [pkg-go] Bug#894131: Bug#894131: prometheus-alertmanager: New upstream release 0.14.0 available. Please package and backport to stretch.
On 12.06.2018 18:04, Martín Ferrari wrote:
Does it understand that 0.15.0-rc.1 is lower than 0.15.0, for example?
If that is the case, I could replace the tilde in the metadata.
I have not tested it, but looking at the code, it seems to be reasonably
intelligent and handling major, minor, patch levels, as well as
prerelease versions.
// Quick comparison if a version has no prerelease versions
if len(v.Pre) == 0 && len(o.Pre) == 0 {
return 0
} else if len(v.Pre) == 0 && len(o.Pre) > 0 {
return 1
} else if len(v.Pre) > 0 && len(o.Pre) == 0 {
return -1
}
So the version number 0.15.0-rc.1 would have len(v.Pre) > 0, and thus be
considered less than 0.15.0, with len(v.Pre) == 0.
Bug#894131: [pkg-go] Bug#894131: Bug#894131: prometheus-alertmanager: New upstream release 0.14.0 available. Please package and backport to stretch.
On 12/06/18 17:00, Daniel Swarbrick wrote: > On 12.06.2018 17:50, Martín Ferrari wrote: >> I had not heard about unsee until now, we should package it too! :) > That would totally rock! I was just taking a look, the main thing would be to be able to build all the JS stuff, but it does not seem too bad.. Just need to find the time to do it :) > There are a couple of other exporters which I think would be of quite > high interest to a lot of sites, such as the snmp_exporter. Perhaps I > could assist you packaging some of them. That would be great! If you want to join, there is an IRC channel (no mailing list for now) to chat and coordinate the packaging efforts: #debian-prometheus in OFTC. >> Yeah, the tilde will be removed once the final release is out.. But it >> still seems like a bug to panic due to that. I don't know how upstream >> presents the RC version number, but shouldn't that also break semver >> parsing? > The upstream version presents version number "0.15.0-rc.1", which > doesn't throw any errors in the semver.Parse function > (https://github.com/blang/semver/blob/master/semver.go). However, the > Unsee dashboard uses the MustParse() variant of that function, which of > course panics if Parse() returns an error. Does it understand that 0.15.0-rc.1 is lower than 0.15.0, for example? If that is the case, I could replace the tilde in the metadata. > As you may have seen in the Github issue I opened, somebody is working > on it to hopefully make it a little more tolerant and robust. Yeah, but the solution proposed is just to strip everything after the tilde, which does not seem like a good solution. -- Martín Ferrari (Tincho)
Bug#894131: [pkg-go] Bug#894131: Bug#894131: prometheus-alertmanager: New upstream release 0.14.0 available. Please package and backport to stretch.
On 12.06.2018 17:50, Martín Ferrari wrote: I had not heard about unsee until now, we should package it too! :) That would totally rock! There are a couple of other exporters which I think would be of quite high interest to a lot of sites, such as the snmp_exporter. Perhaps I could assist you packaging some of them. Yeah, the tilde will be removed once the final release is out.. But it still seems like a bug to panic due to that. I don't know how upstream presents the RC version number, but shouldn't that also break semver parsing? The upstream version presents version number "0.15.0-rc.1", which doesn't throw any errors in the semver.Parse function (https://github.com/blang/semver/blob/master/semver.go). However, the Unsee dashboard uses the MustParse() variant of that function, which of course panics if Parse() returns an error. As you may have seen in the Github issue I opened, somebody is working on it to hopefully make it a little more tolerant and robust.
Bug#894131: [pkg-go] Bug#894131: Bug#894131: prometheus-alertmanager: New upstream release 0.14.0 available. Please package and backport to stretch.
Hi Daniel, On 12/06/18 16:42, Daniel Swarbrick wrote: > We've been running your 0.15.0~rc.1~git20180507.28967e3+ds-1 packages > from experimental for about a week now, with no issues bar one - the Oh, great! > tilde in the version number upsets the semantic version parsing in > Cloudflare's "unsee" dashboard > (https://github.com/cloudflare/unsee/issues/263). I had not heard about unsee until now, we should package it too! :) > I presume that issue should resolve itself once the final release is > out... I hope. Yeah, the tilde will be removed once the final release is out.. But it still seems like a bug to panic due to that. I don't know how upstream presents the RC version number, but shouldn't that also break semver parsing? -- Martín Ferrari (Tincho)
Bug#894131: [pkg-go] Bug#894131: Bug#894131: prometheus-alertmanager: New upstream release 0.14.0 available. Please package and backport to stretch.
Hi Martin, We've been running your 0.15.0~rc.1~git20180507.28967e3+ds-1 packages from experimental for about a week now, with no issues bar one - the tilde in the version number upsets the semantic version parsing in Cloudflare's "unsee" dashboard (https://github.com/cloudflare/unsee/issues/263). I presume that issue should resolve itself once the final release is out... I hope. On 12.06.2018 17:38, Martín Ferrari wrote: An update to this... I have prepared packages (without any UI) for 0.15-rc.2 and uploaded to experimental. If you can, please test them. I plan to upload to unstable as soon as 0.15 is released.
