Bug#905769: node-toidentifier: Unnecessary $(DEB_BUILD_PROFILES) check?

2018-08-11 Thread Chris Lamb 
Bastian,

> It is a feature that dpkg-buildpackage -P nocheck does not set
> DEB_BUILD_OPTIONS.
> 
> My solution above is policy compliant and allow to test nocheck with
> dpkg-buildpackage

Then the lintian check and/or description is buggy and/or misleading.

Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#905769: node-toidentifier: Unnecessary $(DEB_BUILD_PROFILES) check?

2018-08-11 Thread roucaries bastien 
On Thu, Aug 9, 2018 at 11:36 AM Chris Lamb  wrote:
>
> Source: node-toidentifier
> Version: 1.0.0-1
> Severity: wishlist
> X-Debbugs-CC: Bastien Roucaris ,
> ftpmas...@debian.org
>
> Hi,
>
> I just ACCEPTed node-toidentifier from NEW but was wondering if:
>
>ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS) $(DEB_BUILD_PROFILES)))
>
> .. should really be checking (only) DEB_BUILD_OPTIONS?

It is a feature that dpkg-buildpackage -P nocheck does not set
DEB_BUILD_OPTIONS.

My solution above is policy compliant and allow to test nocheck with
dpkg-buildpackage

Bastien

>
>
> Regards,
>
> --
>   ,''`.
>  : :'  : Chris Lamb
>  `. `'`  la...@debian.org / chris-lamb.co.uk
>`-

Bug#905769: node-toidentifier: Unnecessary $(DEB_BUILD_PROFILES) check?

2018-08-09 Thread Chris Lamb 
Source: node-toidentifier
Version: 1.0.0-1
Severity: wishlist
X-Debbugs-CC: Bastien Roucaris , 
ftpmas...@debian.org

Hi,

I just ACCEPTed node-toidentifier from NEW but was wondering if:

   ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS) $(DEB_BUILD_PROFILES)))

.. should really be checking (only) DEB_BUILD_OPTIONS?


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-