Bug#910705: Bug#910687: dgit: build-source and push-source disregard -wc

2018-10-27 Thread Sean Whitton
Hello, On Wed 10 Oct 2018 at 11:14PM +0100, Ian Jackson wrote: > But I'm not really convinced that push-source and build-source ought > ever to run rules clean. So I think we need a new interpretation of > clean modes: ie, the source builds should look at the clean mode and > do *something*: and

Bug#910705: Bug#910687: dgit: build-source and push-source disregard -wc

2018-10-27 Thread Sean Whitton
Hello, On Wed 10 Oct 2018 at 11:24PM +0100, Ian Jackson wrote: > There are three levels of dirtiness: contains uncommitted changes to > tracked files; contains untracked but ignored files; contains > untracked and un-ignored files. > > Currently dgit only *complains* about uncommitted changes to

Bug#910705: Bug#910687: dgit: build-source and push-source disregard -wc

2018-10-10 Thread Ian Jackson
Sean Whitton writes ("Bug#910705: Bug#910687: dgit: build-source and push-source disregard -wc"): > I'm pretty sure this is a straightforward bug -- unless --ignore-dirty > or --include-dirty is specified, push-source and build-source are meant > to error out if the t

Bug#910705: Bug#910687: dgit: build-source and push-source disregard -wc

2018-10-10 Thread Ian Jackson
Ian Jackson writes ("Re: Bug#910687: dgit: build-source and push-source disregard -wc"): > I think in fact that this needs to be more general. For example, with > --clean=dpkg-source: if dpkg-source leaves untracked files, this > should be detected. I think this check should happen any time dgit

Bug#910705: Bug#910687: dgit: build-source and push-source disregard -wc

2018-10-10 Thread Sean Whitton
Hello, On Wed 10 Oct 2018 at 01:51AM +0100, Ian Jackson wrote: > Also, arguably something should have stopped you proceeding with an > untracked unignored files (perhaps, especially as you specified -wc). > But the clean mode is basically ignored with build-source (and > push-source) since the tr

Bug#910705: Bug#910687: dgit: build-source and push-source disregard -wc

2018-10-10 Thread Ian Jackson
Mattia Rizzolo writes ("Re: Bug#910687: dgit: build-source and push-source disregard -wc"): > On Wed, Oct 10, 2018 at 11:34:40AM +0100, Ian Jackson wrote: > > You never made a commit like that. The dgit import isn't because it > > doesn't have debian/patches because it was an import of a > > 1.0-

Bug#910705: Bug#910687: dgit: build-source and push-source disregard -wc

2018-10-10 Thread Mattia Rizzolo
On Wed, Oct 10, 2018 at 11:34:40AM +0100, Ian Jackson wrote: > Mmm, that seems like reasonable expectations - at least the first > half. I didn't try with --include-dirty. You were intending to push, > right ? You can't push with --includ-dirty. Nope, just test building for now. > > But from w

Bug#910705: Bug#910687: dgit: build-source and push-source disregard -wc

2018-10-10 Thread Ian Jackson
Mattia Rizzolo writes ("Re: Bug#910687: dgit: build-source and push-source disregard -wc"): > Right. I also thought about it later, and decided to try with > --include-dirty. > What I had expected, especially using -wc, was to give up istantly with > a "your working tree is dirty" message, and to

Bug#910705: Bug#910687: dgit: build-source and push-source disregard -wc

2018-10-10 Thread Mattia Rizzolo
Control: retitle -1 dgit: build-source and push-source disregard -wc On Wed, Oct 10, 2018 at 01:51:44AM +0100, Ian Jackson wrote: > Control: clone -1 -2 [ replying to the clone here! ] > FYI, I discovered some other weirdness with what you were trying to > do. > > Firstly, from your transcript,