Bug#915831: zfsutils-linux: Upgrading to 0.7.12 breaks during dpkg --configure

2019-01-05 Thread Carsten Leonhardt
Hi,

Chris Zubrzycki  writes:

> Here is the fix, or you can move zfs-share to zfs-zed for some reason:

I can confirm this patch works.


Aron Xu  writes:

> I'm temped to not ship init.d scripts for Buster if there is any
> important issue open when freeze approaches (e.g. bug #915831).

Please let's just stick to fixing bugs instead of introducing new ones
(c.f. policy 9.11.).

Best Regards,

Carsten



Bug#915831: zfsutils-linux: Upgrading to 0.7.12 breaks during dpkg --configure

2019-01-04 Thread Chris Zubrzycki
> Tried upgrading from stretch-backports 0.7.11 to testing 0.7.12, because
> the package hadn't landed in backports yet, and discovered it broke on
> dpkg --configure :
> Setting up zfsutils-linux (0.7.12-1) ...
> insserv: Service zfs-zed has to be enabled to start service zfs-share
> insserv: exiting now!
> update-rc.d: error: insserv rejected the script header
> dpkg: error processing package zfsutils-linux (--configure):
> subprocess installed post-installation script returned error exit status 1
> dpkg: dependency problems prevent configuration of zfs-zed:
> zfs-zed depends on zfsutils-linux (>= 0.7.12-1); however:
>  Package zfsutils-linux is not configured yet.
> 
> Someone else had reported a similar problem upstream to ZoL from Ubuntu's
> packages, at:
> https://github.com/zfsonlinux/zfs/issues/8127

Sorry! I messed up the order of packages and thought I fixed it, but I didn’t.

You have a circular dependency and that’s why it is failing. You have zfs-zed 
set to depend on zfsutils-linux, but there is a hard dependency in the 
zfs-share init file on zfs-zed. 
There is no need for zed to be running before sharing is started, however it 
does provide helpful status logging. It is not necessarily an upstream bug, 
because debian decided to split zed out as it’s own package and it’s debian’s 
tools that are having trouble with the circular dependency caused. It is safe 
to remove it from Required-Start, as shown by the systemd files not requiring 
zed to be started first.


Here is the fix, or you can move zfs-share to zfs-zed for some reason:

--- zfs-share.orig  2019-01-04 11:26:09.076322596 -0500
+++ zfs-share   2019-01-04 11:26:32.643426954 -0500
@@ -9,8 +9,8 @@
 #
 ### BEGIN INIT INFO
 # Provides:  zfs-share
-# Required-Start:$local_fs $network $remote_fs zfs-mount zfs-zed
-# Required-Stop: $local_fs $network $remote_fs zfs-mount zfs-zed
+# Required-Start:$local_fs $network $remote_fs zfs-mount
+# Required-Stop: $local_fs $network $remote_fs zfs-mount
 # Default-Start: 2 3 4 5
 # Default-Stop:  0 1 6
 # Should-Start:  iscsi iscsitarget istgt scst nfs-kernel-server samba 
samba4 zfs-mount zfs-zed




-chris zubrzycki
- --
PGP ID: 0xA2ABC070
Fingerprint: 26B0 BA6B A409 FA83 42B3  1688 FBF9 8232 A2AB C070


Unix  _IS_  user friendly... It's just selective about who its friends are.



Bug#915831: zfsutils-linux: Upgrading to 0.7.12 breaks during dpkg --configure

2019-01-04 Thread Chris Zubrzycki
> Tried upgrading from stretch-backports 0.7.11 to testing 0.7.12, because
> the package hadn't landed in backports yet, and discovered it broke on
> dpkg --configure :
> Setting up zfsutils-linux (0.7.12-1) ...
> insserv: Service zfs-zed has to be enabled to start service zfs-share
> insserv: exiting now!
> update-rc.d: error: insserv rejected the script header
> dpkg: error processing package zfsutils-linux (--configure):
>  subprocess installed post-installation script returned error exit status 1
> dpkg: dependency problems prevent configuration of zfs-zed:
>  zfs-zed depends on zfsutils-linux (>= 0.7.12-1); however:
>   Package zfsutils-linux is not configured yet.
> 
> Someone else had reported a similar problem upstream to ZoL from Ubuntu's
> packages, at:
> https://github.com/zfsonlinux/zfs/issues/8127

Has anyone else reproduced this? I just made a new VM to test and I could not 
get it to trigger. I installed systemd-sysv, initscripts and insserv, then I 
installed zfs, installed 0.11 with the init scripts, then the 0.12 packages 
from unstable which also have init scripts, and there was no error. Maybe I’m 
missing something?

Processing triggers for initramfs-tools (0.130) ...
update-initramfs: Generating /boot/initrd.img-4.9.0-4-amd64
Setting up zfsutils-linux (0.7.12-1) ...
Installing new version of config file /etc/zfs/zfs-functions ...
zfs-import-scan.service is a disabled or a static unit, not starting it.
Processing triggers for systemd (232-25+deb9u6) ...
Processing triggers for man-db (2.7.6.1-2) ...
Setting up zfs-dkms (0.7.12-1) ...

 




If there is a conflict, what about trying to move zfs-share to the zfs-zed 
package if it really depends on it to start? If not, remove the hard depends 
and maybe it’ll start? Seems zfs had a similar bug 3 years ago and they said 
the service start order was important… 

https://github.com/zfsonlinux/zfs/issues/2680

I mean, that’s what it looks like is going wrong from the error. There’s an 
init file(1) that depends on another init file(2) in a package(2) that depends 
on package(1). Circular dep. Am I understanding it right?


Bug#915831: zfsutils-linux: Upgrading to 0.7.12 breaks during dpkg --configure

2018-12-11 Thread Petter Reinholdtsen
[Rich Ercolani]
> Setting up zfsutils-linux (0.7.12-1) ...
> insserv: Service zfs-zed has to be enabled to start service zfs-share
> insserv: exiting now!
> update-rc.d: error: insserv rejected the script header

An alternative to dropping the boot order relation is to change the
order the scripts are registered into the boot sequence.  Is it possible
to ensure zfs-zed is registered before zfs-share on installation, and
unregistered after on package uninstallation?

-- 
Happy hacking
Petter Reinholdtsen



Bug#915831: zfsutils-linux: Upgrading to 0.7.12 breaks during dpkg --configure

2018-12-07 Thread Rich Ercolani
Package: zfsutils-linux
Version: 0.7.12-1
Severity: normal

Dear Maintainer,

Tried upgrading from stretch-backports 0.7.11 to testing 0.7.12, because
the package hadn't landed in backports yet, and discovered it broke on
dpkg --configure :
Setting up zfsutils-linux (0.7.12-1) ...
insserv: Service zfs-zed has to be enabled to start service zfs-share
insserv: exiting now!
update-rc.d: error: insserv rejected the script header
dpkg: error processing package zfsutils-linux (--configure):
 subprocess installed post-installation script returned error exit status 1
dpkg: dependency problems prevent configuration of zfs-zed:
 zfs-zed depends on zfsutils-linux (>= 0.7.12-1); however:
  Package zfsutils-linux is not configured yet.

Someone else had reported a similar problem upstream to ZoL from Ubuntu's
packages, at:
https://github.com/zfsonlinux/zfs/issues/8127

I worked up a terrible hackjob of a patch to work around this long enough to
install it and then reverted the patch (attached), but there's probably a better
way to handle this.

(Don't mind the arc_summary changed warning; I've been testing improvements to 
it.)

-- System Information:
Debian Release: 9.6
  APT prefers stable-debug
  APT policy: (1000, 'stable-debug'), (1000, 'stable'), (900, 'testing-debug'), 
(900, 'testing'), (800, 'unstable-debug'), (800, 'unstable'), (500, 
'stable-updates'), (500, 'proposed-updates-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-8-amd64 (SMP w/16 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages zfsutils-linux depends on:
ii  libblkid12.29.2-1+deb9u1
ii  libc62.24-11+deb9u3
ii  libnvpair1linux  0.7.12-1
ii  libuuid1 2.29.2-1+deb9u1
ii  libuutil1linux   0.7.12-1
ii  libzfs2linux 0.7.12-1
ii  libzpool2linux   0.7.12-1
ii  python3  3.5.3-1
ii  zlib1g   1:1.2.8.dfsg-5

Versions of packages zfsutils-linux recommends:
ii  lsb-base9.20161125
ii  zfs-dkms [zfs-modules]  0.7.12-1
ii  zfs-zed 0.7.12-1

Versions of packages zfsutils-linux suggests:
ii  nfs-kernel-server  1:1.3.4-2.1
ii  samba-common-bin   2:4.5.12+dfsg-2+deb9u4
ii  zfs-initramfs  0.7.12-1

-- Configuration Files:
/etc/sudoers.d/zfs [Errno 13] Permission denied: '/etc/sudoers.d/zfs'

-- debconf-show failed

-- debsums errors found:
debsums: changed file /usr/sbin/arc_summary (from zfsutils-linux package)
diff --git a/init.d/zfs-share b/init.d/zfs-share
index 6564720..2e800d1 100755
--- a/init.d/zfs-share
+++ b/init.d/zfs-share
@@ -9,8 +9,8 @@
 #
 ### BEGIN INIT INFO
 # Provides:  zfs-share
-# Required-Start:$local_fs $network $remote_fs zfs-mount zfs-zed
-# Required-Stop: $local_fs $network $remote_fs zfs-mount zfs-zed
+# Required-Start:$local_fs $network $remote_fs zfs-mount
+# Required-Stop: $local_fs $network $remote_fs zfs-mount
 # Default-Start: 2 3 4 5
 # Default-Stop:  0 1 6
 # Should-Start:  iscsi iscsitarget istgt scst nfs-kernel-server samba 
samba4 zfs-mount zfs-zed
@@ -34,7 +34,7 @@

 do_depend()
 {
-   after sysfs zfs-mount zfs-zed
+   after sysfs zfs-mount
keyword -lxc -openvz -prefix -vserver
 }