Bug#922006: please move dkimpy-milter to python3

2019-02-21 Thread Daniel Kahn Gillmor
Control: forwarded 922006 
https://code.launchpad.net/~dkimpy-milter-dev/dkimpy-milter/+git/dkimpy-milter/+ref/dkg/python3

On Mon 2019-02-11 03:02:30 -0500, Scott Kitterman wrote:
> I think the code changes are probably very small.  I just did an SPF milter 
> using pyspf and the python3 pymilter (pyspf-milter - in Buster already) and 
> it 
> seemed pretty straightforward.
>
> It may be as little as using io.BytesIO vice StringIO.StringIO.  Given it 
> wasn't a bother for the SPF milter, I'll probably go ahead with it soon.

thanks!  I've submitted the dkg/python3 branch upstream for your
review.  It is applied after a series of changes i made that provide a
simple test environment, so you can verify that the milter behaves the
same way after the python3 conversion.  Commit ID
ea09bab1a8fb9eeed3429e9a8411ee42f9c423f3 is the most complex patch, in
particular bytes vs. strings.  the commit message there provides more
information about the difficulties i encountered.

I'm now running this; i'll let you know if i see any problems with it.

--dkg


signature.asc
Description: PGP signature


Bug#922006: please move dkimpy-milter to python3

2019-02-11 Thread Daniel Kahn Gillmor
On https://bugs.debian.org/922006 Mon 2019-02-11 03:02:30 -0500, Scott 
Kitterman wrote:
> It may be as little as using io.BytesIO vice StringIO.StringIO.  Given it 
> wasn't a bother for the SPF milter, I'll probably go ahead with it soon.

great, thanks!  I'm happy to help test if you like.

   --dkg


signature.asc
Description: PGP signature


Bug#922006: please move dkimpy-milter to python3

2019-02-11 Thread Scott Kitterman
On Monday, February 11, 2019 02:33:35 AM Daniel Kahn Gillmor wrote:
> Package: dkimpy-milter
> Version: 1.0.0-1
> 
> Hi Scott--
> 
> I see that python3-milter exists now.  it would be great to move
> dkimpy-milter to python3 as well, so that mailserver administrators
> using dkimpy-milter don't need to have python2 installed.
> 
> If you want a hand with the transition, i'd be happy to help.

I think the code changes are probably very small.  I just did an SPF milter 
using pyspf and the python3 pymilter (pyspf-milter - in Buster already) and it 
seemed pretty straightforward.

It may be as little as using io.BytesIO vice StringIO.StringIO.  Given it 
wasn't a bother for the SPF milter, I'll probably go ahead with it soon.

Scott K

signature.asc
Description: This is a digitally signed message part.


Bug#922006: please move dkimpy-milter to python3

2019-02-10 Thread Daniel Kahn Gillmor
Package: dkimpy-milter
Version: 1.0.0-1

Hi Scott--

I see that python3-milter exists now.  it would be great to move
dkimpy-milter to python3 as well, so that mailserver administrators
using dkimpy-milter don't need to have python2 installed.

If you want a hand with the transition, i'd be happy to help.

Regards,

  --dkg


signature.asc
Description: PGP signature