Bug#972674: ITP: toolbox -- Unprivileged container development environment

[Andrej Shadura]

Hi,

On Wed, 10 Feb 2021 15:28:29 -0300 Andre Moreira Magalhaes
 wrote:
> Hi,
> 
> I ended up using this packaging as base for Endless OS and pushed
> the updated packaging to
> https://salsa.debian.org/andrunko-guest/toolbox/ (incl. update to
> 0.0.99).
> 
> The packaging still needs some work, specially regarding the two extra
> modules not yet packaged in Debian (see "debian/gocode"), but it works
> fine as is.
> 
> I also checked about using dh-golang but I don't think we should do it
> here tbh, unless upstream changes their build system from meson to go
> (the current repo dir structure doesn't play well with dh-golang).
> 
> I don't plan to work on this anymore atm but thought I'd share our
> changes in case anyone find them useful.

I took your packaging, dropped one of the vendored packages having
updated it in Debian, and uploaded it to NEW.

The Git repository is now located here:
https://salsa.debian.org/debian/podman-toolbox

-- 
Cheers,
  Andrej

Bug#972674: ITP: toolbox -- Unprivileged container development environment

[Andre Moreira Magalhaes]

Hi,

I ended up using this packaging as base for Endless OS and pushed
the updated packaging to
https://salsa.debian.org/andrunko-guest/toolbox/ (incl. update to
0.0.99).

The packaging still needs some work, specially regarding the two extra
modules not yet packaged in Debian (see "debian/gocode"), but it works
fine as is.

I also checked about using dh-golang but I don't think we should do it
here tbh, unless upstream changes their build system from meson to go
(the current repo dir structure doesn't play well with dh-golang).

I don't plan to work on this anymore atm but thought I'd share our
changes in case anyone find them useful.

Cheers,
Andre

On Thu, 03 Dec 2020 18:10:47 +1100 Hayley Hughes 
wrote:
> 
> Alright so I've had a go at addressing the issues with mixed results.
> 
> I've changed the names of the source and binary packages to what has 
> been suggested andupdated the Maintainer field to the debian golang 
> packaging team. I did try to migrate over to using dh-golang as the 
> buildsystem but I ran into errors such as
> 
> can't load package: package 
> /usr/share/doc/golang-github-grpc-ecosystem-grpc-gateway-dev/examples/gateway:
>  
> import 
> "/usr/share/doc/golang-github-grpc-ecosystem-grpc-gateway-dev/examples/gateway":
>  
> cannot import absolute path
> 
> and wasn't able to find a solution. I had a look at how arch and fedora 
> package toolbox and they all used meson, so it seems like that might be 
> the best way to package it (and I have made a few improvements such as 
> setting the profile_dir variable) although the biggest problem with it 
> currently is that it pulls dependencies from github rather then using 
> what's packaged in the repos. I believe that can be fixed by setting 
> the GOPATH environment variable but I'm unsure as to what to set it to.
> 
> If anyone is able to help, it would be much appreciated.
> 
> Many thanks,
> Hayley
> 
> On Tue, Dec 1, 2020 at 10:54, Hayley Hughes  
> wrote:
> > Hey all,
> > 
> > Thanks Raphael for CCing the correct people and thanks to Reinhard 
> > for offering to sponsor.
> > 
> >> Would you be happy to maintain the packaging under the golang-team 
> >> umbrella or would you have
> >> other preferences? Having it in the debian/ namespace on salsa would 
> >> work for me
> >> equally well.
> > 
> > I would be happy to maintain it under the golang team umbrella. 
> > Although it might make things a little easier for them if I changed 
> > it over to using dh_golang to keep things more consistent with other 
> > go packages. I only really chose to go with meson because I needed 
> > something that I knew would just work for the short term.
> > 
> >>  I agree with Raphael, the currently chosen names are too generic 
> >> for integration
> >> into a general-purpose distribution such as Debian. I'd propose:
> >> 
> >> src:golang-github-containers-toolbox to produce toolbox-podman (or 
> >> podman-toolbox)
> > 
> > I definitely agree and will look into fixing everything sometime 
> > today.
> > 
> > Kind regards,
> > Hayley
> > 
> > On Mon, Nov 30, 2020 at 07:26, Reinhard Tartler  

Bug#972674: ITP: toolbox -- Unprivileged container development environment

[Hayley Hughes]

Alright so I've had a go at addressing the issues with mixed results.

I've changed the names of the source and binary packages to what has 
been suggested andupdated the Maintainer field to the debian golang 
packaging team. I did try to migrate over to using dh-golang as the 
buildsystem but I ran into errors such as


can't load package: package 
/usr/share/doc/golang-github-grpc-ecosystem-grpc-gateway-dev/examples/gateway: 
import 
"/usr/share/doc/golang-github-grpc-ecosystem-grpc-gateway-dev/examples/gateway": 
cannot import absolute path


and wasn't able to find a solution. I had a look at how arch and fedora 
package toolbox and they all used meson, so it seems like that might be 
the best way to package it (and I have made a few improvements such as 
setting the profile_dir variable) although the biggest problem with it 
currently is that it pulls dependencies from github rather then using 
what's packaged in the repos. I believe that can be fixed by setting 
the GOPATH environment variable but I'm unsure as to what to set it to.


If anyone is able to help, it would be much appreciated.

Many thanks,
Hayley

On Tue, Dec 1, 2020 at 10:54, Hayley Hughes  
wrote:

Hey all,

Thanks Raphael for CCing the correct people and thanks to Reinhard 
for offering to sponsor.


Would you be happy to maintain the packaging under the golang-team 
umbrella or would you have
other preferences? Having it in the debian/ namespace on salsa would 
work for me

equally well.


I would be happy to maintain it under the golang team umbrella. 
Although it might make things a little easier for them if I changed 
it over to using dh_golang to keep things more consistent with other 
go packages. I only really chose to go with meson because I needed 
something that I knew would just work for the short term.


 I agree with Raphael, the currently chosen names are too generic 
for integration

into a general-purpose distribution such as Debian. I'd propose:

src:golang-github-containers-toolbox to produce toolbox-podman (or 
podman-toolbox)


I definitely agree and will look into fixing everything sometime 
today.


Kind regards,
Hayley

On Mon, Nov 30, 2020 at 07:26, Reinhard Tartler  
wrote:

Thanks Raphael for highlighting Hayley's work.


On 11/30/20 4:22 AM, Raphael Hertzog wrote:

 Hi,

 On Thu, 22 Oct 2020, Hayley Hughes wrote:

 * URL : 

 Toolbox is a tool that offers a familiar package based 
environment for
 developing and debugging software that runs fully unprivileged 
using Podman.

 […]

 I have already made some progress which can be found on salsa
 () for my own benefit 
(please feel
 free to review it and suggest changes) and I thought that it 
might be an
 idea to make an attempt to properly package it and add it to the 
Debian

 archives.

 Will be keen to hear what others think.


 I was looking for the package and I'm glad that you are working on
 packaging it.

 I have put in CC Reinhard Tartler and Dmitry Smirnov that are the
 Uploaders of podman and buildah, maybe they would be willing to 
sponsor

 your package and integrate it in the pkg-go team.


I looked at the upstream README and over the packaging, which seems 
clean to me.
Curiously, while written in go, it doesn't use the dh_golang 
debhelper but
the upstream meson build system. That's a first for me, but 
(probably) not concerning.


I'd be happy to upload the package on your behalf.

Would you be happy to maintain the packaging under the golang-team 
umbrella or would you have
other preferences? Having it in the debian/ namespace on salsa would 
work for me

equally well.



 As for the discussion about the package name, podman-toolbox or
 container-toolbox looks good to me.


I agree with Raphael, the currently chosen names are too generic for 
integration

into a general-purpose distribution such as Debian. I'd propose:

src:golang-github-containers-toolbox to produce toolbox-podman (or 
podman-toolbox)



[currently, the packaging uses src:toolbox and toolbox as binary 
package name]


Best,
-rt

Bug#972674: ITP: toolbox -- Unprivileged container development environment

[Hayley Hughes]

Hey all,

Thanks Raphael for CCing the correct people and thanks to Reinhard for 
offering to sponsor.


Would you be happy to maintain the packaging under the golang-team 
umbrella or would you have
other preferences? Having it in the debian/ namespace on salsa would 
work for me

equally well.


I would be happy to maintain it under the golang team umbrella. 
Although it might make things a little easier for them if I changed it 
over to using dh_golang to keep things more consistent with other go 
packages. I only really chose to go with meson because I needed 
something that I knew would just work for the short term.


 I agree with Raphael, the currently chosen names are too generic for 
integration

into a general-purpose distribution such as Debian. I'd propose:

src:golang-github-containers-toolbox to produce toolbox-podman (or 
podman-toolbox)


I definitely agree and will look into fixing everything sometime today.

Kind regards,
Hayley

On Mon, Nov 30, 2020 at 07:26, Reinhard Tartler  
wrote:

Thanks Raphael for highlighting Hayley's work.


On 11/30/20 4:22 AM, Raphael Hertzog wrote:

 Hi,

 On Thu, 22 Oct 2020, Hayley Hughes wrote:

 * URL : <>

 Toolbox is a tool that offers a familiar package based environment 
for
 developing and debugging software that runs fully unprivileged 
using Podman.

 […]

 I have already made some progress which can be found on salsa
 (<>) for my own benefit 
(please feel
 free to review it and suggest changes) and I thought that it might 
be an
 idea to make an attempt to properly package it and add it to the 
Debian

 archives.

 Will be keen to hear what others think.


 I was looking for the package and I'm glad that you are working on
 packaging it.

 I have put in CC Reinhard Tartler and Dmitry Smirnov that are the
 Uploaders of podman and buildah, maybe they would be willing to 
sponsor

 your package and integrate it in the pkg-go team.


I looked at the upstream README and over the packaging, which seems 
clean to me.
Curiously, while written in go, it doesn't use the dh_golang 
debhelper but
the upstream meson build system. That's a first for me, but 
(probably) not concerning.


I'd be happy to upload the package on your behalf.

Would you be happy to maintain the packaging under the golang-team 
umbrella or would you have
other preferences? Having it in the debian/ namespace on salsa would 
work for me

equally well.



 As for the discussion about the package name, podman-toolbox or
 container-toolbox looks good to me.


I agree with Raphael, the currently chosen names are too generic for 
integration

into a general-purpose distribution such as Debian. I'd propose:

src:golang-github-containers-toolbox to produce toolbox-podman (or 
podman-toolbox)



[currently, the packaging uses src:toolbox and toolbox as binary 
package name]


Best,
-rt

Bug#972674: ITP: toolbox -- Unprivileged container development environment

[Reinhard Tartler]

Thanks Raphael for highlighting Hayley's work.


On 11/30/20 4:22 AM, Raphael Hertzog wrote:
> Hi,
> 
> On Thu, 22 Oct 2020, Hayley Hughes wrote:
>> * URL : 
>>
>> Toolbox is a tool that offers a familiar package based environment for
>> developing and debugging software that runs fully unprivileged using Podman.
> […]
>> I have already made some progress which can be found on salsa
>> () for my own benefit (please feel
>> free to review it and suggest changes) and I thought that it might be an
>> idea to make an attempt to properly package it and add it to the Debian
>> archives.
>>
>> Will be keen to hear what others think.
> 
> I was looking for the package and I'm glad that you are working on
> packaging it.
> 
> I have put in CC Reinhard Tartler and Dmitry Smirnov that are the
> Uploaders of podman and buildah, maybe they would be willing to sponsor
> your package and integrate it in the pkg-go team.

I looked at the upstream README and over the packaging, which seems clean to me.
Curiously, while written in go, it doesn't use the dh_golang debhelper but
the upstream meson build system. That's a first for me, but (probably) not 
concerning.

I'd be happy to upload the package on your behalf.

Would you be happy to maintain the packaging under the golang-team umbrella or 
would you have
other preferences? Having it in the debian/ namespace on salsa would work for me
equally well.


> As for the discussion about the package name, podman-toolbox or
> container-toolbox looks good to me. 

I agree with Raphael, the currently chosen names are too generic for integration
into a general-purpose distribution such as Debian. I'd propose:

src:golang-github-containers-toolbox to produce toolbox-podman (or 
podman-toolbox)


[currently, the packaging uses src:toolbox and toolbox as binary package name]

Best,
-rt

Bug#972674: ITP: toolbox -- Unprivileged container development environment

[Raphael Hertzog]

Hi,

On Thu, 22 Oct 2020, Hayley Hughes wrote:
> * URL : 
> 
> Toolbox is a tool that offers a familiar package based environment for
> developing and debugging software that runs fully unprivileged using Podman.
[…]
> I have already made some progress which can be found on salsa
> () for my own benefit (please feel
> free to review it and suggest changes) and I thought that it might be an
> idea to make an attempt to properly package it and add it to the Debian
> archives.
> 
> Will be keen to hear what others think.

I was looking for the package and I'm glad that you are working on
packaging it.

I have put in CC Reinhard Tartler and Dmitry Smirnov that are the
Uploaders of podman and buildah, maybe they would be willing to sponsor
your package and integrate it in the pkg-go team.

As for the discussion about the package name, podman-toolbox or
container-toolbox looks good to me. 

Cheers,
-- 
  ⢀⣴⠾⠻⢶⣦⠀   Raphaël Hertzog 
  ⣾⠁⢠⠒⠀⣿⡁
  ⢿⡄⠘⠷⠚⠋The Debian Handbook: https://debian-handbook.info/get/
  ⠈⠳⣄   Debian Long Term Support: https://deb.li/LTS

Bug#972674: ITP: toolbox -- Unprivileged container development environment

[Hayley Hughes]

Hey Gunnar,
That’s a good point you’ve raised.

Personally I’m leaning towards the name podman-toolbox because it explicitly 
states the container runtime which toolbox is designed for; Although it doesn’t 
quite roll off the tongue as nice as container-toolbox.

Although I’m open for suggestions/feedback.

Hayley

> On 24 Oct 2020, at 05:13, Gunnar Wolf  wrote:
> 
> Hayley Hughes dijo [Thu, Oct 22, 2020 at 09:31:30PM +1100]:
>> * Package name : toolbox
>> (...)
>> Toolbox is a tool that offers a familiar package based environment for
>> developing and debugging software that runs fully unprivileged using Podman.
>> 
>> The toolbox environment is based on an OCI image such as fedora-toolbox.
>> This image is used to create a toolbox container that seamlessly integrates
>> with the rest of the operating system.
>> (...)
> 
> The name "toolbox" is very non-descriptive. There are many different
> toolboxes for different things in Debian. Even though this is, of
> course, upstream's chosen project name, I suggest you to consider
> qualifying the name in a way to make it clearer - probably something
> like "toolbox-container", "container-toolbox" or something like that?

Bug#972674: ITP: toolbox -- Unprivileged container development environment

[Gunnar Wolf]

Hayley Hughes dijo [Thu, Oct 22, 2020 at 09:31:30PM +1100]:
> * Package name : toolbox
> (...)
> Toolbox is a tool that offers a familiar package based environment for
> developing and debugging software that runs fully unprivileged using Podman.
> 
> The toolbox environment is based on an OCI image such as fedora-toolbox.
> This image is used to create a toolbox container that seamlessly integrates
> with the rest of the operating system.
> (...)

The name "toolbox" is very non-descriptive. There are many different
toolboxes for different things in Debian. Even though this is, of
course, upstream's chosen project name, I suggest you to consider
qualifying the name in a way to make it clearer - probably something
like "toolbox-container", "container-toolbox" or something like that?

Bug#972674: ITP: toolbox -- Unprivileged container development environment

[Hayley Hughes]

Package: wnpp
Severity: wishlist
Owner: Hayley Hughes 
X-Debbugs-Cc: debian-de...@lists.debian.org 



* Package name : toolbox
  Version : 0.0.96
  Upstream Author : Red Hat contributors
* URL : 
* License : Apache-2
  Description :

Toolbox is a tool that offers a familiar package based environment for 
developing and debugging software that runs fully unprivileged using 
Podman.


The toolbox environment is based on an OCI image such as 
fedora-toolbox. This image is used to create a toolbox container that 
seamlessly integrates with the rest of the operating system.


This is rather handy to create what are sometimes referred to 'pet 
containers' where you can set up your development environment inside a 
container. This not only helps to keep your OS clean but also allows 
one to easily make it reproducible by creating custom images.


I have already made some progress which can be found on salsa 
() for my own benefit (please 
feel free to review it and suggest changes) and I thought that it might 
be an idea to make an attempt to properly package it and add it to the 
Debian archives.


Will be keen to hear what others think.

Kind Regards,
Hayley