Bug#291011: arggg fix the real problem.
Jamie Heilman [2005-01-18 10:42 -0800]: Changes: sysfsutils (1.2.0-2) unstable; urgency=low . * sysfsutils.init: Use shell bash instead of sh. (closes: #291011) Please do not use bash, just fix the real problem, I offered a patch in #291022 which does this (and more). What is the _real_ problem? Using awk is a problem because it might not be available at the time the init script runs (there is a reason that init script can only use programs in /bin, not in /usr/bin). Additional bugs in the current script: Your replacement of '.' to '/' isn't a good idea because there are paths in sysfs which can contain '.' -- my patch accounted for that as well. Hmm, right. I think I should just drop support for separating the path components with a dot (I wanted to make that similar to the procps init script, but that does not have this problem). You defined a configuration file variable, and then didn't use it, my patch took care of that too. Sorry, will be fixed. Thanks! Martin -- Martin Pitt http://www.piware.de Ubuntu Developerhttp://www.ubuntulinux.org Debian GNU/Linux Developer http://www.debian.org signature.asc Description: Digital signature
Bug#291011: arggg fix the real problem.
Martin Pitt wrote: Jamie Heilman [2005-01-18 10:42 -0800]: Changes: sysfsutils (1.2.0-2) unstable; urgency=low . * sysfsutils.init: Use shell bash instead of sh. (closes: #291011) Please do not use bash, just fix the real problem, I offered a patch in #291022 which does this (and more). What is the _real_ problem? The 'real problem' I was referring to was the use bash substitution syntax when it wasn't necessary... Using awk is a problem because it might not be available at the time the init script runs (there is a reason that init script can only use programs in /bin, not in /usr/bin). Well, for some init scripts sure, however: [98]stink-foot/etc/rcS.d/ls *sysfsutils ls: *sysfsutils: No such file or directory Seeing as you didn't have a link in rcS.d I didn't figure you cared about what was or wasn't mounted yet. (ISTR your bash substitution syntax also didn't trim leading whitespace from the component value, which may or may not be important, mine doesn't trim leading whitespace from the key, or trailing from the value, though thats easy to fix with gsub; I haven't check to see if its a real problem though.) -- Jamie Heilman http://audible.transient.net/~jamie/ Most people wouldn't know music if it came up and bit them on the ass. -Frank Zappa -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#291011: arggg fix the real problem.
Changes: sysfsutils (1.2.0-2) unstable; urgency=low . * sysfsutils.init: Use shell bash instead of sh. (closes: #291011) Please do not use bash, just fix the real problem, I offered a patch in #291022 which does this (and more). Additional bugs in the current script: Your replacement of '.' to '/' isn't a good idea because there are paths in sysfs which can contain '.' -- my patch accounted for that as well. You defined a configuration file variable, and then didn't use it, my patch took care of that too. -- Jamie Heilman http://audible.transient.net/~jamie/ I was in love once -- a Sinclair ZX-81. People said, No, Holly, she's not for you. She was cheap, she was stupid and she wouldn't load -- well, not for me, anyway. -Holly -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
