Bug#445985: Setting http_proxy discards proxy information altogether for https
On Mon, Dec 15, 2008 at 06:41:27PM +0200, Eugene V. Lyubimkin wrote:
Otavio Salvador wrote:
deity team hat
I think this could be fixed since the fix should be fairly trivial and
we could send it for pre-approval from RM team.
/deity team hat
Ok. I will try produce a patch as soon as I have enough time.
Thanks a lot for the patch, I merged it and uploaded it (along with
some more fixes) to experimental. I was slightly hesitant about it
first because in the past {http,ftp}_proxy always won over the apt
conf. But I guess if we release note it (or put it into NEWS.Debian or
something) we should be fine. It more correct this way.
Thanks,
Michael
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#445985: Setting http_proxy discards proxy information altogether for https
Jussi Hakala wrote: Any update on this? Hello. I believe that the correct way to deal with these two bugs is: 1) look at Acquire::http::*, if needed info is found, use just it 2) use http_proxy if it's present 3) otherwise connect directly Otavio, should this bug be fixed for Lenny? I just saw pre-announce for d-i RC2 and deep freeze (soon)... -- Eugene V. Lyubimkin aka JackYF, JID: jackyf.devel(maildog)gmail.com Ukrainian C++ Developer, Debian APT contributor signature.asc Description: OpenPGP digital signature
Bug#445985: Setting http_proxy discards proxy information altogether for https
Eugene V. Lyubimkin jackyf.de...@gmail.com writes: Jussi Hakala wrote: Any update on this? Hello. I believe that the correct way to deal with these two bugs is: 1) look at Acquire::http::*, if needed info is found, use just it 2) use http_proxy if it's present 3) otherwise connect directly Otavio, should this bug be fixed for Lenny? I just saw pre-announce for d-i RC2 and deep freeze (soon)... d-i RM hat APT doesn't block a d-i release since it is installed in base and not included in the initrd image. No objection for d-i to get it fixed. /d-i RM hat deity team hat I think this could be fixed since the fix should be fairly trivial and we could send it for pre-approval from RM team. /deity team hat -- O T A V I OS A L V A D O R - E-mail: ota...@debian.org UIN: 5906116 GNU/Linux User: 239058 GPG ID: 49A5F855 Home Page: http://otavio.ossystems.com.br - Microsoft sells you Windows ... Linux gives you the whole house. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#445985: Setting http_proxy discards proxy information altogether for https
Otavio Salvador wrote: deity team hat I think this could be fixed since the fix should be fairly trivial and we could send it for pre-approval from RM team. /deity team hat Ok. I will try produce a patch as soon as I have enough time. -- Eugene V. Lyubimkin aka JackYF, JID: jackyf.devel(maildog)gmail.com Ukrainian C++ developer, Debian APT contributor signature.asc Description: OpenPGP digital signature
Bug#445985: Setting http_proxy discards proxy information altogether for https
Any update on this? -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#445985: Setting http_proxy discards proxy information altogether for https
[EMAIL PROTECTED] wrote: Tim Connors [EMAIL PROTECTED] writes: I strongly object to the proxy environment variable overriding that in the conf file, because the apt.conf setting is more specific I'm on same page of you. Eh, the patch submitter attached just makes https method behave _same_ way http and ftp methods work? Currently https behaves like this: if http_proxy is not not set use apt-conf variables else connect directly Which, is most clearly unexpected and wrong. The rest methods work like this if http_proxy is not not set use apt-conf variables else use http_proxy for proxy If you do not intend to change that behaviour for other methods, I don't see why reject a patch that makes https method behave different from others. If proxy variables are used wrong, lets be atleast uniformly wrong :) -- rm -rf only sounds scary if you don't have backups signature.asc Description: Digital signature
Bug#445985: Setting http_proxy discards proxy information altogether for https
Package: apt-transport-https
Version: 0.7.6
When http_proxy environment variable is set, all information about proxy
is discarded. Both the information present in the environment variable
and the information in apt.conf (Acquire::http::Proxy).
It should either honor the http_proxy over the apt.conf (see also
#157759) or use the one specified in the configuration, regardless
what's in the environment variable.
The issue is https only.
Included a patch to use the http_proxy whenever it's set, overriding the
apt.conf value.
--- orig/apt-0.7.6/methods/https.cc 2007-07-24 15:33:30.0 +0300
+++ new/apt-0.7.6/methods/https.cc 2007-10-09 17:16:50.0 +0300
@@ -75,6 +75,10 @@
else
Proxy = DefProxy;
}
+ else
+ {
+ Proxy = getenv(http_proxy);
+ }
// Parse no_proxy, a , separated list of domains
if (getenv(no_proxy) != 0)
