Bug#800832: mate-terminal: sets TERM to ‘xterm’ even though ‘xterm-256colors’ would be appropriate

[astian]

Control: found -1 1.20.0-2

Patch refreshed.

Cheers.
Description: Stop setting TERM
 TERM should be set by libvte by default, do not override it.
 .
 See also: https://bugzilla.gnome.org/show_bug.cgi?id=740641
 .
Author: astian 

---
Bug: https://github.com/mate-desktop/mate-terminal/issues/209
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800832
Last-Update: 2018-04-06

--- mate-terminal-1.20.0.orig/src/terminal-screen.c
+++ mate-terminal-1.20.0/src/terminal-screen.c
@@ -1440,8 +1440,6 @@ get_child_environment (TerminalScreen *s
 	g_hash_table_remove (env_table, "LINES");
 	g_hash_table_remove (env_table, "MATE_DESKTOP_ICON");
 
-	g_hash_table_replace (env_table, g_strdup ("TERM"), g_strdup ("xterm")); /* FIXME configurable later? */
-
 	/* FIXME: moving the tab between windows, or the window between displays will make the next two invalid... */
 	g_hash_table_replace (env_table, g_strdup ("WINDOWID"), g_strdup_printf ("%ld", GDK_WINDOW_XID (gtk_widget_get_window (window;
 	g_hash_table_replace (env_table, g_strdup ("DISPLAY"), g_strdup (gdk_display_get_name (display)));

Bug#800832: mate-terminal: sets TERM to ‘xterm’ even though ‘xterm-256colors’ would be appropriate

[astian]

Control: found -1 1.20.0-1

This still affects the latest release in sid.

I tweaked the patch so that it applies cleanly (COLORTERM was
removed upstream, so no need to patch that out anymore).

Cheers.
Description: Stop setting TERM
 TERM should be set by libvte by default, do not override it.
 .
 See also: https://bugzilla.gnome.org/show_bug.cgi?id=740641
 .
Author: astian 

---
Bug: https://github.com/mate-desktop/mate-terminal/issues/209
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800832
Last-Update: 2018-02-15

--- mate-terminal-1.20.0.orig/src/terminal-screen.c
+++ mate-terminal-1.20.0/src/terminal-screen.c
@@ -1421,8 +1421,6 @@ get_child_environment (TerminalScreen *s
 	g_hash_table_remove (env_table, "LINES");
 	g_hash_table_remove (env_table, "MATE_DESKTOP_ICON");
 
-	g_hash_table_replace (env_table, g_strdup ("TERM"), g_strdup ("xterm")); /* FIXME configurable later? */
-
 	/* FIXME: moving the tab between windows, or the window between displays will make the next two invalid... */
 	g_hash_table_replace (env_table, g_strdup ("WINDOWID"), g_strdup_printf ("%ld", GDK_WINDOW_XID (gtk_widget_get_window (window;
 	g_hash_table_replace (env_table, g_strdup ("DISPLAY"), g_strdup (gdk_display_get_name (display)));

Bug#800832: mate-terminal: sets TERM to ‘xterm’ even though ‘xterm-256colors’ would be appropriate

[astian]

Control: tags -1 + patch

Here's a trivial patch.

Cheers.
Description: Stop setting TERM and COLORTERM
 TERM should be set by libvte by default, do not override it.  COLORTERM is
 obsolete.
 .
 See also: https://git.gnome.org/browse/gnome-terminal/commit/?id=1d5c1b6ca6373c1301494edbc9e43c3e6a9c9aaf
 .
Author: astian 

---
Bug: https://github.com/mate-desktop/mate-terminal/issues/209
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800832
Last-Update: 2017-12-28

--- mate-terminal-1.18.2.orig/src/terminal-screen.c
+++ mate-terminal-1.18.2/src/terminal-screen.c
@@ -1338,9 +1338,6 @@ get_child_environment (TerminalScreen *s
 	g_hash_table_remove (env_table, "LINES");
 	g_hash_table_remove (env_table, "MATE_DESKTOP_ICON");
 
-	g_hash_table_replace (env_table, g_strdup ("COLORTERM"), g_strdup (EXECUTABLE_NAME));
-	g_hash_table_replace (env_table, g_strdup ("TERM"), g_strdup ("xterm")); /* FIXME configurable later? */
-
 	/* FIXME: moving the tab between windows, or the window between displays will make the next two invalid... */
 	g_hash_table_replace (env_table, g_strdup ("WINDOWID"), g_strdup_printf ("%ld", GDK_WINDOW_XID (gtk_widget_get_window (window;
 	g_hash_table_replace (env_table, g_strdup ("DISPLAY"), g_strdup (gdk_display_get_name (display)));

Bug#800832: mate-terminal: sets TERM to ‘xterm’ even though ‘xterm-256colors’ would be appropriate

[astian]

Control: notforwarded -1
Control: reassign -1 mate-terminal
Control: tags -1 - fixed-upstream
Control: severity -1 normal
Control: found -1 1.18.2-1

This is still broken and has not been fixed in mate-terminal upstream, which
is where the bug is.  From src/terminal-screen.c:

  g_hash_table_replace (env_table, g_strdup ("TERM"), g_strdup ("xterm")); /* 
FIXME configurable later? */

That ancient code comes from gnome-terminal 2.33.4 or earlier.

There's an unresolved bug report in upstream's bug tracker:

  https://github.com/mate-desktop/mate-terminal/issues/209

Also the proposed work-around (not a fix) is not good enough: it won't work
for cases in which the terminal is told to spawn some other program.  (For the 
same
reason, overriding TERM in some shell initialisation script is, besides 
idiotic, also
ineffective.)  Consider:

  $ mate-terminal -x vim

This is not a contrived example, many application will launch a terminal in
exactly that fashion.

I'm raising the severity and reassigning.

Cheers.

_

Ihre E-Mail-Postf�cher sicher & zentral an einem Ort. Jetzt wechseln und alte 
E-Mail-Adresse mitnehmen! https://www.eclipso.de

Bug#800832: mate-terminal: sets TERM to ‘xterm’ even though ‘xterm-256colors’ would be appropriate

[Axel]

Package: mate-terminal
Version: 1.8.1+dfsg1-4
Severity: minor

Dear Maintainer,

This results in programs like E Links and Midnight Commander only offering 16 
colour
interfaces, at least by default. Whereas some programs, like E Links, can just 
be set to
use 256 colours, others, like the Midnight Commander, will refuse to accept any 
such
setting.

A quick fix can be achieved by using the “Run a custom command instead of my 
shell”
setting (menu → Edit → Profile Preferences → Title and Command) and using this 
command:

env TERM=xterm-256color 

e.g.:

env TERM=xterm-256color /bin/bash

-- System Information:
Debian Release: 8.2
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_IE.UTF-8, LC_CTYPE=en_IE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages mate-terminal depends on:
ii  libatk1.0-0   2.14.0-1
ii  libc6 2.19-18+deb8u1
ii  libcairo2 1.14.0-2.1
ii  libdconf1 0.22.0-1
ii  libfontconfig12.11.0-6.3
ii  libfreetype6  2.5.2-3
ii  libgdk-pixbuf2.0-02.31.1-2+deb8u2
ii  libglib2.0-0  2.42.1-1
ii  libgtk2.0-0   2.24.25-3
ii  libice6   2:1.0.9-1+b1
ii  libpango-1.0-01.36.8-3
ii  libpangocairo-1.0-0   1.36.8-3
ii  libpangoft2-1.0-0 1.36.8-3
ii  libsm62:1.2.2-1+b1
ii  libvte9   1:0.28.2-5
ii  libx11-6  2:1.6.2-3
ii  libxext6  2:1.3.3-1
ii  mate-desktop-common   1.8.1+dfsg1-3+deb8u1
ii  mate-terminal-common  1.8.1+dfsg1-4
pn  python:any

mate-terminal recommends no packages.

mate-terminal suggests no packages.

-- no debconf information