Bug#837960: spdylay: FTBFS with openssl 1.1.0

[Sebastian Andrzej Siewior]

control: tags -1 fixed-upstream

On 2016-09-17 22:01:25 [+0900], Tatsuhiro Tsujikawa wrote:
> > ​Thank you for the patch.  It has been applied and merged into master
> > branch.
> > I've made another couple of commits​ to fix OpenSSL 1.1.0 deprecation
> > warnings.

That would be
https://github.com/tatsuhiro-t/spdylay/commit/83ab19e842531df45b3f4a06d8ec9ac15c82a177
https://github.com/tatsuhiro-t/spdylay/commit/52e07b266823fa5efa37201ba22ca8e9c52fc406
https://github.com/tatsuhiro-t/spdylay/commit/1ddd0d310f3f9c7b108ed0e555666be49e5c46e5
https://github.com/tatsuhiro-t/spdylay/commit/651e4fd3081a1240199eb86b9132fa13d8691804

> > spdylay end-to-end test (which failed above) require libevent which is
> > also built with OpenSSL 1.1.0.  But it seems the latest stable libevent
> > does not compile OpenSSL 1.1.0.  I guess that the above error "wrong
> > version number" could mean that libevent has been built with older OpenSSL
> > version.
> >
> >
> ​I was wrong.  end_to_end.py does not require libevent, and after upgrading
> key pair, all tests passed.

libevent is somewehre on the list, too. Thanks for taking care of it so
quickly!

> Best regards,
> Tatsuhiro Tsujikawa​

Sebastian

Bug#837960: spdylay: FTBFS with openssl 1.1.0

[Tatsuhiro Tsujikawa]

On Sat, Sep 17, 2016 at 6:08 PM, Tatsuhiro Tsujikawa 
wrote:

> Hi,
>
> On Fri, Sep 16, 2016 at 6:46 AM, Sebastian Andrzej Siewior <
> sebast...@breakpoint.cc> wrote:
>
>> Package: spdylay
>> Version: 1.3.2-2
>> Severity: important
>> Tags: patch
>> Control: block 827061 by -1
>> Control: user pkg-openssl-devel-requ...@lists.alioth.debian.org
>> Control: usertag -1 openssl-1.1-trans-keypkg
>> Control: usertag -1 openssl-1.1-trans
>>
>> This package fails currently to compile against openssl 1.1.0 (currently
>> available in experimental). The issues look not openssl specific. The
>> full build of the build failure is available
>>   https://breakpoint.cc/openssl-1.1-rebuild-2016-08-26/failed/
>> spdylay_1.3.2-2_amd64-2016-08-26T19%3A47%3A25Z
>>
>> With the patch attached is manages to build. The testsuite fails then :)
>> The SSL error message was obtained via ERR_print_errors_fp(stderr):
>>
>> | =
>> |spdylay 1.3.2: tests/test-suite.log
>> | =
>> |
>> | # TOTAL: 3
>> | # PASS:  2
>> | # SKIP:  0
>> | # XFAIL: 0
>> | # FAIL:  1
>> | # XPASS: 0
>> | # ERROR: 0
>> |
>> | .. contents:: :depth: 2
>> |
>> | FAIL: end_to_end.py
>> | ===
>> |
>> | SSL_CTX_use_certificate_file failed.
>> | 140680762493824:error:140AB18F:SSL routines:SSL_CTX_use_certificate:ee
>> key too small:ssl/ssl_rsa.c:305:
>> | Could not connect to the host: localhost:9893
>> | error:1408F10B:SSL routines:ssl3_get_record:wrong version number
>> | Could not connect to the host: localhost:79
>> | FCould not connect to the host: localhost:2
>> | .Could not connect to the host: localhost:9893
>> | Could not connect to the host: localhost:9893
>> | FCould not connect to the host: localhost:9893
>> | FCould not connect to the host: localhost:9893
>> | FSSL_CTX_use_certificate_file failed.
>> | 140100289985408:error:140AB18F:SSL routines:SSL_CTX_use_certificate:ee
>> key too small:ssl/ssl_rsa.c:305:
>> | Could not connect to the host: localhost:9893
>>
>> So it looks like the key in the test is too small.
>>
>> Sebastian
>>
>
> ​Thank you for the patch.  It has been applied and merged into master
> branch.
> I've made another couple of commits​ to fix OpenSSL 1.1.0 deprecation
> warnings.
>
> spdylay end-to-end test (which failed above) require libevent which is
> also built with OpenSSL 1.1.0.  But it seems the latest stable libevent
> does not compile OpenSSL 1.1.0.  I guess that the above error "wrong
> version number" could mean that libevent has been built with older OpenSSL
> version.
>
>
​I was wrong.  end_to_end.py does not require libevent, and after upgrading
key pair, all tests passed.

Best regards,
Tatsuhiro Tsujikawa​




> For key size issues, I renewed key pair, and now use 2048 bits public key
> rather than 512 bits.
>
> Best regards,
> Tatsuhiro Tsujikawa
>
>
>
>
>
>

Bug#837960: spdylay: FTBFS with openssl 1.1.0

[Tatsuhiro Tsujikawa]

Hi,

On Fri, Sep 16, 2016 at 6:46 AM, Sebastian Andrzej Siewior <
sebast...@breakpoint.cc> wrote:

> Package: spdylay
> Version: 1.3.2-2
> Severity: important
> Tags: patch
> Control: block 827061 by -1
> Control: user pkg-openssl-devel-requ...@lists.alioth.debian.org
> Control: usertag -1 openssl-1.1-trans-keypkg
> Control: usertag -1 openssl-1.1-trans
>
> This package fails currently to compile against openssl 1.1.0 (currently
> available in experimental). The issues look not openssl specific. The
> full build of the build failure is available
>   https://breakpoint.cc/openssl-1.1-rebuild-2016-08-26/failed/
> spdylay_1.3.2-2_amd64-2016-08-26T19%3A47%3A25Z
>
> With the patch attached is manages to build. The testsuite fails then :)
> The SSL error message was obtained via ERR_print_errors_fp(stderr):
>
> | =
> |spdylay 1.3.2: tests/test-suite.log
> | =
> |
> | # TOTAL: 3
> | # PASS:  2
> | # SKIP:  0
> | # XFAIL: 0
> | # FAIL:  1
> | # XPASS: 0
> | # ERROR: 0
> |
> | .. contents:: :depth: 2
> |
> | FAIL: end_to_end.py
> | ===
> |
> | SSL_CTX_use_certificate_file failed.
> | 140680762493824:error:140AB18F:SSL routines:SSL_CTX_use_certificate:ee
> key too small:ssl/ssl_rsa.c:305:
> | Could not connect to the host: localhost:9893
> | error:1408F10B:SSL routines:ssl3_get_record:wrong version number
> | Could not connect to the host: localhost:79
> | FCould not connect to the host: localhost:2
> | .Could not connect to the host: localhost:9893
> | Could not connect to the host: localhost:9893
> | FCould not connect to the host: localhost:9893
> | FCould not connect to the host: localhost:9893
> | FSSL_CTX_use_certificate_file failed.
> | 140100289985408:error:140AB18F:SSL routines:SSL_CTX_use_certificate:ee
> key too small:ssl/ssl_rsa.c:305:
> | Could not connect to the host: localhost:9893
>
> So it looks like the key in the test is too small.
>
> Sebastian
>

​Thank you for the patch.  It has been applied and merged into master
branch.
I've made another couple of commits​ to fix OpenSSL 1.1.0 deprecation
warnings.

spdylay end-to-end test (which failed above) require libevent which is also
built with OpenSSL 1.1.0.  But it seems the latest stable libevent does not
compile OpenSSL 1.1.0.  I guess that the above error "wrong version number"
could mean that libevent has been built with older OpenSSL version.

For key size issues, I renewed key pair, and now use 2048 bits public key
rather than 512 bits.

Best regards,
Tatsuhiro Tsujikawa

Bug#837960: spdylay: FTBFS with openssl 1.1.0

[Sebastian Andrzej Siewior]

Package: spdylay
Version: 1.3.2-2
Severity: important
Tags: patch
Control: block 827061 by -1
Control: user pkg-openssl-devel-requ...@lists.alioth.debian.org
Control: usertag -1 openssl-1.1-trans-keypkg
Control: usertag -1 openssl-1.1-trans

This package fails currently to compile against openssl 1.1.0 (currently
available in experimental). The issues look not openssl specific. The
full build of the build failure is available
  
https://breakpoint.cc/openssl-1.1-rebuild-2016-08-26/failed/spdylay_1.3.2-2_amd64-2016-08-26T19%3A47%3A25Z

With the patch attached is manages to build. The testsuite fails then :)
The SSL error message was obtained via ERR_print_errors_fp(stderr):

| =
|spdylay 1.3.2: tests/test-suite.log
| =
| 
| # TOTAL: 3
| # PASS:  2
| # SKIP:  0
| # XFAIL: 0
| # FAIL:  1
| # XPASS: 0
| # ERROR: 0
| 
| .. contents:: :depth: 2
| 
| FAIL: end_to_end.py
| ===
| 
| SSL_CTX_use_certificate_file failed.
| 140680762493824:error:140AB18F:SSL routines:SSL_CTX_use_certificate:ee key 
too small:ssl/ssl_rsa.c:305:
| Could not connect to the host: localhost:9893
| error:1408F10B:SSL routines:ssl3_get_record:wrong version number
| Could not connect to the host: localhost:79
| FCould not connect to the host: localhost:2
| .Could not connect to the host: localhost:9893
| Could not connect to the host: localhost:9893
| FCould not connect to the host: localhost:9893
| FCould not connect to the host: localhost:9893
| FSSL_CTX_use_certificate_file failed.
| 140100289985408:error:140AB18F:SSL routines:SSL_CTX_use_certificate:ee key 
too small:ssl/ssl_rsa.c:305:
| Could not connect to the host: localhost:9893

So it looks like the key in the test is too small.

Sebastian
>From 9e74d00a28bf3294722d07a52646a8b1a5740237 Mon Sep 17 00:00:00 2001
From: Sebastian Andrzej Siewior 
Date: Thu, 15 Sep 2016 20:01:49 +
Subject: [PATCH] spdylay: compile against openssl-1.1.0

It fails to compile against openssl 1.1.0 due to things like
|shrpx_client_handler.cc:90:30: error: 'strerror' was not declared in this scope
|shrpx_listen_handler.cc:112:32: error: 'memset' was not declared in this scope
|shrpx_listen_handler.cc:114:43: error: 'memcpy' was not declared in this scope

This resolves it.

Signed-off-by: Sebastian Andrzej Siewior 
---
 examples/spdycli.c  | 1 +
 src/shrpx.cc| 1 +
 src/shrpx_client_handler.cc | 1 +
 src/shrpx_listen_handler.cc | 1 +
 src/shrpx_ssl.cc| 2 +-
 5 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/examples/spdycli.c b/examples/spdycli.c
index 3874aa4..040ae82 100644
--- a/examples/spdycli.c
+++ b/examples/spdycli.c
@@ -39,6 +39,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
diff --git a/src/shrpx.cc b/src/shrpx.cc
index 65e9afd..f7bd742 100644
--- a/src/shrpx.cc
+++ b/src/shrpx.cc
@@ -41,6 +41,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
diff --git a/src/shrpx_client_handler.cc b/src/shrpx_client_handler.cc
index df6bb1c..e8db861 100644
--- a/src/shrpx_client_handler.cc
+++ b/src/shrpx_client_handler.cc
@@ -26,6 +26,7 @@
 
 #include 
 #include 
+#include 
 
 #include "shrpx_upstream.h"
 #include "shrpx_spdy_upstream.h"
diff --git a/src/shrpx_listen_handler.cc b/src/shrpx_listen_handler.cc
index aabd013..f5b8ac6 100644
--- a/src/shrpx_listen_handler.cc
+++ b/src/shrpx_listen_handler.cc
@@ -28,6 +28,7 @@
 #include 
 
 #include 
+#include 
 
 #include 
 
diff --git a/src/shrpx_ssl.cc b/src/shrpx_ssl.cc
index f712816..58753be 100644
--- a/src/shrpx_ssl.cc
+++ b/src/shrpx_ssl.cc
@@ -30,7 +30,7 @@
 #include 
 
 #include 
-#include 
+#include 
 
 #include 
 #include 
-- 
2.9.3