Bug#854327: pulseaudio: default configuration depends on consolekit

[Faidon Liambotis]

On Sat, Jul 08, 2017 at 02:35:05PM +0200, bert schulze wrote:
> 1. ConsoleKit is not maintained and recommends systemd-logind [1]

In the 3½ years since this bug was reported, ConsoleKit was removed from
Debian as "dead upstream", cf. #911416. It was not even part of buster.

I think the proper fix here would be... for Debian to not ship the
module at all :)

Faidon

Bug#854327: pulseaudio: default configuration depends on consolekit

[julien forest]

Maybe one should just change the default.pa as follows (not a real
diff but the + lines are just to add): 

.ifexists module-console-kit.so
+.nofail
load-module module-console-kit
+.fail
.endif


It suffices for me to make pulseaudio works without consolekit nor
systemd installed. 

Best regards, 

Julien

Bug#854327: pulseaudio: default configuration depends on consolekit

[bert schulze]

tag 854327 +patch
thanks

hi,

> The real fix is of course for consolekit module to exit gracefully if
> consolekit is not installed (the logind module does the same). But I
> have no idea how to do that. Would it be enough to check the dbus
> error name? I can't find a canonical list of error names though

I think it's a bad idea to load the module in the first place if it is
not supposed to be loaded at all.

As pulseaudio is *modular* why do we need to deliver the console-kit
module with pulseaudio itself in the first place?

The default.pa configuration uses ifdef style module loading, if the so
file is not present theres nothing to be loaded.

.ifexists module-console-kit.so
load-module module-console-kit
.endif

1. ConsoleKit is not maintained and recommends systemd-logind [1]

2. The majority of Debian users should be using systemd-logind now
where module-console-kit is being ignored.

3. Others like Felipe and me may neither use systemd nor console-kit
and will end up with PA not willing to load at all

4. Only users having ConsoleKit installed need the module.

=> split out the module into a pulseaudio-module-consolekit package
and add a Depends: consolekit

build and use-tested patch splitting out the console-kit module attached

bye

[1] https://www.freedesktop.org/wiki/Software/ConsoleKit/
diff -Nrup a/debian/control b/debian/control
--- a/debian/control	2017-06-15 10:07:30.0 +
+++ b/debian/control	2017-07-08 12:15:06.068749893 +
@@ -122,6 +122,19 @@ Description: PulseAudio ESD compatibilit
  many useful applications. It enables a PulseAudio sound server to
  fully replace ESD.
 
+Package: pulseaudio-module-consolekit
+Architecture: any
+Depends: ${shlibs:Depends}, ${misc:Depends}, consolekit (>= 0.4.6)
+Description: ConsoleKit module for PulseAudio sound server
+ PulseAudio, previously known as Polypaudio, is a sound server for POSIX and
+ WIN32 systems. It is a drop in replacement for the ESD sound server with
+ much better latency, mixing/re-sampling quality and overall architecture.
+ .
+ This module enables PulseAudio to dynamically give the current user access
+ to the soundcard(s) when using ConsoleKit user session switching.
+ .
+ The module is called module-console-kit.
+
 Package: pulseaudio-module-zeroconf
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}, avahi-daemon
diff -Nrup a/debian/pulseaudio-module-consolekit.install b/debian/pulseaudio-module-consolekit.install
--- a/debian/pulseaudio-module-consolekit.install	1970-01-01 00:00:00.0 +
+++ b/debian/pulseaudio-module-consolekit.install	2017-07-08 12:04:37.436752291 +
@@ -0,0 +1 @@
+usr/lib/pulse-*/modules/module-console-kit.so
diff -Nrup a/debian/pulseaudio.install b/debian/pulseaudio.install
--- a/debian/pulseaudio.install	2017-06-15 10:07:30.0 +
+++ b/debian/pulseaudio.install	2017-07-08 12:04:20.916752354 +
@@ -20,7 +20,6 @@ usr/lib/pulse-*/modules/librtp.so
 [linux-any] usr/lib/pulse-*/modules/module-alsa-sink.so
 [linux-any] usr/lib/pulse-*/modules/module-alsa-source.so
 usr/lib/pulse-*/modules/module-always-sink.so
-usr/lib/pulse-*/modules/module-console-kit.so
 usr/lib/pulse-*/modules/module-device-restore.so
 usr/lib/pulse-*/modules/module-echo-cancel.so
 usr/lib/pulse-*/modules/module-stream-restore.so


signature.asc
Description: PGP signature

Bug#854327: pulseaudio: default configuration depends on consolekit

[Felipe Sateler]

On Sun, Feb 19, 2017 at 7:17 PM, Michael Gilbert  wrote:
> control: tag -1 - moreinfo
>
> On Mon, Feb 6, 2017 at 8:07 AM, Felipe Sateler wrote:
>> module-console-kit does nothing when systemd-logind is detected. If
>> it's failing for you then you do not have systemd (or the -shim)
>> installed and running.
>
> You are correct, I do not have systemd installed on this system, but
> then again it's kfreebsd so I can't.  However, the only thing standing
> in the way of working pulseaudio on kfreebsd is this consolekit error,
> which as I suggest below can be worked around in a couple ways.

Heh, kfreebsd doesn't really count as "default configuration".

>
>>> To fix this, either the "load-module module-console-kit" line can be
>>> commented in /etc/pulse/default.pa.  Or the consolekit package can be
>>> installed, but there are a lot of setups where it's not needed or
>>> wanted.
>>
>> But if you are not using the default settings, you can surely also
>> modify pulseaudio's configuration?  Or are you suggesting we drop
>> consolekit support entirely?
>
> I should have worded that paragraph more clearly.  Those are just a
> couple workarounds that can be used while the bug exists.  I have not
> thought about how to fix the problem generally.

The real fix is of course for consolekit module to exit gracefully if
consolekit is not installed (the logind module does the same). But I
have no idea how to do that. Would it be enough to check the dbus
error name? I can't find a canonical list of error names though

-- 

Saludos,
Felipe Sateler

Bug#854327: pulseaudio: default configuration depends on consolekit

[Michael Gilbert]

control: tag -1 - moreinfo

On Mon, Feb 6, 2017 at 8:07 AM, Felipe Sateler wrote:
> module-console-kit does nothing when systemd-logind is detected. If
> it's failing for you then you do not have systemd (or the -shim)
> installed and running.

You are correct, I do not have systemd installed on this system, but
then again it's kfreebsd so I can't.  However, the only thing standing
in the way of working pulseaudio on kfreebsd is this consolekit error,
which as I suggest below can be worked around in a couple ways.

>> To fix this, either the "load-module module-console-kit" line can be
>> commented in /etc/pulse/default.pa.  Or the consolekit package can be
>> installed, but there are a lot of setups where it's not needed or
>> wanted.
>
> But if you are not using the default settings, you can surely also
> modify pulseaudio's configuration?  Or are you suggesting we drop
> consolekit support entirely?

I should have worded that paragraph more clearly.  Those are just a
couple workarounds that can be used while the bug exists.  I have not
thought about how to fix the problem generally.

Best wishes,
Mike

Bug#854327: pulseaudio: default configuration depends on consolekit

[Felipe Sateler]

Control: tags -1 moreinfo

On 5 February 2017 at 22:44, Michael Gilbert  wrote:
> package: pulseaudio
> severity: important
> version: 10.0-1
>
> Pulseaudio's default settings require the consolekit package to be
> installed, but the package has no relationship to consolekit.
>
> Without consolekit:
> $ pulseaudio
> [...]
> E: [pulseaudio] module.c: Failed to load module "module-console-kit"
> (argument: ""): initialization failed
> E: [pulseaudio] main.c: Module load failed.
> E: [pulseaudio] main.c: Failed to initialize daemon.


module-console-kit does nothing when systemd-logind is detected. If
it's failing for you then you do not have systemd (or the -shim)
installed and running.

> To fix this, either the "load-module module-console-kit" line can be
> commented in /etc/pulse/default.pa.  Or the consolekit package can be
> installed, but there are a lot of setups where it's not needed or
> wanted.

But if you are not using the default settings, you can surely also
modify pulseaudio's configuration? Or are you suggesting we drop
consolekit support entirely?

-- 

Saludos,
Felipe Sateler

Bug#854327: pulseaudio: default configuration depends on consolekit

[Michael Gilbert]

package: pulseaudio
severity: important
version: 10.0-1

Pulseaudio's default settings require the consolekit package to be
installed, but the package has no relationship to consolekit.

Without consolekit:
$ pulseaudio
[...]
E: [pulseaudio] module.c: Failed to load module "module-console-kit"
(argument: ""): initialization failed
E: [pulseaudio] main.c: Module load failed.
E: [pulseaudio] main.c: Failed to initialize daemon.

To fix this, either the "load-module module-console-kit" line can be
commented in /etc/pulse/default.pa.  Or the consolekit package can be
installed, but there are a lot of setups where it's not needed or
wanted.

Best wishes,
Mike