Bug#856474: stap: include runtime_defines.h not found

2017-03-06 Thread Jack Henschel
On 03/04/2017 10:24 AM, Ritesh Raj Sarraf wrote: > Thank you very much, Ben. I tested with your fix and it resolves the issue. Can confirm, the patch fixes it. Thank you Ben and Ritesh for your super quick actions! :-) Greetings Jack signature.asc Description: OpenPGP digital signature

Bug#856474: stap: include runtime_defines.h not found

2017-03-04 Thread Ritesh Raj Sarraf
On Sat, 2017-03-04 at 02:12 +, Ben Hutchings wrote: > On Sat, 2017-03-04 at 01:39 +, Ben Hutchings wrote: > [...] > > I investigated this and found that it occurs when the kernel source and > > object trees are separate (an "out-of-tree" build, not to be confused > > with out-of-tree

Bug#856474: stap: include runtime_defines.h not found

2017-03-03 Thread Jack Henschel
On Sat, 04 Mar 2017 01:39:58 + Ben Hutchings wrote: > So my fix is to delete quotes before checking for the exclusions: Wow Ben, that was a really quick fix! I'll test it on Monday and report back. signature.asc Description: OpenPGP digital signature

Bug#856474: stap: include runtime_defines.h not found

2017-03-03 Thread Ben Hutchings
On Sat, 2017-03-04 at 01:39 +, Ben Hutchings wrote: [...] > I investigated this and found that it occurs when the kernel source and > object trees are separate (an "out-of-tree" build, not to be confused > with out-of-tree modules).  We separate them in Debian kernel header > packages to avoid

Bug#856474: stap: include runtime_defines.h not found

2017-03-03 Thread Ben Hutchings
Control: tag -1 upstream patch On Fri, 03 Mar 2017 23:10:56 +0530 Ritesh Raj Sarraf wrote: [...] > Dear (Linux) Kernel Team: >  > We currently have systemtap 3.0 in Debian testing  where this problem was > reported. >  > In Experimental, I have also pushed the 3.1 release. The

Bug#856474: stap: include runtime_defines.h not found

2017-03-03 Thread Gerald Turner
I modified systemtap buildrun.cxx so that the Makefile it produces during Pass 3 doesn't have quotes around the include path, i.e.: Before: EXTRA_CFLAGS += -I"/usr/share/systemtap/runtime" After: EXTRA_CFLAGS += -I/usr/share/systemtap/runtime Then stap works fine against the Debian

Bug#856474: stap: include runtime_defines.h not found

2017-03-03 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Control: reassign -1 linux Assigning it to the kernel team. In this bug report, we have 2 confirmations of systemtap working fine with non- Debian build Linux kernel (upstream kernel from Linus's tree built with the bindeb-pkg make target)

Bug#856474: stap: include runtime_defines.h not found

2017-03-03 Thread Jack Henschel
Can confirm, the stable kernel (compiled directly from kernel.org) works just fine (along with the included packaging) with SystemTap 3.1 from Debian experimental: $ stap -V Systemtap translator/driver (version 3.1/0.168, Debian version 3.1-1 (experimental)) Copyright (C) 2005-2017 Red Hat,

Bug#856474: stap: include runtime_defines.h not found

2017-03-03 Thread Frank Ch. Eigler
Hi - On Thu, Mar 02, 2017 at 01:25:03PM -0800, Gerald Turner wrote: > FWIW, I attempted to kludge around the mangled include argument by > running stap with "-B 'EXTRA_CFLAGS += -I/usr/share/systemtap/runtime'". > This seems to work around the compilation failure of missing > runtime_defines.h in

Bug#856474: stap: include runtime_defines.h not found

2017-03-03 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Gerald, On Thu, 2017-03-02 at 13:25 -0800, Gerald Turner wrote: > FWIW, I attempted to kludge around the mangled include argument by > running stap with "-B 'EXTRA_CFLAGS += -I/usr/share/systemtap/runtime'". > This seems to work around the

Bug#856474: stap: include runtime_defines.h not found

2017-03-02 Thread Gerald Turner
FWIW, I attempted to kludge around the mangled include argument by running stap with "-B 'EXTRA_CFLAGS += -I/usr/share/systemtap/runtime'". This seems to work around the compilation failure of missing runtime_defines.h in include path, however compiliation then fails due to what appears to be API

Bug#856474: stap: include runtime_defines.h not found

2017-03-02 Thread Jack Henschel
On 03/02/2017 06:40 PM, Ritesh Raj Sarraf wrote: > I just pushed 3.1 to Experimental, the reason being 3.0 is going to be useless > for Debian Stretch. We need 3.1 to get it working proper with 4.9 kernel too. Did I get that right: you are planning to ship SystemTap 3.1 with Stretch? (If so:

Bug#856474: stap: include runtime_defines.h not found

2017-03-02 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Control: severity -1 grave Control: tag -1 +help On Thu, 2017-03-02 at 14:37 +0530, Ritesh Raj Sarraf wrote: > > > Also I can confirm this not an issue with the _packaging_ of systemtap in > > Debian, > > I downloaded and compiled the latest

Bug#856474: stap: include runtime_defines.h not found

2017-03-02 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Wed, 2017-03-01 at 19:48 +0100, Jack Henschel wrote: > I mentioned that in one of my earlier mails (#22). Sorry about that. I completely missed that one. There's also another odd thing I noticed. ``` -

Bug#856474: stap: include runtime_defines.h not found

2017-03-01 Thread Jack Henschel
On 03/01/2017 06:44 PM, Ritesh Raj Sarraf wrote: > Thanks to hints from Frank, I can see the culprit now. > > -Werror > -I/usr/src/linux-headers-4.9.0-2-common/"/usr/share/systemtap/runtime" > -DMODULE > > > The full compile command is: > >gcc-6 >

Bug#856474: stap: include runtime_defines.h not found

2017-03-01 Thread Ritesh Raj Sarraf
On Wed, 2017-03-01 at 12:30 -0500, Frank Ch. Eigler wrote: > Hi - > > > [...]  Running in verbose mode, it shows: [...]  Those paths are > > provided by the linux-headers-xxx-amd64 (or equivalent arch) > > package. In Debian, build/ and source/ paths are pointing to > > separate locations,

Bug#856474: stap: include runtime_defines.h not found

2017-03-01 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Thanks to hints from Frank, I can see the culprit now. - -Werror -I/usr/src/linux-headers-4.9.0-2-common/"/usr/share/systemtap/runtime" -DMODULE The full compile command is: gcc-6

Bug#856474: stap: include runtime_defines.h not found

2017-03-01 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 This is specific to the linux-headers package and has nothing to do with systemtap. Please ignore this one. On Wed, 2017-03-01 at 22:56 +0530, Ritesh Raj Sarraf wrote: > Running in verbose mode, it shows: > > test -e include/generated/autoconf.h

Bug#856474: stap: include runtime_defines.h not found

2017-03-01 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Wed, 2017-03-01 at 12:07 -0500, Frank Ch. Eigler wrote: > We've received intermittent reports of this sort of thing happening on > a few non-RH platforms.  A common element seemed to be some > nonstandard kernel build tree environment - some sort

Bug#856474: stap: include runtime_defines.h not found

2017-03-01 Thread Frank Ch. Eigler
Hi - > [...] Running in verbose mode, it shows: [...] Those paths are > provided by the linux-headers-xxx-amd64 (or equivalent arch) > package. In Debian, build/ and source/ paths are pointing to > separate locations, provided by separate package. [...] Could you provide a make V=1 transcript

Bug#856474: stap: include runtime_defines.h not found

2017-03-01 Thread Ritesh Raj Sarraf
Hello Frank, We have this bug report in Debian, where systemtap is looking for a local header file rather than using the system provided one (provided by the systemtap-common package). The translate.cxx file writes the code. This looks like deliberately done, under certain conditions. I am not

Bug#856474: stap: include runtime_defines.h not found

2017-03-01 Thread Frank Ch. Eigler
Hi - > I have been able to reproduce this on a Debian kernel. > [...] > /tmp/stapUHT1si/stap_7ef754ea40ea0990a9bfaf74753e8a9d_1538_src.c:10:29: fatal > error: runtime_defines.h: No such file or directory >  #include "runtime_defines.h" >  ^ > compilation terminated. >

Bug#856474: stap: include runtime_defines.h not found

2017-03-01 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Control: tag -1 +confirmed -moreinfo On Wed, 2017-03-01 at 18:58 +0530, Ritesh Raj Sarraf wrote: > But in my logs, runtime_defines.h is properly detected. I'll try to run the > command on a Debian kernel to verify if it is broken or not. I have

Bug#856474: stap: include runtime_defines.h not found

2017-03-01 Thread Jack Henschel
> Ritesh Raj Sarraf hat am 1. März 2017 um 14:28 geschrieben: > That file is provided by the systemtap-common package, which is properly > marked > as a Depends for systemtap. I know, the package is installed and the files are present: $ find /usr/share/systemtap/ -iname

Bug#856474: stap: include runtime_defines.h not found

2017-03-01 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Control: tag -1 +moreinfo On Wed, 2017-03-01 at 13:53 +0100, Jack Henschel wrote: > after I set up systemtap, I ran the example command provided in the > documentation: >

Bug#856474: stap: include runtime_defines.h not found

2017-03-01 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Wed, 2017-03-01 at 18:58 +0530, Ritesh Raj Sarraf wrote: > But in my logs, runtime_defines.h is properly detected. I'll try to run the > command on a Debian kernel to verify if it is broken or not. Forgot to add the log. ``` rrs@learner:/tmp$

Bug#856474: stap: include runtime_defines.h not found

2017-03-01 Thread Jack Henschel
Package: systemtap Version: 3.0-7 Severity: normal Tags: stretch Hi, after I set up systemtap, I ran the example command provided in the documentation: https://sourceware.org/systemtap/SystemTap_Beginners_Guide/using-systemtap.html#testing > stap -v -e 'probe vfs.read {printf("read