Bug#889042: lintian: Do not use dot as a separator in build profile names
Javier, > > I still do not understand your unnecessary antagonism towards me (or > > anyone) here, > > I will not explain side issues here because this report is meant for > lintian. Fair enough. I was therefore wondering whether you also saw: > > if you no longer believe this is a bug please go ahead and > > close it. Thanks in advance. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#889042: lintian: Do not use dot as a separator in build profile names
El ds 13 de 10 de 2018 a les 08:52 +0100, Chris Lamb va escriure: > I still do not understand your unnecessary antagonism towards me (or > anyone) here, I will not explain side issues here because this report is meant for lintian. smime.p7s Description: S/MIME cryptographic signature
Bug#889042: lintian: Do not use dot as a separator in build profile names
Javier, > > > I do my job. Your position regarding humankind is > > > established already. > > > > Sorry, I don't understand your response - can you elaborate? > > Why? No one wants to hear it. So, let me go back to work. I still do not understand your unnecessary antagonism towards me (or anyone) here, but regardless if you no longer believe this is a bug please go ahead and close it. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#889042: lintian: Do not use dot as a separator in build profile names
El dv 13 de 07 de 2018 a les 10:18 +0100, Chris Lamb va escriure: > > I do my job. Your position regarding humankind is > > established already. > > Sorry, I don't understand your response - can you elaborate? Why? No one wants to hear it. So, let me go back to work. smime.p7s Description: S/MIME cryptographic signature
Bug#889042: lintian: Do not use dot as a separator in build profile names
Dear Javier, > I can see through your polite answer. > > I do my job. Your position regarding humankind is established already. Sorry, I don't understand your response - can you elaborate? Best wishes, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#889042: lintian: Do not use dot as a separator in build profile names
I can see through your polite answer. I do my job. Your position regarding humankind is established already. smime.p7s Description: S/MIME cryptographic signature
Bug#889042: lintian: Do not use dot as a separator in build profile names
Hi Javier, > Control: tags -1 patch > > Fix works on 2.5.50.4. This patch is for 2.5.92. Thanks for the patch! :) However, I think we would like to see some resolution to #757760 (or similar) as Mattia outlines in: https://bugs.debian.org/889042#25 .. before we merge it. :) Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#889042: lintian: Do not use dot as a separator in build profile names
Control: tags -1 patch
Fix works on 2.5.50.4. This patch is for 2.5.92.Bug-Debian: https://bugs.debian.org/889042
Index: lintian-2.5.92/checks/control-file.desc
===
--- lintian-2.5.92.orig/checks/control-file.desc
+++ lintian-2.5.92/checks/control-file.desc
@@ -285,7 +285,7 @@ Info: The restriction formula in Build-P
"noudeb",
"stage1",
"stage2"
- and "pkg.srcpkg.anything".
+ and "pkg/srcpkg/anything".
Ref: https://wiki.debian.org/BuildProfileSpec#Registered_profile_names
Tag: multiline-architecture-field
Index: lintian-2.5.92/checks/control-file.pm
===
--- lintian-2.5.92.orig/checks/control-file.pm
+++ lintian-2.5.92/checks/control-file.pm
@@ -364,7 +364,7 @@ sub run {
tag 'invalid-profile-name-in-build-profiles-field',
$profile, $bin
unless $KNOWN_BUILD_PROFILES->known($profile)
- or $profile =~ /^pkg\.[a-z0-9][a-z0-9+.-]+\../;
+ or $profile =~ /^pkg\/[a-z0-9][a-z0-9+.-]+\/./;
}
}
}
Index: lintian-2.5.92/checks/fields.desc
===
--- lintian-2.5.92.orig/checks/fields.desc
+++ lintian-2.5.92/checks/fields.desc
@@ -669,7 +669,7 @@ Info: The restriction formula in the sou
"noudeb",
"stage1",
"stage2"
- and "pkg.srcpkg.anything".
+ and "pkg/srcpkg/anything".
Ref: https://wiki.debian.org/BuildProfileSpec#Registered_profile_names
Tag: build-depends-on-build-essential-package-without-using-version
Index: lintian-2.5.92/checks/fields.pm
===
--- lintian-2.5.92.orig/checks/fields.pm
+++ lintian-2.5.92/checks/fields.pm
@@ -1097,7 +1097,7 @@ sub run {
tag 'invalid-profile-name-in-source-relation',
"$prof [$field: $part_d_orig]"
unless $KNOWN_BUILD_PROFILES->known($prof)
- or $prof =~ /^pkg\.[a-z0-9][a-z0-9+.-]+\../;
+ or $prof =~ /^pkg\/[a-z0-9][a-z0-9+.-]+\/./;
}
}
Index: lintian-2.5.92/t/tests/fields-build-profiles-general/debian/debian/control.in
===
--- lintian-2.5.92.orig/t/tests/fields-build-profiles-general/debian/debian/control.in
+++ lintian-2.5.92/t/tests/fields-build-profiles-general/debian/debian/control.in
@@ -5,7 +5,7 @@ Maintainer: {$author}
Standards-Version: {$standards_version}
Build-Depends: {$build_depends},
big , bpfail1 ,
- bpcomplicated
+ bpcomplicated
Rules-Requires-Root: no
Package: {$source}-wrong-syntax
@@ -23,7 +23,7 @@ Description: {$description} (wrong synta
Package: {$source}-unknown-profile
Architecture: {$architecture}
Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
-Build-Profiles:
+Build-Profiles:
Description: {$description} (unknown profile)
Check for unknown profile names
.
smime.p7s
Description: S/MIME cryptographic signature
Bug#889042: lintian: Do not use dot as a separator in build profile names
El dv 02 de 02 de 2018 a les 06:50 +0100, Helmut Grohne va escriure: > A > different solution (without requiring any package to change) would be to > forbid dots in $anything. This would break profiles with dots in $anything and it is less flexible. > Yes, Javier asked me on irc, but I didn't ack the change. [11:33] guillem: feel free to fix it [11:33] I don't think it is worth the effort [11:33] or rather *my* effort ;) > So I state that: > 1. I don't think this is worth fixing. But you do not oppose. > 2. There is an alternative and simpler fix available. => No consensus. Replied above. > 3. The idea of changing the separator is not completely insane, but the >cost of performing it is very high. sed -e "s#pkg.$sourcepackage.#pkg/$sourcepackage/#g" > 4. You don't drive the discussion by filing bugs at lintian. Yesterday: [12:38] guillem: I'll fix #889042 someday. There is no further discussion on #debian-bootstrap. > 5. Discussion this has already wasted too much time better spent on >fixing real bugs. Can we stop it now? I did not request your participation, feel free to stop. smime.p7s Description: S/MIME cryptographic signature
Bug#889042: lintian: Do not use dot as a separator in build profile names
On Thu, Feb 01, 2018 at 06:21:00PM +, Niels Thykier wrote: > >> Please switch the dot to a suitable character, such as slash, in > >> pkg.$sourcepackage.$anything build profile names, since dot is a valid > >> character in package names. I acknowledge that this is a weakness of the namespacing mechanism. A different solution (without requiring any package to change) would be to forbid dots in $anything. Yes, Javier asked me on irc, but I didn't ack the change. I said that I don't think it is worth fixing. When Guillem vaguely jumped in favour, I said that he could drive the discussion forward. > Regarding the proposal: Lintian is not the one deciding the namespace > rules for build-profiles. We only emit tags based on the existing > guidelines/namespace rules (https://wiki.debian.org/BuildProfileSpec). > I have CC'ed Helmut as he is more involved in the build-profiles work. I think we'd certainly need Joschs input. So I state that: 1. I don't think this is worth fixing. 2. There is an alternative and simpler fix available. => No consensus. 3. The idea of changing the separator is not completely insane, but the cost of performing it is very high. Look, we still use DEB_STAGE (15 packages) and DEB_BUILD_PROFILE (13 packages) in unstable. 4. You don't drive the discussion by filing bugs at lintian. 5. Discussion this has already wasted too much time better spent on fixing real bugs. Can we stop it now? Helmut
Bug#889042: lintian: Do not use dot as a separator in build profile names
El dj 01 de 02 de 2018 a les 22:16 +0100, Mattia Rizzolo va escriure: > Or at least until https://wiki.debian.org/BuildProfileSpec is amended > and somebody from the relevant group of people (Helmut, Josch, Guillem > comes to my mind) ACKs it. Missatge reenviat De: Javier Serrano Polo Per a: 889...@bugs.debian.org Data: Thu, 01 Feb 2018 20:05:19 +0100 We had some words at #debian-bootstrap. Helmut agrees. I will fix this someday. smime.p7s Description: S/MIME cryptographic signature
Bug#889042: lintian: Do not use dot as a separator in build profile names
On Thu, Feb 01, 2018 at 06:21:00PM +, Niels Thykier wrote: > Regarding the proposal: Lintian is not the one deciding the namespace > rules for build-profiles. We only emit tags based on the existing > guidelines/namespace rules (https://wiki.debian.org/BuildProfileSpec). > I have CC'ed Helmut as he is more involved in the build-profiles work. That's why I believe this bug should be closed as wontfix, until a clear policy is set upon. For example until something good comes out of policy's bug #757760. Or at least until https://wiki.debian.org/BuildProfileSpec is amended and somebody from the relevant group of people (Helmut, Josch, Guillem comes to my mind) ACKs it. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#889042: lintian: Do not use dot as a separator in build profile names
We had some words at #debian-bootstrap. Helmut agrees. I will fix this someday. smime.p7s Description: S/MIME cryptographic signature
Bug#889042: lintian: Do not use dot as a separator in build profile names
Chris Lamb: > tags 889042 + moreinfo > thanks > > Hi Javier, > >> Please switch the dot to a suitable character, such as slash, in >> pkg.$sourcepackage.$anything build profile names, since dot is a valid >> character in package names. > > Unless I'm missing something obvious, Lintian does not generate these > files...? > > > Regards, > @lamby: It is a build-profile (not a file). As used in e.g. the Build-Profiles field in d/control. Regarding the proposal: Lintian is not the one deciding the namespace rules for build-profiles. We only emit tags based on the existing guidelines/namespace rules (https://wiki.debian.org/BuildProfileSpec). I have CC'ed Helmut as he is more involved in the build-profiles work. Thanks, ~Niels
Bug#889042: lintian: Do not use dot as a separator in build profile names
tags 889042 + moreinfo thanks Hi Javier, > Please switch the dot to a suitable character, such as slash, in > pkg.$sourcepackage.$anything build profile names, since dot is a valid > character in package names. Unless I'm missing something obvious, Lintian does not generate these files...? Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#889042: lintian: Do not use dot as a separator in build profile names
Package: lintian Version: 2.5.72 Severity: wishlist Please switch the dot to a suitable character, such as slash, in pkg.$sourcepackage.$anything build profile names, since dot is a valid character in package names. smime.p7s Description: S/MIME cryptographic signature
