Bug#890721: flatpak: FTBFS with glibc 2.27: error: static declaration of 'copy_file_range' follows non-static declaration

[Simon McVittie]

Version: 0.11.3-1

On Mon, 19 Feb 2018 at 09:53:14 +, Simon McVittie wrote:
> flatpak 0.11.0 has the upstream fix that you described, so this is
> certainly fixed in experimental.

Just to make sure, I built the version I'm about to upload against glibc
2.27 and it seems fine. I'll do the same check for 0.10.4 shortly.

smcv

Bug#890721: flatpak: FTBFS with glibc 2.27: error: static declaration of 'copy_file_range' follows non-static declaration

[Simon McVittie]

Control: tags -1 + confirmed moreinfo

On Sat, 17 Feb 2018 at 23:57:48 +0100, Aurelien Jarno wrote:
> flatpak 0.10.3-1 (and version 0.10.4-1 currently in sid) fails to build
> with glibc 2.27 (2.27-0experimental0 from experimental)

Did you test 0.10.4-1 unsuccessfully, or is that based on extrapolation
from 0.10.3-1? I can confirm that 0.10.3-1 FTBFS in the way you described,
but 0.10.4-1 builds OK for me with glibc 2.27-0experimental0.

> glibc 2.27 added support for copy_file_range. Unfortunately flatpak,
> or rather the included libglnx library, also has such a function to
> wrap the corresponding syscall.
> 
> The issue has already been fixed upstream in commit 3e16d4ef with an
> update of the libglnx submodule. The corresponding libglnx commit is
> 4577dc82.

flatpak 0.11.0 has the upstream fix that you described, so this is
certainly fixed in experimental.

flatpak 0.10.4 has commit 084164a20ad2ea5a02ed7e9a915cb3539a8828ba
which is meant to fix copy_file_range detection with the older libglnx
submodule: . So I believe
this should also be fixed in unstable already?

Thanks,
smcv

Bug#890721: flatpak: FTBFS with glibc 2.27: error: static declaration of 'copy_file_range' follows non-static declaration

[Simon McVittie]

Control: tags -1 + fixed-upstream

On Sat, 17 Feb 2018 at 23:57:48 +0100, Aurelien Jarno wrote:
> flatpak 0.10.3-1 (and version 0.10.4-1 currently in sid) fails to build
> with glibc 2.27 (2.27-0experimental0 from experimental)
...
> The issue has already been fixed upstream in commit 3e16d4ef with an
> update of the libglnx submodule. The corresponding libglnx commit is
> 4577dc82.

Thanks, I'll look at patching this in after 0.10.4-1 migrates to testing,
which should happen next week (it needs to go through in lockstep with
xdg-desktop-portal 0.10, so I don't want to delay that migration more
than I have to).

smcv

Bug#890721: flatpak: FTBFS with glibc 2.27: error: static declaration of 'copy_file_range' follows non-static declaration

[Aurelien Jarno]

Package: flatpak
Version: 0.10.3-1
Severity: important
Tags: upstream
User: debian-gl...@lists.debian.org
Usertags: 2.27

flatpak 0.10.3-1 (and version 0.10.4-1 currently in sid) fails to build
with glibc 2.27 (2.27-0experimental0 from experimental):

| libtool: compile:  gcc -DHAVE_CONFIG_H -I. -DFLATPAK_BINDIR=\"/usr/bin\" 
-DFLATPAK_SYSTEMDIR=\"/var/lib/flatpak\" -DFLATPAK_CONFIGDIR=\"/etc/flatpak\" 
-DFLATPAK_BASEDIR=\"/usr/share/flatpak\" 
-DFLATPAK_TRIGGERDIR=\"/usr/share/flatpak/triggers\" 
-DSYSTEM_FONTS_DIR=\"/usr/share/fonts\" 
-DSYSTEM_FONT_CACHE_DIRS=\"/var/cache/fontconfig:/usr/lib/fontconfig/cache\" 
-DDBUSPROXY=\"/usr/lib/flatpak/flatpak-dbus-proxy\" -DG_LOG_DOMAIN=\"flatpak\" 
-I./libglnx -I./common -I./common -I./lib -I./lib -include config.h 
-DHELPER=\"bwrap\" -Wdate-time -D_FORTIFY_SOURCE=2 -fvisibility=hidden 
-DFLATPAK_COMPILATION -I./lib -I./lib -pipe -Wall -Werror=empty-body 
-Werror=strict-prototypes -Werror=missing-prototypes 
-Werror=implicit-function-declaration -Werror=format=2 -Werror=format-security 
-Werror=format-nonliteral -Werror=pointer-arith -Werror=init-self 
-Werror=missing-declarations -Werror=return-type -Werror=overflow 
-Werror=int-conversion -Werror=incompatible-pointer-types 
-Werror=misleading-indentation -Werror=missing-include-dirs -pthread 
-I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/libxml2 -pthread 
-I/usr/include/ostree-1 -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread 
-I/usr/include/libsoup-2.4 -I/usr/include/libxml2 -I/usr/include/glib-2.0 
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread 
-I/usr/include/json-glib-1.0 -I/usr/include/glib-2.0 
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g -O2 
-fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat 
-Werror=format-security -c lib/flatpak-enum-types.c  -fPIC -DPIC -o 
lib/.libs/libflatpak_la-flatpak-enum-types.o
| In file included from ./libglnx/glnx-missing.h:95:0,
|  from ./libglnx/libglnx.h:28,
|  from ./common/flatpak-utils.h:26,
|  from lib/flatpak-installed-ref.c:25:
| ./libglnx/glnx-missing-syscall.h:142:23: error: static declaration of 
'copy_file_range' follows non-static declaration
|  static inline ssize_t copy_file_range(int fd_in, loff_t *off_in,
|^~~
| In file included from /usr/include/glib-2.0/gio/gcredentials.h:32:0,
|  from /usr/include/glib-2.0/gio/gio.h:46,
|  from ./libglnx/libglnx.h:23,
|  from ./common/flatpak-utils.h:26,
|  from lib/flatpak-installed-ref.c:25:
| /usr/include/unistd.h:1110:9: note: previous declaration of 'copy_file_range' 
was here
|  ssize_t copy_file_range (int __infd, __off64_t *__pinoff,
|  ^~~
| In file included from ./libglnx/glnx-missing.h:95:0,
|  from ./libglnx/libglnx.h:28,
|  from ./common/flatpak-utils.h:26,
|  from lib/flatpak-related-ref.c:25:
| ./libglnx/glnx-missing-syscall.h:142:23: error: static declaration of 
'copy_file_range' follows non-static declaration
|  static inline ssize_t copy_file_range(int fd_in, loff_t *off_in,
|^~~
| In file included from /usr/include/glib-2.0/gio/gcredentials.h:32:0,
|  from /usr/include/glib-2.0/gio/gio.h:46,
|  from ./libglnx/libglnx.h:23,
|  from ./common/flatpak-utils.h:26,
|  from lib/flatpak-related-ref.c:25:
| /usr/include/unistd.h:1110:9: note: previous declaration of 'copy_file_range' 
was here
|  ssize_t copy_file_range (int __infd, __off64_t *__pinoff,
|  ^~~
| In file included from ./libglnx/glnx-missing.h:95:0,
|  from ./libglnx/libglnx.h:28,
|  from ./common/flatpak-utils.h:26,
|  from lib/flatpak-ref.c:23:
| ./libglnx/glnx-missing-syscall.h:142:23: error: static declaration of 
'copy_file_range' follows non-static declaration
|  static inline ssize_t copy_file_range(int fd_in, loff_t *off_in,
|^~~
| In file included from /usr/include/glib-2.0/gio/gcredentials.h:32:0,
|  from /usr/include/glib-2.0/gio/gio.h:46,
|  from ./libglnx/libglnx.h:23,
|  from ./common/flatpak-utils.h:26,
|  from lib/flatpak-ref.c:23:
| /usr/include/unistd.h:1110:9: note: previous declaration of 'copy_file_range' 
was here
|  ssize_t copy_file_range (int __infd, __off64_t *__pinoff,
|  ^~~
| In file included from ./libglnx/glnx-missing.h:95:0,
|  from ./libglnx/libglnx.h:28,
|  from ./common/flatpak-utils.h:26,
|  from lib/flatpak-remote.c:23:
| ./libglnx/glnx-missing-syscall.h:142:23: error: static declaration of 
'copy_file_range' follows non-st