Bug#983574:

[Nicholas Brown]

This is caused by the following backward incompatible change in GNU 4.3:

https://lists.gnu.org/archive/html/info-gnu/2020-01/msg4.html

* WARNING: Backward-incompatibility!
  Previously appending using '+=' to an empty variable would result in a
value
  starting with a space.  Now the initial space is only added if the
variable
  already contains some value.  Similarly, appending an empty string does
not
  add a trailing space.

Bug#983574:

[Nicholas Brown]

> It appears that commas are being replaced with dashes.
>
>
DEB_BUILD_OPTIONS="dpdk_config_options=-Duse_hpet=true,-Dmax_ethports=128,-Dmax_numa_nodes=8,-Ddisable_drivers=net/softnic"
> gbp buildpackage -uc -us
>
> dh_auto_configure --
>
-Duse_hpet=true-Dmax_ethports=128-Dmax_numa_nodes=8-Ddisable_drivers=net/softnic

Correction, the commas are not being replaced with dashes, but should have
been replaced with spaces.

Presumably due to this not working any more:
https://salsa.debian.org/debian/dpdk/-/blob/unstable/debian/rules#L41

Bug#983574: dpdk_config_options in DEB_BUILD_OPTIONS fails

[Nicholas Brown]

Package: dpdk
Version: unstable

The support for specifying dpdk_config_options in DEB_BUILD_OPTIONS fails
when building the unstable branch in a bullseye schroot.

It appears that commas are being replaced with dashes.

DEB_BUILD_OPTIONS="dpdk_config_options=-Duse_hpet=true,-Dmax_ethports=128,-Dmax_numa_nodes=8,-Ddisable_drivers=net/softnic"
gbp buildpackage -uc -us

dh_auto_configure --
-Duse_hpet=true-Dmax_ethports=128-Dmax_numa_nodes=8-Ddisable_drivers=net/softnic
\
--includedir=include/dpdk \
--default-library=shared \
-Dper_library_versions=false \
-Dinclude_subdir_arch=../x86_64-linux-gnu/dpdk \
-Dmachine="default"
install -d obj-x86_64-linux-gnu
cd obj-x86_64-linux-gnu && LC_ALL=C.UTF-8 meson .. --wrap-mode=nodownload
--buildtype=plain --prefix=/usr --sysconfdir=/etc --localstatedir=/var
--libdir=lib/x86_64-linux-gnu
-Duse_hpet=true-Dmax_ethports=128-Dmax_numa_nodes=8-Ddisable_drivers=net/softnic
--includedir=include/dpdk --default-library=shared
-Dper_library_versions=false -Dinclude_subdir_arch=../x86_64-linux-gnu/dpdk
-Dmachine=default
The Meson build system
Version: 0.56.2
Source dir: /home/brownn/dpdk
Build dir: /home/brownn/dpdk/obj-x86_64-linux-gnu
Build type: native build
Program cat found: YES (/bin/cat)

../meson.build:4:0: ERROR: Value
true-Dmax_ethports=128-Dmax_numa_nodes=8-Ddisable_drivers=net/softnic is
not boolean (true or false).

A full log can be found at
/home/brownn/dpdk/obj-x86_64-linux-gnu/meson-logs/meson-log.txt
cd obj-x86_64-linux-gnu && tail -v -n \+0 meson-logs/meson-log.txt
==> meson-logs/meson-log.txt <==
Build started at 2021-02-26T15:25:29.485465
Main binary: /usr/bin/python3
Build Options:
-Duse_hpet=true-Dmax_ethports=128-Dmax_numa_nodes=8-Ddisable_drivers=net/softnic
-Dper_library_versions=false -Dinclude_subdir_arch=../x86_64-linux-gnu/dpdk
-Dmachine=default -Dprefix=/usr -Dincludedir=include/dpdk
-Dlibdir=lib/x86_64-linux-gnu -Dlocalstatedir=/var -Dsysconfdir=/etc
-Dbuildtype=plain -Ddefault_library=shared -Dwrap_mode=nodownload
Python system: Linux
The Meson build system
Version: 0.56.2
Source dir: /home/brownn/dpdk
Build dir: /home/brownn/dpdk/obj-x86_64-linux-gnu
Build type: native build
Program cat found: YES (/bin/cat)
Running command: /bin/cat /home/brownn/dpdk/VERSION
--- stdout ---
20.11.0

--- stderr ---



../meson.build:4:0: ERROR: Value
true-Dmax_ethports=128-Dmax_numa_nodes=8-Ddisable_drivers=net/softnic is
not boolean (true or false).
dh_auto_configure: error: cd obj-x86_64-linux-gnu && LC_ALL=C.UTF-8 meson
.. --wrap-mode=nodownload --buildtype=plain --prefix=/usr --sysconfdir=/etc
--localstatedir=/var --libdir=lib/x86_64-linux-gnu
-Duse_hpet=true-Dmax_ethports=128-Dmax_numa_nodes=8-Ddisable_drivers=net/softnic
--includedir=include/dpdk --default-library=shared
-Dper_library_versions=false -Dinclude_subdir_arch=../x86_64-linux-gnu/dpdk
-Dmachine=default returned exit code 1
make[1]: *** [debian/rules:83: override_dh_auto_configure] Error 25