Re: Boot regression in Linux v6.4-rc3

2023-05-31 Thread Luis Chamberlain
On Wed, May 31, 2023 at 11:16 AM Frank Scheiner wrote: > Looking forward to the next occasion - for your sake maybe on another > architecture, but can't promise... ;-) I think it would be prudent for Song to also ask you to test his future upcoming modules patches on ia64 given how hard it is to

Re: Boot regression in Linux v6.4-rc3

2023-05-31 Thread Frank Scheiner
On 31.05.23 21:14, Luis Chamberlain wrote: On Wed, May 31, 2023 at 11:16 AM Frank Scheiner wrote: Looking forward to the next occasion - for your sake maybe on another architecture, but can't promise... ;-) I think it would be prudent for Song to also ask you to test his future upcoming

Re: Boot regression in Linux v6.4-rc3

2023-05-31 Thread Frank Scheiner
Hi Linus, hi Song, On 29.05.23 00:46, Song Liu wrote: [...] Thanks for running the test! I will send the official patch. Thanks, Song With the fix merged and to conclude this, I'd like to add that it was a pleasure to work with you on this problem, although I didn't do much. Looking

Re: Boot regression in Linux v6.4-rc3

2023-05-30 Thread Konstantin Ryabitsev
On Tue, May 30, 2023 at 05:04:56PM -0400, Linus Torvalds wrote: > On Tue, May 30, 2023 at 4:21 PM Konstantin Ryabitsev > wrote: > > > > We only add things to lore when someone asks, and nobody's asked. :) I guess > > I'll consider this an ask and put it on the radar. > > Thanks. It would

Re: Boot regression in Linux v6.4-rc3

2023-05-30 Thread Linus Torvalds
On Tue, May 30, 2023 at 4:21 PM Konstantin Ryabitsev wrote: > > We only add things to lore when someone asks, and nobody's asked. :) I guess > I'll consider this an ask and put it on the radar. Thanks. It would probably be good to see if there are any other vger.kernel.org lists with any

Re: Boot regression in Linux v6.4-rc3

2023-05-30 Thread Konstantin Ryabitsev
On Sat, May 27, 2023 at 10:08:24AM -0700, Linus Torvalds wrote: > This does make it clear just how great a mailing list archive lore is. > Konstantin, is there any particular reason why > linux-i...@vger.kernel.org isn't in lore? Is it just a rational hatred > of all things itanium? We only add

Re: Boot regression in Linux v6.4-rc3

2023-05-28 Thread Song Liu
On Sun, May 28, 2023 at 1:10 AM Frank Scheiner wrote: > > Hi again, > > On 28.05.23 09:30, Frank Scheiner wrote: > > [...] > > Thanks, that patch (as -patch4 on top of v6.4-rc3) fixes the boot > > regression for me on the rx2620: > > > > [...] > > > > Great! I'll give it a try on my rx2800-i2,

Re: Boot regression in Linux v6.4-rc3

2023-05-28 Thread John Paul Adrian Glaubitz
Hi! On Sun, 2023-05-28 at 09:30 +0200, Frank Scheiner wrote: > > Frank, could you please give it a try? > > > > Thanks, > > Song > > > > diff --git i/kernel/module/main.c w/kernel/module/main.c > > index 0f9183f1ca9f..e4e723e1eb21 100644 > > --- i/kernel/module/main.c > > +++

Re: Boot regression in Linux v6.4-rc3

2023-05-28 Thread Frank Scheiner
Hi again, On 28.05.23 09:30, Frank Scheiner wrote: [...] Thanks, that patch (as -patch4 on top of v6.4-rc3) fixes the boot regression for me on the rx2620: [...] Great! I'll give it a try on my rx2800-i2, too, but assume it wil work there, too. Indeed, -patch4 also makes it work on the

Re: Boot regression in Linux v6.4-rc3

2023-05-28 Thread Frank Scheiner
Hi Song, Linus, On 28.05.23 07:24, Song Liu wrote: AFAICT, .got should go to rodata, while .sdata and .sbss should go to (rw)data. However, reading the code before the module_memory change, I think they were all copied to (rw)data, which is not ideal but most likely OK. To match the behavior

Re: Boot regression in Linux v6.4-rc3

2023-05-27 Thread Song Liu
On Sat, May 27, 2023 at 12:34 PM Linus Torvalds wrote: > > On Sat, May 27, 2023 at 11:41 AM Frank Scheiner wrote: > > > > Ok, I put the decoded console messages on [2]. > > > > [2]: https://pastebin.com/dLYMijfS > > Ugh. Apparently ia64 decoding isn't great. But at least it gives > multiple line

Re: Boot regression in Linux v6.4-rc3

2023-05-27 Thread Frank Scheiner
Hi, On 27.05.23 21:34, Linus Torvalds wrote: On Sat, May 27, 2023 at 11:41 AM Frank Scheiner wrote: Ok, I put the decoded console messages on [2]. [2]: https://pastebin.com/dLYMijfS Ugh. Apparently ia64 decoding isn't great. But at least it gives multiple line numbers: load_module

Re: Boot regression in Linux v6.4-rc3

2023-05-27 Thread Linus Torvalds
On Sat, May 27, 2023 at 11:41 AM Frank Scheiner wrote: > > Ok, I put the decoded console messages on [2]. > > [2]: https://pastebin.com/dLYMijfS Ugh. Apparently ia64 decoding isn't great. But at least it gives multiple line numbers: load_module (kernel/module/main.c:2291

Re: Boot regression in Linux v6.4-rc3

2023-05-27 Thread Frank Scheiner
Hi, On 27.05.23 19:08, Linus Torvalds wrote: Anyway, the WARN_ON() is likely related, but the bug is clearly an unexpected page fault in __copy_user() when called by load_module(). The ia64 oops output is nasty, presumably because ia64 aggressively inlines things. It would help a lot if you

Re: Boot regression in Linux v6.4-rc3

2023-05-27 Thread Linus Torvalds
On Sat, May 27, 2023 at 12:01 AM Frank Scheiner wrote: > > If it is of any help, my initial report is available for example via: > > https://marc.info/?l=linux-ia64=168509859125505=2 > > ...the whole thread is currently at: > > https://marc.info/?t=16850986823=1=2 This does make it clear

Re: Boot regression in Linux v6.4-rc3

2023-05-27 Thread Frank Scheiner
On 27.05.23 00:22, Linus Torvalds wrote: [...] But this is my "monkey see, monkey do" pattern matching reaction, not from any deeper understanding of the problem (I can't even see the report) or really even the code. If it is of any help, my initial report is available for example via:

Re: Boot regression in Linux v6.4-rc3

2023-05-27 Thread Frank Scheiner
Hi, On 26.05.23 23:01, Song Liu wrote: Thanks for running the test. Thanks for staying with me. I am not very familiar with the code, but I think we shouldn't hit that WARN_ON_ONCE. Could you please try with the follow patch to see which section caused this issue? Thanks, Song diff --git

Re: Boot regression in Linux v6.4-rc3

2023-05-26 Thread Luis Chamberlain
On Fri, May 26, 2023 at 12:55:14PM +0200, Frank Scheiner wrote: > Dear all, > > there is a boot regression in effect in Linux v6.4-rc3 that affects at > least: > > * rx2620 (w/2 x Montecito and zx1) > * rx2800-i2 (w/1 x Tukwila) Jesus, ia64 is even dropped from qemu as of 2.11. We're now around

Re: Boot regression in Linux v6.4-rc3

2023-05-26 Thread Song Liu
On Fri, May 26, 2023 at 3:22 PM Linus Torvalds wrote: > > On Fri, May 26, 2023 at 2:59 PM Luis Chamberlain wrote: > > > > Not saying that debugging commit ac3b4328392344 ("module: replace > > module_layout with module_memory") is going to be impossible, quite > > the contrary I think it would be

Re: Boot regression in Linux v6.4-rc3

2023-05-26 Thread Linus Torvalds
On Fri, May 26, 2023 at 2:59 PM Luis Chamberlain wrote: > > Not saying that debugging commit ac3b4328392344 ("module: replace > module_layout with module_memory") is going to be impossible, quite > the contrary I think it would be good to root cause it, if possible, > as perhaps it may also be

Re: Boot regression in Linux v6.4-rc3

2023-05-26 Thread Song Liu
On Fri, May 26, 2023 at 11:36 AM Frank Scheiner wrote: > > Hi Song, > > On 26.05.23 18:49, Song Liu wrote: > > Hi Frank, > > > > Thanks for the report. > > Sure, thanks for your help in this. > > > It seems the error happened during the WARN_ON_ONCE. Could you > > please try whether something

Re: Boot regression in Linux v6.4-rc3

2023-05-26 Thread Frank Scheiner
Hi Song, On 26.05.23 18:49, Song Liu wrote: Hi Frank, Thanks for the report. Sure, thanks for your help in this. It seems the error happened during the WARN_ON_ONCE. Could you please try whether something like the following fixes it? diff --git i/kernel/module/main.c

Re: Boot regression in Linux v6.4-rc3

2023-05-26 Thread Song Liu
Hi Frank, Thanks for the report. On Fri, May 26, 2023 at 3:55 AM Frank Scheiner wrote: > > Dear all, > > there is a boot regression in effect in Linux v6.4-rc3 that affects at > least: > > * rx2620 (w/2 x Montecito and zx1) > * rx2800-i2 (w/1 x Tukwila) > > ...(see second part of [1] and