Bug#785707: Add USB support for APM Mustang

2015-06-01 Thread Steve McIntyre 
On Sat, May 23, 2015 at 11:45:15AM +0100, Ian Campbell wrote:
On Sat, 2015-05-23 at 11:42 +0100, Ian Campbell wrote:
 Including a v3 which is slightly different to what has been posted here
[...]
 So that's the one I intend to apply

Looks like Ben a) already spotted there was a v3 and b) committed it to
svn for both Sid and Jessie already, so I shall be doing no such thing!

Yay! :-)

(Belatedly) tested and working for me - my Mustang happily talks USB
now \o/.

-- 
Steve McIntyre, Cambridge, UK.st...@einval.com
I suspect most samba developers are already technically insane... Of
 course, since many of them are Australians, you can't tell. -- Linus Torvalds


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20150601120113.ga18...@einval.com

Bug#785707: Add USB support for APM Mustang

2015-05-23 Thread Ian Campbell 
On Sat, 2015-05-23 at 11:42 +0100, Ian Campbell wrote:
 Including a v3 which is slightly different to what has been posted here
[...]
 So that's the one I intend to apply

Looks like Ben a) already spotted there was a v3 and b) committed it to
svn for both Sid and Jessie already, so I shall be doing no such thing!

Ian.


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/1432377915.5748.153.ca...@debian.org

Bug#785707: Add USB support for APM Mustang

2015-05-23 Thread Ian Campbell 
On Thu, 2015-05-21 at 20:33 +0100, Steve McIntyre wrote:
 On Thu, May 21, 2015 at 07:49:37PM +0100, Ian Campbell wrote:
 On Wed, 2015-05-20 at 07:53 +0100, Steve McIntyre wrote:
  Here's patch v2...
 
 Thanks.
 
 Has this been posted to anywhere upstream? Usual policy is that this
 should happen before we take it into our kernel. That will also give us
 something (i.e. an archive URL) to put in an Origin: header.
 
 I'm just pulling out a patch that Mark already sent upstream. Looking
 for the URL... It's sometimes a PITA that Google likes Debian lists
 and the BTS so much - most obvious links are just to this bug now!
 
 http://www.spinics.net/lists/arm-kernel/msg373699.html

Thanks, the message id there led me to
http://thread.gmane.org/gmane.linux.usb.general/117272

which has the whole thread.

Including a v3 which is slightly different to what has been posted here
so far:
http://thread.gmane.org/gmane.linux.usb.general/117272/focus=118786

It uses dma_set_mask_and_coherent rather than individual calls to
dma_set_coherent_mask then dma_set_mask, which the various feedback in
the thread seems to indicate is more correct.

So that's the one I intend to apply along with the Kconfig part of
http://thread.gmane.org/gmane.linux.usb.general/117272/focus=118784
(post beer festival though I'm afraid ;-))

Ian.


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/1432377738.5748.152.ca...@debian.org

Bug#785707: Add USB support for APM Mustang

2015-05-21 Thread Ian Campbell 
On Wed, 2015-05-20 at 07:53 +0100, Steve McIntyre wrote:
 Here's patch v2...

Thanks.

Has this been posted to anywhere upstream? Usual policy is that this
should happen before we take it into our kernel. That will also give us
something (i.e. an archive URL) to put in an Origin: header.

We should probably apply this to the sid kernel as well as the jessie
one.

Ian.


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/1432234177.5748.127.ca...@debian.org

Bug#785707: Add USB support for APM Mustang

2015-05-21 Thread Steve McIntyre 
On Thu, May 21, 2015 at 07:49:37PM +0100, Ian Campbell wrote:
On Wed, 2015-05-20 at 07:53 +0100, Steve McIntyre wrote:
 Here's patch v2...

Thanks.

Has this been posted to anywhere upstream? Usual policy is that this
should happen before we take it into our kernel. That will also give us
something (i.e. an archive URL) to put in an Origin: header.

I'm just pulling out a patch that Mark already sent upstream. Looking
for the URL... It's sometimes a PITA that Google likes Debian lists
and the BTS so much - most obvious links are just to this bug now!

http://www.spinics.net/lists/arm-kernel/msg373699.html

We should probably apply this to the sid kernel as well as the jessie
one.

That would be nice, yes! :-)

--
Steve McIntyre, Cambridge, UK.st...@einval.com
Who needs computer imagery when you've got Brian Blessed?


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20150521193351.ga5...@einval.com

Bug#785707: Add USB support for APM Mustang

2015-05-20 Thread Steve McIntyre 
Here's patch v2...

-- 
Steve McIntyre, Cambridge, UK.st...@einval.com
Into the distance, a ribbon of black
Stretched to the point of no turning back
diff -Nru linux-3.16.7-ckt9/debian/changelog linux-3.16.7-ckt9/debian/changelog
--- linux-3.16.7-ckt9/debian/changelog  2015-04-13 01:01:55.0 +
+++ linux-3.16.7-ckt9/debian/changelog  2015-05-15 08:47:00.0 +
@@ -1,3 +1,10 @@
+linux (3.16.7-ckt9-2.1) unstable; urgency=medium
+
+  * arm64: enable XHCI USB on APM X-Gene
+  * usb: host: allow 64-bit DMA mask for XHCI
+
+ -- Steve McIntyre 93...@debian.org  Fri, 15 May 2015 09:41:31 +0100
+
 linux (3.16.7-ckt9-2) unstable; urgency=medium
 
   * btrfs: simplify insert_orphan_item (Closes: #782362)
diff -Nru linux-3.16.7-ckt9/debian/config/arm64/config 
linux-3.16.7-ckt9/debian/config/arm64/config
--- linux-3.16.7-ckt9/debian/config/arm64/config2015-01-02 
03:46:07.0 +
+++ linux-3.16.7-ckt9/debian/config/arm64/config2015-05-15 
08:54:05.0 +
@@ -120,6 +120,8 @@
 CONFIG_USB_EHCI_HCD_PLATFORM=m
 CONFIG_USB_OHCI_HCD=m
 CONFIG_USB_OHCI_HCD_PLATFORM=m
+CONFIG_USB_XHCI_HCD=m
+CONFIG_USB_XHCI_PLATFORM=y
 
 ##
 ## file: drivers/virtio/Kconfig
diff -Nru 
linux-3.16.7-ckt9/debian/patches/features/arm64/xgene-enable-xhci-usb.patch 
linux-3.16.7-ckt9/debian/patches/features/arm64/xgene-enable-xhci-usb.patch
--- linux-3.16.7-ckt9/debian/patches/features/arm64/xgene-enable-xhci-usb.patch 
1970-01-01 00:00:00.0 +
+++ linux-3.16.7-ckt9/debian/patches/features/arm64/xgene-enable-xhci-usb.patch 
2015-05-15 10:48:28.0 +
@@ -0,0 +1,61 @@
+From: Mark Langsdorf mlang...@redhat.com
+Date: Wed, 20 May 2015 00:19:13 +0100
+Subject: [usb] make xhci platform driver use 64 bit or 32 bit DMA
+Bug-Debian: https://bugs.debian.org/785707
+Forwarded: no
+
+The xhci platform driver needs to work on systems that either only
+support 64-bit DMA or only support 32-bit DMA. Attempt to set a
+coherent dma mask for 64-bit DMA, and attempt again with 32-bit
+DMA if that fails.
+
+Signed-off-by: Mark Langsdorf mlang...@redhat.com
+Signed-off-by: Steve McIntyre st...@einval.com
+
+Index: linux-3.16.7-ckt9/drivers/usb/host/xhci-plat.c
+===
+--- linux-3.16.7-ckt9.orig/drivers/usb/host/xhci-plat.c
 linux-3.16.7-ckt9/drivers/usb/host/xhci-plat.c
+@@ -115,14 +115,18 @@ static int xhci_plat_probe(struct platfo
+   if (!res)
+   return -ENODEV;
+ 
+-  /* Initialize dma_mask and coherent_dma_mask to 32-bits */
+-  ret = dma_set_coherent_mask(pdev-dev, DMA_BIT_MASK(32));
+-  if (ret)
+-  return ret;
++  /* Try setting the coherent_dma_mask to 64 bits, then try 32 bits */
++  if (sizeof(dma_addr_t)  8 ||
++  dma_set_coherent_mask(pdev-dev, DMA_BIT_MASK(64))) {
++  ret = dma_set_coherent_mask(pdev-dev, DMA_BIT_MASK(32));
++  if (ret)
++  return ret;
++  }
+   if (!pdev-dev.dma_mask)
+   pdev-dev.dma_mask = pdev-dev.coherent_dma_mask;
+   else
+-  dma_set_mask(pdev-dev, DMA_BIT_MASK(32));
++  dma_set_mask(pdev-dev, pdev-dev.coherent_dma_mask);
++
+ 
+   hcd = usb_create_hcd(driver, pdev-dev, dev_name(pdev-dev));
+   if (!hcd)
+Index: linux-3.16.7-ckt9/drivers/usb/host/Kconfig
+===
+--- linux-3.16.7-ckt9.orig/drivers/usb/host/Kconfig
 linux-3.16.7-ckt9/drivers/usb/host/Kconfig
+@@ -27,7 +27,13 @@
+ if USB_XHCI_HCD
+ 
+ config USB_XHCI_PLATFORM
+-  tristate
++  tristate Generic XHCI driver for a platform device
++  default n
++  ---help---
++Adds an XHCI host driver for a generic platform device, which
++provides a memory space and an irq.
++
++If unsure, say N.
+ 
+ config USB_XHCI_MVEBU
+   tristate xHCI support for Marvell Armada 375/38x
diff -Nru linux-3.16.7-ckt9/debian/patches/series 
linux-3.16.7-ckt9/debian/patches/series
--- linux-3.16.7-ckt9/debian/patches/series 2015-04-13 00:40:38.0 
+
+++ linux-3.16.7-ckt9/debian/patches/series 2015-05-15 08:47:26.0 
+
@@ -578,3 +578,4 @@
 debian/procfs-avoid-abi-change-in-3.16.7-ckt8.patch
 
 bugfix/all/btrfs-simplify-insert_orphan_item.patch
+features/arm64/xgene-enable-xhci-usb.patch

Bug#785707: Add USB support for APM Mustang

2015-05-19 Thread Steve McIntyre 
Package: src:linux
Version: 3.16.7-ckt9-2
Severity: normal
Tags: d-i patch

Hi folks,

As described a little at
http://blog.einval.com/2015/05/19#mustang_installer I've been working
on getting Mustang support working. There's a (quite generic!) patch
from Mark Langsdorf for the XHCI platform code that allows for a
64-bit DMA mask:

http://www.spinics.net/lists/arm-kernel/msg373699.html

AFAICS this is needed for the Mustang, as all of its memory is mapped
over 4GiB. The patch hasn't (yet!) been accepted upstream, but I've
swapped mail with Mark and he says he's about to propose it again this
week. With the small attached patch applied to the Jessie kernel
(Mark's code plus a config tweak), I've got things working just fine.

It would be lovely if we could get this into Jessie for the 8.1 point
release. :-)

-- System Information:
Debian Release: 8.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru linux-3.16.7-ckt9/debian/changelog linux-3.16.7-ckt9/debian/changelog
--- linux-3.16.7-ckt9/debian/changelog	2015-04-13 01:01:55.0 +
+++ linux-3.16.7-ckt9/debian/changelog	2015-05-15 08:47:00.0 +
@@ -1,3 +1,10 @@
+linux (3.16.7-ckt9-2.1) unstable; urgency=medium
+
+  * arm64: enable XHCI USB on APM X-Gene
+  * usb: host: allow 64-bit DMA mask for XHCI
+
+ -- Steve McIntyre 93...@debian.org  Fri, 15 May 2015 09:41:31 +0100
+
 linux (3.16.7-ckt9-2) unstable; urgency=medium
 
   * btrfs: simplify insert_orphan_item (Closes: #782362)
diff -Nru linux-3.16.7-ckt9/debian/config/arm64/config linux-3.16.7-ckt9/debian/config/arm64/config
--- linux-3.16.7-ckt9/debian/config/arm64/config	2015-01-02 03:46:07.0 +
+++ linux-3.16.7-ckt9/debian/config/arm64/config	2015-05-15 08:54:05.0 +
@@ -120,6 +120,8 @@
 CONFIG_USB_EHCI_HCD_PLATFORM=m
 CONFIG_USB_OHCI_HCD=m
 CONFIG_USB_OHCI_HCD_PLATFORM=m
+CONFIG_USB_XHCI_HCD=m
+CONFIG_USB_XHCI_PLATFORM=y
 
 ##
 ## file: drivers/virtio/Kconfig
diff -Nru linux-3.16.7-ckt9/debian/patches/features/arm64/xgene-enable-xhci-usb.patch linux-3.16.7-ckt9/debian/patches/features/arm64/xgene-enable-xhci-usb.patch
--- linux-3.16.7-ckt9/debian/patches/features/arm64/xgene-enable-xhci-usb.patch	1970-01-01 00:00:00.0 +
+++ linux-3.16.7-ckt9/debian/patches/features/arm64/xgene-enable-xhci-usb.patch	2015-05-15 10:48:28.0 +
@@ -0,0 +1,40 @@
+Index: linux-3.16.7-ckt9/drivers/usb/host/xhci-plat.c
+===
+--- linux-3.16.7-ckt9.orig/drivers/usb/host/xhci-plat.c
 linux-3.16.7-ckt9/drivers/usb/host/xhci-plat.c
+@@ -115,14 +115,18 @@ static int xhci_plat_probe(struct platfo
+ 	if (!res)
+ 		return -ENODEV;
+ 
+-	/* Initialize dma_mask and coherent_dma_mask to 32-bits */
+-	ret = dma_set_coherent_mask(pdev-dev, DMA_BIT_MASK(32));
+-	if (ret)
+-		return ret;
++	/* Try setting the coherent_dma_mask to 64 bits, then try 32 bits */
++	if (sizeof(dma_addr_t)  8 ||
++		dma_set_coherent_mask(pdev-dev, DMA_BIT_MASK(64))) {
++		ret = dma_set_coherent_mask(pdev-dev, DMA_BIT_MASK(32));
++		if (ret)
++			return ret;
++	}
+ 	if (!pdev-dev.dma_mask)
+ 		pdev-dev.dma_mask = pdev-dev.coherent_dma_mask;
+ 	else
+-		dma_set_mask(pdev-dev, DMA_BIT_MASK(32));
++		dma_set_mask(pdev-dev, pdev-dev.coherent_dma_mask);
++
+ 
+ 	hcd = usb_create_hcd(driver, pdev-dev, dev_name(pdev-dev));
+ 	if (!hcd)
+Index: linux-3.16.7-ckt9/drivers/usb/host/Kconfig
+===
+--- linux-3.16.7-ckt9.orig/drivers/usb/host/Kconfig
 linux-3.16.7-ckt9/drivers/usb/host/Kconfig
+@@ -28,6 +28,7 @@
+ 
+ config USB_XHCI_PLATFORM
+ 	tristate
++	default m
+ 
+ config USB_XHCI_MVEBU
+ 	tristate xHCI support for Marvell Armada 375/38x
diff -Nru linux-3.16.7-ckt9/debian/patches/series linux-3.16.7-ckt9/debian/patches/series
--- linux-3.16.7-ckt9/debian/patches/series	2015-04-13 00:40:38.0 +
+++ linux-3.16.7-ckt9/debian/patches/series	2015-05-15 08:47:26.0 +
@@ -578,3 +578,4 @@
 debian/procfs-avoid-abi-change-in-3.16.7-ckt8.patch
 
 bugfix/all/btrfs-simplify-insert_orphan_item.patch
+features/arm64/xgene-enable-xhci-usb.patch

Bug#785707: Add USB support for APM Mustang

2015-05-19 Thread Ben Hutchings 
On Tue, 2015-05-19 at 12:52 +0100, Steve McIntyre wrote:
 diff -Nru linux-3.16.7-ckt9/debian/changelog 
 linux-3.16.7-ckt9/debian/changelog
 --- linux-3.16.7-ckt9/debian/changelog  2015-04-13 01:01:55.0 +
 +++ linux-3.16.7-ckt9/debian/changelog  2015-05-15 08:47:00.0 +
 @@ -1,3 +1,10 @@
 +linux (3.16.7-ckt9-2.1) unstable; urgency=medium
 +
 +  * arm64: enable XHCI USB on APM X-Gene
 +  * usb: host: allow 64-bit DMA mask for XHCI
 +
 + -- Steve McIntyre 93...@debian.org  Fri, 15 May 2015 09:41:31 +0100
 +
  linux (3.16.7-ckt9-2) unstable; urgency=medium
  
* btrfs: simplify insert_orphan_item (Closes: #782362)
 diff -Nru linux-3.16.7-ckt9/debian/config/arm64/config 
 linux-3.16.7-ckt9/debian/config/arm64/config
 --- linux-3.16.7-ckt9/debian/config/arm64/config2015-01-02 
 03:46:07.0 +
 +++ linux-3.16.7-ckt9/debian/config/arm64/config2015-05-15 
 08:54:05.0 +
 @@ -120,6 +120,8 @@
  CONFIG_USB_EHCI_HCD_PLATFORM=m
  CONFIG_USB_OHCI_HCD=m
  CONFIG_USB_OHCI_HCD_PLATFORM=m
 +CONFIG_USB_XHCI_HCD=m
 +CONFIG_USB_XHCI_PLATFORM=y

Never specify hidden config symbols under debian/config; it has no
effect so it's misleading.

  ##
  ## file: drivers/virtio/Kconfig
 diff -Nru 
 linux-3.16.7-ckt9/debian/patches/features/arm64/xgene-enable-xhci-usb.patch 
 linux-3.16.7-ckt9/debian/patches/features/arm64/xgene-enable-xhci-usb.patch
 --- 
 linux-3.16.7-ckt9/debian/patches/features/arm64/xgene-enable-xhci-usb.patch 
 1970-01-01 00:00:00.0 +
 +++ 
 linux-3.16.7-ckt9/debian/patches/features/arm64/xgene-enable-xhci-usb.patch 
 2015-05-15 10:48:28.0 +
 @@ -0,0 +1,40 @@

This patch needs a header.

 +Index: linux-3.16.7-ckt9/drivers/usb/host/xhci-plat.c
 +===
 +--- linux-3.16.7-ckt9.orig/drivers/usb/host/xhci-plat.c
  linux-3.16.7-ckt9/drivers/usb/host/xhci-plat.c
[...]
 +--- linux-3.16.7-ckt9.orig/drivers/usb/host/Kconfig
  linux-3.16.7-ckt9/drivers/usb/host/Kconfig
 +@@ -28,6 +28,7 @@
 + 
 + config USB_XHCI_PLATFORM
 +   tristate
 ++  default m

This is wrong; we should not be building USB_XHCI_PLATFORM on every
architecture that has USB.  Maybe this symbol should be un-hidden
instead?

Ben.

 + config USB_XHCI_MVEBU
 +   tristate xHCI support for Marvell Armada 375/38x
 diff -Nru linux-3.16.7-ckt9/debian/patches/series 
 linux-3.16.7-ckt9/debian/patches/series
 --- linux-3.16.7-ckt9/debian/patches/series 2015-04-13 00:40:38.0 
 +
 +++ linux-3.16.7-ckt9/debian/patches/series 2015-05-15 08:47:26.0 
 +
 @@ -578,3 +578,4 @@
  debian/procfs-avoid-abi-change-in-3.16.7-ckt8.patch
  
  bugfix/all/btrfs-simplify-insert_orphan_item.patch
 +features/arm64/xgene-enable-xhci-usb.patch

-- 
Ben Hutchings
I'm not a reverse psychological virus.  Please don't copy me into your sig.


signature.asc
Description: This is a digitally signed message part

Bug#785707: Add USB support for APM Mustang

2015-05-19 Thread Steve McIntyre 
On Tue, May 19, 2015 at 02:20:08PM +0100, Ben Hutchings wrote:
On Tue, 2015-05-19 at 12:52 +0100, Steve McIntyre wrote:
 diff -Nru linux-3.16.7-ckt9/debian/changelog 
 linux-3.16.7-ckt9/debian/changelog
 --- linux-3.16.7-ckt9/debian/changelog  2015-04-13 01:01:55.0 +
 +++ linux-3.16.7-ckt9/debian/changelog  2015-05-15 08:47:00.0 +
 @@ -1,3 +1,10 @@
 +linux (3.16.7-ckt9-2.1) unstable; urgency=medium
 +
 +  * arm64: enable XHCI USB on APM X-Gene
 +  * usb: host: allow 64-bit DMA mask for XHCI
 +
 + -- Steve McIntyre 93...@debian.org  Fri, 15 May 2015 09:41:31 +0100
 +
  linux (3.16.7-ckt9-2) unstable; urgency=medium
  
* btrfs: simplify insert_orphan_item (Closes: #782362)
 diff -Nru linux-3.16.7-ckt9/debian/config/arm64/config 
 linux-3.16.7-ckt9/debian/config/arm64/config
 --- linux-3.16.7-ckt9/debian/config/arm64/config2015-01-02 
 03:46:07.0 +
 +++ linux-3.16.7-ckt9/debian/config/arm64/config2015-05-15 
 08:54:05.0 +
 @@ -120,6 +120,8 @@
  CONFIG_USB_EHCI_HCD_PLATFORM=m
  CONFIG_USB_OHCI_HCD=m
  CONFIG_USB_OHCI_HCD_PLATFORM=m
 +CONFIG_USB_XHCI_HCD=m
 +CONFIG_USB_XHCI_PLATFORM=y

Never specify hidden config symbols under debian/config; it has no
effect so it's misleading.

  ##
  ## file: drivers/virtio/Kconfig
 diff -Nru 
 linux-3.16.7-ckt9/debian/patches/features/arm64/xgene-enable-xhci-usb.patch 
 linux-3.16.7-ckt9/debian/patches/features/arm64/xgene-enable-xhci-usb.patch
 --- 
 linux-3.16.7-ckt9/debian/patches/features/arm64/xgene-enable-xhci-usb.patch 
 1970-01-01 00:00:00.0 +
 +++ 
 linux-3.16.7-ckt9/debian/patches/features/arm64/xgene-enable-xhci-usb.patch 
 2015-05-15 10:48:28.0 +
 @@ -0,0 +1,40 @@

This patch needs a header.

ACK, will add one shortly.

 +Index: linux-3.16.7-ckt9/drivers/usb/host/xhci-plat.c
 +===
 +--- linux-3.16.7-ckt9.orig/drivers/usb/host/xhci-plat.c
  linux-3.16.7-ckt9/drivers/usb/host/xhci-plat.c
[...]
 +--- linux-3.16.7-ckt9.orig/drivers/usb/host/Kconfig
  linux-3.16.7-ckt9/drivers/usb/host/Kconfig
 +@@ -28,6 +28,7 @@
 + 
 + config USB_XHCI_PLATFORM
 +   tristate
 ++  default m

This is wrong; we should not be building USB_XHCI_PLATFORM on every
architecture that has USB.  Maybe this symbol should be un-hidden
instead?

I have absolutely no idea how to do that - help please!

-- 
Steve McIntyre, Cambridge, UK.st...@einval.com
Since phone messaging became popular, the young generation has lost the
 ability to read or write anything that is longer than one hundred and sixty
 characters.  -- Ignatios Souvatzis


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20150519172224.gd4...@einval.com

Bug#785707: Add USB support for APM Mustang

2015-05-19 Thread Ben Hutchings 
On Tue, 2015-05-19 at 18:22 +0100, Steve McIntyre wrote:
 On Tue, May 19, 2015 at 02:20:08PM +0100, Ben Hutchings wrote:
 On Tue, 2015-05-19 at 12:52 +0100, Steve McIntyre wrote:
[...]
  +Index: linux-3.16.7-ckt9/drivers/usb/host/xhci-plat.c
  +===
  +--- linux-3.16.7-ckt9.orig/drivers/usb/host/xhci-plat.c
   linux-3.16.7-ckt9/drivers/usb/host/xhci-plat.c
 [...]
  +--- linux-3.16.7-ckt9.orig/drivers/usb/host/Kconfig
   linux-3.16.7-ckt9/drivers/usb/host/Kconfig
  +@@ -28,6 +28,7 @@
  + 
  + config USB_XHCI_PLATFORM
  +   tristate
  ++  default m
 
 This is wrong; we should not be building USB_XHCI_PLATFORM on every
 architecture that has USB.  Maybe this symbol should be un-hidden
 instead?
 
 I have absolutely no idea how to do that - help please!

Add a prompt string after 'tristate'.

Ben.

-- 
Ben Hutchings
I'm not a reverse psychological virus.  Please don't copy me into your sig.


signature.asc
Description: This is a digitally signed message part

Bug#785707: Add USB support for APM Mustang

2015-05-19 Thread Steve McIntyre 
On Tue, May 19, 2015 at 08:03:12PM +0100, Ian Campbell wrote:
On Tue, 2015-05-19 at 20:02 +0100, Ian Campbell wrote:
 On Tue, 2015-05-19 at 12:52 +0100, Steve McIntyre wrote:
  +CONFIG_USB_XHCI_PLATFORM=y
 
 This guy seems to match on:
 static const struct of_device_id usb_xhci_of_match[] = {
 { .compatible = generic-xhci },
 { .compatible = xhci-platform },
 { .compatible = marvell,armada-375-xhci},
 { .compatible = marvell,armada-380-xhci},
 { .compatible = renesas,xhci-r8a7790},
 { .compatible = renesas,xhci-r8a7791},
 { },
 
 But I don't see any of those in the mustang DTBs even in the mainline
 kernel.

But I do see them in the latest APM UEFI firmware, so I suppose this
will only work with that and not with e.g. uboot.

That's exactly it, yet - the USB matches are in the latest 1.15.10 APM
drop. I really couldn't care less about trying to support U-Boot with
this stuff - everybody's being told to go UEFI now AFAIK.

Not a blocker per se, I'm not even sure if u-boot can boot from usb
anyhow.

In theory it *can* (I could read files off USB with it), but it's not
going to be useful for this.

-- 
Steve McIntyre, Cambridge, UK.st...@einval.com
 liw everything I know about UK hotels I learned from Fawlty Towers


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20150519220520.gf4...@einval.com

Bug#785707: Add USB support for APM Mustang

2015-05-19 Thread Ian Campbell 
On Tue, 2015-05-19 at 12:52 +0100, Steve McIntyre wrote:
 +CONFIG_USB_XHCI_PLATFORM=y

This guy seems to match on:
static const struct of_device_id usb_xhci_of_match[] = {
{ .compatible = generic-xhci },
{ .compatible = xhci-platform },
{ .compatible = marvell,armada-375-xhci},
{ .compatible = marvell,armada-380-xhci},
{ .compatible = renesas,xhci-r8a7790},
{ .compatible = renesas,xhci-r8a7791},
{ },

But I don't see any of those in the mustang DTBs even in the mainline
kernel. AFAIK the USB on this platform isn't PCI based or anything like
that.

Are additional DTB patches also needed? (Or more worryingly, custom
firmware...)

Ian.


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/1432062126.5748.102.ca...@debian.org

Bug#785707: Add USB support for APM Mustang

2015-05-19 Thread Ian Campbell 
On Tue, 2015-05-19 at 20:02 +0100, Ian Campbell wrote:
 On Tue, 2015-05-19 at 12:52 +0100, Steve McIntyre wrote:
  +CONFIG_USB_XHCI_PLATFORM=y
 
 This guy seems to match on:
 static const struct of_device_id usb_xhci_of_match[] = {
 { .compatible = generic-xhci },
 { .compatible = xhci-platform },
 { .compatible = marvell,armada-375-xhci},
 { .compatible = marvell,armada-380-xhci},
 { .compatible = renesas,xhci-r8a7790},
 { .compatible = renesas,xhci-r8a7791},
 { },
 
 But I don't see any of those in the mustang DTBs even in the mainline
 kernel.

But I do see them in the latest APM UEFI firmware, so I suppose this
will only work with that and not with e.g. uboot.

Not a blocker per se, I'm not even sure if u-boot can boot from usb
anyhow.


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/1432062192.5748.103.ca...@hellion.org.uk