Re: New team on salsa, which repositories shall we migrate?
On Fri, 23 Feb 2018, Steve McIntyre wrote: > On Fri, Feb 23, 2018 at 08:28:55PM +0100, Raphael Hertzog wrote: > >On Fri, 09 Feb 2018, Steve McIntyre wrote: > >> 10 repos moved now: > > > >I just noticed that you did not setup the email integration with the > >package tracker and the hook tagpending. I just did this for all the > >repositories. > > I've no idea how to do that, so thanks! Using the scripts emails_on_push.sh and hook_tagpending.sh here: https://salsa.debian.org/mehdi/salsa-scripts Or doing it manually as described here: https://wiki.debian.org/Teams/pkg-security#Creating_new_repositories Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: https://www.freexian.com/services/debian-lts.html Learn to master Debian: https://debian-handbook.info/get/
Re: New team on salsa, which repositories shall we migrate?
On Fri, Feb 23, 2018 at 08:28:55PM +0100, Raphael Hertzog wrote: >On Fri, 09 Feb 2018, Steve McIntyre wrote: >> 10 repos moved now: > >I just noticed that you did not setup the email integration with the >package tracker and the hook tagpending. I just did this for all the >repositories. I've no idea how to do that, so thanks! -- Steve McIntyre, Cambridge, UK.st...@einval.com "...In the UNIX world, people tend to interpret `non-technical user' as meaning someone who's only ever written one device driver." -- Daniel Pead
Processed: Bug #886337 in live-boot marked as pending
Processing control commands: > tag -1 pending Bug #886337 [live-boot-initramfs-tools] live-boot-initramfs-tools: Please support building smaller initrd Ignoring request to alter tags of bug #886337 to the same tags previously set -- 886337: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886337 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Bug #885455 in live-boot marked as pending
Processing control commands: > tag -1 pending Bug #885455 [src:live-boot] live-boot: Please drop wget from initrd (busybox provides wget) Ignoring request to alter tags of bug #885455 to the same tags previously set -- 885455: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=885455 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Bug #885455 in live-boot marked as pending
Processing control commands: > tag -1 pending Bug #885455 [src:live-boot] live-boot: Please drop wget from initrd (busybox provides wget) Ignoring request to alter tags of bug #885455 to the same tags previously set -- 885455: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=885455 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Bug #886328 in live-boot marked as pending
Processing control commands: > tag -1 pending Bug #886328 [src:live-boot] live-boot: Please use /run/live instead of /lib/live/mount Added tag(s) pending. -- 886328: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886328 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Bug #885453 in live-boot marked as pending
Processing control commands: > tag -1 pending Bug #885453 [src:live-boot] live-boot: Please strip double slashes from path Added tag(s) pending. -- 885453: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=885453 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Bug #885466 in live-boot marked as pending
Processing control commands: > tag -1 pending Bug #885466 [src:live-boot] live-boot: Please support setting upperdir tmpfs mount point size Added tag(s) pending. -- 885466: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=885466 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Bug #868559 in live-boot marked as pending
Processing control commands: > tag -1 pending Bug #868559 [live-boot] live-boot: httpfs does not work due to util-linux's mount being used Ignoring request to alter tags of bug #868559 to the same tags previously set -- 868559: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=868559 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Bug #868559 in live-boot marked as pending
Processing control commands: > tag -1 pending Bug #868559 [live-boot] live-boot: httpfs does not work due to util-linux's mount being used Ignoring request to alter tags of bug #868559 to the same tags previously set -- 868559: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=868559 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Re: New team on salsa, which repositories shall we migrate?
On Fri, 09 Feb 2018, Steve McIntyre wrote: > 10 repos moved now: I just noticed that you did not setup the email integration with the package tracker and the hook tagpending. I just did this for all the repositories. Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: https://www.freexian.com/services/debian-lts.html Learn to master Debian: https://debian-handbook.info/get/
Processed: Bug #868559 in live-boot marked as pending
Processing control commands: > tag -1 pending Bug #868559 [live-boot] live-boot: httpfs does not work due to util-linux's mount being used Added tag(s) pending. -- 868559: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=868559 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Re: Bug#885455: live-boot: Please drop wget from initrd (busybox provides wget)
Processing control commands: > tag -1 + pending Bug #885455 [src:live-boot] live-boot: Please drop wget from initrd (busybox provides wget) Added tag(s) pending. -- 885455: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=885455 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Bug #868559 in live-boot marked as pending
Processing control commands: > tag -1 pending Bug #868559 [live-boot] live-boot: httpfs does not work due to util-linux's mount being used Ignoring request to alter tags of bug #868559 to the same tags previously set -- 868559: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=868559 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Bug #886337 in live-boot marked as pending
Processing control commands: > tag -1 pending Bug #886337 [live-boot-initramfs-tools] live-boot-initramfs-tools: Please support building smaller initrd Added tag(s) pending. -- 886337: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886337 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Bug #885455 in live-boot marked as pending
Processing control commands: > tag -1 pending Bug #885455 [src:live-boot] live-boot: Please drop wget from initrd (busybox provides wget) Ignoring request to alter tags of bug #885455 to the same tags previously set -- 885455: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=885455 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#885455: live-boot: Please drop wget from initrd (busybox provides wget)
> > Am Mittwoch, den 21.02.2018, 10:08 +0100 schrieb Raphael Hertzog: > > Hello, > > > > On Wed, 27 Dec 2017, Benjamin Drung wrote: > > > The wget binary depends on many libraries. On Debian 9 (stretch) > > > these > > > are: libffi6, libgnutls30, libhogweed4, libidn11, libidn2-0, > > > libnettle6, > > > libp11-kit0, libpsl5, libtasn1-6, libunistring0. In total 8 > > > megabytes. > > > This increases the initramfs size a lot. To save space, use wget > > > from > > > busybox instead. Commit 4328832d0 that adds wget does not give a > > > reason > > > why busybox's wget is not used. A patch is tested and attached. > > > > The usual reason is for "https" support. Have you tried to use https > > URLs in the various places where we can use URLs? > > Okay. I did some tests in a minimal schroot environment: > > (stretch)root@konstrukt:~# dpkg -s busybox | grep ^Version > Version: 1:1.22.0-19+b3 > (stretch)root@konstrukt:~# busybox wget https://bugs.debian.org/ > wget: not an http or ftp url: https://bugs.debian.org/ > > (buster)root@konstrukt:~# dpkg -s busybox | grep ^Version > Version: 1:1.27.2-2 > (buster)root@konstrukt:~# busybox wget https://bugs.debian.org/ > Connecting to bugs.debian.org (209.87.16.39:443) > Connecting to www.debian.org (5.153.231.4:443) > index.html 100% |***| 18089 0:00:00 ETA > > So busybox in stretch does not support HTTPS, but it supports HTTPS in > testing/unstable. Busybox version of wget does not check the certificate at all, which defeat the purpose of https. Tested with (on testing): busybox wget 'https://untrusted-root.badssl.com/' and busybox wget 'https://expired.badssl.com/' - Kristian
Bug#886328: live-boot: Please use /run/live instead of /lib/live/mount
Hello, On Fri, 05 Jan 2018, intrigeri wrote: > Benjamin Drung: > > Therefore move /lib/live/mount to /run/live and skip the intermedia > > /live mount points. This reduces code and complexity. > > As someone who had to repeatedly bang his head against exactly this > part of the live-boot code (last time earlier this week), I can only > agree with the proposed simplification idea. I didn't do a full code > review though. I'm not familiar enough with this part either and I am unlikely to find any obvious mistake. But I committed the patch anyway It would be nice if we could test the live-boot in git before I upload it. Benjamin, did you test your changes with persistence enabled? To whoever is following, please test and report back. Thank you. Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: https://www.freexian.com/services/debian-lts.html Learn to master Debian: https://debian-handbook.info/get/
Bug#884355: live-boot: Please support live-{top,premount,bottom} hooks
Hi,
On Thu, 14 Dec 2017, Benjamin Drung wrote:
> initramfs-tools support hooks for top, premount, bottom when booting
> with boot=local or boot=nfs. Please add similar support to live-boot
> when booting with boot=live. A patch (for git) is attached.
I will gladly apply your patch but I think it's time to clean up the
mess with this:
> --- a/components/9990-initramfs-tools.sh
> +++ b/components/9990-initramfs-tools.sh
> @@ -73,3 +73,25 @@ panic()
> . /scripts/functions
> panic "$@"
> }
> +
> +# Note: Other components source /scripts/functions before sourcing this file.
> +# /scripts/functions overrides the mount_* functions (to no-ops). Thus fix
> +# the mount_* options here again.
This kind of duplication is just ugly. I looked around and saw this:
$ grep -r -E 'functions|9990-initramfs-tools.sh' components/
components/9990-initramfs-tools.sh:# Override maybe_break from scripts/functions
components/9990-initramfs-tools.sh: . /scripts/functions
components/9990-initramfs-tools.sh:# Override panic from scripts/functions
components/9990-initramfs-tools.sh: . /scripts/functions
components/9990-fstab.sh: # FIXME: stop hardcoding overloading of
initramfs-tools functions
components/9990-fstab.sh: . /scripts/functions
components/9990-fstab.sh: . /lib/live/boot/9990-initramfs-tools.sh
components/9990-misc-helpers.sh:# the output of setup_loop is evaluated
in other functions,
components/9990-netbase.sh: # FIXME: stop hardcoding overloading of
initramfs-tools functions
components/9990-netbase.sh: . /scripts/functions
components/9990-netbase.sh: . /lib/live/boot/9990-initramfs-tools.sh
I have the feeling that all those problematic include are no longer necessary
nowadays because we first source all the files and then we execute functions
in the expected order. My review has not been thorough but can you try to remove
all those include and see if things still work?
/script/functions is already sourced in backend/initramfs-tools/live.script
so it should not be required to have it in the components, right?
BTW, I merged all you other patches. For the future, please send patches
as merge requests on the salsa repositories.
The only correction I made in multiple places is replacing "${VAR-foo}"
with "${VAR:-foo}". This gives a default value also when the variable is set
to an empty value.
Cheers,
--
Raphaël Hertzog ◈ Debian Developer
Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/
Bug#884553: live-build: Foreign architecture package support for linux kernel flavours in Stretch
Hi, On Sat, 23 Dec 2017, adrian15 wrote: > 3) So I dropped that implementation of the patch and searched for > something more elegant. A patch that modified the least possible lines > of the live-build code and I finally found out how... with this new > package based variable that would only have to be used in one specific > place. > > And that's the patch I submitted here in the first place. Ok, fine. But we should use more explicit variable names. Please modify scripts/build/config to store the value of --linux-flavours in LB_LINUX_FLAVOURS_WITH_ARCH and then define LB_LINUX_FLAVOURS in functions/defaults.sh based on LB_LINUX_FLAVOURS_WITH_ARCH (as you did but with different variable names). Also update the lb-config manual page to explain that you can use architecture qualifier. And you should submit an update to live-manual too (see section 8.2.9 Kernel flavour and version). https://debian-live.alioth.debian.org/live-manual/stable/manual/html/live-manual.en.html#435 Please submit both patches as merge requests: https://salsa.debian.org/live-team/live-build/merge_requests https://salsa.debian.org/live-team/live-manual/merge_requests Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: https://www.freexian.com/services/debian-lts.html Learn to master Debian: https://debian-handbook.info/get/
Bug#891206: live-build: using local offline mirrors fails due to regression
Package: live-build Version: 1:20161202 Tags: patch Severity: normal Dear Maintainer, Commit a15b5796 (#775989) [1] dropped an early exit from the chroot_archives remove step in case the parent mirror chroot and binary parameters are the same and unfortunately introduced a regression in an (infrequent) corner case, as with the following live-build now fails when the parent mirror is using a file:/ local apt repository (for example when the build worker is offline and uses a pre-built cache of packages). Example config: lb config --mirror-bootstrap "file:/pkgs" \ --mirror-chroot "file:/pkgs/" \ --mirror-binary "file:/pkgs" \ --parent-mirror-bootstrap "file:/pkgs" \ --parent-mirror-chroot "file:/pkgs/" \ --parent-mirror-binary "file:/pkgs" \ ... with /pkgs being a directory with the packages for the installation and the apt metadata (Packages/Sources/Release). The problem is that, with such a setup, the /pkgs directory is bind mounted inside the chroot as an optimisation in the install step, and umounted as one of the first actions in the remove step for chroot_archives. Before that fix, the script terminated immediately. But now it progresses and at the end it tries to run apt update inside the chroot which will fail since the repository directory has been umounted, and thus the packages and the apt metadata are no longer available, while still being listed in /etc/apt/sources.list. The proposed solution is to avoid running apt update in the chroot at the end of the chroot_archives remove step if the repository is local and has been umounted. A PR [2] has been opened on Salsa with the proposed fix. Please let me know if you'd like more information or a different solution. Thanks! -- Kind regards, Luca Boccassi [1] https://salsa.debian.org/live-team/live-build/commit/a15b579652e64317fbcc0597a1ea1012fb1d3ba8 [2] https://salsa.debian.org/live-team/live-build/merge_requests/1 signature.asc Description: This is a digitally signed message part
