Re: NDEBUG and CMake

2018-04-27 Thread Sébastien Jodogne
Dear Gert, On 26/04/18 09:47, Gert Wollny wrote: Am Mittwoch, den 25.04.2018, 12:32 +0200 schrieb Sébastien Jodogne: cmake -DCMAKE_C_FLAGS=-DNDEBUG -DCMAKE_CXX_FLAGS=-DNDEBUG [...] Please someone could validate this approach? TIA! Add this at the top of d/rules: export

Re: NDEBUG and CMake

2018-04-26 Thread Gert Wollny
Am Mittwoch, den 25.04.2018, 12:32 +0200 schrieb Sébastien Jodogne: > > cmake -DCMAKE_C_FLAGS=-DNDEBUG -DCMAKE_CXX_FLAGS=-DNDEBUG [...] > > Please someone could validate this approach? TIA! Add this at the top of d/rules: export DEB_CFLAGS_MAINT_APPEND=-DNDEBUG export

Re: NDEBUG and CMake

2018-04-25 Thread rleigh
On 2018-04-25 11:32, Sébastien Jodogne wrote: Dear all, The Debian packages for Orthanc and its associated plugins pay attention to the fact of *not* setting "-DCMAKE_BUILD_TYPE=Release", as requested by the Debian policy [1]. However, the source code of the upstream Orthanc project makes many

Re: NDEBUG and CMake

2018-04-25 Thread Sébastien Jodogne
Hello, Have you tried RelWithDebInfo as the build type? (https://cmake.org/Wiki/CMake_Useful_Variables) This should set NDEBUG but still use -g to get debug symbols. Thanks for the reply. However, previous discussions on Debian clearly state that CMAKE_BUILD_TYPE must be set to None, not

Re: NDEBUG and CMake

2018-04-25 Thread Andreas Tille
6 main.cpp:1146] Performance warning: Non-release build, > runtime debug assertions are turned on > > > I have not been able to find a definite answer about how "NDEBUG" should be > properly handled. I am considering to add the following arguments wile > invoking CMake

NDEBUG and CMake

2018-04-25 Thread Sébastien Jodogne
ot; should be properly handled. I am considering to add the following arguments wile invoking CMake in debian/rules in order to have "NDEBUG" manually defined: cmake -DCMAKE_C_FLAGS=-DNDEBUG -DCMAKE_CXX_FLAGS=-DNDEBUG [...] Please someone could validate this approach? TIA! Regards,