Re: [Debian-med-packaging] Bug#1062404: orthanc-python: flaky autopkgtest: Test failed with
Hello again, On 3/30/24 15:04, Nilesh Patra wrote: I have just uploaded it: https://salsa.debian.org/med-team/orthanc-python/-/commit/3cdc765442ab3fce9148c33ba865467983b11e0b Actually, the patch was more of a local workaround based on your system configuration and should stay the way it was for debci based workers/lxc backend. With that change the autopkgtest job fails[1] and that's a bad sign OK, fine, I've just removed the patch from the package. I'll manually reapply it on my local machine if needed. Best, Sébastien-
Re: [Debian-med-packaging] Bug#1062404: orthanc-python: flaky autopkgtest: Test failed with
Now, the next problem is: The test always succeeds on my standard amd64 architecture. Despite many attempts, I am totally unable to reproduce #1062404. @Paul: How could I reproduce the issue? @Nilesh: Shouldn't this test simply be disabled? OK, I think I have finally found the culprit. This is most probably because the unit test doesn't properly test whether Orthanc has finalized its startup. Indeed, instead of testing the existence of the "orthanc" process, one has to wait until the REST API of Orthanc is actually available. I have just committed the fix: https://salsa.debian.org/med-team/orthanc-python/-/commit/9101662e09d956886da7394bacbb7e81d9cb511a I am now working on a new release that should hopefully close this issue. Do not hesitate to re-open the issue if my fix proves to be insufficient. Kind Regards, Sébastien-
Re: [Debian-med-packaging] Bug#1062404: orthanc-python: flaky autopkgtest: Test failed with
On Sat, Mar 30, 2024 at 02:26:07PM +0100, Sébastien Jodogne wrote: > > For some reason, this is not taking needs-sudo restriction well. Can you > > try once with this > > patch (no need to re-compile) and let me know if that helps? > > > > diff --git a/debian/tests/control b/debian/tests/control > > index 5e8c44d..4f9b12a 100644 > > --- a/debian/tests/control > > +++ b/debian/tests/control > > @@ -1,3 +1,3 @@ > > Tests: run-unit-test > > Depends: @, python3, orthanc, curl, libcurl4, orthanc-python, procps > > -Restrictions: needs-sudo, allow-stderr, isolation-container > > +Restrictions: allow-stderr > > Wonderful! I confirm that with this patch, I am able to run autopkgtest as > follows: > > $ sudo autopkgtest -B ../build-area/orthanc-python_4.1+ds-3_amd64.deb -- > null > > I have just uploaded it: > https://salsa.debian.org/med-team/orthanc-python/-/commit/3cdc765442ab3fce9148c33ba865467983b11e0b Actually, the patch was more of a local workaround based on your system configuration and should stay the way it was for debci based workers/lxc backend. With that change the autopkgtest job fails[1] and that's a bad sign :-) > Now, the next problem is: The test always succeeds on my standard amd64 > architecture. Despite many attempts, I am totally unable to reproduce > #1062404. > > @Paul: How could I reproduce the issue? > > @Nilesh: Shouldn't this test simply be disabled? The test was added to ensure the binary actually works with rest of the Debian ecosytem -- if you feel that's not needed, sure feel free to drop it -- your judgement is more qualified than mine since you're the upstream maintainer, so I defer that decision onto you. [1]: https://salsa.debian.org/med-team/orthanc-python/-/jobs/5519508 Best, Nilesh signature.asc Description: PGP signature
Re: [Debian-med-packaging] Bug#1062404: orthanc-python: flaky autopkgtest: Test failed with
Hi Nilesh, For some reason, this is not taking needs-sudo restriction well. Can you try once with this patch (no need to re-compile) and let me know if that helps? diff --git a/debian/tests/control b/debian/tests/control index 5e8c44d..4f9b12a 100644 --- a/debian/tests/control +++ b/debian/tests/control @@ -1,3 +1,3 @@ Tests: run-unit-test Depends: @, python3, orthanc, curl, libcurl4, orthanc-python, procps -Restrictions: needs-sudo, allow-stderr, isolation-container +Restrictions: allow-stderr Wonderful! I confirm that with this patch, I am able to run autopkgtest as follows: $ sudo autopkgtest -B ../build-area/orthanc-python_4.1+ds-3_amd64.deb -- null I have just uploaded it: https://salsa.debian.org/med-team/orthanc-python/-/commit/3cdc765442ab3fce9148c33ba865467983b11e0b Now, the next problem is: The test always succeeds on my standard amd64 architecture. Despite many attempts, I am totally unable to reproduce #1062404. @Paul: How could I reproduce the issue? @Nilesh: Shouldn't this test simply be disabled? Kind Regards, Sébastien-
Re: [Debian-med-packaging] Bug#1062404: orthanc-python: flaky autopkgtest: Test failed with
Hi Sébastien, On Sat, Mar 30, 2024 at 12:51:56PM +0100, Sébastien Jodogne wrote: > On 3/30/24 12:41, Nilesh Patra wrote: > > > Once compilation is done, how can I execute autopkgtest? I have tried > > > multiple variations, including the most basic: > > > > > > $ sudo autopkgtest . -- null > > > $ sudo autopkgtest ../build-area/orthanc-python_4.1+ds-2_amd64.changes -- > > > null > > > > This should work I suppose, in an unstable system. > > I however pass in the .deb instead of the .changes file. > > > > This is the command I use incase that helps you: > > > > $ sudo autopkgtest -B ../*.deb -- schroot unstable-amd64-sbuild > > > > You could use `-- null` if you don't use a schroot. > > > > If this still does not work, can you share the error that you see? > > In all of those commands (including yours, as well as if using ".deb" > instead of ".changes"), I always get the attached log. > > The actual test seems to never be executed: The autopkgtest command always > stops with the "Reading package lists...". Nothing more happens. > ... > Removing autopkgtest-satdep (0) ... > run-unit-testSKIP Cannot enable needs-sudo restriction: no ordinary > user available > autopkgtest [12:47:49]: summary > run-unit-testSKIP Cannot enable needs-sudo restriction: no ordinary > user available For some reason, this is not taking needs-sudo restriction well. Can you try once with this patch (no need to re-compile) and let me know if that helps? diff --git a/debian/tests/control b/debian/tests/control index 5e8c44d..4f9b12a 100644 --- a/debian/tests/control +++ b/debian/tests/control @@ -1,3 +1,3 @@ Tests: run-unit-test Depends: @, python3, orthanc, curl, libcurl4, orthanc-python, procps -Restrictions: needs-sudo, allow-stderr, isolation-container +Restrictions: allow-stderr signature.asc Description: PGP signature
Re: [Debian-med-packaging] Bug#1062404: orthanc-python: flaky autopkgtest: Test failed with
Dear Nilesh, Thanks for your so fast support! On 3/30/24 12:41, Nilesh Patra wrote: Once compilation is done, how can I execute autopkgtest? I have tried multiple variations, including the most basic: $ sudo autopkgtest . -- null $ sudo autopkgtest ../build-area/orthanc-python_4.1+ds-2_amd64.changes -- null This should work I suppose, in an unstable system. I however pass in the .deb instead of the .changes file. This is the command I use incase that helps you: $ sudo autopkgtest -B ../*.deb -- schroot unstable-amd64-sbuild You could use `-- null` if you don't use a schroot. If this still does not work, can you share the error that you see? In all of those commands (including yours, as well as if using ".deb" instead of ".changes"), I always get the attached log. The actual test seems to never be executed: The autopkgtest command always stops with the "Reading package lists...". Nothing more happens. Regards, Sébastien-$ sudo autopkgtest ../build-area/orthanc-python_4.1+ds-2_amd64.deb -- null autopkgtest [12:47:42]: starting date and time: 2024-03-30 12:47:42+0100 autopkgtest [12:47:42]: version 5.33 autopkgtest [12:47:42]: host debian-unstable; command line: /usr/bin/autopkgtest ../build-area/orthanc-python_4.1+ds-2_amd64.deb -- null autopkgtest [12:47:42]: testbed dpkg architecture: amd64 autopkgtest [12:47:42]: testbed apt version: 2.7.14 autopkgtest [12:47:42]: testbed running kernel: Linux 6.7.9-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.7.9-2 (2024-03-13) autopkgtest [12:47:42]: unbuilt-tree . autopkgtest [12:47:42]: testing package orthanc-python version 4.1+ds-2 autopkgtest [12:47:42]: build not needed autopkgtest [12:47:42]: test run-unit-test: preparing testbed Get:1 file:/tmp/autopkgtest.I5zY18/binaries InRelease Ign:1 file:/tmp/autopkgtest.I5zY18/binaries InRelease Get:2 file:/tmp/autopkgtest.I5zY18/binaries Release [816 B] Get:2 file:/tmp/autopkgtest.I5zY18/binaries Release [816 B] Get:3 file:/tmp/autopkgtest.I5zY18/binaries Release.gpg Ign:3 file:/tmp/autopkgtest.I5zY18/binaries Release.gpg Get:4 file:/tmp/autopkgtest.I5zY18/binaries Packages [1,379 B] Reading package lists... Reading package lists... Building dependency tree... Reading state information... Starting pkgProblemResolver with broken count: 0 Starting 2 pkgProblemResolver with broken count: 0 Done 0 upgraded, 0 newly installed, 1 reinstalled, 0 to remove and 0 not upgraded. Need to get 0 B/193 kB of archives. After this operation, 0 B of additional disk space will be used. Get:1 file:/tmp/autopkgtest.I5zY18/binaries orthanc-python 4.1+ds-2 [193 kB] (Reading database ... 196769 files and directories currently installed.) Preparing to unpack .../binaries/./orthanc-python.deb ... Unpacking orthanc-python (4.1+ds-2) over (4.1+ds-2) ... Setting up orthanc-python (4.1+ds-2) ... Processing triggers for libc-bin (2.37-15.1) ... Processing triggers for orthanc (1.12.3+dfsg-1) ... orthanc-restart-trigger: restarting the Orthanc service W: --force-yes is deprecated, use one of the options starting with --allow instead. Reading package lists... Done Building dependency tree... Done Reading state information... Done Note, selecting 'autopkgtest-satdep' instead of '/tmp/autopkgtest.I5zY18/2-autopkgtest-satdep.deb' Starting pkgProblemResolver with broken count: 0 Starting 2 pkgProblemResolver with broken count: 0 Done The following NEW packages will be installed: autopkgtest-satdep 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded. Need to get 0 B/736 B of archives. After this operation, 0 B of additional disk space will be used. Get:1 /tmp/autopkgtest.I5zY18/2-autopkgtest-satdep.deb autopkgtest-satdep amd64 0 [736 B] Selecting previously unselected package autopkgtest-satdep. (Reading database ... 196769 files and directories currently installed.) Preparing to unpack .../2-autopkgtest-satdep.deb ... Unpacking autopkgtest-satdep (0) ... Setting up autopkgtest-satdep (0) ... (Reading database ... 196769 files and directories currently installed.) Removing autopkgtest-satdep (0) ... run-unit-testSKIP Cannot enable needs-sudo restriction: no ordinary user available autopkgtest [12:47:49]: summary run-unit-testSKIP Cannot enable needs-sudo restriction: no ordinary user available autopkgtest [12:47:49]: Binaries: resetting testbed apt configuration Hit:1 http://deb.debian.org/debian unstable InRelease Reading package lists...
Re: [Debian-med-packaging] Bug#1062404: orthanc-python: flaky autopkgtest: Test failed with
On Sat, Mar 30, 2024 at 12:28:45PM +0100, Sébastien Jodogne wrote: > Hello, > > On 2/1/24 17:36, Nilesh Patra wrote: > > On Thu, Feb 01, 2024 at 01:55:21PM +0100, Sébastien Jodogne wrote: > > > Even if I'm tagged as the maintainer of "orthanc-python", I don't know > > > how autopkgtest/flaky works (I haven't implemented such tests by > > > myself). > > > > This is the script that runs for tests: > > > > > > https://salsa.debian.org/med-team/orthanc-python/-/blob/master/debian/tests/run-unit-test?ref_type=heads > > > > This is a basic script that should work and did work at least locally -- > > note that I only "sponsored" > > an upload for this package and did not delve very deep into the working > > detaiks. > > Please, I really need help here. Despite hours of trial and error, I'm still > unable to understand how autopkgtest works. Unfortunately, I can't find by > myself a Debian tutorial on how to run such tests. There's a tutorial inside the autopkgtest package itself: $ zcat /usr/share/doc/autopkgtest/README.running-tests.rst.gz > At time point, I build the package using the following command line: > > $ gbp buildpackage -us -uc --git-pristine-tar > --git-export-dir=../build-area/ -j4 > > Once compilation is done, how can I execute autopkgtest? I have tried > multiple variations, including the most basic: > > $ sudo autopkgtest . -- null > $ sudo autopkgtest ../build-area/orthanc-python_4.1+ds-2_amd64.changes -- > null This should work I suppose, in an unstable system. I however pass in the .deb instead of the .changes file. This is the command I use incase that helps you: $ sudo autopkgtest -B ../*.deb -- schroot unstable-amd64-sbuild You could use `-- null` if you don't use a schroot. If this still does not work, can you share the error that you see? > as well as the use of qemu: > > $ sudo autopkgtest-build-qemu unstable /var/tmp/autopkgtest-unstable.img > $ sudo autopkgtest ../build-area/orthanc-python_4.1+ds-2_amd64.changes -- > qemu /var/tmp/autopkgtest-unstable.img > > Could someone indicate me the proper way of calling autopkgtest so that I > can debug the test that was sponsored? I apologize that this upload is creating some un-necessary mess for you Best, Nilesh signature.asc Description: PGP signature
Re: [Debian-med-packaging] Bug#1062404: orthanc-python: flaky autopkgtest: Test failed with
Hello, On 2/1/24 17:36, Nilesh Patra wrote: On Thu, Feb 01, 2024 at 01:55:21PM +0100, Sébastien Jodogne wrote: Even if I'm tagged as the maintainer of "orthanc-python", I don't know how autopkgtest/flaky works (I haven't implemented such tests by myself). This is the script that runs for tests: https://salsa.debian.org/med-team/orthanc-python/-/blob/master/debian/tests/run-unit-test?ref_type=heads This is a basic script that should work and did work at least locally -- note that I only "sponsored" an upload for this package and did not delve very deep into the working detaiks. Please, I really need help here. Despite hours of trial and error, I'm still unable to understand how autopkgtest works. Unfortunately, I can't find by myself a Debian tutorial on how to run such tests. At time point, I build the package using the following command line: $ gbp buildpackage -us -uc --git-pristine-tar --git-export-dir=../build-area/ -j4 Once compilation is done, how can I execute autopkgtest? I have tried multiple variations, including the most basic: $ sudo autopkgtest . -- null $ sudo autopkgtest ../build-area/orthanc-python_4.1+ds-2_amd64.changes -- null as well as the use of qemu: $ sudo autopkgtest-build-qemu unstable /var/tmp/autopkgtest-unstable.img $ sudo autopkgtest ../build-area/orthanc-python_4.1+ds-2_amd64.changes -- qemu /var/tmp/autopkgtest-unstable.img Could someone indicate me the proper way of calling autopkgtest so that I can debug the test that was sponsored? Kind Regards, Sébastien-
Re: [Debian-med-packaging] Bug#1062404: orthanc-python: flaky autopkgtest: Test failed with
On Thu, Feb 01, 2024 at 01:55:21PM +0100, Sébastien Jodogne wrote: > Even if I'm tagged as the maintainer of "orthanc-python", I don't know > how autopkgtest/flaky works (I haven't implemented such tests by > myself). This is the script that runs for tests: https://salsa.debian.org/med-team/orthanc-python/-/blob/master/debian/tests/run-unit-test?ref_type=heads This is a basic script that should work and did work at least locally -- note that I only "sponsored" an upload for this package and did not delve very deep into the working detaiks. IDK why the logs are incomplete though. > I consequently forward your message to the Debian Med mailing > list, as I cannot help on this bug by myself. If you prefer, we can drop this test altogether and test locally before each upload. signature.asc Description: PGP signature
Re: [Debian-med-packaging] Bug#1062404: orthanc-python: flaky autopkgtest: Test failed with
Hello, Even if I'm tagged as the maintainer of "orthanc-python", I don't know how autopkgtest/flaky works (I haven't implemented such tests by myself). I consequently forward your message to the Debian Med mailing list, as I cannot help on this bug by myself. Regards, Sébastien- > I looked at the results of the autopkgtest of your package. I noticed > that it regularly fails on several architectures because it currently > blocks glibc. Unfortunately the log seems to be missing the actual > problem as it ends with: > 45s W0131 12:12:35.955520 MAIN FromDcmtkBridge.cpp:382] > Loading external DICOM dictionary: "/usr/share/libdcmtk17/private.dic" > 45s Test failed with > > Because the unstable-to-testing migration software now blocks on > regressions in testing, flaky tests, i.e. tests that flip between > passing and failing without changes to the list of installed packages, > are causing people unrelated to your package to spend time on these > tests. > > Don't hesitate to reach out if you need help and some more information > from our infrastructure.
