I know nothing about emacs lisp and its
> debhelper.
> Where did it remove any file?
Take a look at the two overrides in d/rules. You shouldn't need to know
anything about Emacs lisp to understand those.
[1] https://www.debian.org/doc/packaging-manuals/debian-emacs-policy
[2] We ca
to do it --
you can just delete them before you regenerate them/just overwrite
them. See the ebib source package for a very simple example of
regenerating a file without removing it from the upstream tarball.
Let me know what you think of these suggestions.
--
Sean Whitton
Upstream Author : David Bremner & Sean Whitton
* URL : https://pkg-emacsen.alioth.debian.org/
* License : GPL-3+
Section : devel
Changes since the last upload:
* Fix version comparison in elpa.pm.
Quote "0.90" so that the trailing 0 is not lost.
theme unless you have clear proof
> that upstream is withholding the source files.
>
> That is completely separate to the license concern mentioned in the
> issue that you filed of course.
Right: the unclear authorship/license is the main problem right now.
--
Sean Whitton
signature.asc
Description: PGP signature
Hello,
On Wed, Aug 31, 2016 at 08:07:52PM +0800, Boyuan Yang wrote:
> 2016-08-25 5:41 GMT+08:00 Sean Whitton :
> > You claim that the upstream files are only licensed under the GPL
> > version 2 (and no later version). But looking at the headers of the .h
> > and .cpp files
e looking at an older version: I removed "Suggests:
elpa-flycheck" and "Depends: www-browser". Are you using the version
from mentors?
The elpa-flycheck dependency is necessary because I'm using
dh_installdocs --link-doc=elpa-flycheck
--
Sean Whitton
signature.asc
Description: PGP signature
f you have my key
gbp buildpackage
Thanks.
--
Sean Whitton
signature.asc
Description: PGP signature
gt; to
> git. Can you recommend good documentation to convert my package? Thanks!
One easy way is to do this:
apt-get install git-buildpackage
gbp import-dsc mbpfan_1.9.1-1.dsc
--
Sean Whitton
ools.)
> >
> I will look into this. I did put in a pull request upstream with my Makefile
> changes and I believe it will be merged.
Great -- as I said, remove the moreinfo tag from the bug when you think
it's ready for another review.
--
Sean Whitton
arball compression (unless you're changing the source package name,
which I don't recommend, per our discussion on IRC).
--
Sean Whitton
signature.asc
Description: PGP signature
though there are masses
> of packages which don't implement them). Since you're adopting the
> package, I would rewrite the whole of d/rules using dh.
And indeed, with dh_elpa.
http://pkg-emacsen.alioth.debian.org/elpa-hello/
--
Sean Whitton
ars to test the installed C version against the perl test suite.
--
Sean Whitton
signature.asc
Description: PGP signature
o. (See the manpages for those tools.)
Hope we can make progress with this one! Thanks!
--
Sean Whitton
signature.asc
Description: PGP signature
rride. Perhaps it should be
stated clearly in the package description that install-mimic should be
used in combination with those tools.
--
Sean Whitton
signature.asc
Description: PGP signature
eady.
5. You could use the --linkdoc option of dh_installdocs so that the -dev
package installs the docs to /usr/share/doc/lua-stdlib. Easier for
users to find.
6. It would be nice to install AUTHORS to properly credit the people
who have worked on this software.
HTH!
--
Sean Whitton
signature.asc
Description: PGP signature
5-3 # if you have my key
gbp buildpackage
Thanks.
--
Sean Whitton
signature.asc
Description: PGP signature
On Thu, Aug 25, 2016 at 11:41:11AM +0800, Paul Wise wrote:
> On Thu, Aug 25, 2016 at 5:41 AM, Sean Whitton wrote:
>
> > i.e. images/purple-theme/synchronize.png was probably created with the
> > GIMP. That means the preferred format for modifying this file is
> &g
On Wed, Aug 24, 2016 at 02:41:38PM -0700, Sean Whitton wrote:
> There's a further issue with at least some of the files in images/. The
> check-all-the-things tool reveals:
>
> # Check with upstream where the GIMP XCF source files are.
> $ find -type f \( -iname
Hello,
On Wed, Aug 24, 2016 at 12:37:12PM -0700, Sean Whitton wrote:
> > Hold on, are you looking at upstream copyright file?
> > That file is outdated and not used. Please check the file on Debian branch:
> >
> > https://github.com/hosiet/nixnote2/blob/debian/debian/copy
en `make install`? You could provide
> > them with your d/install file to help.
>
> Thanks, I will file the issue later. This is not of top priority.
> Previously upstream did not provide the `make install' target but to rely on
> `cp'. That target was added recently from a PR but the quality is poor.
Okay, good to know. Agreed that it is low priority.
In summary -- the package is in great shape, and the only issues are the
copyright and licensing stuff above, plus packaging QEverCloud. Great
work so far.
--
Sean Whitton
signature.asc
Description: PGP signature
- You should add yourself to the copyright for debian/*.
- There is a syntax error too :) In the GPL-2+ paragraph.
- Looks like the manpage is copyright Vincent Cheng.
Docs go in /usr/share/doc/nixnote2 not /usr/share/nixnote2 -- you're
installing several to the wrong place, but some to the right place.
The comments in your d/rules file are great. Have you filed an upstream
bug about the broken `make install`? You could provide them with your
d/install file to help.
--
Sean Whitton
signature.asc
Description: PGP signature
using pristine-tar(1).)
Thanks.
--
Sean Whitton
signature.asc
Description: PGP signature
On Tue, Aug 16, 2016 at 08:43:05AM +0200, Ferenc Wágner wrote:
> Sean Whitton writes:
>
> > For example, support I'm packaging 0~git.abc123d. This version number
> > might be used because I'm basing my packaging on upstream git commit
> > whose hash is uniquely
"must-fixes" are quite serious, so I'll end my review here. If you
can deal with the above I'll probably be able to find some more things
you can improve :)
--
Sean Whitton
signature.asc
Description: PGP signature
' (since gbp replaces '~' with '_' in tags due to git
restrictions). Then `gbp buildpackage` would generate the tarball as
needed.
Just calling `git archive` yourself is fine. The only advantage of the
method I just described is that it's easier to remember/document f
ense (to
this native speaker, anyway).
--
Sean Whitton
signature.asc
Description: PGP signature
push
>
> The last command is missing a -k. Otherwise it will fail because gpg cannot
> find your private key on my system. ;)
Ah, couldn't test that part ;)
> Thanks a lot for your work!
>
> Your changes all look good and thus I built, tested and uploaded the package
> unstable.
Thanks for sponsoring my QA upload :)
--
Sean Whitton
signature.asc
Description: PGP signature
with this, I can help -- I use dgit for DM uploads.
If you don't like dgit, I've uploaded a source package to mentors:
dget -x http://mentors.debian.net/debian/pool/main/p/pdfrw/pdfrw_0.2-3.dsc
Thanks.
--
Sean Whitton
signature.asc
Description: PGP signature
should try to write the
changelog so it can easily be understood by those not involved in the
pkg-emacsen group.
--
Sean Whitton
signature.asc
Description: PGP signature
Upstream Author : David Bremner & Sean Whitton
* URL : https://pkg-emacsen.alioth.debian.org/
* License : GPL-3+
Section : devel
Changes since the last upload:
* Attempt to sanitise versions from DEB_* env vars so that Emacs accepts
them as ELPA package v
dget -x
http://mentors.debian.net/debian/pool/main/p/python-argh/python-argh_0.26.1-1.2.dsc
--
Sean Whitton
signature.asc
Description: PGP signature
variable might not be set.
Download with dget:
dget -x
http://mentors.debian.net/debian/pool/main/p/python-argh/python-argh_0.26.1-1.1.dsc
Thanks.
--
Sean Whitton
signature.asc
Description: PGP signature
ke 'changelog.txt'. But I might be wrong.
At debhelper compat 9, I think that you could remove a lot of lines from
your rules file. For example, you probably don't need these lines:
DPKG_EXPORT_BUILDFLAGS = 1
include /usr/share/dpkg/default.mk
include /usr/share/
s hard
to review the package because of items 7--11 above. So I'll leave you
with these things to work on for now and then take another look :)
--
Sean Whitton
signature.asc
Description: PGP signature
Hello,
On Wed, Aug 03, 2016 at 10:21:46AM +0200, Jonas Meurer wrote:
> Please note that this will delete *all* chroots and their configuration.
> I woud prefer something like:
That's what he said he wanted to do :)
--
Sean Whitton
signature.asc
Description: PGP signature
for making the chroot on the sbuild
wiki page, this should do it:
# rm -rf /srv/chroot/* /etc/sbuild/chroot/*-sbuild
/etc/schroot/chroot.d/*-sbuild
If you didn't use the suggestions on the wiki page, just start nuking
stuff in those three directories.
--
Sean Whitton
signature.asc
Description: PGP signature
I think you have to start again
with a 1.2.3+dfsg-1 Debian revision and the new tarball.
--
Sean Whitton
signature.asc
Description: PGP signature
r than maybe experimental. When I talked about low priority in my
previous e-mail, I meant to refer to disruptive and major changes as you
describe. Thanks!
[1] https://lists.debian.org/debian-devel-announce/2013/11/msg7.html
--
Sean Whitton
signature.asc
Description: PGP signature
Hello,
On Tue, Aug 02, 2016 at 12:19:55AM +0200, Jack Henschel wrote:
> On 07/27/2016 03:28 AM, Sean Whitton wrote:
> > I can't sponsor the package, but I hope that the following review is
> > useful to you.
> Thanks for your very in-depth review, it is very helpful!
N
Done.
> > Package updated on mentors and in my git repository.
>
> Uploaded to NEW.
Thanks!
--
Sean Whitton
signature.asc
Description: PGP signature
control: tag -1 -moreinfo
Hello,
On Wed, Jul 20, 2016 at 02:40:57PM +0800, Paul Wise wrote:
> On Wed, Jul 20, 2016 at 7:25 AM, Sean Whitton wrote:
>
> > I am looking for a sponsor for my package self-destructing-cookies.
>
> I am willing to sponsor this.
Thank you
: libs
Changes since the last upload:
* Non-maintainer upload.
* Add gcc-6-build.patch (Closes: #811933).
Download with dget:
dget -x
http://mentors.debian.net/debian/pool/main/g/geis/geis_2.2.17-1.1.dsc
Thanks.
--
Sean Whitton
signature.asc
Description: PGP signature
e and then things should hopefully be cleaned
> up.)
collab-maint definitely isn't compulsory, just in case you didn't know.
I haven't actually tried to build, install and run the package yet; I
thought this review was long enough that I should hit 'send' :)
--
Sean Whitton
signature.asc
Description: PGP signature
On Sun, Jul 24, 2016 at 07:57:36PM -0700, Sean Whitton wrote:
> Or build it with gbp:
>
> gbp clone --pristine-tar
> https://anonscm.debian.org/git/pkg-emacsen/pkg/helm-projectile
> git checkout debian/0.14.0-1
> git verify-tag debian/0.14.0-1 # if you hav
On Sun, Jul 24, 2016 at 07:53:25PM -0700, Sean Whitton wrote:
> Or build it with gbp:
>
> gbp clone --pristine-tar
> https://anonscm.debian.org/git/pkg-emacsen/pkg/projectile
> git checkout debian/0.14.0-1
> git verify-tag debian/0.14.0-1 # if you hav
t/pkg-emacsen/pkg/persp-projectile
# head should be: 3b169889428a3c51b2faae4035916d5493cb06cd
gbp buildpackage
Thanks.
Sean Whitton
signature.asc
Description: PGP signature
h gbp:
gbp clone --pristine-tar
https://anonscm.debian.org/git/pkg-emacsen/pkg/helm-projectile
git checkout debian/0.14.0-1
git verify-tag debian/0.14.0-1 # if you have my key
gbp buildpackage
Thanks.
Sean Whitton
signature.asc
Description: PGP signature
ve my key
gbp buildpackage
Thanks.
Sean Whitton
signature.asc
Description: PGP signature
three changelog entries is
likely to confuse people into thinking there have been three uploads to
Debian.
--
Sean Whitton
signature.asc
Description: PGP signature
Dear Emily,
Are you still interested in packaging maldetect for Debian? We
generally close RFSs which have been reviewed, and where there is no
response to the review, after six weeks.
--
Sean Whitton
signature.asc
Description: PGP signature
ry packages.
10. You could install the content of the samples/ subdir into the
relevant /usr/share/doc/*/examples directory.
That's all for now.
--
Sean Whitton
signature.asc
Description: PGP signature
eams write "far from mature" when really the
software is mature and is suitable for Debian.
Do you consider yabar to be sufficiently mature? It would be good to
hear a justification for your view.
--
Sean Whitton
signature.asc
Description: PGP signature
e
current situation with source packages.
Informative DebConf BoF on the issue:
http://meetings-archive.debian.net/pub/debian-meetings/2012/debconf12/low/861_Git_and_Debian_Packaging.ogv
--
Sean Whitton
ng-cookies/self-destructing-cookies_0.4.10-1.dsc
Or build it with gbp:
gbp clone --pristine-tar
https://anonscm.debian.org/git/pkg-mozext/self-destructing-cookies
git checkout debian/0.4.10-1
git verify-tag debian/0.4.10-1 # if you have my key
gbp buildpackage
Thanks.
-
s most sense for someone typing
apt-get
--
Sean Whitton
s like this one:
<https://vincent.bernat.im/en/blog/2012-gpg-transition-new-key.html>
However, most Debian people will want to meet you in person again in
order to re-sign your key.
--
Sean Whitton
Hello,
On Sun, Jul 10, 2016 at 06:13:03AM +0900, HAYASHI Kentaro wrote:
> P.S. Does anyone knows the way to check [RC] case easily - the package
> contains
> fixed RC bugs
> usually listed Closes:# in debian/changelog?
Yes: I think that's the only way you can find out.
--
Sean Whitton
Thanks.
--
Sean Whitton
ngelog without having it uploaded yet)
What did you have in mind here?
> and also a pull-debian-source for the source, and a debdiff between
> them might *really* simplify the sponsors work!
That would be great.
--
Sean Whitton
ve done those, please remove the moreinfo tag from this bug.
Thanks!
--
Sean Whitton
Hello,
Unfortunately your watch file doesn't seem to work now.
uscan warn: In directory ., downloading
https://github.com/Tookmund/setcolortemperature/releases/download/v1.1/setcolortemperature-1.1.tar.gz.asc
failed: 404 Not Found
--
Sean Whitton
Hello,
On Thu, Jul 07, 2016 at 09:53:01PM +0200, James Cowgill wrote:
> > Why ?
>
> I'm not entirely sure, but it's been like this since forever.
>From the dpkg author:
<https://lists.debian.org/debian-devel/2014/11/msg00672.html>
--
Sean Whitton
Hello,
Since you are upstream, would you consider providing a changelog that
you can install? Lintian is saying no-upstream-changelog and it seems
we can easily fix that :)
--
Sean Whitton
t mine, but written by Ingo Thies, who would have
> copyright over the whitepoints data if it is copyrightable. Putting it
> there was the advice I got from debian-legal (see below).
Thanks for the link to the debian-legal thread. That was useful for me
to read. I think you are good if you re-organise the Copyright: for
sct.c as suggested above.
> > 10. You're missing at least one build dependency. Please try building
> > in a clean sid chroot (see the pbuilder or sbuild tools).
>
> Yep. Was missing libx11-dev and libxrandr-dev (dpkg -S is the best :) ).
> I've fixed it now. Thanks for finding that.
It builds now, and I also confirmed that it installs and works.
--
Sean Whitton
ame bugs as
you while your upload is in preparation, you can set yourself as the
owner of the bugs in question.
--
Sean Whitton
whitepoints data copyright 2013 Ingo Thies
License: public-domain-sct and public-domain-colorramp
9. Please install the README into /usr/share/doc.
10. You're missing at least one build dependency. Please try building
in a clean sid chroot (see the pbuilder or sbuild tools).
--
Sean Whitton
On Tue, Jul 05, 2016 at 09:13:10AM +, Sean Whitton wrote:
> Download with dget:
>
> dget -x
> http://mentors.debian.net/debian/pool/main/lib/libstroke/libstroke_0.5.1-8.dsc
Should be:
dget -x
http://mentors.debian.net/debian/pool/main/libs/libstroke/libstroke_0.5.1-8
age
Thanks.
--
Sean Whitton
close 829568
thanks
--
Sean Whitton
tream, so I'm taking on that role myself.
* Package name: git-remote-gcrypt
Version : 1.0.0-1
Upstream Author : engla, Joey Hess, Sean Whitton and contributors
* URL : https://git.spwhitton.name/git-remote-gcrypt
* License : GPL-2+
Section : vc
control: noowner -1
control: tag -1 +confirmed -moreinfo
Dear Dmitry,
In my view evil-paredit-el is ready to be uploaded, bar `dch -r`.
Thanks.
--
Sean Whitton
upload:
* Non-maintainer upload.
* Add missing dependency on python3-pkg-resources (Closes: #818617).
Download with dget:
dget -x
http://mentors.debian.net/debian/pool/main/i/img2pdf/img2pdf_0.2.0-1.1.dsc
Thanks.
--
Sean Whitton
>
> Which commit?
86d8ab33c, 6eea8638a
--
Sean Whitton
ELPA, melpa ships 25beta. Who would benefit
> from forwarding?
Someone installing manually from GitHub.
--
Sean Whitton
various versions of paredit.
You should definitely forward the dependency relaxation upstream: they
shouldn't be declaring so tight a dependency if they have the
compatibility code.
--
Sean Whitton
m an NMU or team upload. What information
would I want to know if I was doing that? That's a helpful heuristic.
--
Sean Whitton
IBUTION BY PACKAGE MANAGERS
SUCH AS APT" so it looks like we'll be on 24 for a while.
--
Sean Whitton
. I think that fails DEP-3 but that might be okay for the sake of
sane gbp usage. Up to the judgment of the DD who sponsors!
Thanks for your patience.
--
Sean Whitton
a clean
build in pbuilder/sbuild which isn't possible due to the dtach issue.
You might consider re-running dch -r to refresh the timestamp in the
changelog so it lies after all our changes.
--
Sean Whitton
you file an
upstream bug report, explain what you did to fix the problem for the
Debian package, and put a link to that bug report in the Forwarded:
header of the patch and also as a comment in d/rules.
Another thing :) I don't think you need to invoke find(1) in d/rules.
You can just do something like this:
sed -i 's#foo..'
debian/elpa-evil/usr/share/emacs/site-lisp/elpa-src/evil-*/evil-autoloads.el
That's more explicit and easier to understand.
--
Sean Whitton
generally resort to using quilt :(
--
Sean Whitton
ream, they have to deal with either:
> [...]
> * evil mode is autoloaded, interactive and with sane description. Ugliness
>in code.
Do you know whether the problem if Debian-specific, or if it also arises
when installing evil from MELPA?
--
Sean Whitton
>
> > Error in post-command-hook (evil-repeat-post-hook): (void-function
> > evil-repeat-post-hook)
> > Error in pre-command-hook (evil-repeat-pre-hook): (void-function
> > evil-repeat-pre-hook)
>
> Patched it. Check again.
Nice work. Have you forwarded the fix upstream?
--
Sean Whitton
n this case, it's not
necessary since there is no test suite.
--
Sean Whitton
ode, I get this:
Error in post-command-hook (evil-repeat-post-hook): (void-function
evil-repeat-post-hook)
Error in pre-command-hook (evil-repeat-pre-hook): (void-function
evil-repeat-pre-hook)
Does that happen for you if you move .emacs.d? I'm actually testing on
Ubuntu 16.04 instead of Debian but it shouldn't be relevant.
--
Sean Whitton
t/apvlv.git
cd apvlv
git checkout debian/0.1.5+dfsg-1
git verify-tag debian/0.1.5+dfsg-1 # if you have my key
gbp buildpackage
Thanks.
--
Sean Whitton
signature.asc
Description: PGP signature
esting we always use the emacs- prefix? I don't see why we
would need to do that. goto-chg is fine in this case. Though you could
bring it up on debian-emacsen@l.d.o.
--
Sean Whitton
signature.asc
Description: PGP signature
Thu, Jun 23, 2016 at 07:40:56PM +0200, Jakub Wilk wrote:
> * Sean Whitton , 2016-06-23, 23:36:
> > > > https://mentors.debian.net/debian/pool/main/libs/libstroke/libstroke_0.5.1-7.dsc
>
> Looks pretty good to me.
> Just a few minor points:
>
> > + * Bump de
Hello,
Thank you for taking the time to look at my upload.
On Thu, Jun 23, 2016 at 03:58:13PM +0200, Jakub Wilk wrote:
> * Sean Whitton , 2016-06-23, 22:22:
> > > > * Replace libstroke0.postinst with ldconfig trigger in
> > > > libstroke0.triggers.
> &g
t think uscan can
extract the version from the contents of the file: it needs the URL of
the wiki page to change with each version and that's not going to
happen. I think we have to abandon this goal.
> We probably need to make emacsen policy more... verbose.
I agree. Please feel free to edit the team ikiwiki.
--
Sean Whitton
signature.asc
Description: PGP signature
Hello,
On Thu, Jun 23, 2016 at 03:15:20PM +0200, Jakub Wilk wrote:
> * Sean Whitton , 2016-06-23, 22:02:
> > * Replace libstroke0.postinst with ldconfig trigger in
> > libstroke0.triggers.
>
> You shouldn't need this file; dh_makeshlibs is supposed to register the
&g
t -x
http://mentors.debian.net/debian/pool/main/l/libstroke/libstroke_0.5.1-7.dsc
Thanks.
--
Sean Whitton
signature.asc
Description: PGP signature
(1) for how to do this: basically, raise to compat
level 10 and then set DH_ELPA_TEST_* env vars.
5. Please add a d/watch.
--
Sean Whitton
signature.asc
Description: PGP signature
utoloading.
Generally with Debian's ELPA packages, the user should be able to just
M-x foo-mode RET but in this case that doesn't work. Please investigate!
--
Sean Whitton
signature.asc
Description: PGP signature
the Emacs Wiki counts as a
"Homepage". It's the correct thing to put in Source: field of
d/copyright, but I don't think it should go in d/control.
--
Sean Whitton
signature.asc
Description: PGP signature
On Wed, Jun 22, 2016 at 10:30:23AM +0200, JCF Ploemen wrote:
> ps: please do cc me on replies, as the bts doesn't keep bug submitters
> in the loop automagically.
If you subscribe to debian-mentors@lists.debian.org you'll get all the messages.
--
Sean Whitton
signature.asc
debian/1.4.40-2 # if you have my key
gbp buildpackage
Successful sbuild:
http://debomatic-i386.debian.net/distribution#unstable/burp/1.4.40-2/buildlog
Thanks.
--
Sean Whitton
signature.asc
Description: PGP signature
hing about the NMU policy
I'm misunderstanding, so David can offer a justification.
--
Sean Whitton
signature.asc
Description: PGP signature
e C
compiler or something like that.
Perhaps I misunderstood you and you only had this latter case in mind.
--
Sean Whitton
signature.asc
Description: PGP signature
ilable.
>
> $ git tag | grep 0.6.6
> [empty]
Hmm, nevermind, not sure where I thought I'd found 0.6.8.
> > 4. Please apply a PGP-signed tag to the correct commit in the team
> >repo. Then it will appear correctly on PET.[1]
>
> You mean, I should gpg-tag '
301 - 400 of 537 matches
Mail list logo
