Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system

[Eric Heintzmann]

Hi Gianfranco,


Le 16/05/2016 15:16, Gianfranco Costamagna a écrit :
> Hi Eric,
>
> nice indeed, so please wait some more time, and ping me back in 7-15 days if 
> nobody
> picked up the work in the meanwhile.
>
>
Iain R. Learmonth has uploaded gnustep-make.

Thanks to you for helping me to improve gnustep-make packaging.

Eric

Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system

[Eric Heintzmann]

oops !  accidentally removed gsdh_gnustep symlinks !
Fixed and reuploaded

add this line to changelog

  * Provide a new debian/gnustep-make.links.

https://mentors.debian.net/package/gnustep-make
or
dget -x
https://mentors.debian.net/debian/pool/main/g/gnustep-make/gnustep-make_2.6.8-1.dsc

Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system

[Eric Heintzmann]

Hi

Le 17/05/2016 11:52, Gianfranco Costamagna a écrit :
>
>
> Depends: gnustep-common (>= ${source:Version}),
> gnustep-common (<< ${source:Version}.1~),
> gobjc,
> -autotools-dev,
> ${misc:Depends},
> -${gnustep:Depends}
> +${perl:Depends}
> +Replaces: gnustep-common (<< 2.6.8-1)
> +Breaks: gnustep-common (<< 2.6.8-1)
>
>
>
> seems fine [1], just two questions: why did you drop gnustep:Depends?
What is the second question ?

Thanks
Eric

Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system

[Eric Heintzmann]

Le 17/05/2016 19:27, Eric Heintzmann a écrit :
> Hi,
> Reuploaded !

https://mentors.debian.net/package/gnustep-make

or

dget -x 
https://mentors.debian.net/debian/pool/main/g/gnustep-make/gnustep-make_2.6.8-1.dsc



Updated changelog:

gnustep-make (2.6.8-1) unstable; urgency=low

  * Team upload.
  * In agreement with the Debian GNUstep maintainers,
add myself as new Co-Maintainer.
  * New upstream version
  * Remove patches applied upstream:
+ honor-CFLAGS.patch
+ info-document-missing-direntry.patch
+ library-combo-whatis-entry.patch
+ manpage-spelling-errors.patch
+ test-clean-core.patch
+ texi-section-level.patch
  * Update no-gzip-timestamps.patch.
  * Update use-makeinfo.patch.
  * Bump Standards-Version to 3.6.8 in debian/control.
  * Set debhelper compatibility level to 9.
  * Update Vcs-* fields in debian/control
  * Rewrite debian/rules:
+ Use dh $@ --with autoreconf and --buiddirectory
+ No more use autotools-dev: drop dependencies
+ Disable strict gnustep-make version 2 mode for now
+ Build and install doc in *-indep sequence (Closes: #823281, #806197)
+ Use --with-layout=debian in configure scripts:
  - remove fhs-system-includedir.patch
  - remove obsolete {gnustep:Depends} var in debian/control
+ Remove debian/control.in file, useless now
+ Remove debian/fhs/gnustep-common.disr.in, now useless
+ Remove debian/fhs/gnustep-common.links.in, now useless
+ Remove debian/gnustep-make.dirs.in, now useless
  * Provide a new debian/clean file.
  * Update debian/copyright file.
  * Update debian/watch file to version 4.
  * Replace debian/upstream/signig-key.pgp by signing-key.asc:
remove debian/source/include-binaries file.
  * Provide a new debian/gnustep-make-doc.install file.
  * Provide a new debian/gnustep-make-doc.info file.
  * Rename debian/gnustep-make-doc.doc-base to
debian/gnustep-make-doc.doc-base.gnustep-make.
  * Provides new debian/gnustep-make-doc.doc-base.* files.
  * Provide a new debian/gnustep-make.install file.
  * Provide a new debian/gnustep-make.lintian-overrides file.
  * Provide a new debian/gnustep-make.manpages file:
remove debian/gnustep-test.1 file, useless now.
  * Provide a new debian/gnustep-make.docs file.
  * Rename debian/fhs dir to debian/dh_gnustep.
  * gnustep-make now Depends on {perl:Depends}
  * New debian/addons dir:
+ remove debian/gs_make.in and debian/config.mk.in, now useless
+ new gs_make and config.mk files in debian/addons dir
+ move debian/gs_make.1 to debian/addons dir
  * Remove debian/gnustep-make.dirs.in, useless now.
  * Provide a new debian/gnustep-common.maintscript file.
  * Provide a new debian/gnustep-common.install file.
  * Provide a new debian/gnustep-common.manpages file.
  * Provide a new debian/gnustep-common.docs file.
  * Provide a new debian/gnustep-common.dirs file.
  * Provide a new debian/gnustep-common.links file.
  * Provide a new debian/gnustep-common.lintian-overrides file.
  * Move gnustep-config.1 manpage to gnustep-make package:
gnustep-make now Replaces and Breaks gnustep-common (<<2.6.8-1).

 -- Eric Heintzmann   Tue, 03 May 2016 22:13:30
+0200

Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system

[Eric Heintzmann]

Hi,
Reuploaded !

Le 17/05/2016 18:58, Eric Heintzmann a écrit :
>
>
> Le 17/05/2016 11:52, Gianfranco Costamagna a écrit :
>> Hi,
>>> switch to autoreconf done
>>
>> nice!
>>
>> little nitpick before answering to the open points:
>> * debian/patches/manpage-spelling-errors.patch: New, fix two spelling
>> +
>> errors.
>>
>>
>> there is a new space in changelog
>> (pull-debian-source gnustep-make debdiff of the two dsc files, filterdiff 
>> the debian changes, you will
>> see it)
>>
> Fixed, thanks
>
>
>>> Breaks + Replace done
>> Depends: gnustep-common (>= ${source:Version}),
>> gnustep-common (<< ${source:Version}.1~),
>> gobjc,
>> -autotools-dev,
>> ${misc:Depends},
>> -${gnustep:Depends}
>> +${perl:Depends}
>> +Replaces: gnustep-common (<< 2.6.8-1)
>> +Breaks: gnustep-common (<< 2.6.8-1)
>>
>>
>>
>> seems fine [1], just two questions: why did you drop gnustep:Depends?
>  Let see at dh_gnustep manpage:
>
> "dh_gnustep is a program based on debhelper that is responsible for
> doing GNUstep-specific modifications, such as moving files in the
> GNUstep hierarchy within the System domain, rooted at
>  /usr/lib/GNUstep/System, to Filesystem Hierarchy Standard
> (FHS)-compliant locations."
>
> it is obsoleted by configure option --with-layout=debian
> And I have no perl skills to update it.
>
>
> Let s look again at dh_gnustep manpage:
>
> "GNUstep dependencies:
> Adds any extra dependencies needed for GNUstep.  Currently, the
> only dependency added is to ensure that the package uses the same
> filesystem layout as the other GNUstep packages installed on the
> system."
>
> In reality {gnustep:Depends} just add a dependencies to virtual package
> provided by gnustep-common: gnustep-fslayout-fhs
> Of course I can add a dependency to gnustep-fslayout-fhs,
> but since gnustep-make depends on latest gnustep-common,
> it is not needed.
>
> I will update changelog like that:
>
> + Use --with-layout=debian in configure scripts:
>   - remove fhs-system-includedir.patch
>   - remove obsolete {gnustep:Depends} var in debian/control
>> [1] 
>> http://debomatic-amd64.debian.net/distribution#unstable/gnustep-make/2.6.8-1/piuparts
>
> Thanks for the link
>
> Thanks,
> Eric
>
>
>
>

Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system

[Eric Heintzmann]

Le 17/05/2016 11:52, Gianfranco Costamagna a écrit :
> Hi,
>> switch to autoreconf done
>
>
> nice!
>
> little nitpick before answering to the open points:
> * debian/patches/manpage-spelling-errors.patch: New, fix two spelling
> +
> errors.
>
>
> there is a new space in changelog
> (pull-debian-source gnustep-make debdiff of the two dsc files, filterdiff the 
> debian changes, you will
> see it)
>
Fixed, thanks


>> Breaks + Replace done
>
> Depends: gnustep-common (>= ${source:Version}),
> gnustep-common (<< ${source:Version}.1~),
> gobjc,
> -autotools-dev,
> ${misc:Depends},
> -${gnustep:Depends}
> +${perl:Depends}
> +Replaces: gnustep-common (<< 2.6.8-1)
> +Breaks: gnustep-common (<< 2.6.8-1)
>
>
>
> seems fine [1], just two questions: why did you drop gnustep:Depends?
 Let see at dh_gnustep manpage:

"dh_gnustep is a program based on debhelper that is responsible for
doing GNUstep-specific modifications, such as moving files in the
GNUstep hierarchy within the System domain, rooted at
 /usr/lib/GNUstep/System, to Filesystem Hierarchy Standard
(FHS)-compliant locations."

it is obsoleted by configure option --with-layout=debian
And I have no perl skills to update it.


Let s look again at dh_gnustep manpage:

"GNUstep dependencies:
Adds any extra dependencies needed for GNUstep.  Currently, the
only dependency added is to ensure that the package uses the same
filesystem layout as the other GNUstep packages installed on the
system."

In reality {gnustep:Depends} just add a dependencies to virtual package
provided by gnustep-common: gnustep-fslayout-fhs
Of course I can add a dependency to gnustep-fslayout-fhs,
but since gnustep-make depends on latest gnustep-common,
it is not needed.

I will update changelog like that:

+ Use --with-layout=debian in configure scripts:
  - remove fhs-system-includedir.patch
  - remove obsolete {gnustep:Depends} var in debian/control
>
> [1] 
> http://debomatic-amd64.debian.net/distribution#unstable/gnustep-make/2.6.8-1/piuparts

Thanks for the link

Thanks,
Eric

Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system

[Gianfranco Costamagna]

Hi,
>switch to autoreconf done



nice!

little nitpick before answering to the open points:
* debian/patches/manpage-spelling-errors.patch: New, fix two spelling
+
errors.


there is a new space in changelog
(pull-debian-source gnustep-make debdiff of the two dsc files, filterdiff the 
debian changes, you will
see it)

>Breaks + Replace done


Depends: gnustep-common (>= ${source:Version}),
gnustep-common (<< ${source:Version}.1~),
gobjc,
-autotools-dev,
${misc:Depends},
-${gnustep:Depends}
+${perl:Depends}
+Replaces: gnustep-common (<< 2.6.8-1)
+Breaks: gnustep-common (<< 2.6.8-1)



seems fine [1], just two questions: why did you drop gnustep:Depends?

[1] 
http://debomatic-amd64.debian.net/distribution#unstable/gnustep-make/2.6.8-1/piuparts


cheers,

Gianfranco

Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system

[Eric Heintzmann]

Hi,

Le 16/05/2016 21:15, Gianfranco Costamagna a écrit :
> Hi Eric,
>
>
> As you wish, you can switch in a later upload, or do it now and maybe
> fix/revert in case of troubles 

switch to autoreconf done

> I don't think so, but I can review a patch/package, because some lines
> without their context have no meaning (you need to put the
> breaks+replaces in the right binary package). 

Breaks + Replace done

>> OK, I'm going to update gnustep make to do improvements you suggested.
>> Since I am not familiar with mentors rules, I have a question :
>> Should I prepare a new revision (ie 2.6.8-2) or should I update the
>> 2.6.8-1 revision and reupload it ?
>
> please upload -1 revision until it gets sponsored!

OK I've just reuploaded gnustep-make 2.6.8-1

Changes:

Updated changelog
Updated control file
Remove all debian/*/*.in files

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/gnustep-make


  Alternatively, one can download the package with dget using this command:

dget -x
https://mentors.debian.net/debian/pool/main/g/gnustep-make/gnustep-make_2.6.8-1.dsc


Changelog:

gnustep-make (2.6.8-1) unstable; urgency=low

  * Team upload.
  * In agreement with the Debian GNUstep maintainers,
add myself as new Co-Maintainer.
  * New upstream version
  * Rremove patches applied upstream:
+ honor-CFLAGS.patch
+ info-document-missing-direntry.patch
+ library-combo-whatis-entry.patch
+ manpage-spelling-errors.patch
+ test-clean-core.patch
+ texi-section-level.patch
  * Update no-gzip-timestampss.patch.
  * Update use-makeinfo.patch.
  * Bump Standards-Version to 3.6.8 in debian/control.
  * Set debhelper combatibility level to 9.
  * Update Vcs-* fields in debian/control
  * Remove no more needed {gnustep:Depends} var in debian/control.
  * Rewrite debian/rules:
+ Use dh $@ --with autotools-dev and --buiddirectory
+ No more use autotools-dev: drop dependencies
+ Disable strict gnustep-make version 2 mode for now
+ Build and install doc in *-indep sequence (Closes: #823281, #806197)
+ Use --with-layout=debian in configure scripts:
  remove fhs-system-includedir.patch
+ Remove debian/control.in file, useless now
+ Remove debian/fhs/gnustep-common.disr.in, now useless
+ Remove debian/fhs/gnustep-common.links.in, now useless
+ Remove debian/gnustep-make.dirs.in, now useless
  * Provide a new debian/clean file.
  * Update debian/copyright file.
  * Update debian/watch file to version 4.
  * Replace debian/upstream/signig-key.pgp by signing-key.asc:
remove debian/source/include-binaries file.
  * Provide a new debian/gnustep-make-doc.install file.
  * Provide a new debian/gnustep-make-doc.info file.
  * Rename debian/gnustep-make-doc.doc-base to
debian/gnustep-make-doc.doc-base.gnustep-make.
  * Provides new debian/gnustep-make-doc.doc-base.* files.
  * Provide a new debian/gnustep-make.install file.
  * Provide a new debian/gnustep-make.lintian-overrides file.
  * Provide a new debian/gnustep-make.manpages file:
remove debian/gnustep-test.1 file, useless now.
  * Provide a new debian/gnustep-make.docs file.
  * Rename debian/fhs dir to debian/dh_gnustep.
  * gnustep-make now Depends on {perl:Depends}
  * New debian/addons dir:
+ remove debian/gs_make.in and debian/config.mk.in, now useless
+ new gs_make and config.mk files in debian/addons dir
+ move debian/gs_make.1 to debian/addons dir
  * Remove debian/gnustep-make.dirs.in, useless now.
  * Provide a new debian/gnustep-common.maintscript file.
  * Provide a new debian/gnustep-common.install file.
  * Provide a new debian/gnustep-common.manpages file.
  * Provide a new debian/gnustep-common.docs file.
  * Provide a new debian/gnustep-common.dirs file.
  * Provide a new debian/gnustep-common.links file.
  * Provide a new debian/gnustep-common.lintian-overrides file.
  * Move gnustep-config.1 manpage to gnustep-make package:
gnustep-make now Replaces: and Breaks gnustep-common (<<2.6.8-1).

 -- Eric Heintzmann   Tue, 03 May 2016 22:13:30
+0200

Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system

[Eric Heintzmann]

Hi Gianfranco,

Le 16/05/2016 21:15, Gianfranco Costamagna a écrit :
> Hi Eric,
>
>
>> I think there are too many changes in this release.
>> Is it okay to remove autoreconf for now,
>> and replace autotools-dev by autoreconf at next release ?
>
> it is, just a side note: I never had issues with that move, and in general 
> issues
> arises when: the configure/Makefiles are patched (because you obviously need 
> to patch
> configure.ac and Makefile.am instead), or bad config.guess/config.sub files
> (and usually the result is a build failure on some ports).
>
> As you wish, you can switch in a later upload, or do it now and maybe 
> fix/revert in
> case of troubles
Finally, I'm going to swith to autoreconf now.
>> Reorg: gnustep-common and gnustep-make existed; move one file from
>> gnustep-common to gnustep-make; new gnustep-common does not require new
>> gnustep-make
>> Breaks: gnustep-make (<<2.6.8-1)  
>> Breaks: gnustep-common (<<2.6.8-1)
>>
>> Is it okay to do that?
>
> I don't think so, but I can review a patch/package, because some lines 
> without their
> context have no meaning (you need to put the breaks+replaces in the right 
> binary
> package).
Finally, I reflected and I think we should not mix different version of
gnustep-make and gnustep-common binary packages.
It is unsupported by upstream andI could lead to strange  bugs.

gnustep-common will Breaks: gnustep-make (<< {source:Version})
and
gnustep-make will Depends: gnustep-common(>= {source:Version}

It should prevents the mix of versions and thus Break or Replaces are
now useless

Thanks
Eric



signature.asc
Description: OpenPGP digital signature

Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system

[Gianfranco Costamagna]

Hi Eric,


>I think there are too many changes in this release.

>Is it okay to remove autoreconf for now,
>and replace autotools-dev by autoreconf at next release ?


it is, just a side note: I never had issues with that move, and in general 
issues
arises when: the configure/Makefiles are patched (because you obviously need to 
patch
configure.ac and Makefile.am instead), or bad config.guess/config.sub files
(and usually the result is a build failure on some ports).

As you wish, you can switch in a later upload, or do it now and maybe 
fix/revert in
case of troubles
>Reorg: gnustep-common and gnustep-make existed; move one file from
>gnustep-common to gnustep-make; new gnustep-common does not require new
>gnustep-make

>Breaks: gnustep-make (<<2.6.8-1)  
>Breaks: gnustep-common (<<2.6.8-1)
>
>Is it okay to do that?


I don't think so, but I can review a patch/package, because some lines without 
their
context have no meaning (you need to put the breaks+replaces in the right binary
package).
>OK, I'm going to update gnustep make to do improvements you suggested.
>Since I am not familiar with mentors rules, I have a question :
>Should I prepare a new revision (ie 2.6.8-2) or should I update the
>2.6.8-1 revision and reupload it ?


please upload -1 revision until it gets sponsored!

thanks,

G.

Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system

[Eric Heintzmann]

Le 16/05/2016 15:16, Gianfranco Costamagna a écrit :
> Hi Eric,
>
>
>
>> Well autotools-dev already used. No changes here.
>> About autoreconf, I'm not familiar with it.
>> I installed it to test it. Since all seems ok, I've not removed it.
>
> https://wiki.debian.org/Autoreconf
>
> I was talking more about removing autotools-dev
I think there are too many changes in this release.
Is it okay to remove autoreconf for now,
and replace autotools-dev by autoreconf at next release ?
>
>
> 3) +Replaces: gnustep-common (<< 2.6.8-1)
>
> this is something I don't understand.
> If you upgrade gnustep make bin package with old gnustep-common installed,
> we need to replace the gnustep-config.1 manpage.
>
>
> that file is currently inside gnustep-common
>
> and you moved into gnustep-make
> https://packages.debian.org/sid/alpha/gnustep-common/filelist
Yes, the executable was in gnustep-make, thus i moved the manpage to
gnustep-make.

>
> you probably need some more keywords to ensure a good upgrade path
> https://wiki.debian.org/PackageTransition

Reorg: gnustep-common and gnustep-make existed; move one file from
gnustep-common to gnustep-make; new gnustep-common does not require new
gnustep-make
   
Breaks: gnustep-make (<<2.6.8-1)
   
Breaks: gnustep-common (<<2.6.8-1)

Is it okay to do that?

>> Yes, this is a consequence of the debian/rules rewriting.
>
> line 25, you could add something like "remove control.in file, useless now"
> or similar wording, that one was my question
OK, i m going to do that
>
>> I tested it with latest upstream version of gnustep-base, gnustep-gui
>> and and gnustep-back,
>> and all seems okay. I
>> tried it with several GNUstep related debian packages and all seems to
>> works fine.
>> I also tried to rebuild several debian gnustep packages with it and I
>> did not find any FTBFS.
>
> nice indeed, so please wait some more time, and ping me back in 7-15 days if 
> nobody
> picked up the work in the meanwhile.

OK, I'm going to update gnustep make to do improvements you suggested.
Since I am not familiar with mentors rules, I have a question :
Should I prepare a new revision (ie 2.6.8-2) or should I update the
2.6.8-1 revision and reupload it ?

Thanks

Eric

Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system

[Gianfranco Costamagna]

Hi Eric,



>Well autotools-dev already used. No changes here.

>About autoreconf, I'm not familiar with it.
>I installed it to test it. Since all seems ok, I've not removed it.


https://wiki.debian.org/Autoreconf

I was talking more about removing autotools-dev

>In addition, I've just asked them to post their ask on this list now.


nice!
>
>
> 3) +Replaces: gnustep-common (<< 2.6.8-1)
>
> this is something I don't understand.
If you upgrade gnustep make bin package with old gnustep-common installed,
we need to replace the gnustep-config.1 manpage.


that file is currently inside gnustep-common

and you moved into gnustep-make
https://packages.debian.org/sid/alpha/gnustep-common/filelist

you probably need some more keywords to ensure a good upgrade path
https://wiki.debian.org/PackageTransition
>Yes, this is a consequence of the debian/rules rewriting.


line 25, you could add something like "remove control.in file, useless now"
or similar wording, that one was my question


>I tested it with latest upstream version of gnustep-base, gnustep-gui
>and and gnustep-back,
>and all seems okay. I
>tried it with several GNUstep related debian packages and all seems to
>works fine.
>I also tried to rebuild several debian gnustep packages with it and I
>did not find any FTBFS.


nice indeed, so please wait some more time, and ping me back in 7-15 days if 
nobody
picked up the work in the meanwhile.

thanks!

Gianfranco

Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system

[Eric Heintzmann]

>> also, the control.in file removal is not documented I guess
> Yes, this is a consequence of the debian/rules rewriting.
I mean I've removed control target in debian/rules file,
thus I removed control.in which was not needed any longer.

Thanks
Eric

Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system

[Eric Heintzmann]

Le 16/05/2016 12:40, Gianfranco Costamagna a écrit :
> control: tags -1 moreinfo
>
> Hi Eric, some questions on the changes:
> 1) why do you need both autotools-dev and autoreconf?
Well autotools-dev already used. No changes here.
About autoreconf, I'm not familiar with it.
I installed it to test it. Since all seems ok, I've not removed it.

>
> 2) did you get an ack from maintainers to add yourself as uploader
Yes.
In addition, I've just asked them to post their ask on this list now.

>
>
> 3) +Replaces: gnustep-common (<< 2.6.8-1)
>
> this is something I don't understand.
 If you upgrade gnustep make bin package with old gnustep-common installed,
 we need to replace the gnustep-config.1 manpage.


>
> also, the control.in file removal is not documented I guess
Yes, this is a consequence of the debian/rules rewriting.
>
> maybe Aron (ccd), being the latest sponsor might give you an additional 
> review and sponsor the package

Thanks for the tip.


>
> thanks for the really nice work! 
Thanks, I worked hard last week with upstream.
> I did a test build and the build logs looks good to be, as well as the built
> binaries (however I didn't install them).
I tested it with latest upstream version of gnustep-base, gnustep-gui
and and gnustep-back,
 and all seems okay. I
 tried it with several GNUstep related debian packages and all seems to
works fine.
 I also tried to rebuild several debian gnustep packages with it and I
did not find any FTBFS.

Eric

Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system

[Gianfranco Costamagna]

control: tags -1 moreinfo

Hi Eric, some questions on the changes:
1) why do you need both autotools-dev and autoreconf?

2) did you get an ack from maintainers to add yourself as uploader


3) +Replaces: gnustep-common (<< 2.6.8-1)

this is something I don't understand.

also, the control.in file removal is not documented I guess

maybe Aron (ccd), being the latest sponsor might give you an additional review 
and sponsor the package

thanks for the really nice work! I did a test build and the build logs looks 
good to be, as well as the built
binaries (however I didn't install them).

thanks

Gianfranco



Il Domenica 15 Maggio 2016 3:39, Eric Heintzmann  ha 
scritto:



Le 15/05/2016 03:26, Adam Borowski a écrit :
> On Sun, May 15, 2016 at 03:04:37AM +0200, Eric Heintzmann wrote:
>> Le 15/05/2016 02:46, Adam Borowski a écrit :
>>> On Sat, May 14, 2016 at 12:39:16PM +0200, Eric Heintzmann wrote:
   I am looking for a sponsor for my package "gnustep-make"

  * Package name: gnustep-make
Version : 2.6.8-1

 dget -x 
 https://mentors.debian.net/debian/pool/main/g/gnustep-make/gnustep-make_2.6.8-1.dsc
>>> As there's LOADS of packaging changes, could you please push them to a VCS? 
>>> That'd make reviewing greatly easier.  From the new changelog I assume you
>>> used git, I just don't see anything new past 2.6.6-3 on any branches on
>>> pkg-gnustep/gnustep-make.git.
>> Sorry, but I've not used git nor any VCS because I work all alone
>> since I am the last active member of the Debian GNUstep maintainers.
>> If I had knew that make reviewing easier, I would have used Git.
>> If you want I can push my changes on pkg-gnustep/gnustep-make.git
>> but there will be only one big commit.
>> Sorry, I ve done a mistake how can I repair it ?
> Oif.  I guess trying to split this big commit would be far more work than
> just reviewing it the hard way, so there's nothing that can be done here.
> That's unfortunate as it raises the difficulty of review considerably.
>
> As gnustep-make is a complex package I'm not familiar with, I'm afraid
> I'll leave it to someone with more time and experience.
>
I think I can split this big commit in multiple commits, one for each file.
If needed I will do it.

Thanks

Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system

[Eric Heintzmann]

Le 15/05/2016 03:26, Adam Borowski a écrit :
> On Sun, May 15, 2016 at 03:04:37AM +0200, Eric Heintzmann wrote:
>> Le 15/05/2016 02:46, Adam Borowski a écrit :
>>> On Sat, May 14, 2016 at 12:39:16PM +0200, Eric Heintzmann wrote:
   I am looking for a sponsor for my package "gnustep-make"

  * Package name: gnustep-make
Version : 2.6.8-1

 dget -x 
 https://mentors.debian.net/debian/pool/main/g/gnustep-make/gnustep-make_2.6.8-1.dsc
>>> As there's LOADS of packaging changes, could you please push them to a VCS? 
>>> That'd make reviewing greatly easier.  From the new changelog I assume you
>>> used git, I just don't see anything new past 2.6.6-3 on any branches on
>>> pkg-gnustep/gnustep-make.git.
>> Sorry, but I've not used git nor any VCS because I work all alone
>> since I am the last active member of the Debian GNUstep maintainers.
>> If I had knew that make reviewing easier, I would have used Git.
>> If you want I can push my changes on pkg-gnustep/gnustep-make.git
>> but there will be only one big commit.
>> Sorry, I ve done a mistake how can I repair it ?
> Oif.  I guess trying to split this big commit would be far more work than
> just reviewing it the hard way, so there's nothing that can be done here.
> That's unfortunate as it raises the difficulty of review considerably.
>
> As gnustep-make is a complex package I'm not familiar with, I'm afraid
> I'll leave it to someone with more time and experience.
>
I think I can split this big commit in multiple commits, one for each file.
If needed I will do it.

Thanks

Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system

[Adam Borowski]

On Sun, May 15, 2016 at 03:04:37AM +0200, Eric Heintzmann wrote:
> Le 15/05/2016 02:46, Adam Borowski a écrit :
> > On Sat, May 14, 2016 at 12:39:16PM +0200, Eric Heintzmann wrote:
> >>   I am looking for a sponsor for my package "gnustep-make"
> >>
> >>  * Package name: gnustep-make
> >>Version : 2.6.8-1
> >>
> >> dget -x 
> >> https://mentors.debian.net/debian/pool/main/g/gnustep-make/gnustep-make_2.6.8-1.dsc
> > As there's LOADS of packaging changes, could you please push them to a VCS? 
> > That'd make reviewing greatly easier.  From the new changelog I assume you
> > used git, I just don't see anything new past 2.6.6-3 on any branches on
> > pkg-gnustep/gnustep-make.git.
> 
> Sorry, but I've not used git nor any VCS because I work all alone
> since I am the last active member of the Debian GNUstep maintainers.
> If I had knew that make reviewing easier, I would have used Git.
> If you want I can push my changes on pkg-gnustep/gnustep-make.git
> but there will be only one big commit.
> Sorry, I ve done a mistake how can I repair it ?

Oif.  I guess trying to split this big commit would be far more work than
just reviewing it the hard way, so there's nothing that can be done here.
That's unfortunate as it raises the difficulty of review considerably.

As gnustep-make is a complex package I'm not familiar with, I'm afraid
I'll leave it to someone with more time and experience.

Apologies.
-- 
A tit a day keeps the vet away.

Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system

[Eric Heintzmann]

Le 15/05/2016 02:46, Adam Borowski a écrit :
> Hi!
>
> On Sat, May 14, 2016 at 12:39:16PM +0200, Eric Heintzmann wrote:
>>   I am looking for a sponsor for my package "gnustep-make"
>>
>>  * Package name: gnustep-make
>>Version : 2.6.8-1
>>
>> dget -x 
>> https://mentors.debian.net/debian/pool/main/g/gnustep-make/gnustep-make_2.6.8-1.dsc
> As there's LOADS of packaging changes, could you please push them to a VCS? 
> That'd make reviewing greatly easier.  From the new changelog I assume you
> used git, I just don't see anything new past 2.6.6-3 on any branches on
> pkg-gnustep/gnustep-make.git.

Sorry, but I've not used git nor any VCS because I work all alone
since I am the last active member of the Debian GNUstep maintainers.
If I had knew that make reviewing easier, I would have used Git.
If you want I can push my changes on pkg-gnustep/gnustep-make.git
but there will be only one big commit.
Sorry, I ve done a mistake how can I repair it ?

Thanks

Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system

[Adam Borowski]

Hi!

On Sat, May 14, 2016 at 12:39:16PM +0200, Eric Heintzmann wrote:
>   I am looking for a sponsor for my package "gnustep-make"
> 
>  * Package name: gnustep-make
>Version : 2.6.8-1
> 
> dget -x 
> https://mentors.debian.net/debian/pool/main/g/gnustep-make/gnustep-make_2.6.8-1.dsc

As there's LOADS of packaging changes, could you please push them to a VCS? 
That'd make reviewing greatly easier.  From the new changelog I assume you
used git, I just don't see anything new past 2.6.6-3 on any branches on
pkg-gnustep/gnustep-make.git.

If for whatever reason you can't/don't want to push your changes there (no
access, dislike for amends, etc), any other repository would be fine for
now.  I just don't feel like going through such a huge diff unassisted.

Meow!
-- 
A tit a day keeps the vet away.

Bug#824262: RFS: gnustep-make/2.6.8-1 [RC] -- GNUstep build system

[Eric Heintzmann]

Package: sponsorship-requests
Severity: important

  Dear mentors,

  I am looking for a sponsor for my package "gnustep-make"

 * Package name: gnustep-make
   Version : 2.6.8-1
   Upstream Author : GNUstep Maintainer 
 * URL : http://gnustep.org
 * License : GPL-3+
   Section : gnustep

  It builds those binary packages:

 gnustep-common - Common files for the core GNUstep environment
 gnustep-make - GNUstep build system
 gnustep-make-doc - Documentation for GNUstep Make

  To access further information about this package, please visit the following 
URL:

  https://mentors.debian.net/package/gnustep-make


  Alternatively, one can download the package with dget using this command:

dget -x 
https://mentors.debian.net/debian/pool/main/g/gnustep-make/gnustep-make_2.6.8-1.dsc

  More information about GNUstep can be obtained from 
http://gnustep.org/information/aboutGNUstep.html

  Changes since the last upload:

  
gnustep-make (2.6.8-1) unstable; urgency=low
 .
   * Team upload.
   * Add myself as new Co-Maintainer.
   * New upstream version
   * Rremove patches applied upstream:
 + honor-CFLAGS.patch
 + info-document-missing-direntry.patch
 + library-combo-whatis-entry.patch
 + manpage-spelling-errors.patch
 + test-clean-core.patch
 + texi-section-level.patch
   * Update no-gzip-timestampss.patch.
   * Update use-makeinfo.patch.
   * Bump Standards-Version to 3.6.8 in debian/control.
   * Set debhelper combatibility level to 9.
   * Update Vcs-* fields in debian/control
   * Remove no more needed {gnustep:Depends} var in debian/control.
   * Rewrite debian/rules:
 + Use dh $@ --with autotools-dev, autoreconf and buiddirectory
 + Disable strict gnustep-make version 2 mode for now
 + Build and install doc in *-indep sequence (Closes: #823281, #806197)
 + Use --with-layout=debian in configure scripts:
   remove fhs-system-includedir.patch
   * Provide a nex debian/clean file.
   * Update debian/copyright file.
   * Update debian/watch file to version 4.
   * Replace debian/upstream/signig-key.pgp by signing-key.asc:
 remove debian/source/include-binaries file.
   * Provide a new debian/gnustep-make-doc.install file.
   * Provide a new debian/gnustep-make-doc.info file.
   * Rename debian/gnustep-make-doc.doc-base to
 debian/gnustep-make-doc.doc-base.gnustep-make.
   * Provides new debian/gnustep-make-doc.doc-base.* files.
   * Provide a new debian/gnustep-make.install file.
   * Provide a new debian/gnustep-make.lintian-overrides file.
   * Provide a new debian/gnustep-make.manpages file.
   * Provide a new debian/gnustep-make.docs file.
   * Rename debian/fhs dir to debian/dh_gnustep.
   * New debian/addons dir: move gs_make and config.mk to it.
   * Update debian/gnustep-common.dirs and debian/gnustep-common.links.
   * Provide a new debian/gnustep-common.maintscript file.
   * Provide a new debian/gnustep-common.install file.
   * Provide a new debian/gnustep-common.manpages file.
   * Provide a new debian/gnustep-common.docs file.
   * Move gnustep-config.1 manpage to gnustep-make package:
 gnustep-make now Replaces: gnustep-common (<< 2.6.8-1).


  Regards,
   Eric Heintzmann