Re: Bug#834768: RFS: codicefiscale/0.9-1
On Sat, Aug 20, 2016 at 10:05 PM, Elena ``of Valhalla'' wrote: > Thanks. I currently check packages with lintian (--pedantic) and > piuparts, and I sort-of-know-but-still-don't-use check-all-the-things: If it helps convince you to use it, installing without recommends will lead to knowing which tools to install for the specific package you are checking. Also, patches welcome for the Python TODO list :) https://anonscm.debian.org/cgit/collab-maint/check-all-the-things.git/tree/data/python https://anonscm.debian.org/cgit/collab-maint/check-all-the-things.git/tree/doc/README#n33 > is there something else I should/can add to the list? I guess you are already running it via piuparts, but run adequate on the installed packages. Adding some DEP-8 tests might be a good idea: http://dep.debian.net/deps/dep8/ More stuff will get run when it reaches Debian: https://wiki.debian.org/qa.debian.org -- bye, pabs https://wiki.debian.org/PaulWise
Re: Bug#834768: RFS: codicefiscale/0.9-1
On 2017-08-19 at 20:54:34 +, Mattia Rizzolo wrote: > No, it just means that I rashed too much at reviewing it last night and > was already sleeping. > I didn't notice all those files where inside a directory -.-' lol :) > > That's exactly the issue, I've added a comment with a pointer to > > https://github.com/ema/pycodicefiscale/issues/6 > The project doesn't strike me as very active, but thanks :) Well, the scope of the project is quite limited, and it its feature set is basically complete or nearly so, so the lack of commit activity doesn't worry me. Around the time when I opened that issue I also proposed a (small) pull request to add python3 support and that one was accepted in a very short time, so the project didn't look abandoned. https://github.com/ema/pycodicefiscale/pull/5 > > > * just quickly skimming over the README, I think it would make sense to > > > include in the binaries, as it provides quick documentation (I think) > > > > yes, it does, you're right (added in git) > [...] > This is not going to do what you expect, check both the produced > binaries ;) yeah, that did exactly half of what I expected :) should be fixed now (also in git) > (`debc` right after having built the package is handy for that, I run > it in a pbuilder hook for example) Thanks. I currently check packages with lintian (--pedantic) and piuparts, and I sort-of-know-but-still-don't-use check-all-the-things: is there something else I should/can add to the list? -- Elena ``of Valhalla'' signature.asc Description: PGP signature
Re: Bug#834768: RFS: codicefiscale/0.9-1
On Fri, Aug 19, 2016 at 10:47:37PM +0200, Elena ``of Valhalla'' wrote: > On 2016-08-18 at 22:27:42 +, Mattia Rizzolo wrote: > > * Files-Excluded in d/copyright doesn't list all the files that are > > removed (at least according to `git diff --stat > > upstream/0.9..upstream/0.9+ds0`) > > besides, wrapping that list might not be a bad idea > > Uhm, I used uscan to remove the files, so nothing that wasn't listed was > removed. > > Do you mean that I should explicitely list all of the content of the > directory ``codicefiscale.egg-info``, instead of just listing the > directory? No, it just means that I rashed too much at reviewing it last night and was already sleeping. I didn't notice all those files where inside a directory -.-' > > * why do you disable the tests? (a comment on d/rules might not be a > > bad idea here either) > > + I see setup.py lists non-existant tests, if that's the issue maybe > > you can get that tests= arg removed (or the actual tests included) > > upstream? > > That's exactly the issue, I've added a comment with a pointer to > https://github.com/ema/pycodicefiscale/issues/6 The project doesn't strike me as very active, but thanks :) > > * just quickly skimming over the README, I think it would make sense to > > include in the binaries, as it provides quick documentation (I think) > > yes, it does, you're right (added in git) You did this: diff --git a/debian/docs b/debian/docs new file mode 100644 index 000..a1320b1 --- /dev/null +++ b/debian/docs @@ -0,0 +1 @@ +README.rst This is not going to do what you expect, check both the produced binaries ;) (`debc` right after having built the package is handy for that, I run it in a pbuilder hook for example) -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Re: Bug#834768: RFS: codicefiscale/0.9-1
On 2016-08-18 at 22:27:42 +, Mattia Rizzolo wrote:
> FYI: no need to explicitly CC d-mentors@, RFSes are somehow sent there
> anyway.
ack
> This is DPMT, where the usage of git is mandated, so I expect the git
> repository to match the generated .dsc (hence I'm ignoring mentors here)
it does (hopefully) match, yes
> A few small things I'd like to see:
>
> * you email address in d/copyright
added in git
> * Files-Excluded in d/copyright doesn't list all the files that are
> removed (at least according to `git diff --stat
> upstream/0.9..upstream/0.9+ds0`)
> besides, wrapping that list might not be a bad idea
Uhm, I used uscan to remove the files, so nothing that wasn't listed was
removed.
Do you mean that I should explicitely list all of the content of the
directory ``codicefiscale.egg-info``, instead of just listing the
directory?
> * Also would be nice to see Build-Depends wrap-and-sort'ed
done in git
> * python3-codicefiscale uses ${python:Depends} instead of
> ${python3:Depends}
uooops, fixed in git
> * why do you disable the tests? (a comment on d/rules might not be a
> bad idea here either)
> + I see setup.py lists non-existant tests, if that's the issue maybe
> you can get that tests= arg removed (or the actual tests included)
> upstream?
That's exactly the issue, I've added a comment with a pointer to
https://github.com/ema/pycodicefiscale/issues/6
> * in d/watch, you dversionmangle '.ds0' away, but you're using '+ds0'
> actually, so it's not actually mangling anything
I hate single character typos, fixed in git (it appeared to work in
practice, but only because of versions ordering)
> * just quickly skimming over the README, I think it would make sense to
> include in the binaries, as it provides quick documentation (I think)
yes, it does, you're right (added in git)
--
Elena ``of Valhalla''
Re: Bug#834768: RFS: codicefiscale/0.9-1
control: owner -1 !
control: tag -1 moreinfo
On Thu, Aug 18, 2016 at 10:24:31PM +0200, Elena ``of Valhalla'' Grandi wrote:
> On 2016-08-18 at 21:48:05 +0200, Elena ``of Valhalla'' wrote:
FYI: no need to explicitly CC d-mentors@, RFSes are somehow sent there
anyway.
> > To access further information about this package, please visit the
> > following URL:
> >
> > https://mentors.debian.net/package/codicefiscale
> >
> >
> > Alternatively, one can download the package with dget using this command:
> >
> > dget -x
> > https://mentors.debian.net/debian/pool/main/c/codicefiscale/codicefiscale_0.9-1.dsc
> >
> > Or directly from git at:
> >
> > https://anonscm.debian.org/git/python-modules/packages/codicefiscale.git
>
> sorry, I forgot about removing the codicefiscale.egg-info, the actual
> dsc is:
>
> dget -x
> https://mentors.debian.net/debian/pool/main/c/codicefiscale/codicefiscale_0.9+ds0-1.dsc
>
> (all other urls are ok, and their content have been updated, sorry)
This is DPMT, where the usage of git is mandated, so I expect the git
repository to match the generated .dsc (hence I'm ignoring mentors here)
A few small things I'd like to see:
* you email address in d/copyright
* Files-Excluded in d/copyright doesn't list all the files that are
removed (at least according to `git diff --stat
upstream/0.9..upstream/0.9+ds0`)
besides, wrapping that list might not be a bad idea
* Also would be nice to see Build-Depends wrap-and-sort'ed
* python3-codicefiscale uses ${python:Depends} instead of
${python3:Depends}
* why do you disable the tests? (a comment on d/rules might not be a
bad idea here either)
+ I see setup.py lists non-existant tests, if that's the issue maybe
you can get that tests= arg removed (or the actual tests included)
upstream?
* in d/watch, you dversionmangle '.ds0' away, but you're using '+ds0'
actually, so it's not actually mangling anything
* just quickly skimming over the README, I think it would make sense to
include in the binaries, as it provides quick documentation (I think)
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
Re: Bug#834768: RFS: codicefiscale/0.9-1
On 2016-08-18 at 21:48:05 +0200, Elena ``of Valhalla'' wrote: > To access further information about this package, please visit the following > URL: > > https://mentors.debian.net/package/codicefiscale > > > Alternatively, one can download the package with dget using this command: > > dget -x > https://mentors.debian.net/debian/pool/main/c/codicefiscale/codicefiscale_0.9-1.dsc > > Or directly from git at: > > https://anonscm.debian.org/git/python-modules/packages/codicefiscale.git sorry, I forgot about removing the codicefiscale.egg-info, the actual dsc is: dget -x https://mentors.debian.net/debian/pool/main/c/codicefiscale/codicefiscale_0.9+ds0-1.dsc (all other urls are ok, and their content have been updated, sorry) -- Elena ``of Valhalla'' signature.asc Description: PGP signature
Bug#834768: RFS: codicefiscale/0.9-1
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "codicefiscale" * Package name: codicefiscale Version : 0.9-1 Upstream Author : Emanuele Rocca * URL : https://github.com/ema/pycodicefiscale * License : LGPL-2.1+ Section : python It builds those binary packages: python-codicefiscale - Generate and validate Italian "codice fiscale" (Python 2.x) python3-codicefiscale - Generate and validate Italian "codice fiscale" (Python 3.x) To access further information about this package, please visit the following URL: https://mentors.debian.net/package/codicefiscale Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/c/codicefiscale/codicefiscale_0.9-1.dsc Or directly from git at: https://anonscm.debian.org/git/python-modules/packages/codicefiscale.git This is the first upload for this package (the it ITP bug is at https://bugs.debian.org/834710 ). Regards, -- Elena ``of Valhalla'' Grandi signature.asc Description: PGP signature
