Re: python-requests: adding a documentation package python-requests-doc

2020-01-07 Thread Daniele Tricoli
Hello Mattia,

On Tue, Dec 31, 2019 at 09:15:12PM +0100, Mattia Rizzolo wrote:
> I recommend you enable notifications for all packages in you are interested
> in, by setting the notification switch on salsa to "watch".

Many thanks for the hint, I was not aware of this!

> Otherwise, you could get into the habit of scrolling through your ddpo page
> every so often anche check the VCS column (but there is a huge delay as
> iirc salsa is queried once a week for MRs).

Yes, I usually look at them there, but as you said there is a huge delay.

I will follow your suggestion about switching notification to "watch".

Thanks again,

-- 
  Daniele Tricoli 'eriol'
  https://mornie.org


signature.asc
Description: PGP signature


Re: python-requests: adding a documentation package python-requests-doc

2020-01-07 Thread Daniele Tricoli
Hello Fabrice,

On Thu, Jan 02, 2020 at 08:46:51AM +0100, Fabrice BAUZAC-STEHLY wrote:
> I have updated the merge request.

Merged, many thanks for your contribution!

Regards,

-- 
  Daniele Tricoli 'eriol'
  https://mornie.org


signature.asc
Description: PGP signature


Re: python-requests: adding a documentation package python-requests-doc

2020-01-02 Thread Nicholas D Steeves
Hi Fabrice,

Fabrice BAUZAC-STEHLY  writes:

> Hello Daniele,
>
> Daniele Tricoli writes:
>
>> Please next time can you assign it to me? I should reveive some sort of
>> notification I hope! :)
>
> Sure, will do.
>
> I have updated the merge request.
>
> For d/changelog, I used "debchange -i" which for some reason chose
> "2.22.0-2.1", I've changed it to "2.22.0-3" as it seems to better match
> the existing practice.
>

Debchange/dch chooses upstream_version-x.y (NMU Debian revision) when
one's email address is in neither the Maintainer nor the Uploaders
fields.  Dch --team will do the right thing for the Debian revision;
that said, the "* Team upload" line it generates shouldn't be used if
one of the Uploaders (or Maintainer for weak team attributed package)
will be finalising the changelog and uploading.  'no idea whether or not
that's the case here, btw.

I've filed #947961 against devscripts in the hopes that someone will
enhance dch's behaviour for team-maintained packages.

> Thanks a lot and a happy new year!
>

Thank you, happy New Year to you too! :-D

Cheers,
Nicholas


signature.asc
Description: PGP signature


Re: python-requests: adding a documentation package python-requests-doc

2020-01-01 Thread Fabrice BAUZAC-STEHLY
Hello Daniele,

Daniele Tricoli writes:

> Please next time can you assign it to me? I should reveive some sort of
> notification I hope! :)

Sure, will do.

I have updated the merge request.

For d/changelog, I used "debchange -i" which for some reason chose
"2.22.0-2.1", I've changed it to "2.22.0-3" as it seems to better match
the existing practice.

Thanks a lot and a happy new year!

--
Fabrice BAUZAC-STEHLY
PGP 015AE9B25DCB0511D200A75DE5674DEA514C891D



Re: python-requests: adding a documentation package python-requests-doc

2019-12-31 Thread Mattia Rizzolo
On Tue, 31 Dec 2019, 7:42 pm Daniele Tricoli,  wrote:

> Hello Fabrice,
> thanks for pinging I did not notice the MR :(
> Please next time can you assign it to me? I should reveive some sort of
> notification I hope! :)
>

I recommend you enable notifications for all packages in you are interested
in, by setting the notification switch on salsa to "watch".
Otherwise, you could get into the habit of scrolling through your ddpo page
every so often anche check the VCS column (but there is a huge delay as
iirc salsa is queried once a week for MRs).


>


Re: python-requests: adding a documentation package python-requests-doc

2019-12-31 Thread Daniele Tricoli
Hello Fabrice,
thanks for pinging I did not notice the MR :(
Please next time can you assign it to me? I should reveive some sort of
notification I hope! :)

On Tue, Dec 31, 2019 at 12:35:19AM +0100, Fabrice BAUZAC-STEHLY wrote:
> Hello,
> 
> I wish there was a python-requests-doc package for browsing
> python-requests' documentation offline.  I'd like to add it if I can.
> 
> I saw that debian/watch currently targets the PyPI tarball, which lacks
> the documentation.

Yes, I usually preferred PyPI distribution, but I'm fine switching since it
will enhance users experience.

> As a first step, I'm submitting a merge request [1] so that debian/watch
> tracks the github releases instead, which do contain the documentation.
> 
> After that, once a new upstream release of requests is published and
> propagated into the salsa repository, the latter will start
> containing the missing docs/ subdirectory.  So we'll at least be able to
> start working on a new python-requests-doc binary package containing the
> documentation.
> 
> In the merge request, I've basically applied the github recipe as
> indicated in the uscan(1) manpage.
> 
> If you could have a look at this merge request, that would be excellent.
> 
> [1] https://salsa.debian.org/python-team/modules/requests/merge_requests/1
> 

Looked at it, I would prefer the more common:

-8<
version=4
opts=filenamemangle=s/.+\/v?(\d\S+)\.tar\.gz/requests-$1\.tar\.gz/ \
  https://github.com/psf/requests/tags .*/v?(\d\S+)\.tar\.gz
-8<

Please can you update your MR? Can you also update d/changelog, so I will not
to have to write manually that I thank you and the attribution of the work you
have done? :)

Thanks for your contribution!

Regards and happy new year,

-- 
  Daniele Tricoli 'eriol'
  https://mornie.org


signature.asc
Description: PGP signature


python-requests: adding a documentation package python-requests-doc

2019-12-30 Thread Fabrice BAUZAC-STEHLY
Hello,

I wish there was a python-requests-doc package for browsing
python-requests' documentation offline.  I'd like to add it if I can.

I saw that debian/watch currently targets the PyPI tarball, which lacks
the documentation.

As a first step, I'm submitting a merge request [1] so that debian/watch
tracks the github releases instead, which do contain the documentation.

After that, once a new upstream release of requests is published and
propagated into the salsa repository, the latter will start
containing the missing docs/ subdirectory.  So we'll at least be able to
start working on a new python-requests-doc binary package containing the
documentation.

In the merge request, I've basically applied the github recipe as
indicated in the uscan(1) manpage.

If you could have a look at this merge request, that would be excellent.

[1] https://salsa.debian.org/python-team/modules/requests/merge_requests/1

Thanks a lot!

Best regards

--
Fabrice BAUZAC-STEHLY
PGP 015AE9B25DCB0511D200A75DE5674DEA514C891D