Re: [ftpmas...@ftp-master.debian.org: node-shiny-server_1.5.17.973-1_amd64.changes ACCEPTED into experimental, experimental] (Was: Re: shiny-server in debian)

2022-04-27 Thread Eric Brown
Hello,
I repeated the process and shiny-server from experimental works this
time. I don't know why the error happened the first time but I can't
reproduce it, perhaps it was a transient dependency issue.
Thanks,
Eric

On Wed, Apr 27, 2022 at 12:42 AM Nilesh Patra  wrote:
>
> On Tue, Apr 26, 2022 at 04:21:44PM -0400, Eric Brown wrote:
> > Hi Nilesh,
> > That's good news - however on a fresh debian unstable, when I
> > installed shiny-server from experimental, starting it results in an
> > immediate segmentation fault.
>
> Weird, and unfortunately I am not able to reproduce this, the experimental
> install works just fine for me.
>
> But since it segfaults for you, my hunch is that most likely you upgraded the
> version of nodejs to the version in experimental which you shouldn't be doing.
> By default, a package in experimental uses the dependency version in 
> unstable, unless
> a proper versioned dependency is added.
>
> Can you try configuring exp sources as given here[1] and do a "apt -t 
> experimental install shiny-server"
> and check again? Also ensure that the version of nodejs[2] is 14, and not 16.
>
> > Then on the same system, I built from
> > the salsa git and installed it and it works.
>
> Yep, and that would probably be because you built the package with new 
> version of nodejs
> on your local system and that worked for you, while on the buildd suite 
> node-14 is being used.
>
> For every new major release of node, shiny-server needs to be recompiled you 
> did exactly this locally.
>
> > Do you have any idea why
> > it would be different? Anything you would like to check to help debug?
>
> If you could check the above steps I pointed to, we can track this further.
> That'd be helpful, Eric.
>
> [1]: https://wiki.debian.org/DebianExperimental#To_configure_APT
> [2]: https://tracker.debian.org/pkg/nodejs
>
> Regards,
> Nilesh



-- 
Eric Brown MD MSc FRCPC
For encryption, OpenPGP public key available on request.



Re: [ftpmas...@ftp-master.debian.org: node-shiny-server_1.5.17.973-1_amd64.changes ACCEPTED into experimental, experimental] (Was: Re: shiny-server in debian)

2022-04-26 Thread Eric Brown
Hi Nilesh,
That's good news - however on a fresh debian unstable, when I
installed shiny-server from experimental, starting it results in an
immediate segmentation fault. Then on the same system, I built from
the salsa git and installed it and it works. Do you have any idea why
it would be different? Anything you would like to check to help debug?
Thanks
Eric

On Mon, Apr 25, 2022 at 3:09 PM Nilesh Patra  wrote:
>
> Good news folks, shiny-server is in our archive (experimental suite) now \o/
>
> - Forwarded message from Debian FTP Masters 
>  -
>
> Date: Mon, 25 Apr 2022 18:00:17 +
> From: Debian FTP Masters 
> To: Nilesh Patra , Debian Med Packaging Team 
> 
> Subject: node-shiny-server_1.5.17.973-1_amd64.changes ACCEPTED into 
> experimental, experimental
>
>
>
> Accepted:
>
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> Format: 1.8
> Date: Thu, 14 Apr 2022 11:53:26 +0530
> Source: node-shiny-server
> Binary: shiny-server shiny-server-dbgsym
> Architecture: source amd64
> Version: 1.5.17.973-1
> Distribution: experimental
> Urgency: medium
> Maintainer: Debian Med Packaging Team 
> 
> Changed-By: Nilesh Patra 
> Description:
>  shiny-server - put Shiny web apps online
> Closes: 960906
> Changes:
>  node-shiny-server (1.5.17.973-1) experimental; urgency=medium
>  .
>* Team Upload.
>* Initial release (Closes: #960906)
> Checksums-Sha1:
>  2bdfdc188c2206b9cfe088ac7f4258bfa09a12d0 2835 
> node-shiny-server_1.5.17.973-1.dsc
>  753e26e6e914139b35efce718e0471c48d7823bb 158116 
> node-shiny-server_1.5.17.973.orig.tar.xz
>  406dc4ab2fd14bb9d4f28b812d4d49686b0f6f7e 15784 
> node-shiny-server_1.5.17.973-1.debian.tar.xz
>  c61961727659f12a04191319982bc888a6d1bc3d 17310 
> node-shiny-server_1.5.17.973-1_amd64.buildinfo
>  663dbf2d04430e6c94203f77191700156a5495fb 142464 
> shiny-server-dbgsym_1.5.17.973-1_amd64.deb
>  fc42d81cf4fc58a3d0ab69ee1686bfee78f055f4 271688 
> shiny-server_1.5.17.973-1_amd64.deb
> Checksums-Sha256:
>  c0380690149e17b84d72d8d01a3f2bc9b8344572ffbddf9a46e5a5b951953ba3 2835 
> node-shiny-server_1.5.17.973-1.dsc
>  ce1468abd08108c9c4d21c0a55db62bb1cc65abc00a5664023416bbabe473fc2 158116 
> node-shiny-server_1.5.17.973.orig.tar.xz
>  5529ee90cca23a79d6e6dc2369054f8e4e7ef8e553ce521fbd67dcddd5441e25 15784 
> node-shiny-server_1.5.17.973-1.debian.tar.xz
>  c5aa69ac271cf7cd2a33e3bdd7332f7a33b97d210134498c2addff534adb0dbb 17310 
> node-shiny-server_1.5.17.973-1_amd64.buildinfo
>  34e2e851569950a2d095b14875c2255fbf90da346bcf005e5b97465beb237951 142464 
> shiny-server-dbgsym_1.5.17.973-1_amd64.deb
>  f0c4fa7470f42efecb01283eb7a2608d4802e91335f9f3e677129019b6c9040b 271688 
> shiny-server_1.5.17.973-1_amd64.deb
> Files:
>  f8b9c06896136a77059df8ca86cce4ac 2835 science optional 
> node-shiny-server_1.5.17.973-1.dsc
>  cb459f0ea0259410bdd5e44843c8016e 158116 science optional 
> node-shiny-server_1.5.17.973.orig.tar.xz
>  5625a6d053dd666a46fb326c524522f1 15784 science optional 
> node-shiny-server_1.5.17.973-1.debian.tar.xz
>  f259aab957a825ee95e7724de355471a 17310 science optional 
> node-shiny-server_1.5.17.973-1_amd64.buildinfo
>  65680700505c66bf39d68859132bcec9 142464 debug optional 
> shiny-server-dbgsym_1.5.17.973-1_amd64.deb
>  958a3ba457ac07d9e2ea2a9e29dc8b74 271688 science optional 
> shiny-server_1.5.17.973-1_amd64.deb
>
> -BEGIN PGP SIGNATURE-
>
> iQJGBAEBCgAwFiEEPpmlJvXcwMu/HO6mALrnSzQzafEFAmJXyFkSHG5pbGVzaEBk
> ZWJpYW4ub3JnAAoJEAC650s0M2nxHyIP/jfy5ZKfjnaGkysQXZNn+RJ0sH/uZOlJ
> ahk8lkDXDDNJHZb38/M4K9o69bdyEfhsGozSINL5vVXJPhSHvAyOgp10m1+ica3S
> eJe+EbukTNHu2PUsUORMb//ZknvbDzGnW+nhWufjbmAR7zssPCrixb7eHF14/gFM
> PPAVVs7wV8FzkXA4eHqyhg1S3nTobyWCvh6nuJapl4mkEJOt2ggBVxSTdzai+vim
> NyoFHa6kZU+bbhP8Bj5BSCG+/hlnvYFikb5ahLJJ8Cto8u3K4+KURGT2ff/2Kagr
> NtWSWTTy6yMiuViu9aQP961MMK3PKsWNS2L2BNk8ZCZqLzVzwovM1RGKqCMs41jU
> fow254KITnW4H3XRmiG3G+m1teIPnHjwgUm6/St1FUfarDlWveFhgTFboGc8+NOX
> BTqNSld4CaLFzDHJz7bfX2LRteCNNjG4tXEenAiBsbp+1E4VnfebMlp5M6q0VoD+
> o5XX2VpQ+YozlLaJQUk0C8u7AFmZPa91OIR/MGK+iefQI3g/YxTkad1Cd5yhJEGG
> 3IHt4mGiXnaTFWQRdz2DrvGYDJXZks0Jg8X/Zmx/YmnpIuXVD+bjPwaU88qwWOC8
> VGXGv83ecaOBYV+nqGst0lwygsJbzGtgjEMUspID78oaTlDNbybcdAtod1Es7Fxw
> EWF9EWJD3GBt
> =8p+7
> -END PGP SIGNATURE-
>
>
> Thank you for your contribution to Debian.
>
> - End forwarded message -



-- 
Eric Brown MD MSc FRCPC
For encryption, OpenPGP public key available on request.



Re: shiny-server in debian

2022-04-13 Thread Eric Brown
Hi Nilesh,

This works well. So we did it, shiny-server now runs packaged for Debian.

The only manual intervention that is needed post apt install is to
create /srv/shiny-server/ and move the sample apps or one's own apps
there.

The built in sample apps run without issue, and one of my apps runs
without issue. The other has an error that seems to relate to the
version of r-cran-shiny in Debian as it is fixed by running
update.packages in R. It would be good if others can test too. Once
all the dependencies make it to unstable I will also test on a
Raspberry Pi.

Thanks all,
Eric

On Wed, Apr 13, 2022 at 1:57 PM Nilesh Patra  wrote:
>
> On 4/13/22 9:18 PM, Eric Brown wrote:
> > Thank you Yadd! In my testing with the builds from Nilesh, the problem
> > with node-sockjs-client is fixed.
> >
> > And thank you Nilesh for building for me and trying to address to
> > node_modules directory issue. The build of shiny-server you shared
> > doesn't work, shiny-server will not start. When I build my latest
> > version it does work (with the new node-sockjs-client). I am guessing
>
> eeks! Looks like I made a stupid mistake in a hurry. I have re-uploaded the 
> deb,
> could you please consider to test this?
>
> Best,
> Nilesh
>


-- 
Eric Brown MD MSc FRCPC
For encryption, OpenPGP public key available on request.



Re: shiny-server in debian

2022-04-13 Thread Eric Brown
Thank you Yadd! In my testing with the builds from Nilesh, the problem
with node-sockjs-client is fixed.

And thank you Nilesh for building for me and trying to address to
node_modules directory issue. The build of shiny-server you shared
doesn't work, shiny-server will not start. When I build my latest
version it does work (with the new node-sockjs-client). I am guessing
it is related to changes you may have made with your concerns about
the node_modules folder and symlinks in my version. It's too bad this
approach is not allowed as it would be easier to maintain given it is
how upstream structures their build. Even if it is a folder within the
/usr/lib/shiny-server and only contains symlinks it is not allowed?

This is the error your build gives on trying to start shiny-server:

/usr/lib/shiny-server/lib/main.js:179
  {maxAge:8640}); // one day
  

SyntaxError: Invalid destructuring assignment target
at wrapSafe (internal/modules/cjs/loader.js:1001:16)
at Module._compile (internal/modules/cjs/loader.js:1049:27)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
at Module.load (internal/modules/cjs/loader.js:950:32)
at Function.Module._load (internal/modules/cjs/loader.js:790:12)
at Function.executeUserEntryPoint [as runMain]
(internal/modules/run_main.js:75:12)
at internal/main/run_main_module.js:17:47
/usr/lib/shiny-server/lib/main.js:179
  {maxAge:8640}); // one day
  

SyntaxError: Invalid destructuring assignment target
at wrapSafe (internal/modules/cjs/loader.js:1001:16)
at Module._compile (internal/modules/cjs/loader.js:1049:27)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
at Module.load (internal/modules/cjs/loader.js:950:32)
at Function.Module._load (internal/modules/cjs/loader.js:790:12)
at Function.executeUserEntryPoint [as runMain]
(internal/modules/run_main.js:75:12)
at internal/main/run_main_module.js:17:47

Many thanks to all,
Eric

On Wed, Apr 13, 2022 at 4:43 AM Nilesh Patra  wrote:
>
> On 4/13/22 10:27 AM, Yadd wrote:
> > I pushed on unoptimized build-with-gulp. Could you test it?
>
> Thanks a lot, Yadd!
>
> @Eric, I have pushed the corresponding .deb here[1] and the
> rest of the fixes as per your other email here[2]
> Could you please consider testing your apps with these debs?
>
> That'd be much appreciated.
>
> [1]: 
> https://people.debian.org/~nilesh/shiny-server/pool/main/n/node-sockjs-client/
> [2]: 
> https://people.debian.org/~nilesh/shiny-server/pool/main/n/node-shiny-server/
>
> Regards,
> Nilesh
>
>


-- 
Eric Brown MD MSc FRCPC
For encryption, OpenPGP public key available on request.



Re: shiny-server in debian

2022-04-12 Thread Eric Brown
Hi Nilesh,

Actually it looks like our packaging of shiny-server does
work fine with node-sockjs-client 1.6.0 but there's an issue with the
Debian version of node-sockjs-client. So there is no need to roll back
to 1.5.2.

When the upstream built dist/sockjs.js and dist/sockjs.min.js files
[1] are used (e.g. copied
into place), it works.  The sockjs.js built in Debian is not the same
as upstream.
Could you or someone review to see if there is a problem with the
build process in node-sockjs-client that might account for
differences from upstream that break shiny-server?

https://github.com/sockjs/sockjs-client/commit/dc105cd6500e99018fc1d701715bdb55812752f3

Many thanks,
Eric


On Thu, Apr 7, 2022 at 1:28 AM Eric Brown  wrote:
>
> Hi Nilesh,
>
> Thanks and no worries. I have pushed the changes to the
> node-shiny-server repo that correspond to the fixes in my previous
> email. I am new to Debian packaging so please review when you have
> time and please let me know if I have made an error.
>
> > Yes, but usually we would expect the debian package to work OOTB. Maybe we
> > could ship it for now and file a release-critical bug to keep it
> > out of testing until rest stuff is sorted out.
>
> I agreed with this proposal. I do think it would work out of the box
> even with the current r-cran-shiny, but not all features and perhaps
> some bugs. The provided sample apps run and one of my own apps runs.
> I'm not sure what doesn't work with the current version so I agree
> with your suggestion and hopefully r-cran-shiny can get updated soon.
>
> Best,
> Eric
>
> On Wed, Apr 6, 2022 at 6:47 AM Nilesh Patra  wrote:
> >
> > Hello and apologies for late reply, I am really swamped with work and real 
> > life stuff
> > these days.
> >
> > On Tue, Apr 05, 2022 at 09:05:39PM -0400, Eric Brown wrote:
> > > Hi Nilesh, Andreas et al.
> > >
> > > We spoke about this in the Debian med videoconference. In summary,
> > > Nilesh noted he will likely be able to downgrade node-sockjs-client to
> > > 1.5.2. Upgrading r-cran-shiny is currently blocked by r-cran-bslib
> > > which can't be updated until a font issue is sorted.
> >
> > Thanks for your mail on debian-r@ atleast we can begin by packaging some 
> > fonts,
> > until the rest of the source-less fonts are made available somewhere.
> > Unfortunately it is panning out a lot slower than expected :(
> >
> > > I think it would still be fair to proceed with the shiny-server
> > > package because the end user can easily update shiny in R by running
> > > update.packages(), if they are not already on the latest shiny.
> >
> > Yes, but usually we would expect the debian package to work OOTB. Maybe we
> > could ship it for now and file a release-critical bug to keep it
> > out of testing until rest stuff is sorted out.
> >
> > > I have made some of the changes in my previous email to the
> > > node-shiny-server git, could I be granted access to the  science team
> > > salsa, so I can push them for your review? My username is ericeb (I
> > > currently only have access to the R package team).
> >
> > I have added you to the team, feel free to push whatever changes you'd like.
> >
> > Regards,
> > Nilesh
>
>
>
> --
> Eric Brown MD MSc FRCPC
> For encryption, OpenPGP public key available on request.



--
Eric Brown MD MSc FRCPC
For encryption, OpenPGP public key available on request.



Re: shiny-server in debian

2022-04-06 Thread Eric Brown
Hi Nilesh,

Thanks and no worries. I have pushed the changes to the
node-shiny-server repo that correspond to the fixes in my previous
email. I am new to Debian packaging so please review when you have
time and please let me know if I have made an error.

> Yes, but usually we would expect the debian package to work OOTB. Maybe we
> could ship it for now and file a release-critical bug to keep it
> out of testing until rest stuff is sorted out.

I agreed with this proposal. I do think it would work out of the box
even with the current r-cran-shiny, but not all features and perhaps
some bugs. The provided sample apps run and one of my own apps runs.
I'm not sure what doesn't work with the current version so I agree
with your suggestion and hopefully r-cran-shiny can get updated soon.

Best,
Eric

On Wed, Apr 6, 2022 at 6:47 AM Nilesh Patra  wrote:
>
> Hello and apologies for late reply, I am really swamped with work and real 
> life stuff
> these days.
>
> On Tue, Apr 05, 2022 at 09:05:39PM -0400, Eric Brown wrote:
> > Hi Nilesh, Andreas et al.
> >
> > We spoke about this in the Debian med videoconference. In summary,
> > Nilesh noted he will likely be able to downgrade node-sockjs-client to
> > 1.5.2. Upgrading r-cran-shiny is currently blocked by r-cran-bslib
> > which can't be updated until a font issue is sorted.
>
> Thanks for your mail on debian-r@ atleast we can begin by packaging some 
> fonts,
> until the rest of the source-less fonts are made available somewhere.
> Unfortunately it is panning out a lot slower than expected :(
>
> > I think it would still be fair to proceed with the shiny-server
> > package because the end user can easily update shiny in R by running
> > update.packages(), if they are not already on the latest shiny.
>
> Yes, but usually we would expect the debian package to work OOTB. Maybe we
> could ship it for now and file a release-critical bug to keep it
> out of testing until rest stuff is sorted out.
>
> > I have made some of the changes in my previous email to the
> > node-shiny-server git, could I be granted access to the  science team
> > salsa, so I can push them for your review? My username is ericeb (I
> > currently only have access to the R package team).
>
> I have added you to the team, feel free to push whatever changes you'd like.
>
> Regards,
> Nilesh



-- 
Eric Brown MD MSc FRCPC
For encryption, OpenPGP public key available on request.



Re: shiny-server in debian

2022-04-05 Thread Eric Brown
Hi Nilesh, Andreas et al.

We spoke about this in the Debian med videoconference. In summary,
Nilesh noted he will likely be able to downgrade node-sockjs-client to
1.5.2. Upgrading r-cran-shiny is currently blocked by r-cran-bslib
which can't be updated until a font issue is sorted.

I think it would still be fair to proceed with the shiny-server
package because the end user can easily update shiny in R by running
update.packages(), if they are not already on the latest shiny.

I have made some of the changes in my previous email to the
node-shiny-server git, could I be granted access to the  science team
salsa, so I can push them for your review? My username is ericeb (I
currently only have access to the R package team).

Thanks for considering,
Eric


On Sat, Apr 2, 2022 at 1:28 PM Eric Brown  wrote:
>
> Hi Nilesh et al.,
>
> (Sorry Nilesh for the duplicate emails, I sent some to you alone 
> accidentally).
>
> Good news, I finally figured it out. It's an issue with the updated
> version of node-sockjs-client (1.6.0). The 1.5.2 version that upstream
> uses seems to work.
>
> So to summarize, after installing these are the changes made to get
> shiny-server working:
>
> sudo apt install node-sockjs-client
> sudo mkdir /usr/lib/shiny-server/node_modules
> sudo ln -s /usr/share/nodejs/sockjs-client/ 
> /usr/lib/shiny-server/node_modules/
> sudo ln -s /usr/share/nodejs/shiny-server-client/
> /usr/lib/shiny-server/node_modules/
> sudo cp /usr/lib/shiny-server/node_modules/sockjs-client/dist/sockjs.min.js
> /usr/lib/shiny-server/node_modules/sockjs-client/dist/sockjs.min.js.backup
> sudo curl 
> https://raw.githubusercontent.com/jcheng5/sockjs-client/main/dist/sockjs.min.js
> -o /usr/lib/shiny-server/node_modules/sockjs-client/dist/sockjs.min.js
>
> However, note that one of my apps did not work properly until I
> updated the R package shiny in R (to 1.7.1) which is newer than the
> current debian package (1.5), so we should likely update r-cran-shiny
> when shiny-server gets uploaded.
>
> And to use the examples:
>
> sudo mkdir /srv/shiny-server
> sudo ln -s -r /usr/lib/shiny-server/samples/* /srv/shiny-server
>
> And to enable logging:
>
> The shiny-server.service file is missing the instruction to log.
> Compare the line [1] in our version vs. [2] in version included in the
> upstream repo. When [1] is replaced with [3] and the file
> /var/log/shiny-server.log is created, logging works properly. Probably
> we can replace shiny-server.service with the upstream version
> (https://github.com/rstudio/shiny-server/blob/master/config/systemd/shiny-server.service).
>
> [1] ExecStart=/usr/bin/shiny-server
> [2] ExecStart=/usr/bin/env bash -c 'exec
> /opt/shiny-server/bin/shiny-server >> /var/log/shiny-server.log 2>&1'
>
> [3] ExecStart=/usr/bin/env bash -c 'exec
> /usr/lib/shiny-server/bin/shiny-server >> /var/log/shiny-server.log
> 2>&1'
>
> Then, as far as I can see, it's all working!
>
>
> A number of node-sockjs-client's dependencies were updated between
> 1.5.2 and current 1.6.0 so the underlying issue may be an out of date
> dependency, or some other change that upstream shiny-server has not
> yet adjusted to. Is there a workaround for this, e.g. to ship the
> 1.5.2 sockjs.js and sockjs.min.js files along with shiny-server as a
> patch, until upstream adopts 1.6.0?
>
> Best,
> Eric
>
> On Wed, Mar 30, 2022 at 5:14 AM Nilesh Patra  wrote:
> >
> > Hi Eric,
> >
> > On Sun, Mar 27, 2022 at 06:18:49PM +0530, Nilesh Patra wrote:
> > > > > 3. update outdated node-shiny-server-client to latest upstream
> > > >
> > > > Seems a wise thing to do.
> > >
> > > I have done so.
> > >
> > > @Eric, if you can try with the newer versions of these packages to check 
> > > if your
> > > second app looks better, that'd be much appreciated.
> > > If it is, then rest stuff should be relatively easy to fix.
> >
> > Did you get a chance to test it with updated versions of the packages?
> > I was planning to proceed to finalise this package according to the 
> > feedback.
> >
> > Let me know.
> >
> > Regards,
> > Nilesh
>
>
>
> --
> Eric Brown MD MSc FRCPC
> For encryption, OpenPGP public key available on request.



-- 
Eric Brown MD MSc FRCPC
For encryption, OpenPGP public key available on request.



Re: shiny-server in debian

2022-04-02 Thread Eric Brown
Hi Nilesh et al.,

(Sorry Nilesh for the duplicate emails, I sent some to you alone accidentally).

Good news, I finally figured it out. It's an issue with the updated
version of node-sockjs-client (1.6.0). The 1.5.2 version that upstream
uses seems to work.

So to summarize, after installing these are the changes made to get
shiny-server working:

sudo apt install node-sockjs-client
sudo mkdir /usr/lib/shiny-server/node_modules
sudo ln -s /usr/share/nodejs/sockjs-client/ /usr/lib/shiny-server/node_modules/
sudo ln -s /usr/share/nodejs/shiny-server-client/
/usr/lib/shiny-server/node_modules/
sudo cp /usr/lib/shiny-server/node_modules/sockjs-client/dist/sockjs.min.js
/usr/lib/shiny-server/node_modules/sockjs-client/dist/sockjs.min.js.backup
sudo curl 
https://raw.githubusercontent.com/jcheng5/sockjs-client/main/dist/sockjs.min.js
-o /usr/lib/shiny-server/node_modules/sockjs-client/dist/sockjs.min.js

However, note that one of my apps did not work properly until I
updated the R package shiny in R (to 1.7.1) which is newer than the
current debian package (1.5), so we should likely update r-cran-shiny
when shiny-server gets uploaded.

And to use the examples:

sudo mkdir /srv/shiny-server
sudo ln -s -r /usr/lib/shiny-server/samples/* /srv/shiny-server

And to enable logging:

The shiny-server.service file is missing the instruction to log.
Compare the line [1] in our version vs. [2] in version included in the
upstream repo. When [1] is replaced with [3] and the file
/var/log/shiny-server.log is created, logging works properly. Probably
we can replace shiny-server.service with the upstream version
(https://github.com/rstudio/shiny-server/blob/master/config/systemd/shiny-server.service).

[1] ExecStart=/usr/bin/shiny-server
[2] ExecStart=/usr/bin/env bash -c 'exec
/opt/shiny-server/bin/shiny-server >> /var/log/shiny-server.log 2>&1'

[3] ExecStart=/usr/bin/env bash -c 'exec
/usr/lib/shiny-server/bin/shiny-server >> /var/log/shiny-server.log
2>&1'

Then, as far as I can see, it's all working!


A number of node-sockjs-client's dependencies were updated between
1.5.2 and current 1.6.0 so the underlying issue may be an out of date
dependency, or some other change that upstream shiny-server has not
yet adjusted to. Is there a workaround for this, e.g. to ship the
1.5.2 sockjs.js and sockjs.min.js files along with shiny-server as a
patch, until upstream adopts 1.6.0?

Best,
Eric

On Wed, Mar 30, 2022 at 5:14 AM Nilesh Patra  wrote:
>
> Hi Eric,
>
> On Sun, Mar 27, 2022 at 06:18:49PM +0530, Nilesh Patra wrote:
> > > > 3. update outdated node-shiny-server-client to latest upstream
> > >
> > > Seems a wise thing to do.
> >
> > I have done so.
> >
> > @Eric, if you can try with the newer versions of these packages to check if 
> > your
> > second app looks better, that'd be much appreciated.
> > If it is, then rest stuff should be relatively easy to fix.
>
> Did you get a chance to test it with updated versions of the packages?
> I was planning to proceed to finalise this package according to the feedback.
>
> Let me know.
>
> Regards,
> Nilesh



-- 
Eric Brown MD MSc FRCPC
For encryption, OpenPGP public key available on request.



Re: shiny-server in debian

2022-03-30 Thread Eric Brown
Hi Nilesh,

Thanks for checking in and your ongoing work on this. I've been trying
to get it to work but haven't had luck yet. With this updated version,
the server still runs but now the included sample apps are not working
(the shiny app displays an initial state but is not interactive; my
own apps do not work).

Some dependencies still need updating (remove jslib-sockjs and add
node-sockjs-client).
Some manual intervention is still required:
sudo mkdir /usr/lib/shiny-server/node_modules
sudo ln -s /usr/share/nodejs/sockjs-client/ /usr/lib/shiny-server/node_modules/
sudo ln -s /usr/share/nodejs/shiny-server-client/
/usr/lib/shiny-server/node_modules/

Even with the above, this is the error that shows in the console when
running the basic included sample app:

Uncaught TypeError: global.SockJS is not a constructor
at RobustConnection._factory (shiny-server-client.min.js:1:39593)
at open_p (shiny-server-client.min.js:1:13970)
at attempt (shiny-server-client.min.js:1:42948)
(anonymous)@shiny-server-client.min.js:1
ope...@shiny-server-client.min.js:1
atte...@shiny-server-client.min.js:1
setTimeout (async)
exports.retrypromis...@shiny-server-client.min.js:1
robustconnection._conn...@shiny-server-client.min.js:1
robustconnect...@shiny-server-client.min.js:1
(anonymous)@shiny-server-client.min.js:1
(anonymous)@shiny-server-client.min.js:1
shiny.createsoc...@shiny-server-client.min.js:1
va...@shinyapp.ts:324
va...@shinyapp.ts:277
v...@init.ts:425
(anonymous)@index.ts:56
setTimeout (async)
(anonymous)@index.ts:55
e...@jquery.min.js:2
t...@jquery.min.js:2
setTimeout (async)
(anonymous)@jquery.min.js:2
c...@jquery.min.js:2
firew...@jquery.min.js:2
f...@jquery.min.js:2
c...@jquery.min.js:2
firew...@jquery.min.js:2
re...@jquery.min.js:2
b...@jquery.min.js:2

I have tried various things including adjusting the server
configuration, changing server protocols, trying more symlinks of
dependencies (including symlinking all of the nodejs modules to
node_modules, but have not had success. To try to diagnose the
problem, I ran npm install in the shiny-server directory. This did
result in everything working. To me this suggests we are possibly
missing a node dependency, have an out of date dependency, or they are
not linked properly (not sure exactly what npm install does aside from
fetching and identifying and installing node dependencies, and whether
some parts of this process are still needed when using local/deb
versions). Please let me know if the console error message above gives
you any hints, or if you have suggestions for me to try to narrow this
down.

I did figure out why server logging was not working. The
shiny-server.service file is missing the instruction to log. Compare
the line [1] in our version vs. [2] in version included in the
upstream repo. When [1] is replaced with [3] and the file
/var/log/shiny-server.log is created, logging works properly. Probably
we can replace shiny-server.service with the upstream version
(https://github.com/rstudio/shiny-server/blob/master/config/systemd/shiny-server.service).

[1] ExecStart=/usr/bin/shiny-server
[2] ExecStart=/usr/bin/env bash -c 'exec
/opt/shiny-server/bin/shiny-server >> /var/log/shiny-server.log 2>&1'

[3] ExecStart=/usr/bin/env bash -c 'exec
/usr/lib/shiny-server/bin/shiny-server >> /var/log/shiny-server.log
2>&1'

I'm still looking into all this but am getting stuck and any hints or
suggestions are appreciated.
Best,
Eric

On Wed, Mar 30, 2022 at 5:14 AM Nilesh Patra  wrote:
>
> Hi Eric,
>
> On Sun, Mar 27, 2022 at 06:18:49PM +0530, Nilesh Patra wrote:
> > > > 3. update outdated node-shiny-server-client to latest upstream
> > >
> > > Seems a wise thing to do.
> >
> > I have done so.
> >
> > @Eric, if you can try with the newer versions of these packages to check if 
> > your
> > second app looks better, that'd be much appreciated.
> > If it is, then rest stuff should be relatively easy to fix.
>
> Did you get a chance to test it with updated versions of the packages?
> I was planning to proceed to finalise this package according to the feedback.
>
> Let me know.
>
> Regards,
> Nilesh



-- 
Eric Brown MD MSc FRCPC
For encryption, OpenPGP public key available on request.



Re: shiny-server in debian

2022-03-26 Thread Eric Brown
Hi Nilesh,

Thanks for updating it. I tried it out on a fresh install and was
getting the similar error as previously in the console, but instead of
missing sockjs-0.3.4.min.js, it was unable to find sockjs.min.js.
I was able to fix this by adding the following symbolic links:
ln -s /usr/share/javascript/sockjs/*
/usr/lib/shiny-server/node_modules/sockjs-client/dist
ln -s /usr/share/nodejs/shiny-server-client /usr/lib/shiny-server/node_modules

This results in the sample apps that ship with shiny-server to work
properly, although there are still some errors in the Chromium
console, e.g. it complains of missing strftime-min.js and
html5shiv.min.js.

However it doesn't fix the issue with my apps. I think the problem is
that both my apps use shinyjs, and it appears from the console that
many of the javascript files associated with that are unable to be
found (even though shinyjs loads in R and is installed properly via
apt install r-cran-shinyjs). The bigger issue may be that shiny-server
is not able to find .js files from R packages or elsewhere in the
system. Maybe you have some ideas about why this might be? It could
relate to the problems I found below.

I think we probably need to update Debian's node-shiny-server-client
package as well
(https://salsa.debian.org/science-team/node-shiny-server-client). It
is several years old and it looks like there have been some important
changes upstream that are likely causing problems for us now.

I took a closer look at the sockjs dependencies in Debian, which could
be the cause of some of these problems.

There are 2 upstream packages: sockjs-node (v. 0.3.24, Dec 2, 2021,
https://github.com/sockjs/sockjs-node) and sockjs-client (v. 1.6.0,
Feb 27, 2022, https://github.com/sockjs/sockjs-client).

Debian has node-sockjs-client (v. 1.5.2,
https://github.com/sockjs/sockjs-client) which corresponds to upstream
sockjs-client and is basically up to date.

Debian also has libjs-sockjs v 0.3.4
(https://packages.debian.org/bullseye/libjs-sockjs) which actually
corresponds to an extremely old 2012 version of the same upstream
sockjs-client.

Finally, Debian has node-sockjs v. 0.3.24 which corresponds with
upstream sockjs-node.

I think it was assumed that libjs-sockjs corresponded to sockjs-node
but this doesn't appear to be the case. Since it does have an older
version of node-sockjs-client it did seem to help but it should  not
be a dependency and should probably be removed from Debian.

The other issue I noticed is in node-sockjs-client
(https://salsa.debian.org/js-team/node-sockjs-client). The debian
version removes the dist directory, where sockjs.js and sockjs.min.js
are found (https://salsa.debian.org/js-team/node-sockjs-client). This
was done deliberately in a commit, and I presume (maybe wrongly) if it
was because the files are supposed to be built through the debian
building process, but it appears they are not when installed and I
they are needed. I think we should be using sockjs.js/sockjs.min.js
from here, not from libjs-sockjs. Since there is no version from the
up to date node-sockjs-client, the symlink above uses the very very
old sockjs.js file from the outdated libjs-sockjs package, and may be
causing problems.

So in summary, I think we should try, if this sounds sensible:
1. remove libjs-sockjs as a dependency of shiny-server
2. add back the dist directory to node-sockjs-client, and add
node-sockjs-client as a dependency of shiny-server
3. update outdated node-shiny-server-client to latest upstream

Best,
Eric

On Sat, Mar 26, 2022 at 3:02 PM Nilesh Patra  wrote:
>
> Hi Eric,
>
> On Sat, Mar 26, 2022 at 12:20:59PM -0400, Eric Brown wrote:
> > > I will try to update the package and see. If it's not too much work, I'll 
> > > push an update.
> >
> > Great thanks, and I'd be happy to test again.
>
> I have updated to the latest version and pushed to my personal repo. I did
> not get the the time to test examples, and hence it'd be great if you
> could test+troubleshoot if something is missing.
>
> @All, I renamed shiny-server to node-shiny-server as source package name, 
> binary
> package name is still shiny-server. This is done to not diverge from JS team
> conventions. The repo can be found at: 
> https://salsa.debian.org/science-team/node-shiny-server/
>
> > I'm also hoping to try to build and test in ARM. I think having
> > shiny-server in ARM, for e.g. hosting on a Raspberry pi, would be
> > hugely valuable, as there is currently no straightforward way for
> > users but for many use cases it could be ideal.
>
> Actually debian supports a bunch of architectures;
> So whenever the package is accepted, it'd also build on both armhf and arm64,
> so hopefully that'd easily make it available to users.
>
> Regards,
> Nilesh



--
Eric Brown MD MSc FRCPC
For encryption, OpenPGP public key available on request.



Re: shiny-server in debian

2022-03-26 Thread Eric Brown
Hi Nilesh and Andreas,

> I did not see any according commits in Git.

Sorry I meant I made progress on diagnosing the issues as described in
my email, but did not make any corresponding changes (not sure how
these are best dealt with in Debian).

> Eric, does adding a manual symlink for the minified file to the assets/ 
> directory work for you?

Yes, this also solves the problem: ln -s
/usr/share/nodejs/shiny-server-client
/usr/lib/shiny-server/node_modules. Note that I figured this out by
looking at my shiny server installed the typical way on another system
and this is where all the node modules are located. I'm not sure why
only this one needs to be linked there, but maybe it's something to do
with how we install node-shiny-server compared to other node modules?

> Could you maybe push your project somewhere for us to test?
> Also could you describe a little more on what isn't working as expected for 
> your second project?

Yes, it should be straightforward to test. Here are the steps for my 2
examples, once shiny-server is installed:

Example 1 (appears to fully work):
1. In R, install dependencies: install.packages(c("covidprobability",
"shinyjs"))
2. Save app.R 
(https://raw.githubusercontent.com/eebrown/covidprobability_shiny/main/app.R)
to /srv/shiny-server/covid
3. Run app by going to http://localhost:3838/covid
4. Compare to expected behaviour at http://covid.eebc.ca

Example 2 (does not work properly):
1. In R, install dependencies: install.packages(c("chlorpromazineR", "shinyjs"))
2. Save app.R 
(https://raw.githubusercontent.com/eebrown/chlorpromazineR_shiny/main/app.R)
to /srv/shiny-server/ap
3. Run app by going to http://localhost:3838/ap
4. Compare to expected behaviour at http://ap.eebc.ca

In example 2, the final drop down menu doesn't work at all (no
default, no options) and it is not clear why. It works locally and on
my server. I don't see any illustrative errors in the browser console
or the app log. This is why I was wondering about it being due to an
older version of either shiny-server or shiny-server-client.

> I will try to update the package and see. If it's not too much work, I'll 
> push an update.

Great thanks, and I'd be happy to test again.

> Yep, I re-pinged the maintainer to get that in :)

Thank you!

I'm also hoping to try to build and test in ARM. I think having
shiny-server in ARM, for e.g. hosting on a Raspberry pi, would be
hugely valuable, as there is currently no straightforward way for
users but for many use cases it could be ideal.

Best,
Eric


On Sat, Mar 26, 2022 at 3:15 AM Nilesh Patra  wrote:
>
>
>
> Hi Eric and Andreas,
>
> Replying to both in the same mail
>
> On 26 March 2022 11:20:22 am IST, Andreas Tille  wrote:
> >Hi,
> >
> >Am Fri, Mar 25, 2022 at 08:37:52PM -0400 schrieb Eric Brown:
> >> Thank you Nilesh for explaining why we can't have the example files
> >> placed in /srv automatically. It's not critical. I see in that
> >> document that asking the user for permission to make the links would
> >> be allowed, this to me sounds like a good solution/compromise.
> >
> >Regarding the /srv issue we might have two options: Either we find and
> >patch the code pieces inside shiny-server refering to /srv (in current
> >Git I get:
> >   $ grep -R '/srv' | wc -l
> >   36
> >but there are several examples in this result set) or we provide a
> >symlink in postinst which might be less error prone (but for sure
> >not es clean).
>
> But wouldn't that be an equivalent of installing anyway?
> I thought we need some sort of $debconf to get it in, might be worth asking 
> on -devel once?
>
> >> The console error of missing __assets__/sockjs-0.3.4.min.js is because
> >> libjs-sockjs needs to be included as a dependency of shiny-server.
> >> When I manually apt install libjs-sockjs, that error went away.
>
> Yeah, my hunch was right. I wrongly removed that from depends, I re-added 
> that yesterday.
>
> >> The other missing file in the console I am seeing is
> >> ___assets___/shiny-server-client.min.js. This is a file that gets
> >> installed with node-shiny-server-client. I was able to make this error
> >> go away by copying the entire directory
> >> /usr/share/node-js/shiny-server-client/ to a new directory
> >> /usr/lib/shiny-server/node_modules/shiny-server-client/.
>
> Eric, does adding a manual symlink for the minified file to the assets/ 
> directory work for you?
>
> >> The other one is not quite working as expected, but
> >> is not crashing or throwing errors. I wonder if it may relate to
>
> Could you maybe push your project somewhere for us to test?
> Also could you describe a little more on what isn't work

Re: shiny-server in debian

2022-03-25 Thread Eric Brown
Hi again,

Thank you Nilesh for explaining why we can't have the example files
placed in /srv automatically. It's not critical. I see in that
document that asking the user for permission to make the links would
be allowed, this to me sounds like a good solution/compromise.

After much exploration, I have made some good progress in
troubleshooting the errors.

The console error of missing __assets__/sockjs-0.3.4.min.js is because
libjs-sockjs needs to be included as a dependency of shiny-server.
When I manually apt install libjs-sockjs, that error went away.

The other missing file in the console I am seeing is
___assets___/shiny-server-client.min.js. This is a file that gets
installed with node-shiny-server-client. I was able to make this error
go away by copying the entire directory
/usr/share/node-js/shiny-server-client/ to a new directory
/usr/lib/shiny-server/node_modules/shiny-server-client/.

The above 2 fixes made the console errors go away. One of my apps now
works as expected. The other one is not quite working as expected, but
is not crashing or throwing errors. I wonder if it may relate to
shiny-server and node-shiny-server-client being older versions.

By the way, node-send is now updated and in unstable, resolving the
bug. Nilesh's node-rewire and node-sockjs are in NEW.

Best,
Eric






On Fri, Mar 25, 2022 at 3:21 AM Andreas Tille  wrote:
>
> Hi Nilesh,
>
> thanks a lot for your effort which is really welcome.  I honestly think
> that its the most straightforward way to upload everything to new (if
> not yet done - I did not checked) - possibly to experimental in case you
> are not sure.
>
> Thanks again
> Andreas.
>
> Am Fri, Mar 25, 2022 at 11:13:18AM +0530 schrieb Nilesh Patra:
> > Also adding andreas to the loop in case he has time to check.
> > Andreas, if you happen to build shiny-server, please remember to add
> >
> >   https://people.debian.org/~nilesh/shiny-server/
> >
> > to your pbuilder extra-repos.
> >
> > On Fri, Mar 25, 2022 at 11:10:04AM +0530, Nilesh Patra wrote:
> > > Hi Eric,
> > >
> > > thanks for the feedback
> > >
> > > On Thu, Mar 24, 2022 at 09:40:30PM -0400, Eric Brown wrote:
> > > > First, there are missing symlinks at /srv/shiny-server. I think the
> > > > expected behaviour is for there to be symbolic links to an index.html
> > > > [...]
> > >
> > > I don't think this can happen in the debian land, unfortunately. Debian 
> > > packages
> > > are not supposed to install anything to /srv
> > > The closest thing I could find highlighting it is this lintian tag[1]
> > >
> > > [1]: https://lintian.debian.org/tags/dir-or-file-in-srv
> > >
> > > > When I move the sample files or my own shiny apps to
> > > > /srv/shiny-server, the folder that determines what is hosted, the
> > > > server does serve the pages and they render properly. However, when
> > > > interacting with the shiny app, it is clear they are not working
> > > > properly. The are unresponsive, don't update/produce results and
> > > > ultimately timeout/freeze. When I look at the web browser console, it
> > > > appears that certain internal javascript files are not being found
> > > > (e.g. __assets__/sockjs-0.3.4.min.js).
> > >
> > > This should be trivial to fix, however I do not have time to do that
> > > at the moment.
> > > @Andrius, if you are reading this, could you please make according 
> > > changes in d/links?
> > >
> > > > Finally, I noticed that the server logging is not fully working. The
> > > > server is supposed to log to /var/log/shiny-server.log but there is no
> > > > such file. On the other hand, it does properly log each individual
> > > > app's R output to /var/log/shiny-server/app_name-*.log.
> > >
> > > Maybe something is messed in the config files, again no time to check.
> > > I only chimed in to get the package building, and did not check on the 
> > > rest of
> > > the things, unfortunately I am out of time now, sorry :(
> > >
> > > > I hope this is helpful
> > >
> > > Indeed, thanks for the help.
> > >
> > > Regards,
> > > Nilesh
> >
> >
>
>
>
> --
> http://fam-tille.de



-- 
Eric Brown MD MSc FRCPC
For encryption, OpenPGP public key available on request.



Re: shiny-server in debian

2022-03-24 Thread Eric Brown
Hi again,

As previously noted, using your above-linked repo, shiny-server
installs on a new debian sid VM without error. However it doesn't
fully work as expected. Here are a few issues I have noticed.

First, there are missing symlinks at /srv/shiny-server. I think the
expected behaviour is for there to be symbolic links to an index.html
file and a sample apps folder in this location (specifically these
files https://github.com/rstudio/shiny-server/tree/master/samples),
which I believe is configured here
(https://github.com/rstudio/shiny-server/blob/master/packaging/debian-control/postinst.in)

When I move the sample files or my own shiny apps to
/srv/shiny-server, the folder that determines what is hosted, the
server does serve the pages and they render properly. However, when
interacting with the shiny app, it is clear they are not working
properly. The are unresponsive, don't update/produce results and
ultimately timeout/freeze. When I look at the web browser console, it
appears that certain internal javascript files are not being found
(e.g. __assets__/sockjs-0.3.4.min.js).

Finally, I noticed that the server logging is not fully working. The
server is supposed to log to /var/log/shiny-server.log but there is no
such file. On the other hand, it does properly log each individual
app's R output to /var/log/shiny-server/app_name-*.log.

I wonder whether these issues relate to patching it to use the Debian
node dependencies rather than its upstream internal install process?

I hope this is helpful and let me know if you need any clarifications.

Best,
Eric


On Thu, Mar 24, 2022 at 2:33 PM Eric Brown  wrote:
>
> Hi Nilesh,
> This is fantastic. I can say right off the bat that it installed and ran just 
> fine when I used your repo per the README. I’m going to do it again on a 
> fresh Debian and try my apps, just to be sure because I had been playing 
> around with some dependencies on this current install.
> Thanks for all your work on this.
> Best,
> Eric
>
> On Thu, Mar 24, 2022 at 13:33 Nilesh Patra  wrote:
>>
>> Hi Eric,
>>
>> On 3/24/22 10:05 PM, Eric Brown wrote:
>> > Hi Nilesh,
>> >
>> > I'm not sure whether you are running the current shiny-server version
>> > on salsa (upstream 1.5.14.948) but if so, the errors may be because it
>> > is out of date and subsequent to that release there were some changes
>> > to the iputils.js file
>> > (https://github.com/rstudio/shiny-server/commit/fba8b83ccd58eba1c2118884b25669a1d99ea202).
>> > I wonder if updating to the latest upstream release might fix these
>> > errors?
>>
>> Thanks that helped.
>> I backported selective fixes and got all tests passing and the package 
>> building \o/
>>
>> Since you volunteered to test the package once, I have hosted the '.deb' and 
>> other '.deb'
>> of its dependencies which are not available in the archive here:
>>
>> https://people.debian.org/~nilesh/shiny-server/
>>
>> Readme should help you pull it w/o hassles. If you want to directly install 
>> the '.debs' they are in the
>> pool dir
>>
>> https://people.debian.org/~nilesh/shiny-server/pool/main/
>>
>> Could you please test this? That'd be very helpful.
>>
>> Regards,
>> Nilesh
>>
>>
>>
> --
> Eric Brown MD MSc FRCPC
> For encryption, OpenPGP public key available on request.



--
Eric Brown MD MSc FRCPC
For encryption, OpenPGP public key available on request.



Re: shiny-server in debian

2022-03-24 Thread Eric Brown
Hi Nilesh,
This is fantastic. I can say right off the bat that it installed and ran
just fine when I used your repo per the README. I’m going to do it again on
a fresh Debian and try my apps, just to be sure because I had been playing
around with some dependencies on this current install.
Thanks for all your work on this.
Best,
Eric

On Thu, Mar 24, 2022 at 13:33 Nilesh Patra  wrote:

> Hi Eric,
>
> On 3/24/22 10:05 PM, Eric Brown wrote:
> > Hi Nilesh,
> >
> > I'm not sure whether you are running the current shiny-server version
> > on salsa (upstream 1.5.14.948) but if so, the errors may be because it
> > is out of date and subsequent to that release there were some changes
> > to the iputils.js file
> > (
> https://github.com/rstudio/shiny-server/commit/fba8b83ccd58eba1c2118884b25669a1d99ea202
> ).
> > I wonder if updating to the latest upstream release might fix these
> > errors?
>
> Thanks that helped.
> I backported selective fixes and got all tests passing and the package
> building \o/
>
> Since you volunteered to test the package once, I have hosted the '.deb'
> and other '.deb'
> of its dependencies which are not available in the archive here:
>
> https://people.debian.org/~nilesh/shiny-server/
>
> Readme should help you pull it w/o hassles. If you want to directly
> install the '.debs' they are in the
> pool dir
>
> https://people.debian.org/~nilesh/shiny-server/pool/main/
>
> Could you please test this? That'd be very helpful.
>
> Regards,
> Nilesh
>
>
>
> --
Eric Brown MD MSc FRCPC
For encryption, OpenPGP public key available on request.


Re: shiny-server in debian

2022-03-24 Thread Eric Brown
Hi Nilesh,

I'm not sure whether you are running the current shiny-server version
on salsa (upstream 1.5.14.948) but if so, the errors may be because it
is out of date and subsequent to that release there were some changes
to the iputils.js file
(https://github.com/rstudio/shiny-server/commit/fba8b83ccd58eba1c2118884b25669a1d99ea202).
I wonder if updating to the latest upstream release might fix these
errors?

Best,
Eric

On Thu, Mar 24, 2022 at 6:36 AM Andrius Merkys  wrote:
>
> Hi Nilesh,
>
> On 2022-03-24 12:03, Nilesh Patra wrote:
> > On 3/24/22 3:09 PM, Nilesh Patra wrote:
> >> I figured out the problem. It is so because the debian package
> >> node-send is patched[1]
> >> to use node-mime-types instead of node-mime (not sure why)
> >>
> >> I just filed a bug report (with you in x-debbugs-cc) to possibly fix
> >> it in node-send.
>
> Thanks for debugging this.
>
> > After fixing this locally, there are few failing tests (majority pass,
> > thankfully)
> > on similar lines of:
> >
> > |  1) iputil
> > |   validates addresses:
> > | TypeError: (intermediate value).isValid is not a function
> > |  at Object.isValid (lib/core/iputil.js:35:29)
> > |  at /home/nilesh/packages/shinyserv/shiny-server/test/iputil.js:32:36
> > |  at Array.forEach ()
> >
> > But right now I have no time to further debug this. Would be great if
> > you can take a look.
>
> I gave this a glance, but I cannot understand the problem, alas.
>
> Best,
> Andrius



-- 
Eric Brown MD MSc FRCPC
For encryption, OpenPGP public key available on request.



Re: shiny-server in debian

2022-03-23 Thread Eric Brown
Hi Joost and Andrius,

Thank you both! Andrius, if you're able to get it to build without
node-rewire I would be happy to test a .deb with the shiny apps that I
have made. It looks like Joost is also able to test .debs.

Best,
Eric

On Wed, Mar 23, 2022 at 11:21 AM Andrius Merkys  wrote:
>
> Hi Eric,
>
> On 2022-03-23 16:25, Eric Brown wrote:
> > Thank you Andrius, Andreas et al. for your work in getting
> > node-sockjs-client in Debian testing. It appears that shiny-server
> > (https://salsa.debian.org/science-team/shiny-server) may now have just
> > one dependency left - node-rewire, which I'm not sure is actually
> > required to build as it is for CI/development. Also note despite the
> > warning for node-stable it appears to be packaged
> > (https://packages.debian.org/sid/node-stable).
>
> Revisiting shiny-server, I have turned on the build time tests to have a
> better understanding of what is left to be done. Tests now fail due to
> missing rewire:
>
>debian/rules override_dh_auto_test
> make[1]: Entering directory '/<>'
> mocha test
>
> Error: Cannot find module 'rewire'
>
> Maybe tests using rewire could be ignored for now. Yet I would very much
> want to run the tests, as this would be a great way to find out whether
> shiny-server works as packaged for Debian.
>
> > There have been many interested parties in packaging shiny-server in
> > Debian over the past few years. I wonder if anyone has the time to
> > revisit now that (all?) the dependencies are in Debian? I
> > unfortunately lack the skills for this.
>
> I can give it a glance. However, as I have never used shiny-server
> before, I do not think there is much I can do apart from checking the tests.
>
> Best,
> Andrius



shiny-server in debian

2022-03-23 Thread Eric Brown
Thank you Andrius, Andreas et al. for your work in getting
node-sockjs-client in Debian testing. It appears that shiny-server
(https://salsa.debian.org/science-team/shiny-server) may now have just
one dependency left - node-rewire, which I'm not sure is actually
required to build as it is for CI/development. Also note despite the
warning for node-stable it appears to be packaged
(https://packages.debian.org/sid/node-stable).

There have been many interested parties in packaging shiny-server in
Debian over the past few years. I wonder if anyone has the time to
revisit now that (all?) the dependencies are in Debian? I
unfortunately lack the skills for this.

$ npm2deb depends -r
https://github.com/rstudio/shiny-server/raw/master/package.json
Dependencies:
NPM   Debian
shiny-server (1.5.18) None
├─ bash (0.0.1)   node-bash (0.0.1-4)
├─ client-sessions (^0.8.0)   node-client-sessions (0.8.0-3)
├─ compression (^1.7.4)   node-compression (1.7.4-3)
├─ express (^4.17.2)  node-express
(4.17.3+~4.17.13-1)
├─ faye-websocket (^0.11.4)   node-faye-websocket (0.11.4-1)
├─ graceful-fs (^4.2.9)   node-graceful-fs (4.2.9-1)
├─ handlebars (^4.7.7)node-handlebars
(3:4.7.7+~4.1.0-1)
├─ http-proxy (^1.18.1)   node-http-proxy (1.18.1-6)
├─ ip-address (^8.1.0)node-ip-address (8.1.0-2)
├─ log4js (^6.4.1)node-log4js (6.4.2+~cs8.3.8-1)
├─ moment (^2.29.1)   node-moment (2.29.1+ds-3)
├─ morgan (^1.10.0)   node-morgan (1.10.0-2)
├─ nan (^2.15.0)  node-nan (2.15.0-1)
├─ optimist 
(github:rstudio/node-optimist#dbbadda31e53b63225a57e172a528b1ddc52be52)node-optimist
(0.6.1+~0.0.30-1)
├─ pause (0.1.0)  node-pause (0.1.0-4)
├─ q (^1.5.1) node-q (1.5.1-4)
├─ qs (^6.10.3)   node-qs (6.10.3+ds+~6.9.7-1)
├─ send (^0.17.2) node-send (0.17.2-2)
├─ shiny-server-client
(github:rstudio/shiny-server-client#v1.2.0)node-shiny-server-client
(1.0.0+git20180820.eba5e90+dfsg-5)
├─ sockjs (^0.3.24)   node-sockjs (0.3.24-1)
├─ sockjs-client
(github:jcheng5/sockjs-client#v1.5.2.2-jcheng5)node-sockjs-client
(1.5.2+dfsg1-2)
├─ split (^1.0.1) node-split (1.0.1-1)
├─ stable (^0.1.8)None
└─ underscore (^1.13.2)   underscore (1.13.2~dfsg-2)

Build dependencies:
NPM   Debian
mocha (^9.2.0)node-mocha
(9.2.2+ds1+~cs28.3.8-1)
rewire (^6.0.0)   None
should (^13.2.3)  should.js (13.2.3~dfsg-5)
sinon (^13.0.1)   node-sinon
(13.0.1+ds+~cs71.22.21-2)

Warnings occurred:
 [warning] stable: stable is included in node-svgo. Package it
separately and remove it from node-svgo if you need it for another
module.



Re: [Pkg-javascript-devel] sockjs-client is in Debian but needs update (Was: [covid-19] shiny-server (Was: dependencies Re: ITP: streamlit))

2022-02-27 Thread Eric Brown
Hi Andrius,
Likewise, thank you very much! It’s exciting that the dependencies for
shiny-server are coming together. Please note the upstream for
sockjs-client responded to me and released 1.6.0 which also updates some
other dependency versions.
https://github.com/sockjs/sockjs-client/releases/tag/v1.6.0
Best,
Eric

On Fri, Feb 25, 2022 at 08:51 Andreas Tille  wrote:

> Hi Andrius,
>
> Am Fri, Feb 25, 2022 at 03:27:43PM +0200 schrieb Andrius Merkys:
> >
> > Since there are no reverse dependencies on libjs-sockjs and we are not
> > in a hurry with shiny-server (we can still work on that with local
> > node-sockjs-client package), I would like to avoid experimental. This
> > way I would not have to deal with Breaks+Replaces due to same locations
> > occupied by two different packages.
>
> Perfectly fine for me.
>
> Thanks a lot for caring for this package
>
>Andreas.
>
> --
> http://fam-tille.de
>
-- 
Eric Brown MD MSc FRCPC
For encryption, OpenPGP public key available on request.


Re: sockjs-client is in Debian but needs update (Was: [covid-19] shiny-server (Was: dependencies Re: ITP: streamlit))

2022-02-22 Thread Eric Brown
Thanks Andrius,

I filed an issue asking the upstream dev to consider a new release:

https://github.com/sockjs/sockjs-client/issues/577

Best,
Eric


On Tue, Feb 22, 2022 at 09:20 Andrius Merkys  wrote:

> Hi Eric,
>
> On 2022-02-22 14:52, Eric Brown wrote:
> > If I’m understanding the below correctly, it appears that the node-json3
> > may already have been removed from the dependency socksjs-client, but
> > the updated version is not released yet.
> >
> >
> https://github.com/sockjs/sockjs-client/commit/d9584abe2c7c913ce95a1aea29e5744dd85e1af4
> > <
> https://github.com/sockjs/sockjs-client/commit/d9584abe2c7c913ce95a1aea29e5744dd85e1af4
> >
>
> Great - this saves quite some work.
>
> > I wonder if we ask the dev to consider a release, and then update the
> > Debian package, that would solve the problem?
>
> Preferably. Otherwise we could convert this commit to a patch and
> attempt applying it, or package development version, but having a stable
> release would be better.
>
> Best,
> Andrius
>
-- 
Eric Brown MD MSc FRCPC
For encryption, OpenPGP public key available on request.


Re: [covid-19] shiny-server (Was: dependencies Re: ITP: streamlit)

2022-02-21 Thread Eric Brown
Hello,

It appears that significant progress has been made in packaging the
dependencies of shiny-server. I wonder if anyone is interested and
able to revisit packaging shiny-server?

 npm2deb depends -r
https://github.com/rstudio/shiny-server/raw/master/package.json
Dependencies:
NPM   Debian
shiny-server (1.5.18) None
├─ bash (0.0.1)   node-bash (0.0.1-4)
├─ client-sessions (^0.8.0)   node-client-sessions (0.8.0-3)
├─ compression (^1.7.4)   node-compression (1.7.4-3)
├─ express (^4.17.2)  node-express
(4.17.3+~4.17.13-1)
├─ faye-websocket (^0.11.4)   node-faye-websocket (0.11.4-1)
├─ graceful-fs (^4.2.9)   node-graceful-fs
(4.2.4+repack-1)
├─ handlebars (^4.7.7)node-handlebars
(3:4.7.7+~4.1.0-1)
├─ http-proxy (^1.18.1)   node-http-proxy (1.18.1-6)
├─ ip-address (^8.1.0)node-ip-address (8.1.0-2)
├─ log4js (^6.4.1)node-log4js (6.4.1+~cs8.3.5-1)
├─ moment (^2.29.1)   node-moment (2.29.1+ds-3)
├─ morgan (^1.10.0)   node-morgan (1.10.0-2)
├─ nan (^2.15.0)  node-nan (2.15.0-1)
├─ optimist 
(github:rstudio/node-optimist#dbbadda31e53b63225a57e172a528b1ddc52be52)node-optimist
(0.6.1+~0.0.30-1)
├─ pause (0.1.0)  node-pause (0.1.0-4)
├─ q (^1.5.1) node-q (1.5.1-4)
├─ qs (^6.10.3)   node-qs (6.10.3+ds+~6.9.7-1)
├─ send (^0.17.2) node-send (0.17.2-2)
├─ shiny-server-client
(github:rstudio/shiny-server-client#v1.2.0)node-shiny-server-client
(1.0.0+git20180820.eba5e90+dfsg-5)
├─ sockjs (^0.3.24)   None
│  ├─ faye-websocket (^0.11.3)node-faye-websocket (0.11.4-1)
│  ├─ uuid (^8.3.2)   node-uuid (8.3.2+~8.3.3-1)
│  └─ websocket-driver (^0.7.4)
node-websocket-driver (0.7.4+~cs0.6.7-2)
├─ sockjs-client (github:jcheng5/sockjs-client#v1.5.2.2-jcheng5)None
│  ├─ debug (^3.2.6)  node-debug (4.3.2+~cs4.1.7-1)
│  ├─ eventsource (^1.0.7)node-eventsource
(1.1.0+~1.1.8-1)
│  ├─ faye-websocket (^0.11.3)node-faye-websocket (0.11.4-1)
│  ├─ inherits (^2.0.4)   node-inherits (2.0.4-4)
│  ├─ json3 (^3.3.3)  nodejs
(16.13.2+really14.19.0~dfsg-1)
│  └─ url-parse (^1.5.3)  node-url-parse
(1.5.9+~1.4.8-1)
├─ split (^1.0.1) node-split (1.0.1-1)
├─ stable (^0.1.8)None
└─ underscore (^1.13.2)   underscore (1.13.2~dfsg-2)

Build dependencies:
NPM   Debian
mocha (^9.2.0)node-mocha
(9.2.0+ds1+~cs28.5.4-1)
rewire (^6.0.0)   None
should (^13.2.3)  should.js (13.2.3~dfsg-5)
sinon (^13.0.1)   node-sinon
(13.0.1+ds+~cs71.22.21-2)

Warnings occurred:
 [warning] stable: stable is included in node-svgo. Package it
separately and remove it from node-svgo if you need it for another
module.
 [error]   json3: No longer maintained, use the native `JSON.parse`
and `JSON.stringify` instead


Warm regards,
Eric