Re: ITA: glm -- C++ library for OpenGL GLSL type-based mathematics

[Andrea Pappacoda]

Il 18 settembre 2022 06:26:26 CEST, Nilesh Patra  ha 
scritto:
>I granted you maintainer permissions to glm repo, now you should be able
>to enable CI.

Thanks Nilesh, everything's good now :D

Re: ITA: glm -- C++ library for OpenGL GLSL type-based mathematics

[Nilesh Patra]

On Sat, Sep 17, 2022 at 09:40:22PM +0200, Andrea Pappacoda wrote:
> Il giorno sab 17 set 2022 alle 23:19:48 +05:30:00, Nilesh Patra
>  ha scritto:
> > I have added you to the science team. Feel free to ping me if you still
> > run into any issues with permissions.
> 
> Hi Nilesh, thanks! I've pushed to the repo successfully. One thing I noticed
> though is that I can't change the repo's settings (e.g. I'm unable to reach
> https://salsa.debian.org/science-team/glm/edit or
> https://salsa.debian.org/science-team/glm/-/settings/ci_cd), and I'm thus
> unable to enable CI. Maybe I need some additional permissions for the glm
> repo in particular?

I granted you maintainer permissions to glm repo, now you should be able
to enable CI.
Let me know if you still run into any issues.

-- 
Best,
Nilesh


signature.asc
Description: PGP signature

Re: ITA: glm -- C++ library for OpenGL GLSL type-based mathematics

[Andrea Pappacoda]

Il giorno sab 17 set 2022 alle 23:19:48 +05:30:00, Nilesh Patra 
 ha scritto:
I have added you to the science team. Feel free to ping me if you 
still run into any issues with permissions.


Hi Nilesh, thanks! I've pushed to the repo successfully. One thing I 
noticed though is that I can't change the repo's settings (e.g. I'm 
unable to reach https://salsa.debian.org/science-team/glm/edit or 
https://salsa.debian.org/science-team/glm/-/settings/ci_cd), and I'm 
thus unable to enable CI. Maybe I need some additional permissions for 
the glm repo in particular?


--
OpenPGP key: 66DE F152 8299 0C21 99EF  A801 A8A1 28A8 AB1C EE49

Re: ITA: glm -- C++ library for OpenGL GLSL type-based mathematics

[Nilesh Patra]

On 9/17/22 22:40, Andrea Pappacoda wrote:

Hi list, I've recently started maintaining the glm package (special thanks to 
Pierre and Anton for the help and feedback!), and while I'm now allowed to do 
DM uploads to it, I still don't have write access to the science-team/glm Salsa 
repo.

Could somebody please grant me the Maintainer role (or something similar) so 
that I can push to it? I've just finished preparing the -4 revision, fixing 
some reproducibility issues, but I'd prefer to push to the Vcs repo before 
uploading to the archive.



I have added you to the science team. Feel free to ping me if you still run 
into any issues with permissions.

Cheers!

--
Best,
Nilesh

Re: ITA: glm -- C++ library for OpenGL GLSL type-based mathematics

[Andrea Pappacoda]

Hi list, I've recently started maintaining the glm package (special 
thanks to Pierre and Anton for the help and feedback!), and while I'm 
now allowed to do DM uploads to it, I still don't have write access to 
the science-team/glm Salsa repo.


Could somebody please grant me the Maintainer role (or something 
similar) so that I can push to it? I've just finished preparing the -4 
revision, fixing some reproducibility issues, but I'd prefer to push to 
the Vcs repo before uploading to the archive.


--
OpenPGP key: 66DE F152 8299 0C21 99EF  A801 A8A1 28A8 AB1C EE49

Re: ITA: glm -- C++ library for OpenGL GLSL type-based mathematics

[Pierre Gruet]

Hi Andrea,

Le 04/09/2022 à 13:10, Andrea Pappacoda a écrit :
Il giorno sab 3 set 2022 alle 22:43:50 +02:00:00, Pierre Gruet 
 ha scritto:

Wonderful :) Please let us know when you are done.


Done!

I've reorganized the commits and made some more changes and fixes. The 
last thing I would've liked to do was to rename the branches so that 
they follow DEP14, but I cannot do it without write access to the repo 
(and it's not that important anyway).


Thanks for making the changes that quickly. I am fine with all of them, 
but it seems you forgot to include the changelog entry for version 
0.9.9.8+ds-3 in your merge request (whereas it was in the MR I reviewed 
yesterday). Could you please add it?
This problem was spotted by Lintian, which complained about a Standards 
version too recent regarding the date of the last changelog entry.


Also I am fine with letting the branches layout as is.



If you're ok with the changes I'd prefer to first push to Salsa and then 
upload to Mentors, to be sure that the repo doesn't get out of sync.


Hmm, I feel it is unnecessarily complicated given the situation; with 
just the changelog entry that is currently missing, the MR will be ready 
for being accepted and then we can do the upload without going through 
the mentors process. Your packaging is good and we can just go ahead 
with the changes you made.




Thank you all again for your feedback!



Thanks to you for working on glm!

Best regards,

--
Pierre


OpenPGP_signature
Description: OpenPGP digital signature

Re: ITA: glm -- C++ library for OpenGL GLSL type-based mathematics

[Andrea Pappacoda]

Il giorno sab 3 set 2022 alle 22:43:50 +02:00:00, Pierre Gruet 
 ha scritto:

Wonderful :) Please let us know when you are done.


Done!

I've reorganized the commits and made some more changes and fixes. The 
last thing I would've liked to do was to rename the branches so that 
they follow DEP14, but I cannot do it without write access to the repo 
(and it's not that important anyway).


If you're ok with the changes I'd prefer to first push to Salsa and 
then upload to Mentors, to be sure that the repo doesn't get out of 
sync.


Thank you all again for your feedback!

--
OpenPGP key: 66DE F152 8299 0C21 99EF  A801 A8A1 28A8 AB1C EE49

Re: ITA: glm -- C++ library for OpenGL GLSL type-based mathematics

[Andreas Tille]

Am Sat, Sep 03, 2022 at 09:47:27PM +0200 schrieb Anton Gladky:
> Hi Andrea,
> 
> thanks for taking care of this package! Really appreciate it.
> 
> Please, follow an advices given by Pierre and we will upload
> the package, giving you permissions to upload it in the future.
> 
> It could also be good if you add salsa-CI to be sure that the package

Short notes from vacations:  By using

   routine-update -f

you get salsa-CI for free inside the package.

> is building aod passing all tests. It is also an additional tests for you,
> 
> > I'm a DM, so I can't directly take ownership of the package nor push to
> > Salsa.

Please do not "take ownership" but add yourself to "Uploaders".  The
team should be the owner (=Maintainer).  Pushing to Salsa should be
easy once somebody adds you to the team.  Please also subscribe this
mailing list.

Kind regards

  Andreas.

> > Could somebody please look at my changes, give me write access
> > to the repo and possibly sponsor the first upload? You can find my
> > changes here:
> > 
> >
> > I've already asked this on IRC, and joostvb, while approving my changes
> > in general, said that it would've been better to ask this on the
> > mailing list.
> >
> > Thanks in advance :)
> >
> > --
> > OpenPGP key: 66DE F152 8299 0C21 99EF  A801 A8A1 28A8 AB1C EE49
> >
> >
> >

-- 
http://fam-tille.de

Re: ITA: glm -- C++ library for OpenGL GLSL type-based mathematics

[Pierre Gruet]

Hello again Andrea,

Le 03/09/2022 à 22:35, Andrea Pappacoda a écrit :

Thanks Pierre and Anton for your feedback!


You are very welcome! Thanks also for responding to the various points.


Il giorno sab 3 set 2022 alle 21:32:09 +02:00:00, Pierre Gruet 
[...]

- The long description of libglm-dev in debian/control is not
gender-neutral.


Gender-neutral language is not my area of expertise (in my native 
language even tables have a gender...), what should I change "when a 
programmer knows GLSL, he knows GLM as well" to? "they know GLM"?


Honestly it is also not something I am very familiar with. I can advise 
you to see Section 6.6.2.6 in the Debian Developers' Reference; yes, 
``they know GLM'' is what one shall use here.




Thanks again for your feedback! I submitted the pull request on the 
Salsa repo a while ago, and I didn't know much about packaging back 
then. I'm going to fix everything you reported (and possibly more) as 
soon as possible :)




Wonderful :) Please let us know when you are done.

Best regards,

--
Pierre


OpenPGP_signature
Description: OpenPGP digital signature

Re: ITA: glm -- C++ library for OpenGL GLSL type-based mathematics

[Andrea Pappacoda]

Thanks Pierre and Anton for your feedback!

Il giorno sab 3 set 2022 alle 21:32:09 +02:00:00, Pierre Gruet 
 ha scritto:
As I said above, the overall quality is very good. I have some 
comments

and remarks:
- You could raise the Standards version to the current one;
- The glmConfig.cmake and glmConfig-version.cmake should be patched, 
as
(given where you now install them) they are setting GLM_INCLUDE_DIRS 
to

be ``/usr/share'', while we want ``/usr/include'';


Didn't notice this, thanks for spotting the issue! I'd actually prefer 
to replace the current .cmake files with automatically generated ones, 
like done in the latest snapshot of the upstream repo, as they should 
be more complete/accurate.



- A follow-up notice in debian/tests/glm-tests: the tests refer to
``${glm_INCLUDE_DIRS}'' which is empty. ``${GLM_INCLUDE_DIRS}'' is 
more

appropriate.


I didn't even take a look at d/tests :/

I'll fix it too.


- You could solve the (only!) Lintian note, caught by
lintian -i -I ,
by calling iconv from debian/rules by overriding a relevant dh_ step;


Thanks, I'll look into this too.


- To stick to the Debian-science policy, you should set the Section of
the source package to ``science'' or ``math'';


Oh thanks, I didn't know there was a Debian-science policy - I'm 
reading it right now. I'll probably change the section to math, as GLM 
stands for OpenGL Mathematics


- There is no ``Files: debian/*'' stanza in debian/copyright, adding 
one

would be nice;


I'll add it soon.


- The long description of libglm-dev in debian/control is not
gender-neutral.


Gender-neutral language is not my area of expertise (in my native 
language even tables have a gender...), what should I change "when a 
programmer knows GLSL, he knows GLM as well" to? "they know GLM"?


Thanks again for your feedback! I submitted the pull request on the 
Salsa repo a while ago, and I didn't know much about packaging back 
then. I'm going to fix everything you reported (and possibly more) as 
soon as possible :)


--
OpenPGP key: 66DE F152 8299 0C21 99EF  A801 A8A1 28A8 AB1C EE49

Re: ITA: glm -- C++ library for OpenGL GLSL type-based mathematics

[Anton Gladky]

Hi Andrea,

thanks for taking care of this package! Really appreciate it.

Please, follow an advices given by Pierre and we will upload
the package, giving you permissions to upload it in the future.

It could also be good if you add salsa-CI to be sure that the package
is building aod passing all tests. It is also an additional tests for you,

Best regards

Anton


Am Fr., 2. Sept. 2022 um 22:13 Uhr schrieb Andrea Pappacoda <
and...@pappacoda.it>:

> Hi everyone!
>
> I've been wanting to adopt the glm package, maintained by the Science
> Team, since last September.
>
> I'm a DM, so I can't directly take ownership of the package nor push to
> Salsa. Could somebody please look at my changes, give me write access
> to the repo and possibly sponsor the first upload? You can find my
> changes here:
> 
>
> I've already asked this on IRC, and joostvb, while approving my changes
> in general, said that it would've been better to ask this on the
> mailing list.
>
> Thanks in advance :)
>
> --
> OpenPGP key: 66DE F152 8299 0C21 99EF  A801 A8A1 28A8 AB1C EE49
>
>
>

Re: ITA: glm -- C++ library for OpenGL GLSL type-based mathematics

[Pierre Gruet]

Hi Andrea, hi team,

First: I have reviewed the changes and I am globally satisfied with the 
packaging (some comments below), I would happily sponsor the upload with 
a few changes.


Could someone please give access to the repo to Andrea, and/or also 
allow me (pgt) to process such requests by raising my level to Owner?

Thanks a lot in any case.

Le 02/09/2022 à 22:06, Andrea Pappacoda a écrit :

Hi everyone!

I've been wanting to adopt the glm package, maintained by the Science 
Team, since last September.




It is great someone cares about this package, thanks!

I'm a DM, so I can't directly take ownership of the package nor push to 
Salsa. Could somebody please look at my changes, give me write access to 
the repo and possibly sponsor the first upload? You can find my changes 
here: 


I've already asked this on IRC, and joostvb, while approving my changes 
in general, said that it would've been better to ask this on the mailing 
list.


As I said above, the overall quality is very good. I have some comments 
and remarks:

- You could raise the Standards version to the current one;
- The glmConfig.cmake and glmConfig-version.cmake should be patched, as 
(given where you now install them) they are setting GLM_INCLUDE_DIRS to 
be ``/usr/share'', while we want ``/usr/include'';
- A follow-up notice in debian/tests/glm-tests: the tests refer to 
``${glm_INCLUDE_DIRS}'' which is empty. ``${GLM_INCLUDE_DIRS}'' is more 
appropriate.

- You could solve the (only!) Lintian note, caught by
lintian -i -I ,
by calling iconv from debian/rules by overriding a relevant dh_ step;
- To stick to the Debian-science policy, you should set the Section of 
the source package to ``science'' or ``math'';
- There is no ``Files: debian/*'' stanza in debian/copyright, adding one 
would be nice;
- The long description of libglm-dev in debian/control is not 
gender-neutral.





Thanks in advance :)



Thanks again for working on this package!

Best,

--
Pierre


OpenPGP_signature
Description: OpenPGP digital signature

ITA: glm -- C++ library for OpenGL GLSL type-based mathematics

[Andrea Pappacoda]

Hi everyone!

I've been wanting to adopt the glm package, maintained by the Science 
Team, since last September.


I'm a DM, so I can't directly take ownership of the package nor push to 
Salsa. Could somebody please look at my changes, give me write access 
to the repo and possibly sponsor the first upload? You can find my 
changes here: 



I've already asked this on IRC, and joostvb, while approving my changes 
in general, said that it would've been better to ask this on the 
mailing list.


Thanks in advance :)

--
OpenPGP key: 66DE F152 8299 0C21 99EF  A801 A8A1 28A8 AB1C EE49