[Bug 1244338] Re: External tool won't run if Save is set to All documents
** Changed in: gedit Status: New = Fix Released -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gedit in Ubuntu. https://bugs.launchpad.net/bugs/1244338 Title: External tool won't run if Save is set to All documents To manage notifications about this bug go to: https://bugs.launchpad.net/gedit/+bug/1244338/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1244338] Re: External tool won't run if Save is set to All documents
** Changed in: gedit Status: Unknown = New ** Changed in: gedit Importance: Unknown = Medium -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gedit in Ubuntu. https://bugs.launchpad.net/bugs/1244338 Title: External tool won't run if Save is set to All documents To manage notifications about this bug go to: https://bugs.launchpad.net/gedit/+bug/1244338/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1244338] Re: External tool won't run if Save is set to All documents
I can reproduce this very easily: -Open two documents in gedit -Change both of them -run a script (external tool) that is marked to save just the current document Both documents will be saved. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gedit in Ubuntu. https://bugs.launchpad.net/bugs/1244338 Title: External tool won't run if Save is set to All documents To manage notifications about this bug go to: https://bugs.launchpad.net/gedit/+bug/1244338/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1244338] Re: External tool won't run if Save is set to All documents
The issue has been fixed in https://git.gnome.org/browse/gedit/commit/?id=6c99bb727a8697e37cd55e0ccf40e4069e65f1ce ** Changed in: gedit (Ubuntu) Status: Confirmed = Fix Committed ** Also affects: gedit via https://bugzilla.gnome.org/show_bug.cgi?id=659437 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gedit in Ubuntu. https://bugs.launchpad.net/bugs/1244338 Title: External tool won't run if Save is set to All documents To manage notifications about this bug go to: https://bugs.launchpad.net/gedit/+bug/1244338/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1244338] Re: External tool won't run if Save is set to All documents
This bug was fixed in the package gedit - 3.10.4-0ubuntu2 --- gedit (3.10.4-0ubuntu2) trusty; urgency=medium * debian/patches/git_store_dialog.patch: tweaks to the save files dialog, give enough space to list several documents (lp: #988946) * debian/patches/git_save_run_tool_order.patch: - save the *modified* documents before running a tool (lp: #1244338) -- Sebastien Bacher seb...@ubuntu.com Mon, 10 Feb 2014 16:49:22 +0100 ** Changed in: gedit (Ubuntu) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gedit in Ubuntu. https://bugs.launchpad.net/bugs/1244338 Title: External tool won't run if Save is set to All documents To manage notifications about this bug go to: https://bugs.launchpad.net/gedit/+bug/1244338/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1244338] Re: External tool won't run if Save is set to All documents
I confirm that this fixes the problem, thanks! -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gedit in Ubuntu. https://bugs.launchpad.net/bugs/1244338 Title: External tool won't run if Save is set to All documents To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gedit/+bug/1244338/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1244338] Re: External tool won't run if Save is set to All documents
Please let's get this committed upstream. Could you head over to https://bugzilla.gnome.org/show_bug.cgi?id=659437 (You'll have to create an account if you don't have one but this is a very quick process) Just add a comment that says: -You confirm the bug exisits -This patch fixed it for you. Thanks! -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gedit in Ubuntu. https://bugs.launchpad.net/bugs/1244338 Title: External tool won't run if Save is set to All documents To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gedit/+bug/1244338/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1244338] Re: External tool won't run if Save is set to All documents
Thanks Kris. The fix has been commited. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gedit in Ubuntu. https://bugs.launchpad.net/bugs/1244338 Title: External tool won't run if Save is set to All documents To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gedit/+bug/1244338/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1244338] Re: External tool won't run if Save is set to All documents
It looks like the bug was caused by this patch: https://bugzilla.gnome.org/show_bug.cgi?id=659437 I have created an account and posted comment #10 Here is my explanation of why the patch is broken: This code is working in the opposite way it is intended to. I.e. only the unchanged documents are being saved, and the changed documents are left unsaved. On inspecting the code, it is obvious why: if doc.get_modified(): all_docs = False docs.remove(doc) Modified documents are being removed from the list to be saved. Instead it should be: if not doc.get_modified(): ** Bug watch added: GNOME Bug Tracker #659437 https://bugzilla.gnome.org/show_bug.cgi?id=659437 -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gedit in Ubuntu. https://bugs.launchpad.net/bugs/1244338 Title: External tool won't run if Save is set to All documents To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gedit/+bug/1244338/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1244338] Re: External tool won't run if Save is set to All documents
I have filed a patch on bugzilla. If you can't wait for the upstream fix to filter down, here is a script to apply it locally: http://drup.org/gedit-external-tools-fails-save-documents -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gedit in Ubuntu. https://bugs.launchpad.net/bugs/1244338 Title: External tool won't run if Save is set to All documents To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gedit/+bug/1244338/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1244338] Re: External tool won't run if Save is set to All documents
Going through the code I figured out the problem that is that is causing save to fail when set to All documents--a classic Python bug. If an item is deleted from a list while that list is being looped through, then it's like sawing off the branch of a tree you are sitting on. Here is the code: for i in range(len(docs)): doc = docs[i] ... docs.remove(doc) The code will break with 'list index out of range' if a list member is deleted. There is a simple fix--just reverse the direction of the loop: for i in reversed(range(len(docs))): I have submitted a patch that fixes both errors. Please head over to https://bugzilla.gnome.org/show_bug.cgi?id=659437 and mark the bug confirmed if you are getting the error described in this bug report. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gedit in Ubuntu. https://bugs.launchpad.net/bugs/1244338 Title: External tool won't run if Save is set to All documents To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gedit/+bug/1244338/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1244338] Re: External tool won't run if Save is set to All documents
I'm getting exactly the problem that Kris reports above. It seems that there is an inversion in the logic: If the document has *not* changed, then it saves it. If it has changed then it does not get saved. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gedit in Ubuntu. https://bugs.launchpad.net/bugs/1244338 Title: External tool won't run if Save is set to All documents To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gedit/+bug/1244338/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1244338] Re: External tool won't run if Save is set to All documents
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: gedit (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gedit in Ubuntu. https://bugs.launchpad.net/bugs/1244338 Title: External tool won't run if Save is set to All documents To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gedit/+bug/1244338/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1244338] Re: External tool won't run if Save is set to All documents
I experience the same behavior as described above. I've also noticed that when the external tool is set to save Current document, it doesn't actually save the current document upon being run. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gedit in Ubuntu. https://bugs.launchpad.net/bugs/1244338 Title: External tool won't run if Save is set to All documents To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gedit/+bug/1244338/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1244338] Re: External tool won't run if Save is set to All documents
Thank you for taking the time to report this bug and helping to make Ubuntu better. The issue you are reporting is an upstream one and it would be nice if somebody having it could send the bug to the developers of the software by following the instructions at https://wiki.ubuntu.com/Bugs/Upstream/GNOME. If you have done so, please tell us the number of the upstream bug (or the link), so we can add a bugwatch that will inform us about its status. Thanks in advance. ** Changed in: gedit (Ubuntu) Importance: Undecided = Low -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gedit in Ubuntu. https://bugs.launchpad.net/bugs/1244338 Title: External tool won't run if Save is set to All documents To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gedit/+bug/1244338/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
