[Bug 1716633] Re: /usr/bin/gnome-software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular
I thought that each plugin was only accessed by the same thread, but it turns out this is not the case. This crash seems to be due to these multiple threads accessing the snap cache. This is now protected with a lock. ** Description changed: - Potentially a regression introduced by gnome-software - 3.20.5-0ubuntu0.16.04.6 + [Impact] + GNOME Software has a cache that can be accessed by multiple threads. This can cause GNOME Software to crash. This seems to have been caused by adding support for featured snaps (bug 1663097) as the popular, featured and installed snaps are all requested on different threads. - The Ubuntu Error Tracker has been receiving reports about a problem regarding gnome-software. This problem was most recently seen with package version 3.22.7-0ubuntu3.17.04.7, the problem page at https://errors.ubuntu.com/problem/b8d914cec850474446873c5a60feba99b1d498d9 contains more details, including versions of packages affected, stacktrace or traceback, and individual crash reports. - If you do not have access to the Ubuntu Error Tracker and are a software developer, you can request it at http://forms.canonical.com/reports/. + [Test Case] + Since this is a random crash there's not a good test case. Could be checked by looking at errors.ubuntu.com crash reports or repeated restarts of GNOME Software to see if it crashes on startup. + + [Regression Potential] + Solution is to add a lock around this cache. Some risk of breaking related code. ** Summary changed: - /usr/bin/gnome-software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular + Installed, popular and featured snaps are loaded in parallel threads can crash -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-software in Ubuntu. https://bugs.launchpad.net/bugs/1716633 Title: Installed, popular and featured snaps are loaded in parallel threads can crash To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1716633/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1716633] Re: /usr/bin/gnome-software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular
This bug was fixed in the package gnome-software - 3.26.1-0ubuntu4 --- gnome-software (3.26.1-0ubuntu4) bionic; urgency=medium * debian/patches/0001-snap-Protect-store-cache-with-a-lock.patch: - Fix crash due to multiple threads accessing a cache (LP: #1716633) * debian/patches/0001-snap-Don-t-attempt-to-refine-snaps-without-a-valid-n.patch: - Fix potential crash from invalid snaps * debian/patches/0001-snap-Remove-unused-variables.patch: - Trivial patch added to make above patches apply cleanly -- Robert Ancell Fri, 27 Oct 2017 11:34:43 +1300 ** Changed in: gnome-software (Ubuntu Bionic) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-software in Ubuntu. https://bugs.launchpad.net/bugs/1716633 Title: /usr/bin/gnome- software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1716633/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1716633] Re: /usr/bin/gnome-software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular
** Branch linked: lp:~ubuntu-desktop/gnome-software/ubuntu-zesty -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-software in Ubuntu. https://bugs.launchpad.net/bugs/1716633 Title: /usr/bin/gnome- software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1716633/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1716633] Re: /usr/bin/gnome-software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular
** Branch linked: lp:~ubuntu-desktop/gnome-software/ubuntu -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-software in Ubuntu. https://bugs.launchpad.net/bugs/1716633 Title: /usr/bin/gnome- software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1716633/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1716633] Re: /usr/bin/gnome-software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular
** Branch linked: lp:~ubuntu-desktop/gnome-software/ubuntu-xenial -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-software in Ubuntu. https://bugs.launchpad.net/bugs/1716633 Title: /usr/bin/gnome- software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1716633/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1716633] Re: /usr/bin/gnome-software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular
** Branch linked: lp:~ubuntu-desktop/gnome-software/ubuntu-artful -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-software in Ubuntu. https://bugs.launchpad.net/bugs/1716633 Title: /usr/bin/gnome- software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1716633/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1716633] Re: /usr/bin/gnome-software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular
** Also affects: gnome-software (Ubuntu Zesty) Importance: Undecided Status: New ** Also affects: gnome-software (Ubuntu Bionic) Importance: High Assignee: Robert Ancell (robert-ancell) Status: Confirmed ** Also affects: gnome-software (Ubuntu Xenial) Importance: Undecided Status: New ** Also affects: gnome-software (Ubuntu Artful) Importance: Undecided Status: New ** Changed in: gnome-software (Ubuntu Artful) Importance: Undecided => High ** Changed in: gnome-software (Ubuntu Zesty) Importance: Undecided => High ** Changed in: gnome-software (Ubuntu Xenial) Importance: Undecided => High ** Changed in: gnome-software (Ubuntu Artful) Status: New => Triaged ** Changed in: gnome-software (Ubuntu Zesty) Status: New => Triaged ** Changed in: gnome-software (Ubuntu Xenial) Status: New => Triaged ** Changed in: gnome-software (Ubuntu Bionic) Status: Confirmed => Triaged ** Changed in: gnome-software (Ubuntu Artful) Assignee: (unassigned) => Robert Ancell (robert-ancell) ** Changed in: gnome-software (Ubuntu Zesty) Assignee: (unassigned) => Robert Ancell (robert-ancell) ** Changed in: gnome-software (Ubuntu Xenial) Assignee: (unassigned) => Robert Ancell (robert-ancell) -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-software in Ubuntu. https://bugs.launchpad.net/bugs/1716633 Title: /usr/bin/gnome- software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1716633/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1716633] Re: /usr/bin/gnome-software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular
** Tags added: gnome-software-snap -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-software in Ubuntu. https://bugs.launchpad.net/bugs/1716633 Title: /usr/bin/gnome- software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1716633/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1716633] Re: /usr/bin/gnome-software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular
Some reports are similar but with gs_plugin_add_featured in the backtrace instead of gs_plugin_add_popular -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-software in Ubuntu. https://bugs.launchpad.net/bugs/1716633 Title: /usr/bin/gnome- software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1716633/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1716633] Re: /usr/bin/gnome-software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular
The crash is in new code that was added to the Xenial SRU, not a regression in existing code. The stacktrace doesn't point to an obvious issue that is causing this. It's possible that the hash table has been corrupted by other code gone wrong. I don't think this is worth blocking the SRU on. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-software in Ubuntu. https://bugs.launchpad.net/bugs/1716633 Title: /usr/bin/gnome- software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1716633/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1716633] Re: /usr/bin/gnome-software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular
** Description changed: + Potentially a regression introduced by gnome-software + 3.20.5-0ubuntu0.16.04.6 + The Ubuntu Error Tracker has been receiving reports about a problem regarding gnome-software. This problem was most recently seen with package version 3.22.7-0ubuntu3.17.04.7, the problem page at https://errors.ubuntu.com/problem/b8d914cec850474446873c5a60feba99b1d498d9 contains more details, including versions of packages affected, stacktrace or traceback, and individual crash reports. If you do not have access to the Ubuntu Error Tracker and are a software developer, you can request it at http://forms.canonical.com/reports/. ** Changed in: gnome-software (Ubuntu) Status: New => Confirmed ** Changed in: gnome-software (Ubuntu) Importance: Undecided => High ** Changed in: gnome-software (Ubuntu) Assignee: (unassigned) => Robert Ancell (robert-ancell) -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-software in Ubuntu. https://bugs.launchpad.net/bugs/1716633 Title: /usr/bin/gnome- software:11:g_str_equal:g_hash_table_lookup_node:g_hash_table_insert_internal:find_snaps:gs_plugin_add_popular To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1716633/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
