[Bug 1720331] Re: Whoopsie continually relaunching

[Launchpad Bug Tracker]

This bug was fixed in the package gnome-control-center -
1:3.26.1-0ubuntu6

---
gnome-control-center (1:3.26.1-0ubuntu6) bionic; urgency=medium

  [ James Henstridge ]
  * Modify privacy-panel-whoopsie.patch:
- use an asynchronous D-Bus call when toggling crash reporting, and
  avoid calling SetReportCrashes when setting to the current value.
  (LP: #1720331)

  [ Jeremy Bicha ]
  * Modify ubuntu-gnome-version.patch:
- Use Ubuntu's PRETTY_NAME instead of NAME from /etc/os-release.
  This is needed for the version number in About to end up as
  something like "Ubuntu 18.04.1 LTS" instead of just "Ubuntu 18.04".

 -- James Henstridge   Fri, 27 Oct 2017
11:05:31 -0400

** Changed in: gnome-control-center (Ubuntu)
   Status: Triaged => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu.
https://bugs.launchpad.net/bugs/1720331

Title:
  Whoopsie continually relaunching

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1720331/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1720331] Re: Whoopsie continually relaunching

[Jean-Baptiste Lallement]

** Tags removed: rls-aa-incoming
** Tags added: rls-bb-incoming

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu.
https://bugs.launchpad.net/bugs/1720331

Title:
  Whoopsie continually relaunching

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1720331/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1720331] Re: Whoopsie continually relaunching

[James Henstridge]

Changing the gnome-control-center task to low priority, since the
restart loop is gone with the new whoopsie-preferences that has landed
in the archive.

The gnome-control-center change is nice, but I don't think it is
critical to releasing 17.10 any more.

** Changed in: gnome-control-center (Ubuntu)
   Importance: Medium => Low

** Changed in: whoopsie-preferences (Ubuntu)
 Assignee: (unassigned) => James Henstridge (jamesh)

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu.
https://bugs.launchpad.net/bugs/1720331

Title:
  Whoopsie continually relaunching

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1720331/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1720331] Re: Whoopsie continually relaunching

[Launchpad Bug Tracker]

This bug was fixed in the package whoopsie-preferences - 0.19

---
whoopsie-preferences (0.19) artful; urgency=medium

  * Don't export object on the bus until it has been fully constructed.
(LP: #1720331)

 -- James Henstridge   Wed, 11 Oct 2017
18:20:35 +0800

** Changed in: whoopsie-preferences (Ubuntu)
   Status: Triaged => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu.
https://bugs.launchpad.net/bugs/1720331

Title:
  Whoopsie continually relaunching

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1720331/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1720331] Re: Whoopsie continually relaunching

[Brian Murray]

** Changed in: whoopsie-preferences (Ubuntu)
   Status: New => Triaged

** Changed in: whoopsie-preferences (Ubuntu)
   Importance: Undecided => High

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu.
https://bugs.launchpad.net/bugs/1720331

Title:
  Whoopsie continually relaunching

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1720331/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1720331] Re: Whoopsie continually relaunching

[Launchpad Bug Tracker]

** Branch linked: lp:~jamesh/whoopsie-preferences/bug-1720331

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu.
https://bugs.launchpad.net/bugs/1720331

Title:
  Whoopsie continually relaunching

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1720331/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1720331] Re: Whoopsie continually relaunching

[James Henstridge]

** Also affects: whoopsie-preferences (Ubuntu)
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu.
https://bugs.launchpad.net/bugs/1720331

Title:
  Whoopsie continually relaunching

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1720331/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1720331] Re: Whoopsie continually relaunching

[Launchpad Bug Tracker]

** Branch linked: lp:~jamesh/gnome-control-center/ubuntu-bug-1720331

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu.
https://bugs.launchpad.net/bugs/1720331

Title:
  Whoopsie continually relaunching

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1720331/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1720331] Re: Whoopsie continually relaunching

[James Henstridge]

So I think I've got things sorted out by (a) switching to call
SetReportCrashes async to avoid blocking the UI, and (b) not calling
SetReportCrashes if we're asked to set it to the current (cached) value
of the property.

I've noticed that if whoopsie-preferences exits while the privacy panel
is open, I get a bit of a bounce when toggling the switch next.  This
seems to be due to whoopsie-preferences sending out a stray change
notification signal on start up:

method call time=1507538340.672978 sender=:1.1499 -> 
destination=com.ubuntu.WhoopsiePreferences serial=30 
path=/com/ubuntu/WhoopsiePreferences; interface=com.ubuntu.WhoopsiePreferences; 
member=SetReportCrashes
   boolean false
signal time=1507538340.756225 sender=:1.1507 -> destination=(null 
destination) serial=9 path=/com/ubuntu/WhoopsiePreferences; 
interface=org.freedesktop.DBus.Properties; member=PropertiesChanged
   string "com.ubuntu.WhoopsiePreferences"
   array [
  dict entry(
 string "ReportMetrics"
 variant boolean true
  )
  dict entry(
 string "ReportCrashes"
 variant boolean true
  )
   ]
   array [
   ]
method call time=1507538340.756590 sender=:1.1499 -> destination=:1.1507 
serial=31 path=/com/ubuntu/WhoopsiePreferences; 
interface=org.freedesktop.DBus.Properties; member=GetAll
   string "com.ubuntu.WhoopsiePreferences"
method call time=1507538340.757395 sender=:1.1499 -> 
destination=com.ubuntu.WhoopsiePreferences serial=32 
path=/com/ubuntu/WhoopsiePreferences; interface=com.ubuntu.WhoopsiePreferences; 
member=SetReportCrashes
   boolean true
signal time=1507538341.034321 sender=:1.1507 -> destination=(null 
destination) serial=14 path=/com/ubuntu/WhoopsiePreferences; 
interface=org.freedesktop.DBus.Properties; member=PropertiesChanged
   string "com.ubuntu.WhoopsiePreferences"
   array [
  dict entry(
 string "ReportCrashes"
 variant boolean false
  )
   ]
   array [
   ]
method call time=1507538341.035076 sender=:1.1499 -> destination=:1.1507 
serial=33 path=/com/ubuntu/WhoopsiePreferences; 
interface=com.ubuntu.WhoopsiePreferences; member=SetReportCrashes
   boolean false

So essentially whoopsie-preferences is sending out an unsolicited
PropertiesChanged signal on startup with the initial values before
processing the SetReportCrashes method call.  Then gnome-control-center
responds by trying to match the switch state leading to the bounce.

So I guess I'll have to dive into the whoopsie-preferences code to see
if I can silence the stray signal.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu.
https://bugs.launchpad.net/bugs/1720331

Title:
  Whoopsie continually relaunching

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1720331/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1720331] Re: Whoopsie continually relaunching

[Brian Murray]

** Changed in: whoopsie (Ubuntu)
   Status: Triaged => Invalid

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu.
https://bugs.launchpad.net/bugs/1720331

Title:
  Whoopsie continually relaunching

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1720331/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1720331] Re: Whoopsie continually relaunching

[James Henstridge]

This is definitely a gnome-control-center bug rather than whoopsie.  I
can reproduce it like so:

 1. open gnome-control-center, and select the privacy panel.
 2. ensure that problem reporting is turned on.
 3. wait for whoopsie-preferences to exit on timeout (or manually kill it).

I then see traffic like the following on the system bus:

method call time=1507286449.661622 sender=:1.325 -> destination=:1.336 
serial=96 path=/com/ubuntu/WhoopsiePreferences; 
interface=com.ubuntu.WhoopsiePreferences; member=SetReportCrashes
   boolean false
method call time=1507286449.918969 sender=:1.325 -> destination=:1.336 
serial=97 path=/com/ubuntu/WhoopsiePreferences; 
interface=com.ubuntu.WhoopsiePreferences; member=SetReportCrashes
   boolean true
method call time=1507286450.216068 sender=:1.325 -> destination=:1.336 
serial=98 path=/com/ubuntu/WhoopsiePreferences; 
interface=com.ubuntu.WhoopsiePreferences; member=SetReportCrashes
   boolean false
method call time=1507286450.529908 sender=:1.325 -> destination=:1.336 
serial=99 path=/com/ubuntu/WhoopsiePreferences; 
interface=com.ubuntu.WhoopsiePreferences; member=SetReportCrashes
   boolean true
...

which continues until I kill gnome-control-center.  Whoopsie relaunching
is a direct consequence of these D-Bus method calls coming from gnome-
control-center.

It looks like the logic controlling the GtkSwitch gets into a loop when
whoopsie-preferences stops.  The D-Bus method calls are synchronous, so
this also ends up locking the UI.  I'll have a look into this properly
next week.

** Changed in: gnome-control-center (Ubuntu)
   Importance: Undecided => Medium

** Changed in: gnome-control-center (Ubuntu)
   Status: New => Triaged

** Changed in: gnome-control-center (Ubuntu)
 Assignee: (unassigned) => James Henstridge (jamesh)

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu.
https://bugs.launchpad.net/bugs/1720331

Title:
  Whoopsie continually relaunching

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1720331/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1720331] Re: Whoopsie continually relaunching

[James Henstridge]

** Also affects: gnome-control-center (Ubuntu)
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu.
https://bugs.launchpad.net/bugs/1720331

Title:
  Whoopsie continually relaunching

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1720331/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs