[Bug 280646] Re: ACPI brightness events no longer work on ThinkPad T61

2008-10-11 Thread Matt Zimmerman
I've confirmed the fix on my T61 with gnome-power-manager
2.24.0-0ubuntu4 in Intrepid.

-- 
ACPI brightness events no longer work on ThinkPad T61
https://bugs.launchpad.net/bugs/280646
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-power-manager in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 280646] Re: ACPI brightness events no longer work on ThinkPad T61

2008-10-11 Thread Matt Zimmerman
I have filed bug 281669 about the sticky num lock key (Bryce's issue #2
in
https://bugs.edge.launchpad.net/ubuntu/+source/linux/+bug/280646/comments/41)

-- 
ACPI brightness events no longer work on ThinkPad T61
https://bugs.launchpad.net/bugs/280646
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-power-manager in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 280646] Re: ACPI brightness events no longer work on ThinkPad T61

2008-10-11 Thread Matt Zimmerman
Closing out the linux task; this is not a kernel bug.

** Changed in: linux (Ubuntu)
   Status: Triaged = Invalid

-- 
ACPI brightness events no longer work on ThinkPad T61
https://bugs.launchpad.net/bugs/280646
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-power-manager in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


Re: [Bug 280646] Re: ACPI brightness events no longer work on ThinkPad T61

2008-10-11 Thread Ted Gould
On Fri, 2008-10-10 at 16:17 +, Marc Jauvin wrote:
 Hi Matt, since I did this upgrade, keyboard and mouse don't work after  
 I rebooted... not sure if this is caused by your updated package (or  
 one of their dependency like xinput).

This is likely to be the same as this bug:

   https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/276857

Basically the work around is to restart X on reboot after HAL starts.  I
have to do it on every login.

--Ted

-- 
ACPI brightness events no longer work on ThinkPad T61
https://bugs.launchpad.net/bugs/280646
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-power-manager in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


Re: [Bug 280646] Re: ACPI brightness events no longer work on ThinkPad T61

2008-10-11 Thread Marc Jauvin
Ted Gould [EMAIL PROTECTED] wrote:

 On Fri, 2008-10-10 at 16:17 +, Marc Jauvin wrote:
 Hi Matt, since I did this upgrade, keyboard and mouse don't work after
 I rebooted... not sure if this is caused by your updated package (or
 one of their dependency like xinput).

 This is likely to be the same as this bug:

https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/276857

 Basically the work around is to restart X on reboot after HAL starts.  I
 have to do it on every login.

It turns out there were two packages that had been removed on the last  
upgrade... not sure why:

xserver-xorg-input-evdev
xserver-xorg-input-synaptics

Once they were reinstalled, everything started working again, and the  
brightness problem was solved by Matt's update to gnome-power-manager.

Thanks.

-- 
Marc Jauvin

-- 
ACPI brightness events no longer work on ThinkPad T61
https://bugs.launchpad.net/bugs/280646
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-power-manager in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 280646] Re: ACPI brightness events no longer work on ThinkPad T61

2008-10-10 Thread DSHR
Brightness up/down works for me on Lenovo X60s with intrepid beta - OSD stops 
working after NumLock.
Brightness changes are very slow (1 second).

Most Hotkeys work - still no OSD for the volume control keys ...

-- 
ACPI brightness events no longer work on ThinkPad T61
https://bugs.launchpad.net/bugs/280646
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-power-manager in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 280646] Re: ACPI brightness events no longer work on ThinkPad T61

2008-10-10 Thread Matt Zimmerman

** Attachment added: debdiff using AnyModifier
   http://launchpadlibrarian.net/18390848/gnome-power-manager-280646.debdiff

** Changed in: gnome-power-manager (Ubuntu)
   Importance: Undecided = Medium
 Assignee: (unassigned) = Matt Zimmerman (mdz)
   Status: New = Triaged

-- 
ACPI brightness events no longer work on ThinkPad T61
https://bugs.launchpad.net/bugs/280646
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-power-manager in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


Re: [Bug 280646] Re: ACPI brightness events no longer work on ThinkPad T61

2008-10-10 Thread Matt Zimmerman
On Fri, Oct 10, 2008 at 01:50:49AM -, Bryce Harrington wrote:
 1.  The problem with g-p-m not handling the brightness key when numlock
 is set is in fact an issue local to gnome-power-manager.  It's simply
 neglects to grab the modifiers for the keys.
 
 The first line of the attached patch makes the issue go away (the rest
 of the patch is just instrumentation).  No changes to X are required; it
 seems to be working properly.

Thanks for the analysis, Bryce.  I'm attaching a debdiff which implements
that change.  I don't see any cases in the code where it would be
appropriate to treat these keysyms differently with a modifier, since
they're all special-purpose hotkeys:

gpm_button_xevent_key (button, XF86XK_PowerOff, 
GPM_BUTTON_POWER);
gpm_button_xevent_key (button, XF86XK_Sleep, 
GPM_BUTTON_SUSPEND); /* should be configurable */
gpm_button_xevent_key (button, XF86XK_MonBrightnessUp, 
GPM_BUTTON_BRIGHT_UP);
gpm_button_xevent_key (button, XF86XK_MonBrightnessDown, 
GPM_BUTTON_BRIGHT_DOWN);
gpm_button_xevent_key (button, XF86XK_ScreenSaver, 
GPM_BUTTON_LOCK);
gpm_button_xevent_key (button, XF86XK_KbdBrightnessUp, 
GPM_BUTTON_KBD_BRIGHT_UP);
gpm_button_xevent_key (button, XF86XK_KbdBrightnessDown, 
GPM_BUTTON_KBD_BRIGHT_DOWN);
gpm_button_xevent_key (button, XF86XK_KbdLightOnOff, 
GPM_BUTTON_KBD_BRIGHT_TOGGLE);

 2.  On the Thinkpad T61 specific issue, I discussed it with Peter
 Hutterer.  It seems to be that on this hardware, the numlock key doesn't
 actually send events when the fn is pressed so we have no way of knowing
 that it is pressed.  This was verified via gdb on the xserver.  Scroll
 lock and numlock are shared, so fn has to be pressed to trigger numlock.
 
 So it seems to be either a hardware or kernel bug.

I will open that one as a separate bug.

-- 
 - mdz

-- 
ACPI brightness events no longer work on ThinkPad T61
https://bugs.launchpad.net/bugs/280646
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-power-manager in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 280646] Re: ACPI brightness events no longer work on ThinkPad T61

2008-10-10 Thread Matt Zimmerman
There is a package in my PPA with this patch:

https://edge.launchpad.net/~mdz/+archive

deb http://ppa.launchpad.net/mdz/ubuntu intrepid main
deb-src http://ppa.launchpad.net/mdz/ubuntu intrepid main

I haven't been able to test it on the T61 yet, but would appreciate
regression testing nonetheless.

-- 
ACPI brightness events no longer work on ThinkPad T61
https://bugs.launchpad.net/bugs/280646
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-power-manager in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 280646] Re: ACPI brightness events no longer work on ThinkPad T61

2008-10-10 Thread Matt Zimmerman
** Changed in: gnome-power-manager (Ubuntu)
   Target: None = ubuntu-8.10

-- 
ACPI brightness events no longer work on ThinkPad T61
https://bugs.launchpad.net/bugs/280646
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-power-manager in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 280646] Re: ACPI brightness events no longer work on ThinkPad T61

2008-10-10 Thread Launchpad Bug Tracker
This bug was fixed in the package gnome-power-manager - 2.24.0-0ubuntu4

---
gnome-power-manager (2.24.0-0ubuntu4) intrepid; urgency=low

  * src/gpm-button.c:gpm_button_grab_keystring: use AnyModifier modmask with
XGrabKey so that hotkeys being handled through gpm-button still work if
e.g. numlock happens to be on (thanks, Bryce Harrington, LP: #280646)

 -- Matt Zimmerman [EMAIL PROTECTED]   Fri, 10 Oct 2008 09:55:10 +0100

** Changed in: gnome-power-manager (Ubuntu)
   Status: Triaged = Fix Released

-- 
ACPI brightness events no longer work on ThinkPad T61
https://bugs.launchpad.net/bugs/280646
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-power-manager in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


Re: [Bug 280646] Re: ACPI brightness events no longer work on ThinkPad T61

2008-10-10 Thread Marc Jauvin
Hi Matt, since I did this upgrade, keyboard and mouse don't work after  
I rebooted... not sure if this is caused by your updated package (or  
one of their dependency like xinput).

I'm currently writing this from Hardy since my Intrepid install is  
unusable... ;)

Matt Zimmerman [EMAIL PROTECTED] wrote:

 There is a package in my PPA with this patch:

 https://edge.launchpad.net/~mdz/+archive

 deb http://ppa.launchpad.net/mdz/ubuntu intrepid main
 deb-src http://ppa.launchpad.net/mdz/ubuntu intrepid main

 I haven't been able to test it on the T61 yet, but would appreciate
 regression testing nonetheless.

 --
 ACPI brightness events no longer work on ThinkPad T61
 https://bugs.launchpad.net/bugs/280646
 You received this bug notification because you are a direct subscriber
 of the bug.

 Status in “gnome-power-manager” source package in Ubuntu: Triaged
 Status in “linux” source package in Ubuntu: Triaged

 Bug description:
 Binary package hint: gnome-power-manager

 Problem:
 The state of the numlock key affects how the brightness switching  
 keys work.  The OCD display does not display.  On some systems (e.g.  
 Thinkpad 61's), it also prevents brightness from changing.  This  
 seems to be a new behavior in Intrepid, and not reproducible on Hardy

 A further issue on Thinkpad T61's is that the numlock key does not  
 signal toggle off properly.  This can be seen in xkbwatch, which  
 shows that some modifiers are not getting turned off when numlock is  
 toggled off.

 Original Report:
 [regression from 8.04]

 I'm not sure about the root cause of this yet, but starting here.

 Pressing the brightness up/down keys on my ThinkPad T61 no longer  
 changes the brightness of the LCD backlight.  This worked fine in  
 8.04, and at some point in Intrepid as well.

 When I press the brightness-up key, I see two ACPI events:
 video LCD0 0086 
 ibm/hotkey HKEY 0080 501

 brightness-down is similar:
 video LCD0 0087 
 ibm/hotkey HKEY 0080 501

 In xev, I see KeyPress and KeyRelease events forXF86MonBrightnessUp  
 and XF86MonBrightnessDown, respectively.

 However, the backlight is not actually changed, and  
 gnome-power-manager does not display the brightness level OSD (both  
 of which worked in 8.04)

 WORKAROUND: gconftool-2 --set --type bool  
 /desktop/gnome/peripherals/keyboard/host-perseus/0/numlock_on false

 ProblemType: Bug
 Architecture: amd64
 DistroRelease: Ubuntu 8.10
 Package: linux-image-2.6.27-5-generic 2.6.27-5.8 [modified:  
 lib/modules/2.6.27-5-generic/modules.pcimap  
 lib/modules/2.6.27-5-generic/modules.dep  
 lib/modules/2.6.27-5-generic/modules.ieee1394map  
 lib/modules/2.6.27-5-generic/modules.usbmap  
 lib/modules/2.6.27-5-generic/modules.isapnpmap  
 lib/modules/2.6.27-5-generic/modules.inputmap  
 lib/modules/2.6.27-5-generic/modules.seriomap  
 lib/modules/2.6.27-5-generic/modules.alias  
 lib/modules/2.6.27-5-generic/modules.symbols]
 ProcCmdLine: root=UUID=305dde78-d20a-4248-aaf4-09447b7c5791 ro quiet splash
 ProcEnviron:
  LC_COLLATE=C
   
 PATH=/home/username/bin:/usr/lib/ccache:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/sbin:/usr/sbin:/usr/games:/usr/lib/surfraw
  LANG=en_US.UTF-8
  SHELL=/bin/zsh
 ProcVersionSignature: Ubuntu 2.6.27-5.8-generic
 SourcePackage: linux



-- 
Marc Jauvin
514-905-6500
http://register4less.com

-- 
ACPI brightness events no longer work on ThinkPad T61
https://bugs.launchpad.net/bugs/280646
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-power-manager in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

Re: [Bug 280646] Re: ACPI brightness events no longer work on ThinkPad T61

2008-10-10 Thread Matt Zimmerman
On Fri, Oct 10, 2008 at 04:17:00PM -, Marc Jauvin wrote:
 Hi Matt, since I did this upgrade, keyboard and mouse don't work after  
 I rebooted... not sure if this is caused by your updated package (or  
 one of their dependency like xinput).
 
 I'm currently writing this from Hardy since my Intrepid install is  
 unusable... ;)

I don't see how this change could cause that; it certainly doesn't break my
keyboard or mouse (I'm running with it right now).

Did you upgrade your kernel at the same time?

Please let us know if you can isolate the problem, regardless of whether
it's related to this bug.

-- 
 - mdz

-- 
ACPI brightness events no longer work on ThinkPad T61
https://bugs.launchpad.net/bugs/280646
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-power-manager in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 280646] Re: ACPI brightness events no longer work on ThinkPad T61

2008-10-09 Thread Matt Zimmerman
perseus:[~] cat /proc/acpi/ibm/hotkey 
status: enabled
mask:   0x008c7fff
commands:   enable, disable, reset, mask

-- 
ACPI brightness events no longer work on ThinkPad T61
https://bugs.launchpad.net/bugs/280646
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-power-manager in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 280646] Re: ACPI brightness events no longer work on ThinkPad T61

2008-10-09 Thread Matt Zimmerman
The gpm brightness applet does work, so gpm's logic for setting the
brightness (and whatever it calls out to...xrandr?) is working.

-- 
ACPI brightness events no longer work on ThinkPad T61
https://bugs.launchpad.net/bugs/280646
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-power-manager in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 280646] Re: ACPI brightness events no longer work on ThinkPad T61

2008-10-09 Thread Matt Zimmerman
Starting to look like a hal issue, moving there...

** Changed in: hal (Ubuntu)
Sourcepackagename: gnome-power-manager = hal

-- 
ACPI brightness events no longer work on ThinkPad T61
https://bugs.launchpad.net/bugs/280646
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-power-manager in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 280646] Re: ACPI brightness events no longer work on ThinkPad T61

2008-10-09 Thread Matt Zimmerman
I rebooted into 2.6.24 and the problem persists, so I don't think this
is strictly a kernel issue.  Looking at g-p-m now.

** Changed in: gnome-power-manager (Ubuntu)
Sourcepackagename: linux = gnome-power-manager

-- 
ACPI brightness events no longer work on ThinkPad T61
https://bugs.launchpad.net/bugs/280646
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-power-manager in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 280646] Re: ACPI brightness events no longer work on ThinkPad T61

2008-10-09 Thread Matt Zimmerman
gnome-power-manager --verbose says that it is grabbing the right
keycodes:

TI:11:55:04 TH:0x650a00 FI:gpm-button.c FN:gpm_button_grab_keystring,152
 - Grabbed modmask=0, keycode=233
TI:11:55:04 TH:0x650a00 FI:gpm-button.c FN:gpm_button_grab_keystring,152
 - Grabbed modmask=0, keycode=232

which matches xev:

state 0x10, keycode 232 (keysym 0x1008ff03, XF86MonBrightnessDown), 
same_screen YES,
state 0x10, keycode 233 (keysym 0x1008ff02, XF86MonBrightnessUp), 
same_screen YES,

but somehow gnome-power-manager doesn't seem to respond.

-- 
ACPI brightness events no longer work on ThinkPad T61
https://bugs.launchpad.net/bugs/280646
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-power-manager in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs


[Bug 280646] Re: ACPI brightness events no longer work on ThinkPad T61

2008-10-09 Thread Bryce Harrington
1.  The problem with g-p-m not handling the brightness key when numlock
is set is in fact an issue local to gnome-power-manager.  It's simply
neglects to grab the modifiers for the keys.

The first line of the attached patch makes the issue go away (the rest
of the patch is just instrumentation).  No changes to X are required; it
seems to be working properly.


2.  On the Thinkpad T61 specific issue, I discussed it with Peter
Hutterer.  It seems to be that on this hardware, the numlock key doesn't
actually send events when the fn is pressed so we have no way of knowing
that it is pressed.  This was verified via gdb on the xserver.  Scroll
lock and numlock are shared, so fn has to be pressed to trigger numlock.

So it seems to be either a hardware or kernel bug.


** Attachment added: gpm-button.patch
   http://launchpadlibrarian.net/18385683/gpm-button.patch

** Also affects: gnome-power-manager (Ubuntu)
   Importance: Undecided
   Status: New

-- 
ACPI brightness events no longer work on ThinkPad T61
https://bugs.launchpad.net/bugs/280646
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-power-manager in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs